214235 2020-07-12 09:14:51 -0700 Building PDFPlugin.mm with the macOS Big Sur public SDK fails 2020-07-16 00:23:39 -0700 1 1 1 Unclassified WebKit New Bugs Safari Technology Preview Unspecified Unspecified RESOLVED DUPLICATE 214396 https://bugs.webkit.org/show_bug.cgi?id=214396 P2 Normal --- 214043 1 rbuis rbuis aakash_jain ap beidson benjamin cdumez cmarcelo darin ews-watchlist jbedard thorton oldest_to_newest 1670870 0 rbuis 2020-07-12 09:14:51 -0700 Build fails for PDFPlugin.mm: PDFPlugin.mm:852:5: error: unknown type name 'CGDataProviderDirectAccessRangesCallbacks'; did you mean 'CGDataProviderDirectCallbacks'? CGDataProviderDirectAccessRangesCallbacks dataProviderCallbacks { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ CGDataProviderDirectCallbacks In file included from /Users/rwlbuis/work/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource55-mm.mm:1: In file included from /Users/rwlbuis/work/WebKit/Source/WebKit/WebKit2Prefix.h:38: In file included from /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.16.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CoreGraphics.h:11: In file included from /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.16.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGBitmapContext.h:9: In file included from /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.16.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGContext.h:16: In file included from /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.16.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGColor.h:15: In file included from /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.16.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGColorSpace.h:15: /Applications/Xcode-beta.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.16.sdk/System/Library/Frameworks/CoreGraphics.framework/Headers/CGDataProvider.h:113:46: note: 'CGDataProviderDirectCallbacks' declared here typedef struct CGDataProviderDirectCallbacks CGDataProviderDirectCallbacks; 1670887 1 404108 rbuis 2020-07-12 11:02:06 -0700 Created attachment 404108 Patch 1670900 2 404111 rbuis 2020-07-12 12:38:37 -0700 Created attachment 404111 Patch 1670921 3 404111 darin 2020-07-12 14:31:50 -0700 Comment on attachment 404111 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=404111&action=review > Source/WTF/wtf/PlatformEnableCocoa.h:376 > -#if !defined(ENABLE_PDFKIT_PLUGIN) && PLATFORM(MAC) > +#if !defined(ENABLE_PDFKIT_PLUGIN) && PLATFORM(MAC) && (USE(APPLE_INTERNAL_SDK) || __MAC_OS_X_VERSION_MIN_REQUIRED < 101600) This is the wrong solution. I think the correct solution is for us to put the CGDataProviderDirectAccessRangesCallbacks structure into CoreGraphicsSPI.h. How does this code successfully build on non-Big-Sur macOS? 1671019 4 rbuis 2020-07-13 06:58:47 -0700 There were actually more build errors for this file: In file included from /Users/rwlbuis/work/WebKit/WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource55-mm.mm:3: /Users/rwlbuis/work/WebKit/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:854:9: error: cannot initialize a member subobject of type 'CGDataProviderGetBytePointerCallback _Nullable' (aka 'const void * _Nullable (*)(void * _Nullable)') with an lvalue of type 'size_t (void *, void *, off_t, size_t)' (aka 'unsigned long (void *, void *, long long, unsigned long)'): different number of parameters (1 vs 4) dataProviderGetBytesAtPositionCallback, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/rwlbuis/work/WebKit/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:855:9: error: cannot initialize a member subobject of type 'CGDataProviderReleaseBytePointerCallback _Nullable' (aka 'void (*)(void * _Nullable, const void * _Nonnull)') with an lvalue of type 'void (void *, CFMutableArrayRef, const CFRange *, size_t)' (aka 'void (void *, __CFArray *, const CFRange *, unsigned long)'): different number of parameters (2 vs 4) dataProviderGetByteRangesCallback, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/rwlbuis/work/WebKit/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:856:9: error: cannot initialize a member subobject of type 'CGDataProviderGetBytesAtPositionCallback _Nullable' (aka 'unsigned long (*)(void * _Nullable, void * _Nonnull, long long, unsigned long)') with an lvalue of type 'void (void *)': different number of parameters (4 vs 1) dataProviderReleaseInfoCallback, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/rwlbuis/work/WebKit/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:857:5: error: missing field 'releaseInfo' initializer [-Werror,-Wmissing-field-initializers] }; ^ /Users/rwlbuis/work/WebKit/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:868:106: error: use of undeclared identifier 'kCGDataProviderIndeterminateSize' RetainPtr<CGDataProviderRef> dataProvider = adoptCF(CGDataProviderCreateMultiRangeDirectAccess(this, kCGDataProviderIndeterminateSize, &dataProviderCallbacks)); ^ /Users/rwlbuis/work/WebKit/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:869:51: error: use of undeclared identifier 'kCGDataProviderHasHighLatency' CGDataProviderSetProperty(dataProvider.get(), kCGDataProviderHasHighLatency, kCFBooleanTrue); ^ 7 errors generated. 1671051 5 darin 2020-07-13 09:25:36 -0700 Let me ask this question again, before we start making changes to this file: (In reply to Darin Adler from comment #3) > How does this code successfully build on non-Big-Sur macOS? The answer to that will help us understand what we need to do to fix it. 1671056 6 rbuis 2020-07-13 09:45:40 -0700 (In reply to Darin Adler from comment #5) > Let me ask this question again, before we start making changes to this file: > > (In reply to Darin Adler from comment #3) > > How does this code successfully build on non-Big-Sur macOS? > > The answer to that will help us understand what we need to do to fix it. Ah, it seems this code was introduced by https://bugs.webkit.org/show_bug.cgi?id=208599, guarded by HAVE_INCREMENTAL_PDF_APIS and then enabled by https://bugs.webkit.org/show_bug.cgi?id=208763. So possibly disabling HAVE_INCREMENTAL_PDF_APIS for public SDK is the fix here. I unfortunately have no information on CGDataProviderDirectAccessRangesCallbacks, so for me it is hard to fix it otherwise. 1671066 7 darin 2020-07-13 10:31:28 -0700 (In reply to Rob Buis from comment #6) > Ah, it seems this code was introduced by > https://bugs.webkit.org/show_bug.cgi?id=208599, guarded by > HAVE_INCREMENTAL_PDF_APIS and then enabled by > https://bugs.webkit.org/show_bug.cgi?id=208763. OK, next step is to make a list of things needed from the SPI header for that new HAVE(INCREMENTAL_PDF_APIS) code. > So possibly disabling HAVE_INCREMENTAL_PDF_APIS for public SDK is the fix > here. Disabling features for people who don’t have access to the internal SDK is the absolute last resort. It’s a bad pattern we want to avoid when possible. > I unfortunately have no information on > CGDataProviderDirectAccessRangesCallbacks, so for me it is hard to fix it > otherwise. Yes, you might either need help from or have the be entirely done by someone from Apple who does have that information. I think Alexey said something about this earlier. 1671070 8 rbuis 2020-07-13 10:35:33 -0700 (In reply to Darin Adler from comment #7) > > So possibly disabling HAVE_INCREMENTAL_PDF_APIS for public SDK is the fix > > here. > > Disabling features for people who don’t have access to the internal SDK is > the absolute last resort. It’s a bad pattern we want to avoid when possible. Sorry, I should have been more clear, I meant disabling it for public SDK, not internal SDK. 1671081 9 darin 2020-07-13 10:50:10 -0700 (In reply to Rob Buis from comment #8) > (In reply to Darin Adler from comment #7) > > > So possibly disabling HAVE_INCREMENTAL_PDF_APIS for public SDK is the fix > > > here. > > > > Disabling features for people who don’t have access to the internal SDK is > > the absolute last resort. It’s a bad pattern we want to avoid when possible. > > Sorry, I should have been more clear, I meant disabling it for public SDK, > not internal SDK. Yes, that’s what I am talking about (please re-read and note the phrase "don't have access"). We should *not* disable features for public SDK except in unusual circumstances. 1671082 10 darin 2020-07-13 10:50:52 -0700 Next step is to make a list of things needed from the SPI header for that new HAVE(INCREMENTAL_PDF_APIS) code. Is there someone who can do that? 1671084 11 darin 2020-07-13 10:51:15 -0700 Maybe Brady can make that list for us? 1671088 12 thorton 2020-07-13 10:56:43 -0700 Generally jbedard or someone else does this for the whole project at some point during the summer. I'm not sure what the plan is this year, but cc'ing them. 1671235 13 jbedard 2020-07-13 17:27:05 -0700 Yeah, there are going to be a ton of things like this, not just for Big Sur, but iOS, watchOS and tvOS too. Aakash started work on the 2 weeks ago, but I think tvOS and watchOS EWS were a higher priority. Someone from Ops will get this build working in the next 2 weeks, I’ll make sure we keep this bug updated. 1672049 14 jbedard 2020-07-15 22:26:16 -0700 Linked this up to https://bugs.webkit.org/show_bug.cgi?id=214396, which should be enough to get WebKit to build for Big Sur with the Seed 1 SDK. 1672063 15 rbuis 2020-07-16 00:23:39 -0700 It looks like https://bugs.webkit.org/show_bug.cgi?id=214396 will fix this, so closing this one. Thanks! *** This bug has been marked as a duplicate of bug 214396 *** 404108 2020-07-12 11:02:06 -0700 2020-07-12 12:38:32 -0700 Patch bug-214235-20200712190204.patch text/plain 1285 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQ3YTA4YzE3Y2Y3YmRiNWFjMTYwMzM0 YzA0ZDQzOTQwZTJkNjcwMDAuLjAyZDYxNTc1ZTMyZmQ3Y2ViZTU5NWVmYjgwZmI3ZGI0ZTBiODQ1 N2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDctMTIgIFJvYiBCdWlzICA8cmJ1aXNAaWdh bGlhLmNvbT4KKworICAgICAgICBCdWlsZGluZyBQREZQbHVnaW4ubW0gd2l0aCB0aGUgbWFjT1Mg QmlnIFN1ciBwdWJsaWMgU0RLIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTQyMzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBCdWlsZGluZyBQREZQbHVnaW4ubW0gd2l0aCB0aGUgbWFjT1MgQmln IFN1ciBwdWJsaWMgU0RLIGZhaWxzLCBzbworICAgICAgICBkaXNhYmxlIFBERktJVF9QTFVHSU4g Zm9yIG5vdy4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmg6CisKIDIwMjAt MDctMTEgIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUuY29tPiBhbmQgWXVzdWtlIFN1enVraSAg PHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbGFuZGluZyAiTWFrZSBoYXNoZXIgd29y ayB3aXRoIHR1cGxlLWxpa2UgY2xhc3NlcyIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1Bs YXRmb3JtRW5hYmxlQ29jb2EuaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtRW5hYmxlQ29jb2Eu aAppbmRleCBmODZlYjBhMWI4MmM5NDI1N2IyNzAzNzgzMWFmMWY4OWNjNmVhNGM2Li4yNGFiZTkz MzYyNzkxNzJhZmNjOGYxZmIzYWIzNjU4MGVkODM1YTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm1F bmFibGVDb2NvYS5oCkBAIC0zNzMsNyArMzczLDcgQEAKICNkZWZpbmUgRU5BQkxFX1BJQ1RVUkVf SU5fUElDVFVSRV9BUEkgMQogI2VuZGlmCiAKLSNpZiAhZGVmaW5lZChFTkFCTEVfUERGS0lUX1BM VUdJTikgJiYgUExBVEZPUk0oTUFDKQorI2lmICFkZWZpbmVkKEVOQUJMRV9QREZLSVRfUExVR0lO KSAmJiBQTEFURk9STShNQUMpICYmIFVTRShBUFBMRV9JTlRFUk5BTF9TREspCiAjZGVmaW5lIEVO QUJMRV9QREZLSVRfUExVR0lOIDEKICNlbmRpZgogCg== 404111 2020-07-12 12:38:37 -0700 2020-07-13 09:25:50 -0700 Patch bug-214235-20200712203835.patch text/plain 1302 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQ1ODA3NDZmMzhlOGJiNzRmYjQ2NDJm ZWM2NjIxYTgzZTg3Zjg4OTYuLjkwYzdiYTUxMGQzMWE1MmFjYTBhOGNlMTJiOWI0ZmYxY2JlNmNl MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDctMTIgIFJvYiBCdWlzICA8cmJ1aXNAaWdh bGlhLmNvbT4KKworICAgICAgICBCdWlsZGluZyBQREZQbHVnaW4ubW0gd2l0aCB0aGUgbWFjT1Mg QmlnIFN1ciBwdWJsaWMgU0RLIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTQyMzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBCdWlsZGluZyBQREZQbHVnaW4ubW0gd2l0aCB0aGUgbWFjT1MgQmln IFN1ciBwdWJsaWMgU0RLIGZhaWxzLCBzbworICAgICAgICBkaXNhYmxlIFBERktJVF9QTFVHSU4g Zm9yIHRoYXQgY29uZmlndXJhdGlvbi4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybUVuYWJsZUNv Y29hLmg6CisKIDIwMjAtMDctMTIgIFJvYiBCdWlzICA8cmJ1aXNAaWdhbGlhLmNvbT4KIAogICAg ICAgICBJbXByb3ZlIElQdjYgZGV0ZWN0aW9uIHdoZW4gc2V0dGluZyBob3N0L2hvc3RuYW1lCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmggYi9Tb3VyY2Uv V1RGL3d0Zi9QbGF0Zm9ybUVuYWJsZUNvY29hLmgKaW5kZXggZjg2ZWIwYTFiODJjOTQyNTdiMjcw Mzc4MzFhZjFmODljYzZlYTRjNi4uMDlmNjcyZDhkYjUzZmVhZTdiY2I4M2NjYTliNWE5Y2I4M2Zi MDMwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1FbmFibGVDb2NvYS5oCisr KyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtRW5hYmxlQ29jb2EuaApAQCAtMzczLDcgKzM3Myw3 IEBACiAjZGVmaW5lIEVOQUJMRV9QSUNUVVJFX0lOX1BJQ1RVUkVfQVBJIDEKICNlbmRpZgogCi0j aWYgIWRlZmluZWQoRU5BQkxFX1BERktJVF9QTFVHSU4pICYmIFBMQVRGT1JNKE1BQykKKyNpZiAh ZGVmaW5lZChFTkFCTEVfUERGS0lUX1BMVUdJTikgJiYgUExBVEZPUk0oTUFDKSAmJiAoVVNFKEFQ UExFX0lOVEVSTkFMX1NESykgfHwgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEw MTYwMCkKICNkZWZpbmUgRU5BQkxFX1BERktJVF9QTFVHSU4gMQogI2VuZGlmCiAK