214202 2020-07-10 14:57:37 -0700 AX: Build failure for catalyst 2020-07-10 16:16:16 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer zalan oldest_to_newest 1670594 0 cfleizach 2020-07-10 14:57:37 -0700 ./accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1512:12: error: cannot initialize return object of type 'BOOL' (aka 'signed char') with an rvalue of type 'WebCore::AXCoreObject *' return Accessibility::findAncestor<AXCoreObject>(*self.axBackingObject, false, [] (const AXCoreObject& object) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1522:12: error: cannot initialize return object of type 'BOOL' (aka 'signed char') with an rvalue of type 'WebCore::AXCoreObject *' 1670595 1 webkit-bug-importer 2020-07-10 14:57:48 -0700 <rdar://problem/65366125> 1670600 2 404006 cfleizach 2020-07-10 15:02:37 -0700 Created attachment 404006 patch 1670606 3 zalan 2020-07-10 15:11:32 -0700 wouldn't !(!) work here as well? 1670618 4 cfleizach 2020-07-10 15:36:30 -0700 (In reply to zalan from comment #3) > wouldn't !(!) work here as well? I think so but isn't comparing against nullptr more clear? 1670621 5 ews-feeder 2020-07-10 15:42:20 -0700 Committed r264243: <https://trac.webkit.org/changeset/264243> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404006. 1670622 6 zalan 2020-07-10 15:45:35 -0700 (In reply to chris fleizach from comment #4) > (In reply to zalan from comment #3) > > wouldn't !(!) work here as well? > > I think so but isn't comparing against nullptr more clear? WebKit prefers it the other way around (instead of [if (foo != nullptr)] we usually go like [if (!foo)]) 1670623 7 cfleizach 2020-07-10 15:50:24 -0700 (In reply to zalan from comment #6) > (In reply to chris fleizach from comment #4) > > (In reply to zalan from comment #3) > > > wouldn't !(!) work here as well? > > > > I think so but isn't comparing against nullptr more clear? > WebKit prefers it the other way around (instead of [if (foo != nullptr)] we > usually go like [if (!foo)]) So in this case you think return !(!Accessibility::findAncestor<AXCoreObject>(*self.axBackingObject, false, [] (const AXCoreObject& object) { return object.roleValue() == AccessibilityRole::DescriptionListTerm; })); would be better suited? 1670627 8 zalan 2020-07-10 15:55:23 -0700 (In reply to chris fleizach from comment #7) > (In reply to zalan from comment #6) > > (In reply to chris fleizach from comment #4) > > > (In reply to zalan from comment #3) > > > > wouldn't !(!) work here as well? > > > > > > I think so but isn't comparing against nullptr more clear? > > WebKit prefers it the other way around (instead of [if (foo != nullptr)] we > > usually go like [if (!foo)]) > > So in this case you think > > return !(!Accessibility::findAncestor<AXCoreObject>(*self.axBackingObject, > false, [] (const AXCoreObject& object) { > return object.roleValue() == AccessibilityRole::DescriptionListTerm; > })); > > would be better suited? Yeah, I would change it to !!Accessibility::findAncestor as a drive-by fix whenever you make some changes in here. 1670643 9 cfleizach 2020-07-10 16:16:16 -0700 (In reply to zalan from comment #8) > (In reply to chris fleizach from comment #7) > > (In reply to zalan from comment #6) > > > (In reply to chris fleizach from comment #4) > > > > (In reply to zalan from comment #3) > > > > > wouldn't !(!) work here as well? > > > > > > > > I think so but isn't comparing against nullptr more clear? > > > WebKit prefers it the other way around (instead of [if (foo != nullptr)] we > > > usually go like [if (!foo)]) > > > > So in this case you think > > > > return !(!Accessibility::findAncestor<AXCoreObject>(*self.axBackingObject, > > false, [] (const AXCoreObject& object) { > > return object.roleValue() == AccessibilityRole::DescriptionListTerm; > > })); > > > > would be better suited? > Yeah, I would change it to !!Accessibility::findAncestor as a drive-by fix > whenever you make some changes in here. Noted 404006 2020-07-10 15:02:37 -0700 2020-07-10 15:42:21 -0700 patch file_214202.txt text/plain 1915 cfleizach ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZw0KaW5kZXggMzg2YjNiMzlmMzIuLjk4MTQyNGQzZThkIDEwMDY0NA0KLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nDQorKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cNCkBA IC0xLDMgKzEsMTUgQEANCisyMDIwLTA3LTEwICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBh cHBsZS5jb20+DQorDQorICAgICAgICBBWDogQnVpbGQgZmFpbHVyZSBmb3IgY2F0YWx5c3QNCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQyMDINCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NTM2NjEyNT4NCisNCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLg0KKw0KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2lvcy9XZWJBY2Nl c3NpYmlsaXR5T2JqZWN0V3JhcHBlcklPUy5tbToNCisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxp dHlPYmplY3RXcmFwcGVyIGFjY2Vzc2liaWxpdHlJc0luRGVzY3JpcHRpb25MaXN0VGVybV0pOg0K KyAgICAgICAgKC1bV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgYWNjZXNzaWJpbGl0eUlz SW5EZXNjcmlwdGlvbkxpc3REZWZpbml0aW9uXSk6DQorDQogMjAyMC0wNy0xMCAgR3Vvd2VpIFlh bmcgIDxndW93ZWlfeWFuZ0BhcHBsZS5jb20+DQogDQogICAgICAgICBSZW1vdmluZyB1c2FnZSBv ZiAidXNpbmcgbmFtZXNwYWNlIFdlYkNvcmUiIGZyb20gVGV4dFRyYWNrUmVwcmVzZW50YXRpb25D b2NvYS5tbQ0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaW9zL1dl YkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVySU9TLm1tIGIvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9pb3MvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJJT1MubW0NCmluZGV4IGE1 OGUyZDNmNTVmLi4zYmEzZmEzYjc1YyAxMDA2NDQNCi0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvaW9zL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVySU9TLm1tDQorKysgYi9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lvcy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3Jh cHBlcklPUy5tbQ0KQEAgLTE1MTEsNyArMTUxMSw3IEBAIHN0YXRpYyB2b2lkIGFwcGVuZFN0cmlu Z1RvUmVzdWx0KE5TTXV0YWJsZVN0cmluZyAqcmVzdWx0LCBOU1N0cmluZyAqc3RyaW5nKQ0KIA0K ICAgICByZXR1cm4gQWNjZXNzaWJpbGl0eTo6ZmluZEFuY2VzdG9yPEFYQ29yZU9iamVjdD4oKnNl bGYuYXhCYWNraW5nT2JqZWN0LCBmYWxzZSwgW10gKGNvbnN0IEFYQ29yZU9iamVjdCYgb2JqZWN0 KSB7DQogICAgICAgICByZXR1cm4gb2JqZWN0LnJvbGVWYWx1ZSgpID09IEFjY2Vzc2liaWxpdHlS b2xlOjpEZXNjcmlwdGlvbkxpc3RUZXJtOw0KLSAgICB9KTsNCisgICAgfSkgIT0gbnVsbHB0cjsN CiB9DQogDQogLSAoQk9PTClhY2Nlc3NpYmlsaXR5SXNJbkRlc2NyaXB0aW9uTGlzdERlZmluaXRp b24NCkBAIC0xNTIxLDcgKzE1MjEsNyBAQCBzdGF0aWMgdm9pZCBhcHBlbmRTdHJpbmdUb1Jlc3Vs dChOU011dGFibGVTdHJpbmcgKnJlc3VsdCwgTlNTdHJpbmcgKnN0cmluZykNCiANCiAgICAgcmV0 dXJuIEFjY2Vzc2liaWxpdHk6OmZpbmRBbmNlc3RvcjxBWENvcmVPYmplY3Q+KCpzZWxmLmF4QmFj a2luZ09iamVjdCwgZmFsc2UsIFtdIChjb25zdCBBWENvcmVPYmplY3QmIG9iamVjdCkgew0KICAg ICAgICAgcmV0dXJuIG9iamVjdC5yb2xlVmFsdWUoKSA9PSBBY2Nlc3NpYmlsaXR5Um9sZTo6RGVz Y3JpcHRpb25MaXN0RGV0YWlsOw0KLSAgICB9KTsNCisgICAgfSkgIT0gbnVsbHB0cjsNCiB9DQog DQogLSAoTlNTdHJpbmcgKilhY2Nlc3NpYmlsaXR5SGludA==