214198 2020-07-10 14:27:00 -0700 [iOS] Prompt for requestStorageAccess is inverted in WKWebView 2020-07-10 23:30:29 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ajuma bfulgham bfulgham darin katherine_cheney rkgibson rohitrao webkit-bug-importer wilander oldest_to_newest 1670576 0 404001 ajuma 2020-07-10 14:27:00 -0700 Created attachment 404001 Test case Testing on iOS 14 beta 2, I'm seeing the following broken behavior for the requestStorageAccess prompt in WKWebView: 1. On the simulator, clicking "Don't allow" or "Allow" does the opposite: "Don't allow" grants access while "Allow" denies it. 2. On device, in situations where the prompt should be shown, storage access is granted silently without displaying any prompt. The behavior is correct in Safari, but broken in WKWebView (I'm testing using Chrome). I've attached a test case that reproduces this bug: 1. First visit https://alijuma.github.io/request.html and click the button. 2. Visit the attached test page (which embeds the page above) and click the button, which triggers requestStorageAccess. Expected behavior (and behavior in Safari): a prompt is shown, and clicking on "Allow" or "Don't allow" updates the displayed message to indicate whether the promise resolved or rejected. Actual behavior in WKWebView: On simulator, the prompt is shown, but the buttons do the opposite of what they should. On device, no prompt is shown. 1670578 1 ajuma 2020-07-10 14:32:57 -0700 Also created FB7910866 for this. 1670630 2 bfulgham 2020-07-10 16:02:06 -0700 Oh wow -- I think this has been inverted the whole time! 1670631 3 webkit-bug-importer 2020-07-10 16:02:28 -0700 <rdar://problem/65369725> 1670634 4 bfulgham 2020-07-10 16:04:59 -0700 Ali: Looking at the code, I believe this has been broken in all versions of iOS with this prompt. Did you test in iOS 13 and find that it worked properly in that release? 1670637 5 404015 bfulgham 2020-07-10 16:07:43 -0700 Created attachment 404015 Patch 1670673 6 ajuma 2020-07-10 17:42:57 -0700 (In reply to Brent Fulgham from comment #4) > Ali: Looking at the code, I believe this has been broken in all versions of > iOS with this prompt. Did you test in iOS 13 and find that it worked > properly in that release? On iOS 13, I don't see the prompt at all in WKWebView (storage access is silently granted), presumably because ITP isn't enabled in iOS 13. 1670725 7 ews-feeder 2020-07-10 23:30:28 -0700 Committed r264266: <https://trac.webkit.org/changeset/264266> All reviewed patches have been landed. Closing bug and clearing flags on attachment 404015. 404001 2020-07-10 14:27:00 -0700 2020-07-10 14:27:00 -0700 Test case request-storage-access.html text/html 77 ajuma PGlmcmFtZSB3aWR0aD0iODAwcHgiIHNyYz0iaHR0cHM6Ly9hbGlqdW1hLmdpdGh1Yi5pby9yZXF1 ZXN0Lmh0bWwiPjwvaWZyYW1lPgo= 404015 2020-07-10 16:07:43 -0700 2020-07-10 23:30:29 -0700 Patch bug-214198-20200710160743.patch text/plain 2352 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI1ZmE0NTBiOTA5ODU5MmQ1 NDYzMzc1MTMyNzZkM2RkNjJkYTMzMzAuLjQyOTBjYzY0MTM3NGUyNWUzNGE0M2JiYWUzZTEyMWQw ZWRkMDAxZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDctMTAgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUHJvbXB0IGZvciBy ZXF1ZXN0U3RvcmFnZUFjY2VzcyBpcyBpbnZlcnRlZCBpbiBXS1dlYlZpZXcgCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQxOTgKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzY1MzY5NzI1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSBsYWJlbHMgZm9yICJhbGxvdyIgYW5kICJkZW55IiBTdG9yYWdl QWNjZXNzIEFQSSB3ZXJlIGludmVydGVkIGluIHRoZSBXS1dlYlZpZXcKKyAgICAgICAgaW1wbGVt ZW50YXRpb24uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvV0tTdG9yYWdlQWNjZXNzQWxl cnQubW06CisgICAgICAgIChXZWJLaXQ6OnByZXNlbnRTdG9yYWdlQWNjZXNzQWxlcnQpOgorCiAy MDIwLTA3LTEwICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAg IFtJUEMgaGFyZGVuaW5nXSBVc2UgTUVTU0FHRV9DSEVDSyBpbiBXZWJQYWdlUHJveHk6OnNldENv bG9yUGlja2VyQ29sb3IoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29j b2EvV0tTdG9yYWdlQWNjZXNzQWxlcnQubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2Nv YS9XS1N0b3JhZ2VBY2Nlc3NBbGVydC5tbQppbmRleCA4MWEwZTU2ZmVlOTk3ZmQyNzU5MWI1ZmM5 ZWI1ZmE1YzRiNWNhYjMwLi5hOWNlMDc1YWRkMDkwMTFmMDhjMTI5MzhiM2FlMmJlNmI2NzYzNTFk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1N0b3JhZ2VBY2Nl c3NBbGVydC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XS1N0b3JhZ2VB Y2Nlc3NBbGVydC5tbQpAQCAtNjcsMTIgKzY3LDEyIEBAIHZvaWQgcHJlc2VudFN0b3JhZ2VBY2Nl c3NBbGVydChXS1dlYlZpZXcgKndlYlZpZXcsIGNvbnN0IFdlYkNvcmU6OlJlZ2lzdHJhYmxlRG9t CiAjZWxzZQogICAgIFVJQWxlcnRDb250cm9sbGVyKiBhbGVydCA9IFtVSUFsZXJ0Q29udHJvbGxl ciBhbGVydENvbnRyb2xsZXJXaXRoVGl0bGU6YWxlcnRUaXRsZSBtZXNzYWdlOmluZm9ybWF0aXZl VGV4dCBwcmVmZXJyZWRTdHlsZTpVSUFsZXJ0Q29udHJvbGxlclN0eWxlQWxlcnRdOwogCi0gICAg VUlBbGVydEFjdGlvbiogZG9Ob3RBbGxvd0FjdGlvbiA9IFtVSUFsZXJ0QWN0aW9uIGFjdGlvbldp dGhUaXRsZTphbGxvd0J1dHRvblN0cmluZyBzdHlsZTpVSUFsZXJ0QWN0aW9uU3R5bGVDYW5jZWwg aGFuZGxlcjpbY29tcGxldGlvbkJsb2NrXShVSUFsZXJ0QWN0aW9uICphY3Rpb24pIHsKLSAgICAg ICAgY29tcGxldGlvbkJsb2NrKGZhbHNlKTsKKyAgICBVSUFsZXJ0QWN0aW9uKiBhbGxvd0FjdGlv biA9IFtVSUFsZXJ0QWN0aW9uIGFjdGlvbldpdGhUaXRsZTphbGxvd0J1dHRvblN0cmluZyBzdHls ZTpVSUFsZXJ0QWN0aW9uU3R5bGVDYW5jZWwgaGFuZGxlcjpbY29tcGxldGlvbkJsb2NrXShVSUFs ZXJ0QWN0aW9uICphY3Rpb24pIHsKKyAgICAgICAgY29tcGxldGlvbkJsb2NrKHRydWUpOwogICAg IH1dOwogCi0gICAgVUlBbGVydEFjdGlvbiogYWxsb3dBY3Rpb24gPSBbVUlBbGVydEFjdGlvbiBh Y3Rpb25XaXRoVGl0bGU6ZG9Ob3RBbGxvd0J1dHRvblN0cmluZyBzdHlsZTpVSUFsZXJ0QWN0aW9u U3R5bGVEZWZhdWx0IGhhbmRsZXI6W2NvbXBsZXRpb25CbG9ja10oVUlBbGVydEFjdGlvbiAqYWN0 aW9uKSB7Ci0gICAgICAgIGNvbXBsZXRpb25CbG9jayh0cnVlKTsKKyAgICBVSUFsZXJ0QWN0aW9u KiBkb05vdEFsbG93QWN0aW9uID0gW1VJQWxlcnRBY3Rpb24gYWN0aW9uV2l0aFRpdGxlOmRvTm90 QWxsb3dCdXR0b25TdHJpbmcgc3R5bGU6VUlBbGVydEFjdGlvblN0eWxlRGVmYXVsdCBoYW5kbGVy Oltjb21wbGV0aW9uQmxvY2tdKFVJQWxlcnRBY3Rpb24gKmFjdGlvbikgeworICAgICAgICBjb21w bGV0aW9uQmxvY2soZmFsc2UpOwogICAgIH1dOwogCiAgICAgW2FsZXJ0IGFkZEFjdGlvbjpkb05v dEFsbG93QWN0aW9uXTsK