214196 2020-07-10 13:57:56 -0700 Removing usage of "using namespace WebCore" from TextTrackRepresentationCocoa.mm 2020-07-10 15:08:50 -0700 1 1 1 Unclassified WebKit Text Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 frankhome61 frankhome61 frankhome61 mmaxfield simon.fraser thorton webkit-bug-importer oldest_to_newest 1670565 0 frankhome61 2020-07-10 13:57:56 -0700 Removing the usage of using namespace WebCore from TextTrackRepresentationCocoa.mm, replace it with WebCore:: prefix, and use namespace WebCore { } block for C++ function implementations. This is to avoid potential namespace errors caused by unified source. 1670566 1 webkit-bug-importer 2020-07-10 13:58:35 -0700 <rdar://problem/65362349> 1670570 2 403999 frankhome61 2020-07-10 14:05:12 -0700 Created attachment 403999 Patch 1670597 3 ews-feeder 2020-07-10 14:58:00 -0700 Committed r264241: <https://trac.webkit.org/changeset/264241> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403999. 1670605 4 403999 simon.fraser 2020-07-10 15:08:50 -0700 Comment on attachment 403999 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403999&action=review > Source/WebCore/ChangeLog:13 > + No new tests are requied as this is a code style fix required 403999 2020-07-10 14:05:12 -0700 2020-07-10 14:58:01 -0700 Patch bug-214196-20200710140511.patch text/plain 4198 frankhome61 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTA4MWUxYTI4ZGEyZjVh Mjc1MjBlYTM3M2YyY2U5NGEwNjIwM2VjNy4uMzBlN2UzNTQzZmIxM2E1MmRkMDg0ZTI1ZTkxYzQy M2UyZTg0YjI5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDIwLTA3LTEwICBHdW93 ZWkgWWFuZyAgPGd1b3dlaV95YW5nQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmluZyB1c2Fn ZSBvZiAidXNpbmcgbmFtZXNwYWNlIFdlYkNvcmUiIGZyb20gVGV4dFRyYWNrUmVwcmVzZW50YXRp b25Db2NvYS5tbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjE0MTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIGxpbmUgInVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlIiB3aWxsIGNhdXNlIHByb2JsZW1z IAorICAgICAgICB3aGVuIGNvbXBpbGluZyB1bmlmaWVkIHNvdXJjZS4gUmVtb3ZpbmcgdGhpcyBs aW5lIGFuZCAKKyAgICAgICAgcmVwbGFjZSBpdCB3aXRoIFdlYkNvcmU6OnByZWZpeCBhbmQgbmFt ZXNwYWNlIFdlYkNvcmV7IH0KKyAgICAgICAgdG8gZW5jbG9zZSBDKysgY2FsbHMuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzIGFyZSByZXF1aWVkIGFzIHRoaXMgaXMgYSBjb2RlIHN0eWxlIGZpeAor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvVGV4dFRyYWNrUmVwcmVzZW50YXRp b25Db2NvYS5tbTogcmVtb3ZlZCB1c2FnZSAKKyAgICAgICAgICBvZiAidXNpbmcgbmFtZXNwYWNl IFdlYkNvcmUiIHRvIGF2b2lkIGZ1dHVyZSBlcnJvcnMgd2hpbGUgY29tcGlsaW5nCisgICAgICAg ICgtW1dlYkNvcmVUZXh0VHJhY2tSZXByZXNlbnRhdGlvbkNvY29hSGVscGVyIGluaXRXaXRoUGFy ZW50Ol0pOiBhZGRlZCAiV2ViQ29yZTo6IiBwcmVmaXgKKyAgICAgICAgKC1bV2ViQ29yZVRleHRU cmFja1JlcHJlc2VudGF0aW9uQ29jb2FIZWxwZXIgc2V0UGFyZW50Ol0pOiBkaXR0bworICAgICAg ICAoLVtXZWJDb3JlVGV4dFRyYWNrUmVwcmVzZW50YXRpb25Db2NvYUhlbHBlciBwYXJlbnRdKTog ZGl0dG8KKyAgICAgICAgKFRleHRUcmFja1JlcHJlc2VudGF0aW9uOjpjcmVhdGUpOiBlbmNsb3Nl ZCBpbnNpZGUgbmFtZXNwYWNlIFdlYkNvcmV7IH0KKyAgICAgICAgKFRleHRUcmFja1JlcHJlc2Vu dGF0aW9uQ29jb2E6OlRleHRUcmFja1JlcHJlc2VudGF0aW9uQ29jb2EpOiBEZWxldGVkLiAKKyAg ICAgICAgICBlbmNsb3NlZCBpbnNpZGUgbmFtZXNwYWNlIFdlYkNvcmV7IH0KKyAgICAgICAgKFRl eHRUcmFja1JlcHJlc2VudGF0aW9uQ29jb2E6On5UZXh0VHJhY2tSZXByZXNlbnRhdGlvbkNvY29h KTogZGl0dG8KKyAgICAgICAgKFRleHRUcmFja1JlcHJlc2VudGF0aW9uQ29jb2E6OnVwZGF0ZSk6 IGRpdHRvCisgICAgICAgIChUZXh0VHJhY2tSZXByZXNlbnRhdGlvbkNvY29hOjpzZXRDb250ZW50 U2NhbGUpOiBkaXR0bworICAgICAgICAoVGV4dFRyYWNrUmVwcmVzZW50YXRpb25Db2NvYTo6c2V0 SGlkZGVuIGNvbnN0KTogZGl0dG8KKyAgICAgICAgKFRleHRUcmFja1JlcHJlc2VudGF0aW9uQ29j b2E6OmJvdW5kcyBjb25zdCk6IGRpdHRvCisgICAgICAgIChUZXh0VHJhY2tSZXByZXNlbnRhdGlv bkNvY29hOjpib3VuZHNDaGFuZ2VkKTogZGl0dG8KKwogMjAyMC0wNy0xMCAgUGhpbGlwcGUgTm9y bWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gVW5yZXZp ZXdlZCwgcHJvc3BlY3RpdmUgQVBJIHRlc3QgYm90IGZpeC4uLgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvVGV4dFRyYWNrUmVwcmVzZW50YXRpb25D b2NvYS5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1RleHRUcmFj a1JlcHJlc2VudGF0aW9uQ29jb2EubW0KaW5kZXggNTcyZGU3MWExZTRhNjJlODhmYzI5OTc4YTVj MzAwZGIxOWU2OWZiNS4uZjJlOWRmMTQ3YzAyYTZkYmUwZjZlOWIyZDI4NjQ4ZDk3MTQzMDY3YSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvVGV4dFRy YWNrUmVwcmVzZW50YXRpb25Db2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jb2NvYS9UZXh0VHJhY2tSZXByZXNlbnRhdGlvbkNvY29hLm1tCkBAIC0zOSwxNyAr MzksMTYgQEAKIAogI2ltcG9ydCA8cGFsL3NwaS9jb2NvYS9RdWFydHpDb3JlU1BJLmg+CiAKLXVz aW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBAaW50ZXJmYWNlIFdlYkNvcmVUZXh0VHJhY2tSZXBy ZXNlbnRhdGlvbkNvY29hSGVscGVyIDogTlNPYmplY3QgPENBTGF5ZXJEZWxlZ2F0ZT4gewotICAg IFRleHRUcmFja1JlcHJlc2VudGF0aW9uQ29jb2EqIF9wYXJlbnQ7CisgICAgV2ViQ29yZTo6VGV4 dFRyYWNrUmVwcmVzZW50YXRpb25Db2NvYSogX3BhcmVudDsKIH0KLS0gKGlkKWluaXRXaXRoUGFy ZW50OihUZXh0VHJhY2tSZXByZXNlbnRhdGlvbkNvY29hKilwYXJlbnQ7Ci1AcHJvcGVydHkgKGFz c2lnbikgVGV4dFRyYWNrUmVwcmVzZW50YXRpb25Db2NvYSogcGFyZW50OworLSAoaWQpaW5pdFdp dGhQYXJlbnQ6KFdlYkNvcmU6OlRleHRUcmFja1JlcHJlc2VudGF0aW9uQ29jb2EqKXBhcmVudDsK K0Bwcm9wZXJ0eSAoYXNzaWduKSBXZWJDb3JlOjpUZXh0VHJhY2tSZXByZXNlbnRhdGlvbkNvY29h KiBwYXJlbnQ7CiBAZW5kCiAKIEBpbXBsZW1lbnRhdGlvbiBXZWJDb3JlVGV4dFRyYWNrUmVwcmVz ZW50YXRpb25Db2NvYUhlbHBlcgotLSAoaWQpaW5pdFdpdGhQYXJlbnQ6KFRleHRUcmFja1JlcHJl c2VudGF0aW9uQ29jb2EqKXBhcmVudAorLSAoaWQpaW5pdFdpdGhQYXJlbnQ6KFdlYkNvcmU6OlRl eHRUcmFja1JlcHJlc2VudGF0aW9uQ29jb2EqKXBhcmVudAogewogICAgIGlmICghKHNlbGYgPSBb c3VwZXIgaW5pdF0pKQogICAgICAgICByZXR1cm4gbmlsOwpAQCAtNjUsNyArNjQsNyBAQCAtICh2 b2lkKWRlYWxsb2MKICAgICBbc3VwZXIgZGVhbGxvY107CiB9CiAKLS0gKHZvaWQpc2V0UGFyZW50 OihUZXh0VHJhY2tSZXByZXNlbnRhdGlvbkNvY29hKilwYXJlbnQKKy0gKHZvaWQpc2V0UGFyZW50 OihXZWJDb3JlOjpUZXh0VHJhY2tSZXByZXNlbnRhdGlvbkNvY29hKilwYXJlbnQKIHsKICAgICBp ZiAoX3BhcmVudCkKICAgICAgICAgW19wYXJlbnQtPnBsYXRmb3JtTGF5ZXIoKSByZW1vdmVPYnNl cnZlcjpzZWxmIGZvcktleVBhdGg6QCJib3VuZHMiXTsKQEAgLTc2LDcgKzc1LDcgQEAgLSAodm9p ZClzZXRQYXJlbnQ6KFRleHRUcmFja1JlcHJlc2VudGF0aW9uQ29jb2EqKXBhcmVudAogICAgICAg ICBbX3BhcmVudC0+cGxhdGZvcm1MYXllcigpIGFkZE9ic2VydmVyOnNlbGYgZm9yS2V5UGF0aDpA ImJvdW5kcyIgb3B0aW9uczowIGNvbnRleHQ6MF07CiB9CiAKLS0gKFRleHRUcmFja1JlcHJlc2Vu dGF0aW9uQ29jb2EqKXBhcmVudAorLSAoV2ViQ29yZTo6VGV4dFRyYWNrUmVwcmVzZW50YXRpb25D b2NvYSopcGFyZW50CiB7CiAgICAgcmV0dXJuIF9wYXJlbnQ7CiB9CkBAIC0xMDYsNiArMTA1LDgg QEAgLSAoaWQpYWN0aW9uRm9yTGF5ZXI6KENBTGF5ZXIgKilsYXllciBmb3JLZXk6KE5TU3RyaW5n ICopZXZlbnQKIAogQGVuZAogCituYW1lc3BhY2UgV2ViQ29yZSB7CisKIHN0ZDo6dW5pcXVlX3B0 cjxUZXh0VHJhY2tSZXByZXNlbnRhdGlvbj4gVGV4dFRyYWNrUmVwcmVzZW50YXRpb246OmNyZWF0 ZShUZXh0VHJhY2tSZXByZXNlbnRhdGlvbkNsaWVudCYgY2xpZW50KQogewogICAgIHJldHVybiBt YWtlVW5pcXVlPFRleHRUcmFja1JlcHJlc2VudGF0aW9uQ29jb2E+KGNsaWVudCk7CkBAIC0xNTQs NCArMTU1LDYgQEAgdm9pZCBUZXh0VHJhY2tSZXByZXNlbnRhdGlvbkNvY29hOjpib3VuZHNDaGFu Z2VkKCkKICAgICB9KTsKIH0KIAorfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQorCiAjZW5kaWYgLy8g KFBMQVRGT1JNKElPU19GQU1JTFkpIHx8IChQTEFURk9STShNQUMpICYmIEVOQUJMRShWSURFT19Q UkVTRU5UQVRJT05fTU9ERSkpKSAmJiBFTkFCTEUoVklERU8pCg==