214178 2020-07-10 02:16:17 -0700 [WPE][GTK4] Form controls are not painted when using threaded rendering 2020-07-13 05:17:12 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 210100 1 cgarcia webkit-unassigned aperez bugs-noreply changseok esprehn+autocc ews-watchlist glenn kondapallykalyan pdr zan oldest_to_newest 1670392 0 cgarcia 2020-07-10 02:16:17 -0700 Which is the default for GTK4 since r263888. The problem is that RenderTheme::paint() returns early if the given GraphicsContext doesn't have a platform context, assuming all RenderTheme implementations paint directly to the platform context. 1670394 1 403953 cgarcia 2020-07-10 02:19:31 -0700 Created attachment 403953 Patch 1671006 2 cgarcia 2020-07-13 05:17:12 -0700 Committed r264298: <https://trac.webkit.org/changeset/264298> 403953 2020-07-10 02:19:31 -0700 2020-07-13 03:06:38 -0700 Patch wkgtk4-theme-can-paint.diff text/plain 5128 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2NjVhZDE0NTFjMDAuLjEzYzA2ODY2MjdmOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDI0IEBACisyMDIwLTA3LTEwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtHVEs0XSBGb3JtIGNvbnRyb2xzIGFyZSBub3Qg cGFpbnRlZCB3aGVuIHVzaW5nIHRocmVhZGVkIHJlbmRlcmluZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0MTc4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hpY2ggaXMgdGhlIGRlZmF1bHQgZm9yIEdU SzQgc2luY2UgcjI2Mzg4OC4gVGhlIHByb2JsZW0gaXMgdGhhdCBSZW5kZXJUaGVtZTo6cGFpbnQo KSByZXR1cm5zIGVhcmx5IGlmIHRoZSBnaXZlbgorICAgICAgICBHcmFwaGljc0NvbnRleHQgZG9l c24ndCBoYXZlIGEgcGxhdGZvcm0gY29udGV4dCwgYXNzdW1pbmcgYWxsIFJlbmRlclRoZW1lIGlt cGxlbWVudGF0aW9ucyBwYWludCBkaXJlY3RseSB0byB0aGUKKyAgICAgICAgcGxhdGZvcm0gY29u dGV4dC4gVGhpcyBwYXRjaCBhZGRzIGEgcHVyZSB2aXJ0dWFsIGNhblBhaW50KCkgdG8gUmVuZGVy VGhlbWUgdG8gYmUgdXNlZCBhcyB0aGUgZWFybHkgcmV0dXJuLgorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlclRoZW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lOjpwYWlu dCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lLmg6CisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlclRoZW1lQWR3YWl0YS5oOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVt ZUNvY29hLmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ29jb2EubW06CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUNvY29hOjpjYW5QYWludCBjb25zdCk6CisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlclRoZW1lUGxheVN0YXRpb24uaDoKKyAgICAgICAgKiByZW5kZXJp bmcvUmVuZGVyVGhlbWVXaW4uaDoKKwogMjAyMC0wNy0wOSAgQWxpY2lhIEJveWEgR2FyY8OtYSAg PGFib3lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW01TRV1bR1N0cmVhbWVyXSBEb24ndCBjYWNo ZSBkdXJhdGlvbiBpbiBNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHAKaW5kZXggOGRmNTQ2OGRkNDBhLi4yODZiMTE2MzE0 NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcApAQCAtMjk1LDcg KzI5NSw3IEBAIGJvb2wgUmVuZGVyVGhlbWU6OnBhaW50KGNvbnN0IFJlbmRlckJveCYgYm94LCBD b250cm9sU3RhdGVzJiBjb250cm9sU3RhdGVzLCBjb25zCiAgICAgaWYgKHBhaW50SW5mby5jb250 ZXh0KCkucGFpbnRpbmdEaXNhYmxlZCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBp ZiAoVU5MSUtFTFkoIXBhaW50SW5mby5jb250ZXh0KCkuaGFzUGxhdGZvcm1Db250ZXh0KCkpKQor ICAgIGlmIChVTkxJS0VMWSghY2FuUGFpbnQocGFpbnRJbmZvKSkpCiAgICAgICAgIHJldHVybiBm YWxzZTsKIAogICAgIENvbnRyb2xQYXJ0IHBhcnQgPSBib3guc3R5bGUoKS5hcHBlYXJhbmNlKCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuaCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5oCmluZGV4IDhhY2NlNzc0YzVmYy4u ZWI3YjkxMzIyN2I2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuaApAQCAt Mjc2LDYgKzI3Niw3IEBAIHB1YmxpYzoKICNlbmRpZgogCiBwcm90ZWN0ZWQ6CisgICAgdmlydHVh bCBib29sIGNhblBhaW50KGNvbnN0IFBhaW50SW5mbyYpIGNvbnN0ID0gMDsKICAgICB2aXJ0dWFs IEZvbnRDYXNjYWRlRGVzY3JpcHRpb24mIGNhY2hlZFN5c3RlbUZvbnREZXNjcmlwdGlvbihDU1NW YWx1ZUlEIHN5c3RlbUZvbnRJRCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUNhY2hl ZFN5c3RlbUZvbnREZXNjcmlwdGlvbihDU1NWYWx1ZUlEIHN5c3RlbUZvbnRJRCwgRm9udENhc2Nh ZGVEZXNjcmlwdGlvbiYpIGNvbnN0ID0gMDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lQWR3YWl0YS5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRoZW1lQWR3YWl0YS5oCmluZGV4IDNmYjZkOGRiMDRhMS4uYjg3ZTIzNjdiYjc5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVBZHdhaXRhLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQWR3YWl0YS5oCkBAIC0z NCw2ICszNCw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5SZW5kZXJUaGVtZUFkd2FpdGEoKSA9 IGRlZmF1bHQ7CiAKIHByaXZhdGU6CisgICAgYm9vbCBjYW5QYWludChjb25zdCBQYWludEluZm8m KSBjb25zdCBmaW5hbCB7IHJldHVybiB0cnVlOyB9CisKICAgICBTdHJpbmcgZXh0cmFEZWZhdWx0 U3R5bGVTaGVldCgpIGZpbmFsOwogI2lmIEVOQUJMRShWSURFTykKICAgICBTdHJpbmcgZXh0cmFN ZWRpYUNvbnRyb2xzU3R5bGVTaGVldCgpIGZpbmFsOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ29jb2EuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUaGVtZUNvY29hLmgKaW5kZXggNzNiMGU5OWQ3MjczLi5jYTc0NTkwNGUzZDYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNvY29hLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ29jb2EuaApAQCAtMzksNiAr MzksNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBDRlN0cmluZ1JlZiBjb250ZW50U2l6ZUNhdGVn b3J5KCkgY29uc3QgPSAwOwogCiBwcml2YXRlOgorICAgIGJvb2wgY2FuUGFpbnQoY29uc3QgUGFp bnRJbmZvJikgY29uc3QgZmluYWw7CiAgICAgYm9vbCBzaG91bGRIYXZlQ2Fwc0xvY2tJbmRpY2F0 b3IoY29uc3QgSFRNTElucHV0RWxlbWVudCYpIGNvbnN0IGZpbmFsOwogCiAjaWYgRU5BQkxFKEFQ UExFX1BBWSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVt ZUNvY29hLm1tIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ29jb2EubW0K aW5kZXggODk5NDMwNDNmNzU1Li45YzIyZjhmMmQwYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUaGVtZUNvY29hLm1tCkBAIC01NCw2ICs1NCwxMSBAQCBSZW5kZXJUaGVt ZUNvY29hJiBSZW5kZXJUaGVtZUNvY29hOjpzaW5nbGV0b24oKQogICAgIHJldHVybiBzdGF0aWNf Y2FzdDxSZW5kZXJUaGVtZUNvY29hJj4oUmVuZGVyVGhlbWU6OnNpbmdsZXRvbigpKTsKIH0KIAor Ym9vbCBSZW5kZXJUaGVtZUNvY29hOjpjYW5QYWludChjb25zdCBQYWludEluZm8mIHBhaW50SW5m bykgY29uc3QKK3sKKyAgICByZXR1cm4gcGFpbnRJbmZvLmNvbnRleHQoKS5oYXNQbGF0Zm9ybUNv bnRleHQoKTsKK30KKwogYm9vbCBSZW5kZXJUaGVtZUNvY29hOjpzaG91bGRIYXZlQ2Fwc0xvY2tJ bmRpY2F0b3IoY29uc3QgSFRNTElucHV0RWxlbWVudCYgZWxlbWVudCkgY29uc3QKIHsKICAgICBy ZXR1cm4gZWxlbWVudC5pc1Bhc3N3b3JkRmllbGQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVBsYXlTdGF0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyVGhlbWVQbGF5U3RhdGlvbi5oCmluZGV4IDM1ODRjYzZjNzIzMi4uZTJk MGY5YjcyMzhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhl bWVQbGF5U3RhdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVt ZVBsYXlTdGF0aW9uLmgKQEAgLTM0LDYgKzM0LDggQEAgcHVibGljOgogICAgIGZyaWVuZCBOZXZl ckRlc3Ryb3llZDxSZW5kZXJUaGVtZVBsYXlTdGF0aW9uPjsKIAogcHJpdmF0ZToKKyAgICBib29s IGNhblBhaW50KGNvbnN0IFBhaW50SW5mbyYpIGNvbnN0IGZpbmFsIHsgcmV0dXJuIHRydWU7IH0K KwogICAgIHZvaWQgdXBkYXRlQ2FjaGVkU3lzdGVtRm9udERlc2NyaXB0aW9uKENTU1ZhbHVlSUQg c3lzdGVtRm9udElELCBGb250Q2FzY2FkZURlc2NyaXB0aW9uJikgY29uc3QgZmluYWw7CiB9Owog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uaCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5oCmluZGV4IDVlZWU4ZTY5 YTVhYy4uMWJlNzg5NTM0NmIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGhlbWVXaW4uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhl bWVXaW4uaApAQCAtMTQxLDYgKzE0MSw4IEBAIHByaXZhdGU6CiAgICAgUmVuZGVyVGhlbWVXaW4o KTsKICAgICB2aXJ0dWFsIH5SZW5kZXJUaGVtZVdpbigpOwogCisgICAgYm9vbCBjYW5QYWludChj b25zdCBQYWludEluZm8mKSBjb25zdCBmaW5hbCB7IHJldHVybiB0cnVlOyB9CisKICAgICAvLyBT eXN0ZW0gZm9udHMuCiAgICAgdm9pZCB1cGRhdGVDYWNoZWRTeXN0ZW1Gb250RGVzY3JpcHRpb24o Q1NTVmFsdWVJRCwgRm9udENhc2NhZGVEZXNjcmlwdGlvbiYpIGNvbnN0IG92ZXJyaWRlOwogCg==