214169 2020-07-09 17:45:42 -0700 MobileSafari rotates its scene to portrait upside down if it has a PiP on screen 2020-07-10 13:13:38 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 peng.liu6 peng.liu6 eric.carlson ews-watchlist glenn jer.noble philipj sam sergio webkit-bug-importer oldest_to_newest 1670339 0 peng.liu6 2020-07-09 17:45:42 -0700 MobileSafari rotates its scene to portrait upside down if it has a PiP on screen 1670340 1 403937 peng.liu6 2020-07-09 17:50:10 -0700 Created attachment 403937 Patch 1670341 2 peng.liu6 2020-07-09 17:50:44 -0700 <rdar://problem/64820800> 1670342 3 403937 sam 2020-07-09 17:51:39 -0700 Comment on attachment 403937 Patch What will it take to make a test for this? 1670344 4 403937 jer.noble 2020-07-09 17:56:02 -0700 Comment on attachment 403937 Patch I'm concerned that this line was in here for a good reason, like allowing a portrait-locked app to open video in landscape fullscreen. Maybe a better idea is to set `m_viewContrtoller.get()._ignoreAppSupportedOrientations = NO` when we hide the window? 1670492 5 peng.liu6 2020-07-10 10:32:09 -0700 (In reply to Sam Weinig from comment #3) > Comment on attachment 403937 [details] > Patch > > What will it take to make a test for this? We need a full UI test, where we can open a WK2 app, rotate the device into upside-down-mode, and verify that the UI doesn’t flip that way. That cannot be done with a layout test. We might be able to do that with an API test, but we need to fix a bug regarding video fullscreen and picture-in-picture test first (bug 212654). 1670495 6 jer.noble 2020-07-10 10:35:39 -0700 (In reply to Peng Liu from comment #5) > (In reply to Sam Weinig from comment #3) > > Comment on attachment 403937 [details] > > Patch > > > > What will it take to make a test for this? > > We need a full UI test, where we can open a WK2 app, rotate the device into > upside-down-mode, and verify that the UI doesn’t flip that way. That cannot > be done with a layout test. We might be able to do that with an API test, > but we need to fix a bug regarding video fullscreen and picture-in-picture > test first (bug 212654). We need more than API tests, because we can't drive simulated hardware rotations from API tests. XCUITest would be a reasonable framework for doing this, I think, but we don't have any XCUITests set up at the moment. XCUITests would let us do a bunch more tests of things like "is the fullscreen airplay button "active" during an airplay session", and the like. 1670498 7 403981 peng.liu6 2020-07-10 10:37:55 -0700 Created attachment 403981 Patch 1670501 8 peng.liu6 2020-07-10 10:41:12 -0700 (In reply to Jer Noble from comment #4) > Comment on attachment 403937 [details] > Patch > > I'm concerned that this line was in here for a good reason, like allowing a > portrait-locked app to open video in landscape fullscreen. > > Maybe a better idea is to set > `m_viewContrtoller.get()._ignoreAppSupportedOrientations = NO` when we hide > the window? Good point! I think we need to ignore App's supported orientations when a video is in fullscreen. But, when the video is in picture-in-picture, we should NOT ignore that. I have uploaded a new patch. 1670502 9 peng.liu6 2020-07-10 10:43:03 -0700 (In reply to Jer Noble from comment #6) > (In reply to Peng Liu from comment #5) > > We need more than API tests, because we can't drive simulated hardware > rotations from API tests. XCUITest would be a reasonable framework for doing > this, I think, but we don't have any XCUITests set up at the moment. > > XCUITests would let us do a bunch more tests of things like "is the > fullscreen airplay button "active" during an airplay session", and the like. Right! 1670557 10 ews-feeder 2020-07-10 13:13:38 -0700 Committed r264237: <https://trac.webkit.org/changeset/264237> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403981. 403937 2020-07-09 17:50:10 -0700 2020-07-10 10:37:54 -0700 Patch bug-214169-20200709175009.patch text/plain 1765 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTk2ZmE5ZjUxMzQzMjY1 MzFjNzBhMTU5YjRmNzFmZDE1ODcyNjBiMi4uOTk5MmEwNWQzYjFkZDAyNDhjNTIwYzI4YmVhZGMx ODNkNzQzODFhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3LTA5ICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgTW9iaWxlU2FmYXJpIHJvdGF0 ZXMgaXRzIHNjZW5lIHRvIHBvcnRyYWl0IHVwc2lkZSBkb3duIGlmIGl0IGhhcyBhIFBpUCBvbiBz Y3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx NDE2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBVSVZpZXdDb250cm9sbGVyIGZvciB2aWRlbyBmdWxsc2NyZWVuL3BpY3R1cmUtaW4tcGljdHVy ZSBzdXBwb3J0IHNob3VsZCBub3QgaWdub3JlCisgICAgICAgIHRoZSBBcHAncyBzdXBwb3J0ZWQg b3JpZW50YXRpb25zLgorCisgICAgICAgICogcGxhdGZvcm0vaW9zL1ZpZGVvRnVsbHNjcmVlbklu dGVyZmFjZUFWS2l0Lm1tOgorICAgICAgICAoVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6 OmRvU2V0dXApOgorCiAyMDIwLTA3LTA3ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNv bT4KIAogICAgICAgICBGaXggcG90ZW50aWFsIHBpeGVsIGJ1ZmZlciBsZWFrIGluIEltYWdlUm90 YXRpb25TZXNzaW9uVlQ6OnJvdGF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vaW9zL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vaW9zL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCmluZGV4IDM0Yzg3 MGE1YjUzZWE4NDM1NTM5Y2ViZThkNGVkMmE1ZWM3OGE2NzIuLmJiM2VlYzkzOGZjMDZkZmQ0Yjkz YTM0NWJkNTBmMThiMGRmYWY2ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2lvcy9WaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KQEAgLTEyOTEs NyArMTI5MSw2IEBAIHZvaWQgVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OmRvU2V0dXAo KQogICAgICAgICBpZiAoIW1fdmlld0NvbnRyb2xsZXIpCiAgICAgICAgICAgICBtX3ZpZXdDb250 cm9sbGVyID0gYWRvcHROUyhbUEFMOjphbGxvY1VJVmlld0NvbnRyb2xsZXJJbnN0YW5jZSgpIGlu aXRdKTsKICAgICAgICAgW1ttX3ZpZXdDb250cm9sbGVyIHZpZXddIHNldEZyYW1lOlttX3dpbmRv dyBib3VuZHNdXTsKLSAgICAgICAgW21fdmlld0NvbnRyb2xsZXIgX3NldElnbm9yZUFwcFN1cHBv cnRlZE9yaWVudGF0aW9uczpZRVNdOwogICAgICAgICBbbV93aW5kb3cgc2V0Um9vdFZpZXdDb250 cm9sbGVyOm1fdmlld0NvbnRyb2xsZXIuZ2V0KCldOwogICAgICAgICBbbV93aW5kb3cgc2V0V2lu ZG93TGV2ZWw6UEFMOjpnZXRfVUlLaXRfVUlUZXh0RWZmZWN0c0JlbmVhdGhTdGF0dXNCYXJXaW5k b3dMZXZlbCgpICsgMV07CiAgICAgICAgIFttX3dpbmRvdyBtYWtlS2V5QW5kVmlzaWJsZV07Cg== 403981 2020-07-10 10:37:55 -0700 2020-07-10 13:13:38 -0700 Patch bug-214169-20200710103755.patch text/plain 2219 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTk2ZmE5ZjUxMzQzMjY1 MzFjNzBhMTU5YjRmNzFmZDE1ODcyNjBiMi4uNTM5MDFiMjAyZjNhNTkyMmJlMjk5NTY1MzkzNGMy MjA4Yzk3YTcyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3LTA5ICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgTW9iaWxlU2FmYXJpIHJvdGF0 ZXMgaXRzIHNjZW5lIHRvIHBvcnRyYWl0IHVwc2lkZSBkb3duIGlmIGl0IGhhcyBhIFBpUCBvbiBz Y3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx NDE2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBVSVZpZXdDb250cm9sbGVyIGZvciB2aWRlbyBmdWxsc2NyZWVuL3BpY3R1cmUtaW4tcGljdHVy ZSBzaG91bGQgbm90IGlnbm9yZQorICAgICAgICB0aGUgQXBwJ3Mgc3VwcG9ydGVkIG9yaWVudGF0 aW9ucyB3aGVuIHRoZSB2aWRlbyBlbGVtZW50IGlzIGluIHBpY3R1cmUtaW4tcGljdHVyZS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2lvcy9WaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbToK KyAgICAgICAgKFZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Ojpkb1NldHVwKToKKwogMjAy MC0wNy0wNyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4 IHBvdGVudGlhbCBwaXhlbCBidWZmZXIgbGVhayBpbiBJbWFnZVJvdGF0aW9uU2Vzc2lvblZUOjpy b3RhdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9WaWRlb0Z1bGxz Y3JlZW5JbnRlcmZhY2VBVktpdC5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9WaWRl b0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQppbmRleCAzNGM4NzBhNWI1M2VhODQzNTUzOWNl YmU4ZDRlZDJhNWVjNzhhNjcyLi4yZGQ0NDI4YjY0YTVjN2ZkNzFhMjhlMzZjMjI2ZjhkMTdkZTIy ZTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvVmlkZW9GdWxsc2Ny ZWVuSW50ZXJmYWNlQVZLaXQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1Zp ZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCkBAIC0xMDc4LDYgKzEwNzgsNyBAQCB2b2lk IFZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpkaWRTdGFydFBpY3R1cmVJblBpY3R1cmUo KQogICAgIExPRyhGdWxsc2NyZWVuLCAiVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OmRp ZFN0YXJ0UGljdHVyZUluUGljdHVyZSglcCkiLCB0aGlzKTsKICAgICBzZXRNb2RlKEhUTUxNZWRp YUVsZW1lbnRFbnVtczo6VmlkZW9GdWxsc2NyZWVuTW9kZVBpY3R1cmVJblBpY3R1cmUpOwogICAg IFttX3BsYXllclZpZXdDb250cm9sbGVyIHNldFNob3dzUGxheWJhY2tDb250cm9sczpZRVNdOwor ICAgIFttX3ZpZXdDb250cm9sbGVyIF9zZXRJZ25vcmVBcHBTdXBwb3J0ZWRPcmllbnRhdGlvbnM6 Tk9dOwogCiAgICAgaWYgKG1fY3VycmVudE1vZGUuaGFzRnVsbHNjcmVlbigpKSB7CiAgICAgICAg IG1fc2hvdWxkUmV0dXJuVG9GdWxsc2NyZWVuV2hlblN0b3BwaW5nUGlQID0gWUVTOwpAQCAtMTE0 MCw2ICsxMTQxLDcgQEAgdm9pZCBWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6ZGlkU3Rv cFBpY3R1cmVJblBpY3R1cmUoKQogewogICAgIExPRyhGdWxsc2NyZWVuLCAiVmlkZW9GdWxsc2Ny ZWVuSW50ZXJmYWNlQVZLaXQ6OmRpZFN0b3BQaWN0dXJlSW5QaWN0dXJlKCVwKSIsIHRoaXMpOwog ICAgIG1fdGFyZ2V0TW9kZS5zZXRQaWN0dXJlSW5QaWN0dXJlKGZhbHNlKTsKKyAgICBbbV92aWV3 Q29udHJvbGxlciBfc2V0SWdub3JlQXBwU3VwcG9ydGVkT3JpZW50YXRpb25zOllFU107CiAKICAg ICBpZiAobV9jdXJyZW50TW9kZS5oYXNGdWxsc2NyZWVuKCkgfHwgbV9yZXN0b3JpbmdGdWxsc2Ny ZWVuRm9yUGljdHVyZUluUGljdHVyZVN0b3ApIHsKICAgICAgICAgY2xlYXJNb2RlKEhUTUxNZWRp YUVsZW1lbnRFbnVtczo6VmlkZW9GdWxsc2NyZWVuTW9kZVBpY3R1cmVJblBpY3R1cmUpOwo=