214144 2020-07-09 09:24:00 -0700 Simplify BoxPtr::create 2020-07-09 10:34:16 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 calvaris calvaris benjamin calvaris cdumez cmarcelo darin ews-watchlist webkit-bug-importer oldest_to_newest 1670132 0 calvaris 2020-07-09 09:24:00 -0700 Fix what Darin commented on comment 29 of bug 212379 1670135 1 403875 calvaris 2020-07-09 09:28:43 -0700 Created attachment 403875 Patch 1670150 2 403875 darin 2020-07-09 09:55:22 -0700 Comment on attachment 403875 Patch I also think that create is not the right word for something that takes ownership of an object. Maybe we need to rename those create functions to adopt. 1670166 3 ews-feeder 2020-07-09 10:34:00 -0700 Committed r264180: <https://trac.webkit.org/changeset/264180> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403875. 1670168 4 webkit-bug-importer 2020-07-09 10:34:16 -0700 <rdar://problem/65278265> 403875 2020-07-09 09:28:43 -0700 2020-07-09 10:34:01 -0700 Patch Patch.patch text/plain 1074 calvaris ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggNjFjZDhjNDg1ZGE4Li4yOTM3MDY4MDNkNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIw MjAtMDctMDkgIFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4K KworICAgICAgICBTaW1wbGlmeSBCb3hQdHI6OmNyZWF0ZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0MTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvQm94UHRyLmg6CisgICAgICAgIChXVEY6 OmNyZWF0ZUJveFB0cik6IFVzZSB0aGUgYWxpYXMgaW5zdGVhZCBvZiB0aGUgdW5yb2xsZWQgdHlw ZS4KKwogMjAyMC0wNy0wOSAgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtXVEZdIEltcGxlbWVudCBuZXcgQm94UHRyIGFsaWFzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Cb3hQdHIuaCBiL1NvdXJjZS9XVEYvd3RmL0JveFB0ci5o CmluZGV4IDY0NzdjYjAwMGQ5YS4uMDE0MmVmZmJkZjEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi9Cb3hQdHIuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Cb3hQdHIuaApAQCAtNDgsNyArNDgs NyBAQCB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiB1c2luZyBCb3hQdHIgPSBCb3g8c3RkOjp1bmlxdWVf cHRyPFQsIEJveFB0ckRlbGV0ZXI8VD4+PjsKIAogdGVtcGxhdGU8dHlwZW5hbWUgVD4gQm94UHRy PFQ+IGNyZWF0ZUJveFB0cihUKiBwdHIpCiB7Ci0gICAgcmV0dXJuIEJveDxzdGQ6OnVuaXF1ZV9w dHI8VCwgQm94UHRyRGVsZXRlcjxUPj4+OjpjcmVhdGUocHRyKTsKKyAgICByZXR1cm4gQm94UHRy PFQ+OjpjcmVhdGUocHRyKTsKIH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgVD4gYm9vbCBvcGVyYXRv cj09KGNvbnN0IEJveFB0cjxUPiYgbGhzLCBjb25zdCBCb3hQdHI8VD4mIHJocykK