214129 2020-07-09 05:03:54 -0700 Local internal builds fail on Apple Silicon (building yasm) 2020-07-10 06:01:49 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton ap jbedard mitz webkit-bug-importer oldest_to_newest 1670065 0 thorton 2020-07-09 05:03:54 -0700 Local internal builds fail on Apple Silicon (building yasm) 1670066 1 403856 thorton 2020-07-09 05:04:20 -0700 Created attachment 403856 Patch 1670083 2 403856 mitz 2020-07-09 06:48:57 -0700 Comment on attachment 403856 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403856&action=review > Tools/Scripts/webkitdirs.pm:375 > + if (isAppleCocoaWebKit() && $output eq "arm64") { Could combine with the above into one `if (isAppleCocoaWebKit())` block. > Tools/Scripts/webkitdirs.pm:376 > + $output = determineXcodeSDK(); Why are we assigning an SDK identifier to `$output` (which appears to hold an architecture) here? 1670162 3 403856 thorton 2020-07-09 10:14:10 -0700 Comment on attachment 403856 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403856&action=review >> Tools/Scripts/webkitdirs.pm:375 >> + if (isAppleCocoaWebKit() && $output eq "arm64") { > > Could combine with the above into one `if (isAppleCocoaWebKit())` block. I intentionally did not because the above block will go away and this one won’t. >> Tools/Scripts/webkitdirs.pm:376 >> + $output = determineXcodeSDK(); > > Why are we assigning an SDK identifier to `$output` (which appears to hold an architecture) here? Whoops! That was for debugging and I forgot to revert. Good catch. 1670174 4 403887 thorton 2020-07-09 10:41:47 -0700 Created attachment 403887 Patch 1670187 5 ews-feeder 2020-07-09 11:30:05 -0700 Committed r264182: <https://trac.webkit.org/changeset/264182> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403887. 1670188 6 webkit-bug-importer 2020-07-09 11:31:14 -0700 <rdar://problem/65281288> 1670423 7 403887 jbedard 2020-07-10 06:01:49 -0700 Comment on attachment 403887 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403887&action=review > Tools/Scripts/webkitdirs.pm:381 > + We need to make sure that run-javascriptcore-tests will override arm64e with arm64. I think it already does, but I don’t have a checkout handy. 403856 2020-07-09 05:04:20 -0700 2020-07-09 10:41:45 -0700 Patch bug-214129-20200709050420.patch text/plain 2423 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MTU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzg5ZjZmMjg2ZGQ5MGExOGYzNmJiMWNmMjQ4Yzk1YzY3 NThmMWI1Mi4uZWJhMzI4MTI4ZjUzZDRiZTMxODBiZTY1MTAwNzZiYjhiYzFhOGZlNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDIwLTA3LTA5ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgor CisgICAgICAgIExvY2FsIGludGVybmFsIGJ1aWxkcyBmYWlsIG9uIEFwcGxlIFNpbGljb24gKGJ1 aWxkaW5nIHlhc20pCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTQxMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVybWluZU5hdGl2ZUFy Y2hpdGVjdHVyZSk6CisgICAgICAgIEJ1aWxkIGZvciBhcm02NGUgd2hlbiBidWlsZGluZyB3aXRo IHRoZSBpbnRlcm5hbCBTREsuCisgICAgICAgIEltcG9ydGFudGx5LCB0aGlzIG1hdGNoZXMgdGhl IEFSQ0hTX1NUQU5EQVJEXyogYnVpbGQgc2V0dGluZ3MsIHNvIHRoaXMgd2F5IHdlCisgICAgICAg IHdvbid0IHNldCBhbiBBUkNIIHRoYXQgaXNuJ3QgaW4gVkFMSURfQVJDSFMgZm9yIHByb2plY3Rz IHdobyB1c2UgQVJDSFNfU1RBTkRBUkRfKi4KKworICAgICAgICAoZGV0ZXJtaW5lWGNvZGVTREsp OgorICAgICAgICBGYWxsIGJhY2sgdG8gIm1hY29zeCIsIHNvIHRoYXQgb3RoZXIgY29kZSBjYW4g Y29ycmVjdGx5IGlkZW50aWZ5IHRoYXQgd2UncmUgYnVpbGRpbmcgZm9yIG1hY09TLgorICAgICAg ICBUaGlzIGxvZ2ljIG5lZWRzIHRvIGJlIGhlcmUsIGluc3RlYWQgb2YgaW4gdGhlIGNhbGxlciAo d2hvIGNvdWxkIGFzc3VtZSB1bmRlZmluZWQgbWVhbnMgbWFjT1MpLAorICAgICAgICBiZWNhdXNl IHdlIHdhbnQgdGhlICIuaW50ZXJuYWwiIHNlYXJjaCB0byB0YWtlIHBsYWNlIGFzIHdlbGwuCisK IDIwMjAtMDctMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtTT1VQXSBBZGQgc3VwcG9ydCBmb3IgSFRUUENvb2tpZUFjY2VwdFBvbGljeTo6 T25seUZyb21NYWluRG9jdW1lbnREb21haW4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBlMGVkY2YyMDg5 ZjI0NzVmMjhkNDg1MTNhNzhiZWI5NmIzMWE5YTUxLi4yZjUxMTQxZTc3YzA0NzBiNWQzYjZhMmIw NmZmNTgxMDc2ZTJhNDY0IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0K KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0zNzEsOCArMzcxLDE1IEBAIHN1 YiBkZXRlcm1pbmVOYXRpdmVBcmNoaXRlY3R1cmUoOyQkKQogICAgIGlmIChpc0FwcGxlQ29jb2FX ZWJLaXQoKSAmJiAkb3V0cHV0IG5lICJ4ODZfNjQiKSB7CiAgICAgICAgICRvdXRwdXQgPSAiYXJt NjQiOwogICAgIH0KKworICAgIGlmIChpc0FwcGxlQ29jb2FXZWJLaXQoKSAmJiAkb3V0cHV0IGVx ICJhcm02NCIpIHsKKyAgICAgICAgJG91dHB1dCA9IGRldGVybWluZVhjb2RlU0RLKCk7CisgICAg ICAgIGlmICgkeGNvZGVTREsgZXEgIm1hY29zeC5pbnRlcm5hbCIpIHsKKyAgICAgICAgICAgICRv dXRwdXQgPSAiYXJtNjRlIjsKKyAgICAgICAgfQorICAgIH0KKwogICAgICRvdXRwdXQgPSAiYXJt IiBpZiAkb3V0cHV0IGVxICJhcm12N2wiOwotICAgIGRpZSAiJ2FybTY0ZScgaXMgYW4gaW52YWxp ZCBuYXRpdmUgYXJjaGl0ZWN0dXJlIiBpZiAkb3V0cHV0IGVxICJhcm02NGUiOwogICAgICRuYXRp dmVBcmNoaXRlY3R1cmVNYXB7IiR0YXJnZXQ6JHBvcnQifSA9ICRvdXRwdXQ7CiB9CiAKQEAgLTYz Miw3ICs2MzksMTEgQEAgc3ViIGRldGVybWluZVhjb2RlU0RLCiAgICAgaWYgKGNoZWNrRm9yQXJn dW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS1tYWNjYXRhbHlzdCIpKSB7CiAgICAgICAgICR4Y29k ZVNESyB8fD0gIm1hY2NhdGFseXN0IjsKICAgICB9Ci0gICAgcmV0dXJuIGlmICFkZWZpbmVkICR4 Y29kZVNESzsKKworICAgICMgRmluYWxseSwgZmFsbCBiYWNrIHRvIG1hY09TIGlmIG5vIHBsYXRm b3JtIGlzIHNwZWNpZmllZC4KKyAgICBpZiAoIWRlZmluZWQgJHhjb2RlU0RLKSB7CisgICAgICAg ICR4Y29kZVNESyA9ICJtYWNvc3giOworICAgIH0KICAgICAKICAgICAjIFByZWZlciB0aGUgaW50 ZXJuYWwgdmVyc2lvbiBvZiBhbiBzZGssIGlmIGl0IGV4aXN0cy4KICAgICBteSBAYXZhaWxhYmxl U0RLcyA9IGF2YWlsYWJsZVhjb2RlU0RLcygpOwo= 403887 2020-07-09 10:41:47 -0700 2020-07-09 11:30:05 -0700 Patch bug-214129-20200709104146.patch text/plain 2413 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MTU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzg5ZjZmMjg2ZGQ5MGExOGYzNmJiMWNmMjQ4Yzk1YzY3 NThmMWI1Mi4uZWJhMzI4MTI4ZjUzZDRiZTMxODBiZTY1MTAwNzZiYjhiYzFhOGZlNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDIwLTA3LTA5ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgor CisgICAgICAgIExvY2FsIGludGVybmFsIGJ1aWxkcyBmYWlsIG9uIEFwcGxlIFNpbGljb24gKGJ1 aWxkaW5nIHlhc20pCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTQxMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVybWluZU5hdGl2ZUFy Y2hpdGVjdHVyZSk6CisgICAgICAgIEJ1aWxkIGZvciBhcm02NGUgd2hlbiBidWlsZGluZyB3aXRo IHRoZSBpbnRlcm5hbCBTREsuCisgICAgICAgIEltcG9ydGFudGx5LCB0aGlzIG1hdGNoZXMgdGhl IEFSQ0hTX1NUQU5EQVJEXyogYnVpbGQgc2V0dGluZ3MsIHNvIHRoaXMgd2F5IHdlCisgICAgICAg IHdvbid0IHNldCBhbiBBUkNIIHRoYXQgaXNuJ3QgaW4gVkFMSURfQVJDSFMgZm9yIHByb2plY3Rz IHdobyB1c2UgQVJDSFNfU1RBTkRBUkRfKi4KKworICAgICAgICAoZGV0ZXJtaW5lWGNvZGVTREsp OgorICAgICAgICBGYWxsIGJhY2sgdG8gIm1hY29zeCIsIHNvIHRoYXQgb3RoZXIgY29kZSBjYW4g Y29ycmVjdGx5IGlkZW50aWZ5IHRoYXQgd2UncmUgYnVpbGRpbmcgZm9yIG1hY09TLgorICAgICAg ICBUaGlzIGxvZ2ljIG5lZWRzIHRvIGJlIGhlcmUsIGluc3RlYWQgb2YgaW4gdGhlIGNhbGxlciAo d2hvIGNvdWxkIGFzc3VtZSB1bmRlZmluZWQgbWVhbnMgbWFjT1MpLAorICAgICAgICBiZWNhdXNl IHdlIHdhbnQgdGhlICIuaW50ZXJuYWwiIHNlYXJjaCB0byB0YWtlIHBsYWNlIGFzIHdlbGwuCisK IDIwMjAtMDctMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CiAgICAgICAgIFtTT1VQXSBBZGQgc3VwcG9ydCBmb3IgSFRUUENvb2tpZUFjY2VwdFBvbGljeTo6 T25seUZyb21NYWluRG9jdW1lbnREb21haW4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBlMGVkY2YyMDg5 ZjI0NzVmMjhkNDg1MTNhNzhiZWI5NmIzMWE5YTUxLi43ZTZiNmMwZjg0NTc1Y2U1ZGQ2Nzg1Nzhi YjhmOTI5YWM2NDczYjJhIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0K KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0zNzEsOCArMzcxLDE1IEBAIHN1 YiBkZXRlcm1pbmVOYXRpdmVBcmNoaXRlY3R1cmUoOyQkKQogICAgIGlmIChpc0FwcGxlQ29jb2FX ZWJLaXQoKSAmJiAkb3V0cHV0IG5lICJ4ODZfNjQiKSB7CiAgICAgICAgICRvdXRwdXQgPSAiYXJt NjQiOwogICAgIH0KKworICAgIGlmIChpc0FwcGxlQ29jb2FXZWJLaXQoKSAmJiAkb3V0cHV0IGVx ICJhcm02NCIpIHsKKyAgICAgICAgZGV0ZXJtaW5lWGNvZGVTREsoKTsKKyAgICAgICAgaWYgKCR4 Y29kZVNESyBlcSAibWFjb3N4LmludGVybmFsIikgeworICAgICAgICAgICAgJG91dHB1dCA9ICJh cm02NGUiOworICAgICAgICB9CisgICAgfQorCiAgICAgJG91dHB1dCA9ICJhcm0iIGlmICRvdXRw dXQgZXEgImFybXY3bCI7Ci0gICAgZGllICInYXJtNjRlJyBpcyBhbiBpbnZhbGlkIG5hdGl2ZSBh cmNoaXRlY3R1cmUiIGlmICRvdXRwdXQgZXEgImFybTY0ZSI7CiAgICAgJG5hdGl2ZUFyY2hpdGVj dHVyZU1hcHsiJHRhcmdldDokcG9ydCJ9ID0gJG91dHB1dDsKIH0KIApAQCAtNjMyLDcgKzYzOSwx MSBAQCBzdWIgZGV0ZXJtaW5lWGNvZGVTREsKICAgICBpZiAoY2hlY2tGb3JBcmd1bWVudEFuZFJl bW92ZUZyb21BUkdWKCItLW1hY2NhdGFseXN0IikpIHsKICAgICAgICAgJHhjb2RlU0RLIHx8PSAi bWFjY2F0YWx5c3QiOwogICAgIH0KLSAgICByZXR1cm4gaWYgIWRlZmluZWQgJHhjb2RlU0RLOwor CisgICAgIyBGaW5hbGx5LCBmYWxsIGJhY2sgdG8gbWFjT1MgaWYgbm8gcGxhdGZvcm0gaXMgc3Bl Y2lmaWVkLgorICAgIGlmICghZGVmaW5lZCAkeGNvZGVTREspIHsKKyAgICAgICAgJHhjb2RlU0RL ID0gIm1hY29zeCI7CisgICAgfQogICAgIAogICAgICMgUHJlZmVyIHRoZSBpbnRlcm5hbCB2ZXJz aW9uIG9mIGFuIHNkaywgaWYgaXQgZXhpc3RzLgogICAgIG15IEBhdmFpbGFibGVTREtzID0gYXZh aWxhYmxlWGNvZGVTREtzKCk7Cg==