214128 2020-07-09 04:45:17 -0700 [MSE][GStreamer] Don't cache duration in MediaSourceClientGStreamerMSE 2020-07-09 05:30:27 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj pnormand sergio vjaquez oldest_to_newest 1670063 0 aboya 2020-07-09 04:45:17 -0700 MediaSource should be the single source of truth for the duration of the MediaSource, and querying it to MediaSource is efficient enough (trivial getter). There is no reason for MediaSourceClientGStreamerMSE to store a separate m_duration field. This patch introduces no behavior changes. 1670064 1 403855 aboya 2020-07-09 04:46:22 -0700 Created attachment 403855 Patch 1670074 2 ews-feeder 2020-07-09 05:30:26 -0700 Committed r264166: <https://trac.webkit.org/changeset/264166> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403855. 403855 2020-07-09 04:46:22 -0700 2020-07-09 05:30:27 -0700 Patch bug-214128-20200709134621.patch text/plain 3805 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTc5Yjk1ZmYwMjAyZWE5 Y2NlZDUzOTQ4MWJiY2VmMGM0NmQ3NTJmZC4uYjZiMzc4NGEwNTFhN2EwOTQwMmFmNTg2Y2U5MmE2 ZTEwMWYzYWUwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTA3LTA4ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIERvbid0IGNhY2hlIGR1cmF0aW9uIGluIE1lZGlhU291cmNlQ2xpZW50R1N0cmVhbWVy TVNFCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQx MjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZWRp YVNvdXJjZSBzaG91bGQgYmUgdGhlIHNpbmdsZSBzb3VyY2Ugb2YgdHJ1dGggZm9yIHRoZSBkdXJh dGlvbiBvZgorICAgICAgICB0aGUgTWVkaWFTb3VyY2UsIGFuZCBxdWVyeWluZyBpdCB0byBNZWRp YVNvdXJjZSBpcyBlZmZpY2llbnQgZW5vdWdoCisgICAgICAgICh0cml2aWFsIGdldHRlcikuIFRo ZXJlIGlzIG5vIHJlYXNvbiBmb3IgTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0UKKyAgICAg ICAgdG8gc3RvcmUgYSBzZXBhcmF0ZSBtX2R1cmF0aW9uIGZpZWxkLgorCisgICAgICAgIFRoaXMg cGF0Y2ggaW50cm9kdWNlcyBubyBiZWhhdmlvciBjaGFuZ2VzLgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9NZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRTo6TWVk aWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0UpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTb3Vy Y2VDbGllbnRHU3RyZWFtZXJNU0U6OmR1cmF0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh U291cmNlQ2xpZW50R1N0cmVhbWVyTVNFOjpkdXJhdGlvbkNoYW5nZWQpOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJN U0UuaDoKKwogMjAyMC0wNy0wOCAgQWxpY2lhIEJveWEgR2FyY8OtYSAgPGFib3lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgW01TRV1bR1N0cmVhbWVyXSBSZW1vdmUgb3JwaGFuIGNvZGUgaW4gU291 cmNlQnVmZmVyUHJpdmF0ZUdTdHJlYW1lcjo6YXBwZW5kKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFTb3VyY2VDbGllbnRH U3RyZWFtZXJNU0UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVh bWVyL21zZS9NZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRS5jcHAKaW5kZXggYzA5N2NhM2Ux NjcxN2Q4OGI3YjQ4NmEyMmVjYmE0NWQwOGVjM2QzNi4uMTlhYmVmZGY2OTAwZDUyNzNkZjBiMzk4 ODUyYTRlMWU3MTY5Njg1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL21zZS9NZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9NZWRpYVNv dXJjZUNsaWVudEdTdHJlYW1lck1TRS5jcHAKQEAgLTQ2LDcgKzQ2LDYgQEAgUmVmPE1lZGlhU291 cmNlQ2xpZW50R1N0cmVhbWVyTVNFPiBNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRTo6Y3Jl YXRlKE1lZGlhUGwKIAogTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFtZXJNU0U6Ok1lZGlhU291cmNl Q2xpZW50R1N0cmVhbWVyTVNFKE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRSYgcGxheWVy UHJpdmF0ZSkKICAgICA6IG1fcGxheWVyUHJpdmF0ZShwbGF5ZXJQcml2YXRlKQotICAgICwgbV9k dXJhdGlvbihNZWRpYVRpbWU6OmludmFsaWRUaW1lKCkpCiB7CiAgICAgQVNTRVJUKFdURjo6aXNN YWluVGhyZWFkKCkpOwogfQpAQCAtNzAsMTEgKzY5LDExIEBAIE1lZGlhU291cmNlUHJpdmF0ZTo6 QWRkU3RhdHVzIE1lZGlhU291cmNlQ2xpZW50R1N0cmVhbWVyTVNFOjphZGRTb3VyY2VCdWZmZXIo UmVmCiAgICAgcmV0dXJuIG1fcGxheWVyUHJpdmF0ZS5tX3BsYXliYWNrUGlwZWxpbmUtPmFkZFNv dXJjZUJ1ZmZlcihzb3VyY2VCdWZmZXJQcml2YXRlKTsKIH0KIAotY29uc3QgTWVkaWFUaW1lJiBN ZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRTo6ZHVyYXRpb24oKQorTWVkaWFUaW1lIE1lZGlh U291cmNlQ2xpZW50R1N0cmVhbWVyTVNFOjpkdXJhdGlvbigpCiB7CiAgICAgQVNTRVJUKFdURjo6 aXNNYWluVGhyZWFkKCkpOwogCi0gICAgcmV0dXJuIG1fZHVyYXRpb247CisgICAgcmV0dXJuIG1f cGxheWVyUHJpdmF0ZS5tZWRpYVNvdXJjZVByaXZhdGVDbGllbnQoKS0+ZHVyYXRpb24oKTsKIH0K IAogdm9pZCBNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRTo6ZHVyYXRpb25DaGFuZ2VkKGNv bnN0IE1lZGlhVGltZSYgZHVyYXRpb24pCkBAIC04NSw3ICs4NCw2IEBAIHZvaWQgTWVkaWFTb3Vy Y2VDbGllbnRHU3RyZWFtZXJNU0U6OmR1cmF0aW9uQ2hhbmdlZChjb25zdCBNZWRpYVRpbWUmIGR1 cmF0aW9uKQogICAgIGlmICghZHVyYXRpb24uaXNWYWxpZCgpIHx8IGR1cmF0aW9uLmlzUG9zaXRp dmVJbmZpbml0ZSgpIHx8IGR1cmF0aW9uLmlzTmVnYXRpdmVJbmZpbml0ZSgpKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBtX2R1cmF0aW9uID0gZHVyYXRpb247CiAgICAgbV9wbGF5ZXJQcml2YXRl LmR1cmF0aW9uQ2hhbmdlZCgpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL01lZGlhU291cmNlQ2xpZW50R1N0cmVhbWVyTVNF LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL01lZGlh U291cmNlQ2xpZW50R1N0cmVhbWVyTVNFLmgKaW5kZXggZTE3ZTdhZDM2ZmQyNDRiNzIwMTY1ZmIy NDRhYmVjZWQ3NWQ4MWJiNS4uNmRlMmY0NTY4Zjc1YmNiMGQ1MjUzOWMzYzJlZGMwMWZjNzMwZjAx OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L21zZS9NZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lck1TRS5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFt ZXJNU0UuaApAQCAtNTQsMTQgKzU0LDEzIEBAIHB1YmxpYzoKICAgICB2b2lkIGVucXVldWVTYW1w bGUoUmVmPE1lZGlhU2FtcGxlPiYmKTsKICAgICB2b2lkIGFsbFNhbXBsZXNJblRyYWNrRW5xdWV1 ZWQoY29uc3QgQXRvbVN0cmluZyYpOwogCi0gICAgY29uc3QgTWVkaWFUaW1lJiBkdXJhdGlvbigp OworICAgIE1lZGlhVGltZSBkdXJhdGlvbigpOwogICAgIEdSZWZQdHI8V2ViS2l0TWVkaWFTcmM+ IHdlYktpdE1lZGlhU3JjKCk7CiAKIHByaXZhdGU6CiAgICAgTWVkaWFTb3VyY2VDbGllbnRHU3Ry ZWFtZXJNU0UoTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNFJik7CiAKICAgICBNZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXJNU0UmIG1fcGxheWVyUHJpdmF0ZTsKLSAgICBNZWRpYVRpbWUg bV9kdXJhdGlvbjsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUuCg==