<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>21411</bug_id>
          
          <creation_ts>2008-10-06 14:13:04 -0700</creation_ts>
          <short_desc>ResourceHandleInternal.h uses NS class without C++ declaration</short_desc>
          <delta_ts>2008-10-06 18:05:46 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jeremy Moskovich">playmobil</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>94262</commentid>
    <comment_count>0</comment_count>
    <who name="Jeremy Moskovich">playmobil</who>
    <bug_when>2008-10-06 14:13:04 -0700</bug_when>
    <thetext>ResourceHandleInternal.h is included from ResourceHandle.cpp so it should be a valid C++ header.

However, contains a NSURLAuthenticationChallenge without a C++ compatible forward declaration.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94264</commentid>
    <comment_count>1</comment_count>
      <attachid>24122</attachid>
    <who name="Jeremy Moskovich">playmobil</who>
    <bug_when>2008-10-06 14:17:03 -0700</bug_when>
    <thetext>Created attachment 24122
Add forward declaration</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94265</commentid>
    <comment_count>2</comment_count>
      <attachid>24122</attachid>
    <who name="">mitz</who>
    <bug_when>2008-10-06 14:24:03 -0700</bug_when>
    <thetext>Comment on attachment 24122
Add forward declaration

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94266</commentid>
    <comment_count>3</comment_count>
    <who name="">mitz</who>
    <bug_when>2008-10-06 14:24:45 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 24122 [edit])
&gt; r=me

But please fix
+2008-10-06  Jeremy Moskovich  &lt;set EMAIL_ADDRESS environment variable&gt;

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94268</commentid>
    <comment_count>4</comment_count>
      <attachid>24123</attachid>
    <who name="Jeremy Moskovich">playmobil</who>
    <bug_when>2008-10-06 14:26:49 -0700</bug_when>
    <thetext>Created attachment 24123
Add email address to changelog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94270</commentid>
    <comment_count>5</comment_count>
      <attachid>24123</attachid>
    <who name="">mitz</who>
    <bug_when>2008-10-06 14:28:22 -0700</bug_when>
    <thetext>Comment on attachment 24123
Add email address to changelog.

r=me again</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>94311</commentid>
    <comment_count>6</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2008-10-06 18:05:46 -0700</bug_when>
    <thetext>Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/platform/network/ResourceHandleInternal.h
Committed r37357
</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>24122</attachid>
            <date>2008-10-06 14:17:03 -0700</date>
            <delta_ts>2008-10-06 14:26:49 -0700</delta_ts>
            <desc>Add forward declaration</desc>
            <filename>resourcehandle.patch</filename>
            <type>text/plain</type>
            <size>1240</size>
            <attacher name="Jeremy Moskovich">playmobil</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAzNzM0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTQgQEAKKzIwMDgtMTAtMDYgIEplcmVteSBNb3Nrb3ZpY2ggIDxzZXQgRU1BSUxf
QUREUkVTUyBlbnZpcm9ubWVudCB2YXJpYWJsZT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEFkZGVkIEMrKyBmb3J3YXJkIGRlY2xhcmF0
aW9uIGZvciB0aGUgTlNVUkxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSBjbGFzcworICAgICAgICBz
byB0aGF0IHRoZSBtX2N1cnJlbnRNYWNDaGFsbGVuZ2UgdmFyaWFibGUgZG9lc24ndCBjYXVzZSBh
CisgICAgICAgIGNvbXBpbGF0aW9uIGVycm9yIHdoZW4gUmVzb3VyY2VIYW5kbGVJbnRlcm5hbC5o
IGlzIGluY2x1ZGVkIGZyb20gYSBDKysgZmlsZS4KKyAgICAgICAgRml4ZXM6IGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQxMQorCisgICAgICAgICogcGxhdGZvcm0v
bmV0d29yay9SZXNvdXJjZUhhbmRsZUludGVybmFsLmg6CisKIDIwMDgtMTAtMDYgIERhbiBCZXJu
c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2Vpbmln
LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlSGFuZGxlSW50ZXJuYWwu
aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VIYW5kbGVJ
bnRlcm5hbC5oCShyZXZpc2lvbiAzNzM0NCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9S
ZXNvdXJjZUhhbmRsZUludGVybmFsLmgJKHdvcmtpbmcgY29weSkKQEAgLTU5LDggKzU5LDEwIEBA
IGNsYXNzIFFOZXR3b3JrUmVwbHlIYW5kbGVyOwogCiAjaWYgUExBVEZPUk0oTUFDKQogI2lmZGVm
IF9fT0JKQ19fCitAY2xhc3MgTlNVUkxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZTsKIEBjbGFzcyBO
U1VSTENvbm5lY3Rpb247CiAjZWxzZQorY2xhc3MgTlNVUkxBdXRoZW50aWNhdGlvbkNoYWxsZW5n
ZTsKIGNsYXNzIE5TVVJMQ29ubmVjdGlvbjsKICNlbmRpZgogI2VuZGlmCg==
</data>
<flag name="review"
          id="10946"
          type_id="1"
          status="+"
          setter="mitz"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>24123</attachid>
            <date>2008-10-06 14:26:49 -0700</date>
            <delta_ts>2008-10-06 14:28:22 -0700</delta_ts>
            <desc>Add email address to changelog.</desc>
            <filename>resourcehandle.patch</filename>
            <type>text/plain</type>
            <size>1221</size>
            <attacher name="Jeremy Moskovich">playmobil</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiAzNzM0NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTQgQEAKKzIwMDgtMTAtMDYgIEplcmVteSBNb3Nrb3ZpY2ggIDxqZXJlbXlAY2hy
b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAg
ICAKKyAgICAgICAgQWRkZWQgQysrIGZvcndhcmQgZGVjbGFyYXRpb24gZm9yIHRoZSBOU1VSTEF1
dGhlbnRpY2F0aW9uQ2hhbGxlbmdlIGNsYXNzCisgICAgICAgIHNvIHRoYXQgdGhlIG1fY3VycmVu
dE1hY0NoYWxsZW5nZSB2YXJpYWJsZSBkb2Vzbid0IGNhdXNlIGEKKyAgICAgICAgY29tcGlsYXRp
b24gZXJyb3Igd2hlbiBSZXNvdXJjZUhhbmRsZUludGVybmFsLmggaXMgaW5jbHVkZWQgZnJvbSBh
IEMrKyBmaWxlLgorICAgICAgICBGaXhlczogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIxNDExCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlSGFu
ZGxlSW50ZXJuYWwuaDoKKwogMjAwOC0xMC0wNiAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUu
Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBXZWJDb3JlL3Bs
YXRmb3JtL25ldHdvcmsvUmVzb3VyY2VIYW5kbGVJbnRlcm5hbC5oCj09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl
YkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZUhhbmRsZUludGVybmFsLmgJKHJldmlzaW9u
IDM3MzQ0KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlSGFuZGxlSW50ZXJu
YWwuaAkod29ya2luZyBjb3B5KQpAQCAtNTksOCArNTksMTAgQEAgY2xhc3MgUU5ldHdvcmtSZXBs
eUhhbmRsZXI7CiAKICNpZiBQTEFURk9STShNQUMpCiAjaWZkZWYgX19PQkpDX18KK0BjbGFzcyBO
U1VSTEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlOwogQGNsYXNzIE5TVVJMQ29ubmVjdGlvbjsKICNl
bHNlCitjbGFzcyBOU1VSTEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlOwogY2xhc3MgTlNVUkxDb25u
ZWN0aW9uOwogI2VuZGlmCiAjZW5kaWYK
</data>
<flag name="review"
          id="10947"
          type_id="1"
          status="+"
          setter="mitz"
    />
          </attachment>
      

    </bug>

</bugzilla>