214104 2020-07-08 16:01:07 -0700 Remove glBindFramebuffer flush workaround from ANGLE 2020-07-10 13:25:13 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 206625 1 kbr kbr dino ews-watchlist graouts jdarpinian justin_fan kondapallykalyan webkit-bug-importer oldest_to_newest 1669920 0 kbr 2020-07-08 16:01:07 -0700 In Bug 206625 a workaround was added to WebKit's snapshot of ANGLE to flush around calls to glBindFramebuffer on Intel GPUs as a potential way to address flakiness seen in layout tests after switching to the ANGLE backend. However, it's very likely that jdarpinian@'s fix for Bug 208724, setting the EGL_ROBUST_RESOURCE_INITIALIZATION_ANGLE context creation attribute to true, fixed the underlying root cause. The glBindFramebuffer flush workaround persists in WebKit's ANGLE snapshot, and should be removed as it's very likely unnecessary. 1670353 1 403940 kbr 2020-07-09 19:11:39 -0700 Created attachment 403940 Patch 1670354 2 ews-watchlist 2020-07-09 19:12:16 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1670559 3 ews-feeder 2020-07-10 13:24:55 -0700 Committed r264238: <https://trac.webkit.org/changeset/264238> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403940. 1670560 4 webkit-bug-importer 2020-07-10 13:25:13 -0700 <rdar://problem/65360176> 403940 2020-07-09 19:11:39 -0700 2020-07-10 13:24:56 -0700 Patch bug-214104-20200709191138.patch text/plain 3832 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MDI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggOWY3MDg3YmQ5NTA4ZjlkOTBiMTQ0NGU0OWZlYTcxZGU0Y2UxMTZiOC4uN2RkMDIxNmE2MWJj NmNiNWNmYTIzNzYzODc3NmE1ZDA5NjI4ODQ2YyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA3LTA5ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBnbEJpbmRGcmFtZWJ1ZmZlciBmbHVzaCB3b3Jr YXJvdW5kIGZyb20gQU5HTEUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxNDEwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJlbW92ZSB0aGlzIGRyaXZlciBidWcgd29ya2Fyb3VuZCwgd2hpY2ggdmVyeSBs aWtlbHkgaGFkIG5vCisgICAgICAgIGVmZmVjdCwgYW5kIHdoaWNoIHdhcyBuZXZlciB1cHN0cmVh bWVkIHRvIEFOR0xFLgorCisgICAgICAgICogaW5jbHVkZS9wbGF0Zm9ybS9GZWF0dXJlc0dMLmg6 CisgICAgICAgICogc3JjL2xpYkFOR0xFL3JlbmRlcmVyL2dsL1N0YXRlTWFuYWdlckdMLmNwcDoK KyAgICAgICAgKHJ4OjpTdGF0ZU1hbmFnZXJHTDo6YmluZEZyYW1lYnVmZmVyKToKKyAgICAgICAg KiBzcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvcmVuZGVyZXJnbF91dGlscy5jcHA6CisgICAgICAg IChyeDo6bmF0aXZlZ2xfZ2w6OkluaXRpYWxpemVGZWF0dXJlcyk6CisKIDIwMjAtMDYtMzAgIEFu ZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtYY29kZV0gRW5hYmxlIHRo ZSAiTXkgTWFjIChNYWMgQ2F0YWx5c3QpIiBkZXN0aW5hdGlvbiBpbiBXZWJLaXQgWGNvZGUgcHJv amVjdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL2luY2x1ZGUvcGxhdGZv cm0vRmVhdHVyZXNHTC5oIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvaW5jbHVkZS9wbGF0Zm9y bS9GZWF0dXJlc0dMLmgKaW5kZXggNDExYzllNDM2MzlhZGMzZTE0ZjAzNjVlN2QzZWI2ODc1N2Ni ZGQ0ZC4uNGUyNTE0YWIyNmFhZGNlYTJiNjYyYTU3N2Y2ZTgzYjQxYzAzNzM4NiAxMDA2NDQKLS0t IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvaW5jbHVkZS9wbGF0Zm9ybS9GZWF0dXJlc0dMLmgK KysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvaW5jbHVkZS9wbGF0Zm9ybS9GZWF0dXJlc0dM LmgKQEAgLTQxOCwxMiArNDE4LDYgQEAgc3RydWN0IEZlYXR1cmVzR0wgOiBGZWF0dXJlU2V0QmFz ZQogICAgICAgICAiUmV3cml0ZSByb3cgbWFqb3IgbWF0cmljZXMgaW4gc2hhZGVycyBhcyBjb2x1 bW4gbWFqb3IgYXMgYSBkcml2ZXIgYnVnIHdvcmthcm91bmQiLAogICAgICAgICAmbWVtYmVycywg Imh0dHA6Ly9hbmdsZWJ1Zy5jb20vMjI3MyJ9OwogCi0gICAgLy8gRmx1c2ggYmVmb3JlIGdsQmlu ZEZyYW1lYnVmZmVyIGFzIGEgZHJpdmVyIGJ1ZyB3b3JrYXJvdW5kIGlmIG5lY2Vzc2FyeS4KLSAg ICBGZWF0dXJlIGZsdXNoQmVmb3JlQmluZEZyYW1lYnVmZmVyID0gewotICAgICAgICAiZmx1c2hf YmVmb3JlX2JpbmRmcmFtZWJ1ZmZlciIsIEZlYXR1cmVDYXRlZ29yeTo6T3BlbkdMV29ya2Fyb3Vu ZHMsCi0gICAgICAgICJGbHVzaCBiZWZvcmUgZ2xCaW5kRnJhbWVidWZmZXIgYXMgYSBkcml2ZXIg YnVnIHdvcmthcm91bmQiLAotICAgICAgICAmbWVtYmVycywgImh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDY2MjUifTsKLQogICAgIC8vIEJ1Z3MgZXhpc3QgaW4gdmFy aW91cyBPcGVuR0wgSW50ZWwgZHJpdmVycyBvbiBXaW5kb3dzIHRoYXQgcHJvZHVjZSBpbmNvcnJl Y3QKICAgICAvLyB2YWx1ZXMgZm9yIEdMX0NPTVBSRVNTRURfU1JHQl9TM1RDX0RYVDFfRVhUIGZv cm1hdC4gUmVwbGFjZSBpdCB3aXRoCiAgICAgLy8gR0xfQ09NUFJFU1NFRF9TUkdCX0FMUEhBX1Mz VENfRFhUMV9FWFQgYXMgaXQncyB0aGUgY2xvc2VzdCBvcHRpb24gYWxsb3dlZCBieQpkaWZmIC0t Z2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL2dsL1N0 YXRlTWFuYWdlckdMLmNwcCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9y ZW5kZXJlci9nbC9TdGF0ZU1hbmFnZXJHTC5jcHAKaW5kZXggMjUzMDZjZmEyY2VjMjg5NTAwYjIy MTNkNmE4MTg2YzNkZmQ0NTJlOS4uZTJhMTBjYmZkNzkzNGQzZTFiNDlhYTI2OTQ3NWU5MTUxMTdi ZDFhYSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3Jl bmRlcmVyL2dsL1N0YXRlTWFuYWdlckdMLmNwcAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdM RS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvU3RhdGVNYW5hZ2VyR0wuY3BwCkBAIC01ODAsOSAr NTgwLDYgQEAgdm9pZCBTdGF0ZU1hbmFnZXJHTDo6c2V0UGl4ZWxQYWNrQnVmZmVyKGNvbnN0IGds OjpCdWZmZXIgKnBpeGVsQnVmZmVyKQogCiB2b2lkIFN0YXRlTWFuYWdlckdMOjpiaW5kRnJhbWVi dWZmZXIoR0xlbnVtIHR5cGUsIEdMdWludCBmcmFtZWJ1ZmZlcikKIHsKLSAgICBpZiAobUZlYXR1 cmVzLmZsdXNoQmVmb3JlQmluZEZyYW1lYnVmZmVyLmVuYWJsZWQpCi0gICAgICAgIG1GdW5jdGlv bnMtPmZsdXNoKCk7Ci0KICAgICBzd2l0Y2ggKHR5cGUpCiAgICAgewogICAgICAgICBjYXNlIEdM X0ZSQU1FQlVGRkVSOgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xp YkFOR0xFL3JlbmRlcmVyL2dsL3JlbmRlcmVyZ2xfdXRpbHMuY3BwIGIvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL2dsL3JlbmRlcmVyZ2xfdXRpbHMuY3BwCmlu ZGV4IDY2ZmYxMDllNDM5NjAzMTM4NjU1ODRhZjBmNWIxNGM4ZjA4MjhjNmIuLmZlYzFlZDUzOWZk ODczNTJmMTFmMTE2ZDJiYjE4MTY3Mzg2MTg4OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBh cnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9nbC9yZW5kZXJlcmdsX3V0aWxzLmNwcAor KysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvcmVu ZGVyZXJnbF91dGlscy5jcHAKQEAgLTE3MTEsOSArMTcxMSw2IEBAIHZvaWQgSW5pdGlhbGl6ZUZl YXR1cmVzKGNvbnN0IEZ1bmN0aW9uc0dMICpmdW5jdGlvbnMsIGFuZ2xlOjpGZWF0dXJlc0dMICpm ZWF0dXJlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gVE9ETyhhbmdsZWJ1Zy5jb20v MjI3Myk6IGRpYWdub3NlIGNyYXNoZXMgd2l0aCB0aGlzIHdvcmthcm91bmQuCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZmFsc2UpOwogCi0gICAgLy8gYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDY2MjUKLSAgICBBTkdMRV9GRUFUVVJFX0NPTkRJVElPTihmZWF0dXJlcywg Zmx1c2hCZWZvcmVCaW5kRnJhbWVidWZmZXIsIElzQXBwbGUoKSAmJiBpc0ludGVsKTsKLQogICAg IC8vIFdvcmthcm91bmQgZm9yIGluY29ycmVjdCBzYW1wbGluZyBmcm9tIERYVDEgc1JHQiB0ZXh0 dXJlcyBpbiBJbnRlbCBPcGVuR0wgb24gV2luZG93cy4KICAgICBBTkdMRV9GRUFUVVJFX0NPTkRJ VElPTihmZWF0dXJlcywgYXZvaWREWFQxc1JHQlRleHR1cmVGb3JtYXQsIElzV2luZG93cygpICYm IGlzSW50ZWwpOwogCg==