214101 2020-07-08 15:20:40 -0700 [Windows] Fix errors from calls to uname when not available 2020-07-08 17:15:14 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo stephan.szabo darin ews-watchlist glenn jbedard saam webkit-bug-importer oldest_to_newest 1669909 0 stephan.szabo 2020-07-08 15:20:40 -0700 uname is not something guaranteed available for Windows. Recent updates for calling uname have appeared to cause errors or warnings for commands (build-webkit, check-webkit-style, etc) when used from non-posix shells (like powershell or cmd). 1669916 1 403812 stephan.szabo 2020-07-08 15:49:05 -0700 Created attachment 403812 Patch 1669925 2 403812 darin 2020-07-08 16:25:39 -0700 Comment on attachment 403812 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403812&action=review Seems OK > Tools/Scripts/webkitdirs.pm:365 > - $output = `uname -m`; > + if (!isWindows()) { > + $output = `uname -m`; > + } In Perl we would idiomatically write this: $output = `uname -m` unless isWindows(); > Tools/Scripts/webkitdirs.pm:369 > + chomp $output if (defined $output); No need for those parentheses. 1669929 3 403818 stephan.szabo 2020-07-08 16:35:50 -0700 Created attachment 403818 Patch 1669959 4 ews-feeder 2020-07-08 17:14:46 -0700 Committed r264142: <https://trac.webkit.org/changeset/264142> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403818. 1669960 5 webkit-bug-importer 2020-07-08 17:15:14 -0700 <rdar://problem/65248364> 403812 2020-07-08 15:49:05 -0700 2020-07-08 16:35:50 -0700 Patch 214101.1.diff text/plain 2604 stephan.szabo ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2MTVi N2QxN2JkMy4uMWNjMjlmYjk2NzEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAyMC0wNy0wOCAgU3RlcGhhbiBTemFi byAgPHN0ZXBoYW4uc3phYm9Ac29ueS5jb20+CisKKyAgICAgICAgW1dpbmRvd3NdIEZpeCBlcnJv cnMgZnJvbSBjYWxscyB0byB1bmFtZSB3aGVuIG5vdCBhdmFpbGFibGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDEwMQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzIGJhcmUgd2luZG93cyBkb2Vzbid0 IGRlZmF1bHQgdG8gaGF2aW5nIHVuYW1lLCBhdm9pZCBjYWxscworICAgICAgICB0byBpdCBmb3Ig YXJjaGl0ZWN0dXJlIGRldGVybWluYXRpb24uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRp cnMucG06CisgICAgICAgICAgRG8gbm90IGNhbGwgdW5hbWUgb24gd2luZG93cyAobm9uLWN5Z3dp bikgcGVybAorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9y bWluZm8ucHk6CisgICAgICAgICAgRG8gbm90IGNhbGwgdW5hbWUgZm9yIHdpbmRvd3MgKG5vbi1j eWd3aW4pIHB5dGhvbiwKKyAgICAgICAgICBvcy51bmFtZSgpIGFsc28gZG9lc24ndCBuZWNlc3Nh cmlseSBleGlzdCB0aGVyZSwgCisgICAgICAgICAgc28gdXNlIHBsYXRmb3JtLnVuYW1lKCkgaW5z dGVhZC4KKwogMjAyMC0wNy0wOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5j b20+CiAKICAgICAgICAgW3dlYmtpdHB5XSBydW4tbWluaWJyb3dzZXIgZG9lc24ndCBkZWZhdWx0 IHRvIG1hYyBhbmQgc3Rkb3V0L3N0ZGVyciBhcmUgbm90IGRpc3BsYXllZApkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt CmluZGV4IGE0MThjYmRiM2QxLi5hMzE1YTNmYmFjYiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMzYw LDExICszNjAsMTMgQEAgc3ViIGRldGVybWluZU5hdGl2ZUFyY2hpdGVjdHVyZSg7JCQpCiAKICAg ICBteSAkb3V0cHV0OwogICAgIGlmICgkdGFyZ2V0IGVxICIiKSB7Ci0gICAgICAgICRvdXRwdXQg PSBgdW5hbWUgLW1gOworICAgICAgICBpZiAoIWlzV2luZG93cygpKSB7CisgICAgICAgICAgICAk b3V0cHV0ID0gYHVuYW1lIC1tYDsKKyAgICAgICAgfQogICAgIH0gZWxzZSB7CiAgICAgICAgICRv dXRwdXQgPSBgc3NoIC1vIE5vSG9zdEF1dGhlbnRpY2F0aW9uRm9yTG9jYWxob3N0PXllcyAtcCAk cG9ydCAkdGFyZ2V0ICd1bmFtZSAgLW0nYDsKICAgICB9Ci0gICAgY2hvbXAgJG91dHB1dDsKKyAg ICBjaG9tcCAkb3V0cHV0IGlmIChkZWZpbmVkICRvdXRwdXQpOwogICAgICRvdXRwdXQgPSAieDg2 XzY0IiBpZiAobm90IGRlZmluZWQgJG91dHB1dCk7CiAKICAgICAjIEZJWE1FOiBSZW1vdmUgdGhp cyB3aGVuIDxyZGFyOi8vcHJvYmxlbS82NDIwODUzMj4gaXMgcmVzb2x2ZWQKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWluZm8ucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5CmluZGV4 IDEwNGE2NDVhZTllLi5iNjc5MjNhY2VlMyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5mby5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5CkBAIC0zMSw2ICszMSw3IEBAIGlt cG9ydCBvcwogaW1wb3J0IGxvZ2dpbmcKIGltcG9ydCByZQogaW1wb3J0IHN5cworaW1wb3J0IHBs YXRmb3JtCiAKIGZyb20gd2Via2l0cHkuY29tbW9uLm1lbW9pemVkIGltcG9ydCBtZW1vaXplZAog ZnJvbSB3ZWJraXRweS5jb21tb24udmVyc2lvbiBpbXBvcnQgVmVyc2lvbgpAQCAtMTA5LDYgKzEx MCwxMSBAQCBjbGFzcyBQbGF0Zm9ybUluZm8ob2JqZWN0KToKICAgICBAbWVtb2l6ZWQKICAgICBk ZWYgYXJjaGl0ZWN0dXJlKHNlbGYpOgogICAgICAgICB0cnk6CisgICAgICAgICAgICAjIFdpbmRv d3MgZG9lc24ndCBoYXZlIGJ1aWx0IGluIHVuYW1lLCBub3IgZ3VhcmFudGVlIG9mCisgICAgICAg ICAgICAjIG9zLnVuYW1lKCkKKyAgICAgICAgICAgIGlmIG9zLm5hbWUgPT0gJ250JzoKKyAgICAg ICAgICAgICAgICByZXR1cm4gcGxhdGZvcm0udW5hbWUoKVs0XQorCiAgICAgICAgICAgICAjIG9z LnVuYW1lKCkgd29uJ3Qgd29yayBvbiBlbWJlZGRlZCBkZXZpY2VzLCB3ZSBtYXkgc3VwcG9ydCBt dWx0aXBsZSBhcmNoaXRlY3R1cmVzIGZvciBhIHNpbmdsZSBlbWJlZGRlZCBwbGF0Zm9ybQogICAg ICAgICAgICAgb3V0cHV0ID0gc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsndW5hbWUnLCAn LW0nXSkucnN0cmlwKCkKICAgICAgICAgICAgIGlmIG91dHB1dDoK 403818 2020-07-08 16:35:50 -0700 2020-07-08 17:14:47 -0700 Patch 214101.2.diff text/plain 2574 stephan.szabo ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2MTVi N2QxN2JkMy4uMWNmYzg2M2FlMzMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAyMC0wNy0wOCAgU3RlcGhhbiBTemFi byAgPHN0ZXBoYW4uc3phYm9Ac29ueS5jb20+CisKKyAgICAgICAgW1dpbmRvd3NdIEZpeCBlcnJv cnMgZnJvbSBjYWxscyB0byB1bmFtZSB3aGVuIG5vdCBhdmFpbGFibGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDEwMQorCisgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgIEFzIGJhcmUgd2luZG93cyBkb2Vzbid0IGRl ZmF1bHQgdG8gaGF2aW5nIHVuYW1lLCBhdm9pZCBjYWxscworICAgICAgICB0byBpdCBmb3IgYXJj aGl0ZWN0dXJlIGRldGVybWluYXRpb24uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMu cG06CisgICAgICAgICAgRG8gbm90IGNhbGwgdW5hbWUgb24gd2luZG93cyAobm9uLWN5Z3dpbikg cGVybAorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWlu Zm8ucHk6CisgICAgICAgICAgRG8gbm90IGNhbGwgdW5hbWUgZm9yIHdpbmRvd3MgKG5vbi1jeWd3 aW4pIHB5dGhvbiwKKyAgICAgICAgICBvcy51bmFtZSgpIGFsc28gZG9lc24ndCBuZWNlc3Nhcmls eSBleGlzdCB0aGVyZSwgCisgICAgICAgICAgc28gdXNlIHBsYXRmb3JtLnVuYW1lKCkgaW5zdGVh ZC4KKwogMjAyMC0wNy0wOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW3dlYmtpdHB5XSBydW4tbWluaWJyb3dzZXIgZG9lc24ndCBkZWZhdWx0IHRv IG1hYyBhbmQgc3Rkb3V0L3N0ZGVyciBhcmUgbm90IGRpc3BsYXllZApkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmlu ZGV4IGE0MThjYmRiM2QxLi4zODc5YzVjYzM1YiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMzYwLDEx ICszNjAsMTEgQEAgc3ViIGRldGVybWluZU5hdGl2ZUFyY2hpdGVjdHVyZSg7JCQpCiAKICAgICBt eSAkb3V0cHV0OwogICAgIGlmICgkdGFyZ2V0IGVxICIiKSB7Ci0gICAgICAgICRvdXRwdXQgPSBg dW5hbWUgLW1gOworICAgICAgICAkb3V0cHV0ID0gYHVuYW1lIC1tYCB1bmxlc3MgaXNXaW5kb3dz KCk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgJG91dHB1dCA9IGBzc2ggLW8gTm9Ib3N0QXV0aGVu dGljYXRpb25Gb3JMb2NhbGhvc3Q9eWVzIC1wICRwb3J0ICR0YXJnZXQgJ3VuYW1lICAtbSdgOwog ICAgIH0KLSAgICBjaG9tcCAkb3V0cHV0OworICAgIGNob21wICRvdXRwdXQgaWYgZGVmaW5lZCAk b3V0cHV0OwogICAgICRvdXRwdXQgPSAieDg2XzY0IiBpZiAobm90IGRlZmluZWQgJG91dHB1dCk7 CiAKICAgICAjIEZJWE1FOiBSZW1vdmUgdGhpcyB3aGVuIDxyZGFyOi8vcHJvYmxlbS82NDIwODUz Mj4gaXMgcmVzb2x2ZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L3N5c3RlbS9wbGF0Zm9ybWluZm8ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9z eXN0ZW0vcGxhdGZvcm1pbmZvLnB5CmluZGV4IDEwNGE2NDVhZTllLi5iNjc5MjNhY2VlMyAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5m by5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1p bmZvLnB5CkBAIC0zMSw2ICszMSw3IEBAIGltcG9ydCBvcwogaW1wb3J0IGxvZ2dpbmcKIGltcG9y dCByZQogaW1wb3J0IHN5cworaW1wb3J0IHBsYXRmb3JtCiAKIGZyb20gd2Via2l0cHkuY29tbW9u Lm1lbW9pemVkIGltcG9ydCBtZW1vaXplZAogZnJvbSB3ZWJraXRweS5jb21tb24udmVyc2lvbiBp bXBvcnQgVmVyc2lvbgpAQCAtMTA5LDYgKzExMCwxMSBAQCBjbGFzcyBQbGF0Zm9ybUluZm8ob2Jq ZWN0KToKICAgICBAbWVtb2l6ZWQKICAgICBkZWYgYXJjaGl0ZWN0dXJlKHNlbGYpOgogICAgICAg ICB0cnk6CisgICAgICAgICAgICAjIFdpbmRvd3MgZG9lc24ndCBoYXZlIGJ1aWx0IGluIHVuYW1l LCBub3IgZ3VhcmFudGVlIG9mCisgICAgICAgICAgICAjIG9zLnVuYW1lKCkKKyAgICAgICAgICAg IGlmIG9zLm5hbWUgPT0gJ250JzoKKyAgICAgICAgICAgICAgICByZXR1cm4gcGxhdGZvcm0udW5h bWUoKVs0XQorCiAgICAgICAgICAgICAjIG9zLnVuYW1lKCkgd29uJ3Qgd29yayBvbiBlbWJlZGRl ZCBkZXZpY2VzLCB3ZSBtYXkgc3VwcG9ydCBtdWx0aXBsZSBhcmNoaXRlY3R1cmVzIGZvciBhIHNp bmdsZSBlbWJlZGRlZCBwbGF0Zm9ybQogICAgICAgICAgICAgb3V0cHV0ID0gc2VsZi5fZXhlY3V0 aXZlLnJ1bl9jb21tYW5kKFsndW5hbWUnLCAnLW0nXSkucnN0cmlwKCkKICAgICAgICAgICAgIGlm IG91dHB1dDoK