214093 2020-07-08 12:21:34 -0700 Add a fuzzing toggle for LICM 2020-07-08 14:34:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov guijemont jsc32 keith_miller mark.lam msaboff rmorisset ross.kirsling ticaiolima tuomas.webkit tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1669844 0 saam 2020-07-08 12:21:34 -0700 Since we have an AI based safety checker for LICM, it's helpful to fuzz that we've implemented our AI safety checker correctly by deciding to randomly not hoist nodes. 1669854 1 403803 saam 2020-07-08 12:35:11 -0700 Created attachment 403803 patch 1669858 2 403803 ysuzuki 2020-07-08 12:42:29 -0700 Comment on attachment 403803 patch View in context: https://bugs.webkit.org/attachment.cgi?id=403803&action=review r=me > Source/JavaScriptCore/dfg/DFGLICMPhase.cpp:185 > + WeakRandom random { Options::seedForLICMFuzzer() }; Initialize it only when using with useLICMFuzzing. WeakRandom reads random seeds from entropy pool and this is super slow. 1669872 3 403803 saam 2020-07-08 13:35:29 -0700 Comment on attachment 403803 patch View in context: https://bugs.webkit.org/attachment.cgi?id=403803&action=review >> Source/JavaScriptCore/dfg/DFGLICMPhase.cpp:185 >> + WeakRandom random { Options::seedForLICMFuzzer() }; > > Initialize it only when using with useLICMFuzzing. WeakRandom reads random seeds from entropy pool and this is super slow. Even when it’s seeded? 1669884 4 saam 2020-07-08 14:13:11 -0700 (In reply to Saam Barati from comment #3) > Comment on attachment 403803 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=403803&action=review > > >> Source/JavaScriptCore/dfg/DFGLICMPhase.cpp:185 > >> + WeakRandom random { Options::seedForLICMFuzzer() }; > > > > Initialize it only when using with useLICMFuzzing. WeakRandom reads random seeds from entropy pool and this is super slow. > > Even when it’s seeded? I've verified that this only does simple arithmetic when it's seeded. The default seed is "cryptographicallyRandomNumber()", which is probably what you're thinking about. 1669894 5 ews-feeder 2020-07-08 14:33:58 -0700 Committed r264133: <https://trac.webkit.org/changeset/264133> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403803. 1669895 6 webkit-bug-importer 2020-07-08 14:34:13 -0700 <rdar://problem/65241432> 403803 2020-07-08 12:35:11 -0700 2020-07-08 14:33:59 -0700 patch c-backup.diff text/plain 3949 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjY0MTI1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDIwLTA3LTA4ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEFkZCBhIGZ1enppbmcgdG9nZ2xlIGZvciBMSUNNCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQwOTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZSBoYXZlIGFuIEFJIGJhc2VkIHNhZmV0eSBjaGVja2Vy IGZvciBMSUNNLCB0byBkZXRlcm1pbmUgaWYgaXQncyBzYWZlIHRvCisgICAgICAgIGhvaXN0IG5v ZGVzLiBIaXN0b3JpY2FsbHksIHdlJ3ZlIGhhZCBidWdzIGhlcmUsIHdoZXJlIHdlIGFsbG93IHVu c2FmZQorICAgICAgICBob2lzdGluZy4gSW4gcHJhY3RpY2UsIHdlJ3ZlIGJlZW4gc2F2ZWQgYnkg c2FmZXR5IGNoZWNrcyBhbHNvIGJlaW5nIGhvaXN0ZWQKKyAgICAgICAgYXQgdGhlIHNhbWUgdGlt ZSBhcyB0aGUgb3BlcmF0aW9uIHRoZXkncmUgcHJvdGVjdGluZywgc28gZXZlbiBpZiB3ZQorICAg ICAgICBoYXZlIGJ1Z3MgaW4gQUktYmFzZWQgc2FmZVRvRXhlY3V0ZSwgdGhpbmdzIHVzdWFsbHkg anVzdCB3b3JrLiBTaW5jZQorICAgICAgICB3ZSd2ZSBoYWQgc2VjdXJpdHkgYnVncyBoZXJlIGJl Zm9yZSwgd2hlcmUgdGhlIHNhZmV0eSBjaGVja3MgZG9uJ3QgZ2V0IGhvaXN0ZWQsCisgICAgICAg IGxlYWRpbmcgdG8gaXNzdWVzLCBpdCdzIGhlbHBmdWwgaWYgd2UgY2FuIGZ1enogdGhpcyBhcmVh LiAgVGhpcyBwYXRjaCBpbXBsZW1lbnRzCisgICAgICAgIGEgd2F5IHRvIHNheXMgd2Ugd29uJ3Qg aG9pc3QgYSBub2RlIGJhc2VkIG9uIHNvbWUgcHJvYmFiaWxpdHksIGFsbG93aW5nIHVzIHRvIHBs YXkKKyAgICAgICAgd2l0aCB3aGF0IGRvZXMgYW5kIGRvZXNuJ3QgZ2V0IGhvaXN0ZWQuCisKKyAg ICAgICAgKiBkZmcvREZHTElDTVBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpMSUNNUGhh c2U6OnJ1bik6CisgICAgICAgICogcnVudGltZS9PcHRpb25zTGlzdC5oOgorCiAyMDIwLTA3LTA4 ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIHdheSB0 byByZXR1cm4gZWFybHkgZnJvbSBkZXRlY3RlZCBpbmZpbml0ZSBsb29wcyB0byBhaWQgdGhlIGZ1 enplcgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdMSUNNUGhhc2UuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTElDTVBoYXNlLmNwcAko cmV2aXNpb24gMjY0MTE4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdMSUNNUGhh c2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODEsNiArMTgxLDkgQEAgcHVibGljOgogICAgICAg ICAvLyB0ZW5kIHRvIGhvaXN0IGRvbWluYXRvcnMgYmVmb3JlIGRvbWluYXRlZXMuCiAgICAgICAg IFZlY3Rvcjxjb25zdCBOYXR1cmFsTG9vcCo+IGxvb3BTdGFjazsKICAgICAgICAgYm9vbCBjaGFu Z2VkID0gZmFsc2U7CisKKyAgICAgICAgV2Vha1JhbmRvbSByYW5kb20geyBPcHRpb25zOjpzZWVk Rm9yTElDTUZ1enplcigpIH07CisKICAgICAgICAgZm9yIChCYXNpY0Jsb2NrKiBibG9jayA6IG1f Z3JhcGguYmxvY2tzSW5QcmVPcmRlcigpKSB7CiAgICAgICAgICAgICBpZiAoIWJsb2NrLT5jZmFI YXNWaXNpdGVkKQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwpAQCAtMjEzLDggKzIxNiwxNyBA QCBwdWJsaWM6CiAgICAgICAgICAgICAgICAgTm9kZSomIG5vZGVSZWYgPSBibG9jay0+YXQobm9k ZUluZGV4KTsKICAgICAgICAgICAgICAgICBpZiAobm9kZVJlZi0+b3AoKSA9PSBGb3JjZU9TUkV4 aXQpCiAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgICAgIGZvciAodW5z aWduZWQgc3RhY2tJbmRleCA9IGxvb3BTdGFjay5zaXplKCk7IHN0YWNrSW5kZXgtLTspCisgICAg ICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBzdGFja0luZGV4ID0gbG9vcFN0YWNrLnNpemUoKTsg c3RhY2tJbmRleC0tOykgeworICAgICAgICAgICAgICAgICAgICBpZiAoVU5MSUtFTFkoT3B0aW9u czo6dXNlTElDTUZ1enppbmcoKSkpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0ZXhw ciBkb3VibGUgcmFuZ2UgPSBzdGF0aWNfY2FzdDxkb3VibGU+KHN0ZDo6bnVtZXJpY19saW1pdHM8 dWludDMyX3Q+OjptYXgoKSk7CisgICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCBmbG9v ciA9IHN0YXRpY19jYXN0PHVuc2lnbmVkPigoMS4wIC0gT3B0aW9uczo6YWxsb3dIb2lzdGluZ0xJ Q01Qcm9iYWJpbGl0eSgpKSAqIHJhbmdlKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wg c2hvdWxkQXR0ZW1wdEhvaXN0ID0gcmFuZG9tLmdldFVpbnQzMigpID49IGZsb29yOworICAgICAg ICAgICAgICAgICAgICAgICAgaWYgKCFzaG91bGRBdHRlbXB0SG9pc3QpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICAgICAgICAgIH0KKwogICAgICAg ICAgICAgICAgICAgICBjaGFuZ2VkIHw9IGF0dGVtcHRIb2lzdChibG9jaywgbm9kZVJlZiwgbG9v cFN0YWNrW3N0YWNrSW5kZXhdKTsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAg ICAgICAgIH0KIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9uc0xp c3QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25z TGlzdC5oCShyZXZpc2lvbiAyNjQxMTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PcHRpb25zTGlzdC5oCSh3b3JraW5nIGNvcHkpCkBAIC01MTIsNiArNTEyLDkgQEAgY29uc3Rl eHByIGJvb2wgZW5hYmxlV2ViQXNzZW1ibHlTdHJlYW1pbgogICAgIHYoQm9vbCwgdXNlUHJpdmF0 ZUNsYXNzRmllbGRzLCBmYWxzZSwgTm9ybWFsLCAiSWYgdHJ1ZSwgdGhlIHBhcnNlciB3aWxsIHVu ZGVyc3RhbmQgcHJpdmF0ZSBkYXRhIGZpZWxkcyBpbnNpZGUgY2xhc3Nlcy4iKSBcCiAgICAgdihC b29sLCByZXR1cm5FYXJseUZyb21JbmZpbml0ZUxvb3BzRm9yRnV6emluZywgZmFsc2UsIE5vcm1h bCwgbnVsbHB0cikgXAogICAgIHYoU2l6ZSwgZWFybHlSZXR1cm5Gcm9tSW5maW5pdGVMb29wc0xp bWl0LCAxMzAwMDAwMDAwLCBOb3JtYWwsICJXaGVuIHJldHVybkVhcmx5RnJvbUluZmluaXRlTG9v cHNGb3JGdXp6aW5nIGlzIHRydWUsIHRoaXMgZGV0ZXJtaW5lcyB0aGUgbnVtYmVyIG9mIGV4ZWN1 dGlvbnMgYSBsb29wIGNhbiBydW4gZm9yIGJlZm9yZSBqdXN0IHJldHVybmluZy4gVGhpcyBpcyBo ZWxwZnVsIGZvciB0aGUgZnV6emVyIHNvIGl0IGRvZXNuJ3QgZ2V0IHN0dWNrIGluIGluZmluaXRl IGxvb3BzLiIpIFwKKyAgICB2KEJvb2wsIHVzZUxJQ01GdXp6aW5nLCBmYWxzZSwgTm9ybWFsLCBu dWxscHRyKSBcCisgICAgdihVbnNpZ25lZCwgc2VlZEZvckxJQ01GdXp6ZXIsIDQyNDI0MiwgTm9y bWFsLCBudWxscHRyKSBcCisgICAgdihEb3VibGUsIGFsbG93SG9pc3RpbmdMSUNNUHJvYmFiaWxp dHksIDAuNSwgTm9ybWFsLCBudWxscHRyKSBcCiAKIGVudW0gT3B0aW9uRXF1aXZhbGVuY2Ugewog ICAgIFNhbWVPcHRpb24sCg==