214086 2020-07-08 09:04:11 -0700 [MSE][GStreamer] Remove orphan code in SourceBufferPrivateGStreamer::append() 2020-07-09 01:29:41 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris cgarcia eocanha ews-watchlist gustavo menard pnormand vjaquez oldest_to_newest 1669763 0 aboya 2020-07-08 09:04:11 -0700 A refactor in r240784 missed this line, which was unreachable code before and should have removed. Instead, it has been run every time after sending an append to the AppendPipeline, and it just happens it doesn't have visible consequences. This patch cleans that up removing that line. No visible behavior changes are introduces. 1669764 1 403786 aboya 2020-07-08 09:05:19 -0700 Created attachment 403786 Patch 1669773 2 eocanha 2020-07-08 09:23:57 -0700 I agree with this patch. The changes on r240784 made AppendPipeline::pushNewBuffer() unable to return any error for early append failure. Therefore the call to sourceBufferPrivateAppendComplete() (which should happend only in case of error) wouldn't be needed anymore. 1670045 3 ews-feeder 2020-07-09 01:29:39 -0700 Committed r264161: <https://trac.webkit.org/changeset/264161> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403786. 403786 2020-07-08 09:05:19 -0700 2020-07-09 01:29:40 -0700 Patch bug-214086-20200708180517.patch text/plain 1913 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODljYjQ0ZjRiOTdhODA1 ZDgxZjk3MDg1NjQ0MDc2N2ZkM2JjOTc0MC4uNTc5Yjk1ZmYwMjAyZWE5Y2NlZDUzOTQ4MWJiY2Vm MGM0NmQ3NTJmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTA3LTA4ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIFJlbW92ZSBvcnBoYW4gY29kZSBpbiBTb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVy OjphcHBlbmQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjE0MDg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQSByZWZhY3RvciBpbiByMjQwNzg0IG1pc3NlZCB0aGlzIGxpbmUsIHdoaWNoIHdhcyB1bnJl YWNoYWJsZSBjb2RlCisgICAgICAgIGJlZm9yZSBhbmQgc2hvdWxkIGhhdmUgcmVtb3ZlZC4KKwor ICAgICAgICBJbnN0ZWFkLCBpdCBoYXMgYmVlbiBydW4gZXZlcnkgdGltZSBhZnRlciBzZW5kaW5n IGFuIGFwcGVuZCB0byB0aGUKKyAgICAgICAgQXBwZW5kUGlwZWxpbmUsIGFuZCBpdCBqdXN0IGhh cHBlbnMgaXQgZG9lc24ndCBoYXZlIHZpc2libGUKKyAgICAgICAgY29uc2VxdWVuY2VzLgorCisg ICAgICAgIFRoaXMgcGF0Y2ggY2xlYW5zIHRoYXQgdXAgcmVtb3ZpbmcgdGhhdCBsaW5lLiBObyB2 aXNpYmxlIGJlaGF2aW9yCisgICAgICAgIGNoYW5nZXMgYXJlIGludHJvZHVjZWQuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL1NvdXJjZUJ1ZmZlclByaXZhdGVH U3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U291cmNlQnVmZmVyUHJpdmF0ZUdTdHJl YW1lcjo6YXBwZW5kKToKKwogMjAyMC0wNy0wOCAgQWxpY2lhIEJveWEgR2FyY8OtYSAgPGFib3lh QGlnYWxpYS5jb20+CiAKICAgICAgICAgW01TRV1bR1N0cmVhbWVyXSBNYWtlIGR1cmF0aW9uIGNo YW5nZXMgb25lIHdheQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL21zZS9Tb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvU291cmNlQnVmZmVyUHJp dmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggZDYxMjdjODVkYTY0NWUzMmI3YmU3Yzk2ZTZiYTg5MTQ2 OWE2MTliOS4uNjJiMDk2YzE2NDkyZmFiODlkNjMxMWQxNzljNjg2YWU2YWUwYzg0NCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9Tb3Vy Y2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL1NvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIuY3Bw CkBAIC03OCw3ICs3OCw2IEBAIHZvaWQgU291cmNlQnVmZmVyUHJpdmF0ZUdTdHJlYW1lcjo6YXBw ZW5kKFZlY3Rvcjx1bnNpZ25lZCBjaGFyPiYmIGRhdGEpCiAgICAgICAgIHJldHVybjsKIAogICAg IG1fY2xpZW50LT5hcHBlbmQodGhpcywgV1RGTW92ZShkYXRhKSk7Ci0gICAgbV9zb3VyY2VCdWZm ZXJQcml2YXRlQ2xpZW50LT5zb3VyY2VCdWZmZXJQcml2YXRlQXBwZW5kQ29tcGxldGUoU291cmNl QnVmZmVyUHJpdmF0ZUNsaWVudDo6UmVhZFN0cmVhbUZhaWxlZCk7CiB9CiAKIHZvaWQgU291cmNl QnVmZmVyUHJpdmF0ZUdTdHJlYW1lcjo6YWJvcnQoKQo=