214083 2020-07-08 08:35:41 -0700 [MSE][GStreamer] Make duration changes one way 2020-07-09 04:20:14 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris cgarcia eocanha eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj pnormand sergio vjaquez oldest_to_newest 1669750 0 aboya 2020-07-08 08:35:41 -0700 Until now, AppendPipeline emitted duration changes for the MediaSource. This was done with MediaSourcePrivateClient::durationChanged(const MediaTime&), a method which was added to MediaSource in r207889 just to implement this in the GStreamer port. This is not necessary though. AppendPipeline only needs to inform MediaSource of the duration of the initialization segment, and MediaSource will in turn set duration from the multi-platform code. This patch removes MediaSourcePrivateClient::durationChanged(const MediaTime&) from the multi-platform API, along with its usages in the GStreamer port, giving the multi-platform code sole responsibility on duration changes. This is a code cleanup and it's covered by existing tests. 1669753 1 403783 aboya 2020-07-08 08:46:00 -0700 Created attachment 403783 Patch 1669783 2 eocanha 2020-07-08 09:43:54 -0700 I agree with the change. This was something suggested by Jer Noble on https://bugs.webkit.org/show_bug.cgi?id=162920#c5, so it's great to have it implemented in this patch. 1670059 3 ews-feeder 2020-07-09 04:20:13 -0700 Committed r264164: <https://trac.webkit.org/changeset/264164> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403783. 403783 2020-07-08 08:46:00 -0700 2020-07-09 04:20:13 -0700 Patch bug-214083-20200708174558.patch text/plain 5977 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODQwNmNjNTNmN2ZlZTk2 OGUyZDczYjAzYzM3ZTZiOWVjNjg2NzlhMS4uODljYjQ0ZjRiOTdhODA1ZDgxZjk3MDg1NjQ0MDc2 N2ZkM2JjOTc0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM3IEBACisyMDIwLTA3LTA4ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIE1ha2UgZHVyYXRpb24gY2hhbmdlcyBvbmUgd2F5CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQwODMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVbnRpbCBub3csIEFwcGVuZFBpcGVsaW5lIGVt aXR0ZWQgZHVyYXRpb24gY2hhbmdlcyBmb3IgdGhlCisgICAgICAgIE1lZGlhU291cmNlLiBUaGlz IHdhcyBkb25lIHdpdGgKKyAgICAgICAgTWVkaWFTb3VyY2VQcml2YXRlQ2xpZW50OjpkdXJhdGlv bkNoYW5nZWQoY29uc3QgTWVkaWFUaW1lJiksIGEKKyAgICAgICAgbWV0aG9kIHdoaWNoIHdhcyBh ZGRlZCB0byBNZWRpYVNvdXJjZSBpbiByMjA3ODg5IGp1c3QgdG8gaW1wbGVtZW50CisgICAgICAg IHRoaXMgaW4gdGhlIEdTdHJlYW1lciBwb3J0LgorCisgICAgICAgIFRoaXMgaXMgbm90IG5lY2Vz c2FyeSB0aG91Z2guIEFwcGVuZFBpcGVsaW5lIG9ubHkgbmVlZHMgdG8gaW5mb3JtCisgICAgICAg IE1lZGlhU291cmNlIG9mIHRoZSBkdXJhdGlvbiBvZiB0aGUgaW5pdGlhbGl6YXRpb24gc2VnbWVu dCwgYW5kCisgICAgICAgIE1lZGlhU291cmNlIHdpbGwgaW4gdHVybiBzZXQgZHVyYXRpb24gZnJv bSB0aGUgbXVsdGktcGxhdGZvcm0gY29kZS4KKworICAgICAgICBUaGlzIHBhdGNoIHJlbW92ZXMg TWVkaWFTb3VyY2VQcml2YXRlQ2xpZW50OjpkdXJhdGlvbkNoYW5nZWQoY29uc3QKKyAgICAgICAg TWVkaWFUaW1lJikgZnJvbSB0aGUgbXVsdGktcGxhdGZvcm0gQVBJLCBhbG9uZyB3aXRoIGl0cyB1 c2FnZXMgaW4gdGhlCisgICAgICAgIEdTdHJlYW1lciBwb3J0LCBnaXZpbmcgdGhlIG11bHRpLXBs YXRmb3JtIGNvZGUgc29sZSByZXNwb25zaWJpbGl0eSBvbgorICAgICAgICBkdXJhdGlvbiBjaGFu Z2VzLgorCisgICAgICAgIFRoaXMgaXMgYSBjb2RlIGNsZWFudXAgYW5kIGl0J3MgY292ZXJlZCBi eSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFT b3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTb3VyY2U6OmR1cmF0aW9uQ2hhbmdl ZCk6IERlbGV0ZWQuCisgICAgICAgICogTW9kdWxlcy9tZWRpYXNvdXJjZS9NZWRpYVNvdXJjZS5o OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL01lZGlhU291cmNlUHJpdmF0ZUNsaWVudC5o OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxp bmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXBwZW5kUGlwZWxpbmU6OmRpZFJlY2VpdmVJbml0 aWFsaXphdGlvblNlZ21lbnQpOgorICAgICAgICAoV2ViQ29yZTo6QXBwZW5kUGlwZWxpbmU6OmNv bm5lY3REZW11eGVyU3JjUGFkVG9BcHBzaW5rKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvbXNlL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJNU0U6OmR1cmF0aW9uQ2hh bmdlZCk6CisKIDIwMjAtMDctMDggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI2MzgzNik6IFtHU3RyZWFtZXJdIERlYnVnIEFT U0VSVCBoaXRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNl L01lZGlhU291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvTWVk aWFTb3VyY2UuY3BwCmluZGV4IDBhMWIzYmE1NDM1NTI1YTYwOGE2NTkxNTQ2OGJjYTgwY2I3MGE5 NDkuLmU1YWYyYjE0YjQ4NGY3Njc1MWZmODdhYjQ1ZmY3ODZiZTUwMzQzZTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2UuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2UuY3BwCkBAIC0x NjUsMTIgKzE2NSw2IEBAIE1lZGlhVGltZSBNZWRpYVNvdXJjZTo6ZHVyYXRpb24oKSBjb25zdAog ICAgIHJldHVybiBtX2R1cmF0aW9uOwogfQogCi12b2lkIE1lZGlhU291cmNlOjpkdXJhdGlvbkNo YW5nZWQoY29uc3QgTWVkaWFUaW1lJiBkdXJhdGlvbikKLXsKLSAgICBBTFdBWVNfTE9HKExPR0lE RU5USUZJRVIsIGR1cmF0aW9uKTsKLSAgICBtX2R1cmF0aW9uID0gZHVyYXRpb247Ci19Ci0KIE1l ZGlhVGltZSBNZWRpYVNvdXJjZTo6Y3VycmVudFRpbWUoKSBjb25zdAogewogICAgIHJldHVybiBt X21lZGlhRWxlbWVudCA/IG1fbWVkaWFFbGVtZW50LT5jdXJyZW50TWVkaWFUaW1lKCkgOiBNZWRp YVRpbWU6Onplcm9UaW1lKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhc291cmNlL01lZGlhU291cmNlLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291 cmNlL01lZGlhU291cmNlLmgKaW5kZXggZjIzZTNmMzM4M2E3MDhjYWNlYjY3YTAxOTg2OTMzNGVm NWExNjRmOC4uMGU1OTAxMmUzZjFmNTZkYjc1NWYzZjg4ZDMwM2QwZmE4NGE0MzhhMyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9NZWRpYVNvdXJjZS5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2UuaApAQCAt NzksNyArNzksNiBAQCBwdWJsaWM6CiAgICAgdm9pZCBzdHJlYW1FbmRlZFdpdGhFcnJvcihPcHRp b25hbDxFbmRPZlN0cmVhbUVycm9yPik7CiAKICAgICBNZWRpYVRpbWUgZHVyYXRpb24oKSBjb25z dCBmaW5hbDsKLSAgICB2b2lkIGR1cmF0aW9uQ2hhbmdlZChjb25zdCBNZWRpYVRpbWUmKSBmaW5h bDsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8UGxhdGZvcm1UaW1lUmFuZ2VzPiBidWZmZXJlZCgpIGNv bnN0IGZpbmFsOwogCiAgICAgYm9vbCBhdHRhY2hUb0VsZW1lbnQoSFRNTE1lZGlhRWxlbWVudCYp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFTb3Vy Y2VQcml2YXRlQ2xpZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRp YVNvdXJjZVByaXZhdGVDbGllbnQuaAppbmRleCAzZmUyYWQ0ZTg1MTViMjI5YmZlYzkwNWNhMDA4 OTI0NWFmOTgwNDA5Li5iNTgwNTA4MWY5ZmE1OGIwOWEyOTdjZTcxOTVhNTQwZGYwNTZiNmIyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVNvdXJjZVBy aXZhdGVDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRp YVNvdXJjZVByaXZhdGVDbGllbnQuaApAQCAtNDIsNyArNDIsNiBAQCBwdWJsaWM6CiAKICAgICB2 aXJ0dWFsIHZvaWQgc2V0UHJpdmF0ZUFuZE9wZW4oUmVmPE1lZGlhU291cmNlUHJpdmF0ZT4mJikg PSAwOwogICAgIHZpcnR1YWwgTWVkaWFUaW1lIGR1cmF0aW9uKCkgY29uc3QgPSAwOwotICAgIHZp cnR1YWwgdm9pZCBkdXJhdGlvbkNoYW5nZWQoY29uc3QgTWVkaWFUaW1lJikgPSAwOwogICAgIHZp cnR1YWwgc3RkOjp1bmlxdWVfcHRyPFBsYXRmb3JtVGltZVJhbmdlcz4gYnVmZmVyZWQoKSBjb25z dCA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHNlZWtUb1RpbWUoY29uc3QgTWVkaWFUaW1lJikgPSAw OwogICAgIHZpcnR1YWwgdm9pZCBtb25pdG9yU291cmNlQnVmZmVycygpID0gMDsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5k UGlwZWxpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L21zZS9BcHBlbmRQaXBlbGluZS5jcHAKaW5kZXggZGMwMDk0OWM3MWYwNTg2YTNlMDg3Yzk5MWE3 YzgxNGE3YjhmMzZjYS4uYTAyNTRiZWQwYWU2Mjg5OGFmOGEwY2Y2NWI4NzNmYjk3M2NiNjkwMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21z ZS9BcHBlbmRQaXBlbGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5jcHAKQEAgLTQ5OSw3ICs0OTksNyBAQCB2 b2lkIEFwcGVuZFBpcGVsaW5lOjpkaWRSZWNlaXZlSW5pdGlhbGl6YXRpb25TZWdtZW50KCkKICAg ICBXZWJDb3JlOjpTb3VyY2VCdWZmZXJQcml2YXRlQ2xpZW50OjpJbml0aWFsaXphdGlvblNlZ21l bnQgaW5pdGlhbGl6YXRpb25TZWdtZW50OwogCiAgICAgR1NUX0RFQlVHKCJOb3RpZnlpbmcgU291 cmNlQnVmZmVyIGZvciB0cmFjayAlcyIsIChtX3RyYWNrKSA/IG1fdHJhY2stPmlkKCkuc3RyaW5n KCkudXRmOCgpLmRhdGEoKSA6IG51bGxwdHIpOwotICAgIGluaXRpYWxpemF0aW9uU2VnbWVudC5k dXJhdGlvbiA9IG1fbWVkaWFTb3VyY2VDbGllbnQtPmR1cmF0aW9uKCk7CisgICAgaW5pdGlhbGl6 YXRpb25TZWdtZW50LmR1cmF0aW9uID0gbV9pbml0aWFsRHVyYXRpb247CiAKICAgICBzd2l0Y2gg KG1fc3RyZWFtVHlwZSkgewogICAgIGNhc2UgQXVkaW86IHsKQEAgLTc2NCw5ICs3NjQsNiBAQCB2 b2lkIEFwcGVuZFBpcGVsaW5lOjpjb25uZWN0RGVtdXhlclNyY1BhZFRvQXBwc2luayhHc3RQYWQq IGRlbXV4ZXJTcmNQYWQpCiAgICAgfQogI2VuZGlmCiAKLSAgICBpZiAobV9tZWRpYVNvdXJjZUNs aWVudC0+ZHVyYXRpb24oKS5pc0ludmFsaWQoKSAmJiBtX2luaXRpYWxEdXJhdGlvbiA+IE1lZGlh VGltZTo6emVyb1RpbWUoKSkKLSAgICAgICAgbV9tZWRpYVNvdXJjZUNsaWVudC0+ZHVyYXRpb25D aGFuZ2VkKG1faW5pdGlhbER1cmF0aW9uKTsKLQogICAgIHBhcnNlRGVtdXhlclNyY1BhZENhcHMo Z3N0X2NhcHNfcmVmKGNhcHMuZ2V0KCkpKTsKIAogICAgIHN3aXRjaCAobV9zdHJlYW1UeXBlKSB7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv bXNlL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ck1TRS5jcHAKaW5kZXggMmY3OGY5ZTY0ODZmNWE4ZDFiMDU4MTc5ZGZhY2MzZDVkZGVhMGQzZC4u MWU5YzkyODEzZTliZjA2YjRmYmVmMWUwZWUyNmY4YWExN2UzMGYzYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9NZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXJNU0UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9tc2UvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNFLmNwcApAQCAt NzA3LDcgKzcwNyw2IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNFOjpkdXJh dGlvbkNoYW5nZWQoKQogICAgICAgICAgICAgbV9wbGF5YmFja1BpcGVsaW5lLT5ub3RpZnlEdXJh dGlvbkNoYW5nZWQoKTsKICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICBtX3Nob3VsZFJlcG9y dER1cmF0aW9uV2hlblVuYmxvY2tpbmcgPSB0cnVlOwotICAgICAgICBtX21lZGlhU291cmNlLT5k dXJhdGlvbkNoYW5nZWQobV9tZWRpYVRpbWVEdXJhdGlvbik7CiAgICAgfQogfQogCg==