214045 2020-07-07 08:25:41 -0700 [GTK][WPE] install-dependencies should install the gstreamer plugins 2020-07-08 04:03:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 clopez clopez agomez aperez calvaris clopez ews-watchlist ltilve mcatanzaro pnormand webkit-bug-importer zan oldest_to_newest 1669404 0 clopez 2020-07-07 08:25:41 -0700 When building webkit against system libraries (without flatpak/jhbuild) its needed to have installed the webkit plugins for play media files. The install-dependencies script should install those. 1669405 1 403691 clopez 2020-07-07 08:36:56 -0700 Created attachment 403691 Patch 1669427 2 calvaris 2020-07-07 09:27:31 -0700 I don't know how recommended this is since we have sometimes dependencies on certain patches or certain versions. 1669430 3 mcatanzaro 2020-07-07 09:36:39 -0700 Maybe these scripts should be changed to only install whatever dependencies are needed to build the flatpak runtime...? 1669454 4 clopez 2020-07-07 10:15:26 -0700 The idea of the install-dependencies script is to install every package you will need for developing webkit. The official way of developing developing webkit is with flatpak, but sometimes you might be interested in not using flatpak (I do). So I think its handy that this script makes easier to achieve that. Currently this scripts install every package you will need for - Building webkit with flatpak - Building webkit without flatpak (against your system libraries) - Running tests (with and without flatpak) For me that is fine, but if you are concerned with that maybe we can split this scripts? Perhaps something like this may work: - Tools/flatpak/install-dependencies: install dependencies for building/testing with flatpak - Tools/gtk/install-dependencies: install dependencies for building/testing without flatpak for gtk - Tools/wpe/install-dependencies: install dependencies for building/testing without flatpak for wpe But this looks it can be more confusing than what we have now. Personally I lean towards keeping this as is. I don't see this extra packages installed by the script as a concern. 1669458 5 clopez 2020-07-07 10:21:58 -0700 BTW, note this scripts are already installing libgstreamer-plugins-bad1.0-dev and libgstreamer-plugins-base1.0-dev from the system. This patch only changes that the plugins are also installed 1669711 6 ews-feeder 2020-07-08 04:02:35 -0700 Committed r264094: <https://trac.webkit.org/changeset/264094> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403691. 1669712 7 webkit-bug-importer 2020-07-08 04:03:17 -0700 <rdar://problem/65217902> 403691 2020-07-07 08:36:56 -0700 2020-07-08 04:02:35 -0700 Patch bug-214045-20200707173655.patch text/plain 4926 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MDE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjMxYjM4MjE0OWNlYzcyZDliNGIzODBlOGE3NzAyNjdm NDYxNDU1YS4uMDE1NmIyMzg0ZGRkY2IyZjI5MGJiNGI4MGU2N2NiZTU3OWY4ZTVjMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDIwLTA3LTA3ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gaW5zdGFsbC1kZXBlbmRlbmNpZXMgc2hvdWxk IGluc3RhbGwgdGhlIGdzdHJlYW1lciBwbHVnaW5zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQwNDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGJ1aWxkaW5nIHdlYmtpdCBhZ2FpbnN0IHN5c3Rl bSBsaWJyYXJpZXMgKHdpdGhvdXQgZmxhdHBhay9qaGJ1aWxkKQorICAgICAgICBpdHMgbmVlZGVk IHRvIGhhdmUgaW5zdGFsbGVkIHRoZSB3ZWJraXQgcGx1Z2lucyB0byBwbGF5IG1lZGlhIGZpbGVz LgorICAgICAgICBUaGUgaW5zdGFsbC1kZXBlbmRlbmNpZXMgc2NyaXB0IHNob3VsZCBpbnN0YWxs IHRoZW0uCisKKyAgICAgICAgZ3N0cmVhbWVyLXBsdWdpbnMtdWdseSBpdHMgbGlrZWx5IG5vdCBu ZWVkZWQgZm9yIHRoZSBtYWpvcml0eSBvZiB0aGUgY2FzZXMsCisgICAgICAgIGJ1dCBpdCBjYW4g YmUgcmVxdWlyZWQgYnkgc29tZSB1Z2x5IG1lZGlhIGZpbGVzIHRoYXQgcmVxdWlyZSBhbiB1Z2x5 IGRlY29kZXIuCisgICAgICAgIFNpbmNlIHdlIGFyZSBpbnN0YWxsaW5nIGl0IG9uIHRoZSBmbGF0 cGFrLCBsZXQncyBhZGQgaXQgaGVyZSBhcyB3ZWxsLgorCisgICAgICAgICogZ3RrL2luc3RhbGwt ZGVwZW5kZW5jaWVzOgorICAgICAgICAqIHdwZS9pbnN0YWxsLWRlcGVuZGVuY2llczoKKwogMjAy MC0wNy0wNyAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFk ZGVkIGEgdGVzdCBmb3IgY2FsbE9uTWFpblRocmVhZApkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2lu c3RhbGwtZGVwZW5kZW5jaWVzIGIvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCmluZGV4 IDYxMzY3YjUwMGNhM2YwZTE3OWIyZTViODI4NWNmNGQ5ZDVkZjQ0ODEuLjE0ZjI1NTYyOGQzYWY5 ZjRkMWRlNDY2MGNkYmM0MmRmZGJkNzA4Y2MgMTAwNzU1Ci0tLSBhL1Rvb2xzL2d0ay9pbnN0YWxs LWRlcGVuZGVuY2llcworKysgYi9Ub29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKQEAgLTI0 OSw2ICsyNDksMTYgQEAgZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhBcHQgewogICAg ICAgICBweXRob24zLXNlY3JldHN0b3JhZ2UgXAogICAgICAgICBzdWJ2ZXJzaW9uIgogCisgICAg IyBUaGVzZSBhcmUgR1N0cmVhbWVyIHBsdWdpbnMgbmVlZGVkIHRvIHBsYXkgZGlmZmVyZW50IG1l ZGlhIGZpbGVzLgorICAgIHBhY2thZ2VzPSIkcGFja2FnZXMgXAorICAgICAgICBnc3RyZWFtZXIx LjAtZ2wgXAorICAgICAgICBnc3RyZWFtZXIxLjAtbGliYXYgXAorICAgICAgICBnc3RyZWFtZXIx LjAtcGx1Z2lucy1iYWQgXAorICAgICAgICBnc3RyZWFtZXIxLjAtcGx1Z2lucy1iYXNlIFwKKyAg ICAgICAgZ3N0cmVhbWVyMS4wLXBsdWdpbnMtZ29vZCBcCisgICAgICAgIGdzdHJlYW1lcjEuMC1w bHVnaW5zLXVnbHkgXAorICAgICAgICBnc3RyZWFtZXIxLjAtcHVsc2VhdWRpbyIKKwogICAgIGFw dC1nZXQgaW5zdGFsbCAkcGFja2FnZXMKIAogICAgICMgVWJ1bnR1IEJpb25pYyBkb2Vzbid0IHNo aXAgcGlwZW52LiBTbyBmYWxsYmFjayB0byB0aGUgcGlwMyBpbnN0YWxsIHBhdGguCkBAIC0yODAs NyArMjkwLDYgQEAgZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhQYWNtYW4gewogICAg ICAgICBncmVwIFwKICAgICAgICAgZ3JvZmYgXAogICAgICAgICBnc3RyZWFtZXIgXAotICAgICAg ICBnc3QtcGx1Z2lucy1iYWQgXAogICAgICAgICBnc3QtcGx1Z2lucy1iYXNlLWxpYnMgXAogICAg ICAgICBnemlwIFwKICAgICAgICAgaHlwaGVuIFwKQEAgLTQyNCw2ICs0MzMsMTQgQEAgZnVuY3Rp b24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhQYWNtYW4gewogICAgIHBhY2thZ2VzPSIkcGFja2Fn ZXMgXAogICAgICAgICBweXRob24tc2VjcmV0c3RvcmFnZSBcCiAgICAgICAgIHN2biIKKworICAg ICMgVGhlc2UgYXJlIEdTdHJlYW1lciBwbHVnaW5zIG5lZWRlZCB0byBwbGF5IGRpZmZlcmVudCBt ZWRpYSBmaWxlcy4KKyAgICBwYWNrYWdlcz0iJHBhY2thZ2VzIFwKKyAgICAgICAgZ3N0LXBsdWdp bnMtYmFkIFwKKyAgICAgICAgZ3N0LXBsdWdpbnMtYmFzZSBcCisgICAgICAgIGdzdC1wbHVnaW5z LWdvb2QgXAorICAgICAgICBnc3QtcGx1Z2lucy11Z2x5IgorCiAgICAgcGFjbWFuIC1TIC0tbmVl ZGVkICRwYWNrYWdlcwogCiAJY2F0IDw8LUVPRgpAQCAtNTk5LDYgKzYxNiwxNSBAQCBmdW5jdGlv biBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aERuZiB7CiAgICAgICAgIHB5dGhvbjMtc2VjcmV0c3Rv cmFnZSBcCiAgICAgICAgIHN1YnZlcnNpb24iCiAKKyAgICAjIFRoZXNlIGFyZSBHU3RyZWFtZXIg cGx1Z2lucyBuZWVkZWQgdG8gcGxheSBkaWZmZXJlbnQgbWVkaWEgZmlsZXMuCisgICAgcGFja2Fn ZXM9IiRwYWNrYWdlcyBcCisgICAgICAgIGdzdHJlYW1lcjEtcGx1Z2lucy1iYWQtZnJlZSBcCisg ICAgICAgIGdzdHJlYW1lcjEtcGx1Z2lucy1iYWQtZnJlZS1leHRyYXMgXAorICAgICAgICBnc3Ry ZWFtZXIxLXBsdWdpbnMtYmFzZSBcCisgICAgICAgIGdzdHJlYW1lcjEtcGx1Z2lucy1nb29kIFwK KyAgICAgICAgZ3N0cmVhbWVyMS1wbHVnaW5zLWdvb2QtZXh0cmFzIFwKKyAgICAgICAgZ3N0cmVh bWVyMS1wbHVnaW5zLXVnbHktZnJlZSIKKwogICAgIGRuZiBpbnN0YWxsICRwYWNrYWdlcwogfQog CmRpZmYgLS1naXQgYS9Ub29scy93cGUvaW5zdGFsbC1kZXBlbmRlbmNpZXMgYi9Ub29scy93cGUv aW5zdGFsbC1kZXBlbmRlbmNpZXMKaW5kZXggYWQ4MjYyMTM1ZTlkMzZjMGVkMjUyMzllMjhlNjc5 ZjcwZjdjNjRmYS4uZTdhMGJlMjBhYjRjZGZlMzUwZjRlMGE5NmNkZjY2NDliOTEzMGQ0ZSAxMDA3 NTUKLS0tIGEvVG9vbHMvd3BlL2luc3RhbGwtZGVwZW5kZW5jaWVzCisrKyBiL1Rvb2xzL3dwZS9p bnN0YWxsLWRlcGVuZGVuY2llcwpAQCAtMTUyLDYgKzE1MiwxNiBAQCBmdW5jdGlvbiBpbnN0YWxs RGVwZW5kZW5jaWVzV2l0aEFwdCB7CiAgICAgICAgIHB5dGhvbjMtc2VjcmV0c3RvcmFnZSBcCiAg ICAgICAgIHN1YnZlcnNpb24iCiAKKyAgICAjIFRoZXNlIGFyZSBHU3RyZWFtZXIgcGx1Z2lucyBu ZWVkZWQgdG8gcGxheSBkaWZmZXJlbnQgbWVkaWEgZmlsZXMuCisgICAgcGFja2FnZXM9IiRwYWNr YWdlcyBcCisgICAgICAgIGdzdHJlYW1lcjEuMC1nbCBcCisgICAgICAgIGdzdHJlYW1lcjEuMC1s aWJhdiBcCisgICAgICAgIGdzdHJlYW1lcjEuMC1wbHVnaW5zLWJhZCBcCisgICAgICAgIGdzdHJl YW1lcjEuMC1wbHVnaW5zLWJhc2UgXAorICAgICAgICBnc3RyZWFtZXIxLjAtcGx1Z2lucy1nb29k IFwKKyAgICAgICAgZ3N0cmVhbWVyMS4wLXBsdWdpbnMtdWdseSBcCisgICAgICAgIGdzdHJlYW1l cjEuMC1wdWxzZWF1ZGlvIgorCiAgICAgYXB0LWdldCBpbnN0YWxsICRwYWNrYWdlcwogCiAgICAg IyBVYnVudHUgQmlvbmljIGRvZXNuJ3Qgc2hpcCBwaXBlbnYuIFNvIGZhbGxiYWNrIHRvIHRoZSBw aXAzIGluc3RhbGwgcGF0aC4KQEAgLTE4MSw3ICsxOTEsNiBAQCBmdW5jdGlvbiBpbnN0YWxsRGVw ZW5kZW5jaWVzV2l0aFBhY21hbiB7CiAgICAgICAgIGdyZXAgXAogICAgICAgICBncm9mZiBcCiAg ICAgICAgIGdzdHJlYW1lciBcCi0gICAgICAgIGdzdC1wbHVnaW5zLWJhZCBcCiAgICAgICAgIGdz dC1wbHVnaW5zLWJhc2UtbGlicyBcCiAgICAgICAgIGd6aXAgXAogICAgICAgICBpY3UgXApAQCAt MjY2LDYgKzI3NSwxNCBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aFBhY21hbiB7 CiAgICAgcGFja2FnZXM9IiRwYWNrYWdlcyBcCiAgICAgICAgIHB5dGhvbi1zZWNyZXRzdG9yYWdl IFwKICAgICAgICAgc3ZuIgorCisgICAgIyBUaGVzZSBhcmUgR1N0cmVhbWVyIHBsdWdpbnMgbmVl ZGVkIHRvIHBsYXkgZGlmZmVyZW50IG1lZGlhIGZpbGVzLgorICAgIHBhY2thZ2VzPSIkcGFja2Fn ZXMgXAorICAgICAgICBnc3QtcGx1Z2lucy1iYWQgXAorICAgICAgICBnc3QtcGx1Z2lucy1iYXNl IFwKKyAgICAgICAgZ3N0LXBsdWdpbnMtZ29vZCBcCisgICAgICAgIGdzdC1wbHVnaW5zLXVnbHki CisKICAgICBwYWNtYW4gLVMgLS1uZWVkZWQgJHBhY2thZ2VzCiAKIAljYXQgPDwtRU9GCkBAIC0z OTAsNiArNDA3LDE1IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRoRG5mIHsKICAg ICAgICAgcHl0aG9uMy1zZWNyZXRzdG9yYWdlIFwKICAgICAgICAgc3VidmVyc2lvbiIKIAorICAg ICMgVGhlc2UgYXJlIEdTdHJlYW1lciBwbHVnaW5zIG5lZWRlZCB0byBwbGF5IGRpZmZlcmVudCBt ZWRpYSBmaWxlcy4KKyAgICBwYWNrYWdlcz0iJHBhY2thZ2VzIFwKKyAgICAgICAgZ3N0cmVhbWVy MS1wbHVnaW5zLWJhZC1mcmVlIFwKKyAgICAgICAgZ3N0cmVhbWVyMS1wbHVnaW5zLWJhZC1mcmVl LWV4dHJhcyBcCisgICAgICAgIGdzdHJlYW1lcjEtcGx1Z2lucy1iYXNlIFwKKyAgICAgICAgZ3N0 cmVhbWVyMS1wbHVnaW5zLWdvb2QgXAorICAgICAgICBnc3RyZWFtZXIxLXBsdWdpbnMtZ29vZC1l eHRyYXMgXAorICAgICAgICBnc3RyZWFtZXIxLXBsdWdpbnMtdWdseS1mcmVlIgorCiAgICAgZG5m IGluc3RhbGwgJHBhY2thZ2VzCiB9CiAK