214032 2020-07-06 21:06:04 -0700 Function didCleanupFullscreencreen() should be called at the end of VideoFullscreenInterfaceAVKit::cleanupFullscreen() 2020-07-07 11:03:20 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 peng.liu6 peng.liu6 eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1669323 0 peng.liu6 2020-07-06 21:06:04 -0700 Function didCleanupFullscreencreen() should be called at the end of VideoFullscreenInterfaceAVKit::cleanupFullscreen() 1669324 1 peng.liu6 2020-07-06 21:08:36 -0700 <rdar://problem/65041486> 1669326 2 403663 peng.liu6 2020-07-06 21:12:38 -0700 Created attachment 403663 Patch 1669435 3 403663 eric.carlson 2020-07-07 09:46:29 -0700 Comment on attachment 403663 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403663&action=review > Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:987 > [playerController() setHasEnabledVideo:false]; > [playerController() setHasVideo:false]; Doesn't seem like we should have to call both of these, shouldn't setting `hasVideo` to false automatically set `hasEnabledVideo` to false? Not new to this patch, but it would be good to change this in a future cleanup. 1669466 4 403663 peng.liu6 2020-07-07 10:50:39 -0700 Comment on attachment 403663 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403663&action=review >> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:987 >> [playerController() setHasVideo:false]; > > Doesn't seem like we should have to call both of these, shouldn't setting `hasVideo` to false automatically set `hasEnabledVideo` to false? Not new to this patch, but it would be good to change this in a future cleanup. Right! We need to update WebAVPlayerController to do that. 1669470 5 ews-feeder 2020-07-07 11:03:20 -0700 Committed r264030: <https://trac.webkit.org/changeset/264030> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403663. 403663 2020-07-06 21:12:38 -0700 2020-07-07 11:03:20 -0700 Patch bug-214032-20200706211237.patch text/plain 2044 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzOTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMThmMjhiZGJmOTkwN2U5 MzU2YmQ0MzkxYjMxMjk2MTUyYWU0MGIwNS4uNzRiZDcyMTQ2M2RkODBmYmY4OTY4YjY1MzkxYTFi MmY2YmZjODEzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA3LTA2ICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgRnVuY3Rpb24gZGlkQ2xlYW51 cEZ1bGxzY3JlZW5jcmVlbigpIHNob3VsZCBiZSBjYWxsZWQgYXQgdGhlIGVuZCBvZiBWaWRlb0Z1 bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6Y2xlYW51cEZ1bGxzY3JlZW4oKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE0MDMyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVmlkZW9GdWxsc2NyZWVuTWFuYWdl clByb3h5OjpkaWRDbGVhbnVwRnVsbHNjcmVlbigpIG1heSBkZXN0cm95IGFuIGluc3RhbmNlIG9m IFZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0LgorICAgICAgICBTbyB3ZSBzaG91bGQgbm90 IGFjY2VzcyBtZW1iZXIgdmFyaWFibGVzIG9mIFZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0 IGFmdGVyIGNhbGxpbmcgZGlkQ2xlYW51cEZ1bGxzY3JlZW4oKQorICAgICAgICBpbiBWaWRlb0Z1 bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6Y2xlYW51cEZ1bGxzY3JlZW4oKS4KKworICAgICAgICBG aXggYSBmbGFreSB0ZXN0IGNyYXNoOiBtZWRpYS92aWRlby1hdXRvcGxheS5odG1sCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW06CisgICAg ICAgIChWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6Y2xlYW51cEZ1bGxzY3JlZW4pOgor CiAyMDIwLTA3LTA2ICBQZW5nIExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CiAKICAgICAgICAg Q2xlYW51cCBXZWJWaWRlb0Z1bGxzY3JlZW5Db250cm9sbGVyQVZLaXQubW0gYW5kIFBsYXliYWNr U2Vzc2lvbkludGVyZmFjZUFWS2l0Lm1tCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0gYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KaW5kZXggNTQw MjQzNzk3ZjgyODYwN2M0OGM4ZTg1M2VjMTBjMDZjMWMzYjAzMy4uMzRjODcwYTViNTNlYTg0MzU1 MzljZWJlOGQ0ZWQyYTVlYzc4YTY3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vaW9zL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2lvcy9WaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQpAQCAtOTgy LDEyICs5ODIsMTIgQEAgdm9pZCBWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6Y2xlYW51 cEZ1bGxzY3JlZW4oKQogICAgIG1fdmlkZW9WaWV3ID0gbmlsOwogICAgIG1fcGFyZW50VmlldyA9 IG5pbDsKICAgICBtX3BhcmVudFdpbmRvdyA9IG5pbDsKLSAgICAKLSAgICBpZiAobV9mdWxsc2Ny ZWVuQ2hhbmdlT2JzZXJ2ZXIpCi0gICAgICAgIG1fZnVsbHNjcmVlbkNoYW5nZU9ic2VydmVyLT5k aWRDbGVhbnVwRnVsbHNjcmVlbigpOwogCiAgICAgW3BsYXllckNvbnRyb2xsZXIoKSBzZXRIYXNF bmFibGVkVmlkZW86ZmFsc2VdOwogICAgIFtwbGF5ZXJDb250cm9sbGVyKCkgc2V0SGFzVmlkZW86 ZmFsc2VdOworCisgICAgaWYgKG1fZnVsbHNjcmVlbkNoYW5nZU9ic2VydmVyKQorICAgICAgICBt X2Z1bGxzY3JlZW5DaGFuZ2VPYnNlcnZlci0+ZGlkQ2xlYW51cEZ1bGxzY3JlZW4oKTsKIH0KIAog dm9pZCBWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6aW52YWxpZGF0ZSgpCg==