214026 2020-07-06 20:34:24 -0700 Fix CrashTracer reported in PDFPlugin::ByteRangeRequest::maybeComplete 2020-07-07 18:32:22 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson achristensen ap thorton oldest_to_newest 1669309 0 beidson 2020-07-06 20:34:24 -0700 Fix CrashTracer reported in PDFPlugin::ByteRangeRequest::maybeComplete <rdar://problem/64884982> 1669312 1 403658 beidson 2020-07-06 20:39:54 -0700 Created attachment 403658 Patch 1669402 2 ews-feeder 2020-07-07 08:20:14 -0700 Committed r264018: <https://trac.webkit.org/changeset/264018> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403658. 1669621 3 403658 ap 2020-07-07 18:32:09 -0700 Comment on attachment 403658 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403658&action=review > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1047 > + if (!plugin.m_data) > + return false; What makes it OK to access m_data without synchronization? From the ChangeLog, it sounds like it's manipulated from another thread. 403658 2020-07-06 20:39:54 -0700 2020-07-07 08:20:14 -0700 Patch bug-214026-20200706203953.patch text/plain 2296 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MDA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDliMjA4MzUyYTc5MDkxYzE0 ZjY0ODg2ZjMzZTg1M2Q4Nzg4NDk4YjMuLmFlNGExODk5NDNhOTliYWIyNmRiNDcxNWY3NmI1NWNk NWZmOTMxY2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMjAtMDctMDYgIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBDcmFzaFRyYWNlciByZXBv cnRlZCBpbiBQREZQbHVnaW46OkJ5dGVSYW5nZVJlcXVlc3Q6Om1heWJlQ29tcGxldGUuCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS82NDg4NDk4Mj4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTQwMjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKENyYXNoVHJhY2VyIHdpdGggbm8gcmVwcm9k dWN0aW9uKQorICAgICAgICAKKyAgICAgICAgRHVlIHRvIHRoZSByYWN5LW5lc3Mgb2YgaG93IFBE RktpdCBjYWxscyB1cyBvbiB0aGUgYmFja2dyb3VuZCB0aHJlYWQgdnMuIHdoYXQgbWlnaHQgYmUK KyAgICAgICAgaGFwcGVuaW5nIHdpdGggdGhlIG1haW4gdGhyZWFkLCBzb21ldGltZXMgdGhlIG1h aW4gdGhyZWFkIGlzIGFza2VkIHRvIGhhbmRsZSBhIGRhdGEKKyAgICAgICAgcmVxdWVzdCBlaXRo ZXI6CisgICAgICAgIC0gQmVmb3JlIG1fZGF0YSBpcyBhbGxvY2F0ZWQKKyAgICAgICAgICBvcgor ICAgICAgICAtIEFmdGVyIGl0IGlzIGRlYWxsb2NhdGVkCisKKyAgICAgICAgSW4gZWl0aGVyIGNh c2UgaXQncyBva2F5IHRvIGp1c3Qgbm90IGhhbmRsZSBpdC4KKworICAgICAgICBEZXNwaXRlIHVu ZGVyc3RhbmRpbmcgaG93IHRvIHJlcHJvZHVjZSBpbiB0aGVvcnksIHdyaXRpbmcgYSB0ZXN0IGNh c2UgaGFzIGJlZW4gZWx1c2l2ZS4KKyAgICAgICAgCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVn aW5zL1BERi9QREZQbHVnaW4ubW06CisgICAgICAgIChXZWJLaXQ6OlBERlBsdWdpbjo6Qnl0ZVJh bmdlUmVxdWVzdDo6bWF5YmVDb21wbGV0ZSk6IE51bGwgY2hlY2sgbV9kYXRhIGJlZm9yZSBkb2lu ZyBhbnl0aGluZyB3aXRoIGl0LgorCiAyMDIwLTA3LTA2ICBCcmFkeSBFaWRzb24gIDxiZWlkc29u QGFwcGxlLmNvbT4KIAogICAgICAgICBHZXQgcmlkIG9mIGNvbmNlcHQgb2YgImluaXRpYWwgY29u bmVjdGVkIGdhbWVwYWRzIgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1Bs dWdpbnMvUERGL1BERlBsdWdpbi5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5z L1BERi9QREZQbHVnaW4ubW0KaW5kZXggOGViMDA5ODhiODJiMGI0OWZlYWFmMDQ5MDc2ZjIyMjdm OTZlN2JiMS4uMjA3ZjJhODRiY2I1YWQzOTllNDNiMTAzMmRkOTIyZjJhNzAzMTcxNyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbQor KysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLm1tCkBA IC0xMDQzLDYgKzEwNDMsOSBAQCB2b2lkIFBERlBsdWdpbjo6Qnl0ZVJhbmdlUmVxdWVzdDo6Y29t cGxldGVXaXRoQWNjdW11bGF0ZWREYXRhKFBERlBsdWdpbiYgcGx1Z2luKQogCiBib29sIFBERlBs dWdpbjo6Qnl0ZVJhbmdlUmVxdWVzdDo6bWF5YmVDb21wbGV0ZShQREZQbHVnaW4mIHBsdWdpbikK IHsKKyAgICBpZiAoIXBsdWdpbi5tX2RhdGEpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAg IGlmIChwbHVnaW4ubV9zdHJlYW1lZEJ5dGVzID49IG1fcG9zaXRpb24gKyBtX2NvdW50KSB7CiAg ICAgICAgIGNvbXBsZXRlV2l0aEJ5dGVzKENGRGF0YUdldEJ5dGVQdHIocGx1Z2luLm1fZGF0YS5n ZXQoKSkgKyBtX3Bvc2l0aW9uLCBtX2NvdW50LCBwbHVnaW4pOwogICAgICAgICByZXR1cm4gdHJ1 ZTsKQEAgLTEwNTUsNiArMTA1OCw3IEBAIGJvb2wgUERGUGx1Z2luOjpCeXRlUmFuZ2VSZXF1ZXN0 OjptYXliZUNvbXBsZXRlKFBERlBsdWdpbiYgcGx1Z2luKQogICAgICAgICBjb21wbGV0ZVdpdGhC eXRlcyhDRkRhdGFHZXRCeXRlUHRyKHBsdWdpbi5tX2RhdGEuZ2V0KCkpICsgbV9wb3NpdGlvbiwg bV9jb3VudCwgcGx1Z2luKTsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQorCiAgICAgcmV0 dXJuIGZhbHNlOwogfQogCg==