214022 2020-07-06 17:18:01 -0700 svn-apply should use verbose mode when adding files to git 2020-07-06 17:47:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 213927 1 clopez clopez clopez darin dbates ddkilzer ews-watchlist fujii jbedard webkit-bug-importer oldest_to_newest 1669263 0 clopez 2020-07-06 17:18:01 -0700 In bug 213927 <https://ews.webkit.org/status-bubble/403466/> I noticed some EWS were failing to apply the patch because the command timed out after 10 minutes without output. Example: https://ews-build.webkit.org/#/builders/10/builds/29642 This is because the patch does a bunch of copy operations, which end calling "git" "add" and this is slow and no output its produced for each one of this operations. This is not an issue with svn, since executing "svn add file" produces output. But git doesn't produce any output by default. 1669274 1 403648 clopez 2020-07-06 17:32:11 -0700 Created attachment 403648 Patch 1669276 2 403648 clopez 2020-07-06 17:46:09 -0700 Comment on attachment 403648 Patch Clearing flags on attachment: 403648 Committed r264002: <https://trac.webkit.org/changeset/264002> 1669277 3 clopez 2020-07-06 17:46:13 -0700 All reviewed patches have been landed. Closing bug. 1669279 4 webkit-bug-importer 2020-07-06 17:47:15 -0700 <rdar://problem/65155874> 403648 2020-07-06 17:32:11 -0700 2020-07-06 17:46:09 -0700 Patch bug-214022-20200707023210.patch text/plain 2551 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzOTkxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjI0N2E5MmE3Y2VkOTM1NDhiMjdkN2Q1NDRiOGFmZDRh NWZkMTVlOC4uMWUzNGU3YjA4ODc2YTExZGFiY2IwODZmZGZkNGFkYTVlODUxNTFhNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDIwLTA3LTA2ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIHN2bi1hcHBseSBzaG91bGQgdXNlIHZlcmJvc2UgbW9kZSB3aGVu IGFkZGluZyBmaWxlcyB0byBnaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxNDAyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIElmIGEgcGF0Y2ggY29udGFpbnMgc2V2ZXJhbCBjb3B5IG9yIGFkZCBvcGVy YXRpb25zIGl0IGNhbiBoYXBwZW4gdGhhdCB0aGVyZSBpcworICAgICAgICBubyBvdXRwdXQgZm9y IG1vcmUgdGhhbiA2MDAgc2Vjb25kcyBtZWFud2hpbGUgdGhlIHRvb2wgaXMgYXBwbHlpbmcgdGhl IHBhdGNoLgorICAgICAgICBUaGlzIGNhbiBjYXVzZSBhIGZhdGFsIGVycm9yIG9uIHRoZSBFV1Mu IFBhc3MgdGhlIHZlcmJvc2UgZmxhZyB0byBnaXQsCisgICAgICAgIHNvIGl0IG91dHB1dHMgdGhl IG5hbWUgb2YgdGhlIGZpbGUgYWZ0ZXIgYWRkaW5nIGl0IHRvIHRoZSBpbmRleC4KKyAgICAgICAg VGhpcyBpcyBjb25zZXF1ZW50IGhvdyAic3ZuIGFkZCIgd29ya3MgYnkgZGVmYXVsdCAoaXQgb3V0 cHV0cyB0aGUgbmFtZSBvZiB0aGUgZmlsZSksCisgICAgICAgIG9yIGhvdyAiZ2l0IHJtIiB3b3Jr cyAoaXQgYWxzbyBvdXRwdXRzIHRoZSBuYW1lIG9mIHRoZSBmaWxlIGJ5IGRlZmF1bHQgYXMgd2Vs bCkuCisKKyAgICAgICAgKiBTY3JpcHRzL3N2bi1hcHBseToKKyAgICAgICAgKHNjbUNvcHkpOgor ICAgICAgICAoc2NtQWRkKToKKyAgICAgICAgKHNjbUNvbW1pdFF1ZXVlQWRkZWQpOgorCiAyMDIw LTA3LTA2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBb dGVzdC13ZWJraXRweV0gVXNlIHBsYXRmb3JtIGFyY2hpdGVjdHVyZQpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy9zdm4tYXBwbHkgYi9Ub29scy9TY3JpcHRzL3N2bi1hcHBseQppbmRleCA4NWRk OWI2YzdkOWY5YTYxZWQ0NzE5NjRiNWMzYjM5Y2RlNThmODY0Li41YTllZGY1NjBlZTU4NmQ4YzUw ZTJhYWI0ZjBkZGRmODU3MDllYzA3IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3N2bi1hcHBs eQorKysgYi9Ub29scy9TY3JpcHRzL3N2bi1hcHBseQpAQCAtNDY4LDcgKzQ2OCw3IEBAIHN1YiBz Y21Db3B5KCQkKQogICAgICAgICBzeXN0ZW0oInN2biIsICJjb3B5IiwgJGVzY2FwZWRTb3VyY2Us ICRlc2NhcGVkRGVzdGluYXRpb24pID09IDAgb3IgZGllICJGYWlsZWQgdG8gc3ZuIGNvcHkgJGVz Y2FwZWRTb3VyY2UgJGVzY2FwZWREZXN0aW5hdGlvbi4iOwogICAgIH0gZWxzaWYgKGlzR2l0KCkp IHsKICAgICAgICAgY29weSgkc291cmNlLCAkZGVzdGluYXRpb24pIG9yIGRpZSAiRmFpbGVkIHRv IGNvcHkgJHNvdXJjZSAkZGVzdGluYXRpb24uIjsKLSAgICAgICAgc3lzdGVtKCJnaXQiLCAiYWRk IiwgJGRlc3RpbmF0aW9uKSA9PSAwIG9yIGRpZSAiRmFpbGVkIHRvIGdpdCBhZGQgJGRlc3RpbmF0 aW9uLiI7CisgICAgICAgIHN5c3RlbSgiZ2l0IiwgImFkZCIsICItdiIsICRkZXN0aW5hdGlvbikg PT0gMCBvciBkaWUgIkZhaWxlZCB0byBnaXQgYWRkICRkZXN0aW5hdGlvbi4iOwogICAgIH0KIH0K IApAQCAtNDc5LDcgKzQ3OSw3IEBAIHN1YiBzY21BZGQoJCkKICAgICAgICAgbXkgJGVzY2FwZWRQ YXRoID0gZXNjYXBlU3VidmVyc2lvblBhdGgoJHBhdGgpOwogICAgICAgICBzeXN0ZW0oInN2biIs ICJhZGQiLCAkZXNjYXBlZFBhdGgpID09IDAgb3IgZGllICJGYWlsZWQgdG8gc3ZuIGFkZCAkZXNj YXBlZFBhdGguIjsKICAgICB9IGVsc2lmIChpc0dpdCgpKSB7Ci0gICAgICAgIHN5c3RlbSgiZ2l0 IiwgImFkZCIsICRwYXRoKSA9PSAwIG9yIGRpZSAiRmFpbGVkIHRvIGdpdCBhZGQgJHBhdGguIjsK KyAgICAgICAgc3lzdGVtKCJnaXQiLCAiYWRkIiwgIi12IiwgJHBhdGgpID09IDAgb3IgZGllICJG YWlsZWQgdG8gZ2l0IGFkZCAkcGF0aC4iOwogICAgIH0KIH0KIApAQCAtNTI2LDcgKzUyNiw3IEBA IHN1YiBzY21Db21taXRRdWV1ZUFkZGVkKCkKICAgICBpZiAoaXNTVk4oKSkgewogICAgICAgICBA Y21kQmFzZSA9ICgic3ZuIiwgImFkZCIpCiAgICAgfSBlbHNpZiAoaXNHaXQoKSkgewotICAgICAg ICBAY21kQmFzZSA9ICgiZ2l0IiwgImFkZCIpCisgICAgICAgIEBjbWRCYXNlID0gKCJnaXQiLCAi YWRkIiwgIi12IikKICAgICB9CiAKICAgICAjIFdoZW4gd2UgYXJlIGhhbmRsaW5nIGEgdmVyeSBs YXJnZSBwYXRjaCAobW9yZSB0aGFuIDEwMDAgZmlsZXMgbW9kaWZpZWQpCg==