214011 2020-07-06 16:02:14 -0700 [iOS] WAKWindow should override -resignFirstResponder and clear state 2020-07-06 16:28:02 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates ddkilzer thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1669209 0 dbates 2020-07-06 16:02:14 -0700 WAKWindow maintains state of what the first responder and next responder are. I need way to clear this state when removing a UIWebView from its superview. 1669211 1 webkit-bug-importer 2020-07-06 16:02:31 -0700 <rdar://problem/65152410> 1669214 2 dbates 2020-07-06 16:05:18 -0700 Note that only -[WAKWindow close] ever nils out this state. -makeFirstResponder early returns if passed nil. In AppKit, -makeFirstResponder:nil would make the window first responder, but -firstResponder is in term of WAKView and there doesn't seem to be an existing concept of a "first responder" window. 1669219 3 403631 dbates 2020-07-06 16:21:57 -0700 Created attachment 403631 Patch 1669224 4 dbates 2020-07-06 16:27:29 -0700 Thanks Tim! 1669226 5 403631 dbates 2020-07-06 16:28:00 -0700 Comment on attachment 403631 Patch Clearing flags on attachment: 403631 Committed r263995: <https://trac.webkit.org/changeset/263995> 1669227 6 dbates 2020-07-06 16:28:02 -0700 All reviewed patches have been landed. Closing bug. 403631 2020-07-06 16:21:57 -0700 2020-07-06 16:28:00 -0700 Patch bug-214011-20200706162156.patch text/plain 1872 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzOTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQ3MGMzYzlkYTgxYzA1 ZjdkZTkxNDM2MmM2ZmViZTkzMmFiOThkZS4uZWJkNDZiNGMyM2MxMWUwMmRhNTA0MjRjMzg0ZTll MGY1YmE4NzYxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA3LTA2ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBXQUtXaW5kb3cg c2hvdWxkIG92ZXJyaWRlIC1yZXNpZ25GaXJzdFJlc3BvbmRlciBhbmQgY2xlYXIgc3RhdGUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDAxMQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNjUxNTI0MTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBwYXJ0IG9mIHRoZSBmaXggZm9yIDxyZGFy Oi8vcHJvYmxlbS82MjYxNTI3Mz4uCisKKyAgICAgICAgT3ZlcnJpZGUgLXJlc2lnbkZpcnN0UmVz cG9uZGVyIHRvIGNsZWFyIG91dCBpbnRlcm5hbCBzdGF0ZSB0aGF0IHRyYWNrcyB0aGUgZmlyc3Qg cmVzcG9uZGVyCisgICAgICAgIGluIHRoZSBpT1MgTGVnYWN5IFdlYktpdCB3b3JsZC4KKworICAg ICAgICAqIHBsYXRmb3JtL2lvcy93YWsvV0FLV2luZG93Lm1tOgorICAgICAgICAoLVtXQUtXaW5k b3cgcmVzaWduRmlyc3RSZXNwb25kZXJdKToKKwogMjAyMC0wNy0wNSAgRGFuaWVsIEJhdGVzICA8 ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIFJlbmRlck9iamVjdDo6cG9zaXRpb25G b3JQb2ludCBpbnN0ZWFkIG9mIGhpdCB0ZXN0aW5nIHRoZSBlbnRpcmUgdmlldyBpbiBjbG9zZXN0 RWRpdGFibGVQb3NpdGlvbkluRWxlbWVudEZvckFic29sdXRlUG9pbnQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLV2luZG93Lm1tIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vaW9zL3dhay9XQUtXaW5kb3cubW0KaW5kZXggMGZlM2I3MzBhNWVhZjhjNDI3 NTFhODM2MDA4MGFhNDM0MGQzYjgyZC4uMWU0YmRmZjhiYjI0NWUxZDY3NjFhN2E4ZjFjOTQ5YmJh YWMwODc0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtX aW5kb3cubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtXaW5kb3cu bW0KQEAgLTIwOSw2ICsyMDksMTggQEAgLSAoTlNTZWxlY3Rpb25EaXJlY3Rpb24pa2V5Vmlld1Nl bGVjdGlvbkRpcmVjdGlvbgogICAgIHJldHVybiAoTlNTZWxlY3Rpb25EaXJlY3Rpb24pMDsKIH0K IAorLSAoQk9PTClyZXNpZ25GaXJzdFJlc3BvbmRlcgoreworICAgIEJPT0wgc2hvdWxkUmVzaWdu ID0gW3N1cGVyIHJlc2lnbkZpcnN0UmVzcG9uZGVyXTsKKyAgICBpZiAoc2hvdWxkUmVzaWduICYm IF9yZXNwb25kZXJWaWV3ICYmIFdLVmlld1Jlc2lnbkZpcnN0UmVzcG9uZGVyKFtfcmVzcG9uZGVy VmlldyBfdmlld1JlZl0pKSB7CisgICAgICAgIF9uZXh0UmVzcG9uZGVyID0gbmlsOworICAgICAg ICBbX3Jlc3BvbmRlclZpZXcgcmVsZWFzZV07CisgICAgICAgIF9yZXNwb25kZXJWaWV3ID0gbmls OworICAgICAgICByZXR1cm4gWUVTOworICAgIH0KKyAgICByZXR1cm4gTk87Cit9CisKIC0gKEJP T0wpbWFrZUZpcnN0UmVzcG9uZGVyOihOU1Jlc3BvbmRlciAqKWFSZXNwb25kZXIKIHsKICAgICBp ZiAoIVthUmVzcG9uZGVyIGlzS2luZE9mQ2xhc3M6W1dBS1ZpZXcgY2xhc3NdXSkK