21401 2008-10-06 08:03:35 -0700 Comments field on "Review Patch" page should be initially filled with quoted patch 2008-10-23 09:50:18 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 aroben aroben ddkilzer ggaren oldest_to_newest 94226 0 aroben 2008-10-06 08:03:35 -0700 From an email from Geoff Garen re: the new "Review Patch" page on Bugzilla: > One suggestion: It would be nice for the comments field to initially contain > a plaintext copy of the patch, so it's easy to quote and reply, as in email. 96335 1 24599 aroben 2008-10-23 08:20:19 -0700 Created attachment 24599 patch + ChangeLog 96340 2 24599 hyatt 2008-10-23 09:45:27 -0700 Comment on attachment 24599 patch + ChangeLog r=me 96341 3 aroben 2008-10-23 09:50:18 -0700 Landed in r37813 24599 2008-10-23 08:20:19 -0700 2008-10-23 09:45:27 -0700 patch + ChangeLog 0001--Fix-Bug-21401-Comments-field-on-Review-Pat.patch text/plain 4712 aroben RnJvbSAwYmI3MGY5NjYyMjhjNTk1NGFlMGIwMDA5YzM2NDFjMzk3M2ZlOGU5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFJvYmVuIDxhcm9iZW5AYXBwbGUuY29tPgpEYXRlOiBU aHUsIDIzIE9jdCAyMDA4IDExOjIwOjE3IC0wNDAwClN1YmplY3Q6IFtQRlJdICAgICAgICAgRml4 IEJ1ZyAyMTQwMTogQ29tbWVudHMgZmllbGQgb24gIlJldmlldyBQYXRjaCIgcGFnZSBzaG91bGQg YmUgaW5pdGlhbGx5IGZpbGxlZCB3aXRoIHF1b3RlZCBwYXRjaAoKICAgICAgICA8aHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNDAxPgoKICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgKiBhdHRhY2htZW50LmNnaToKICAgICAgICAoZWRp dCk6IFJldHJpZXZlIHRoZSBhdHRhY2htZW50IGRhdGEgZnJvbSB0aGUgZGF0YWJhc2UgaW5zdGVh ZCBvZiBqdXN0CiAgICAgICAgaXRzIGxlbmd0aC4gV2hlbiB0aGUgYXR0YWNobWVudCBpcyBhIHBh dGNoLCBjcmVhdGUgYSBxdW90ZWRwYXRjaAogICAgICAgIHRlbXBsYXRlIHZhcmlhYmxlIHRoYXQg Y29udGFpbnMgdGhlIHBhdGNoIGRhdGEgd2l0aCBlYWNoIGxpbmUKICAgICAgICBwcmVwZW5kZWQg d2l0aCAiPiAiLgogICAgICAgICogdGVtcGxhdGUvZW4vY3VzdG9tL2F0dGFjaG1lbnQvcmV2aWV3 Zm9ybS5odG1sLnRtcGw6CiAgICAgICAgICAtIENoYW5nZWQgdGhlIGNvbW1lbnRzIGZpZWxkIHRv IGhhdmUgYSBtb25vc3BhY2UgZm9udAogICAgICAgICAgLSBBZGRlZCBhbiAiRW50ZXIgY29tbWVu dHMgYmVsb3c6IiBjYXB0aW9uIGFib3ZlIHRoZSBjb21tZW50cyBmaWVsZAogICAgICAgICAgICB0 byBtYWtlIGl0IGNsZWFyZXIgdGhhdCB0aGlzIGlzIHdoZXJlIGNvbW1lbnRzIHNob3VsZCBnbywg bm93IHRoYXQKICAgICAgICAgICAgdGhlIGNvbW1lbnRzIGZpZWxkIGlzIG5vdCBpbml0aWFsbHkg ZW1wdHkKICAgICAgICAgIC0gRmlsbCB0aGUgY29tbWVudHMgZmllbGQgd2l0aCB0aGUgcXVvdGVk IHBhdGNoCi0tLQogQnVnc1NpdGUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDIxICsrKysrKysrKysrKysrKysrKysrCiBCdWdzU2l0ZS9hdHRhY2htZW50LmNn aSAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTEgKysrKysrKystCiAuLi4vZW4vY3Vz dG9tL2F0dGFjaG1lbnQvcmV2aWV3Zm9ybS5odG1sLnRtcGwgICAgICB8ICAgIDUgKystCiAzIGZp bGVzIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvQnVnc1NpdGUvQ2hhbmdlTG9nIGIvQnVnc1NpdGUvQ2hhbmdlTG9nCmluZGV4IGZkZjM4NmIu LjQ3OGJjNDMgMTAwNjQ0Ci0tLSBhL0J1Z3NTaXRlL0NoYW5nZUxvZworKysgYi9CdWdzU2l0ZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAwOC0xMC0yMyAgQWRhbSBSb2JlbiAgPGFyb2Jl bkBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IEJ1ZyAyMTQwMTogQ29tbWVudHMgZmllbGQgb24g IlJldmlldyBQYXRjaCIgcGFnZSBzaG91bGQgYmUKKyAgICAgICAgaW5pdGlhbGx5IGZpbGxlZCB3 aXRoIHF1b3RlZCBwYXRjaAorCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjE0MDE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBhdHRhY2htZW50LmNnaToKKyAgICAgICAgKGVkaXQpOiBSZXRyaWV2ZSB0 aGUgYXR0YWNobWVudCBkYXRhIGZyb20gdGhlIGRhdGFiYXNlIGluc3RlYWQgb2YganVzdAorICAg ICAgICBpdHMgbGVuZ3RoLiBXaGVuIHRoZSBhdHRhY2htZW50IGlzIGEgcGF0Y2gsIGNyZWF0ZSBh IHF1b3RlZHBhdGNoCisgICAgICAgIHRlbXBsYXRlIHZhcmlhYmxlIHRoYXQgY29udGFpbnMgdGhl IHBhdGNoIGRhdGEgd2l0aCBlYWNoIGxpbmUKKyAgICAgICAgcHJlcGVuZGVkIHdpdGggIj4gIi4K KyAgICAgICAgKiB0ZW1wbGF0ZS9lbi9jdXN0b20vYXR0YWNobWVudC9yZXZpZXdmb3JtLmh0bWwu dG1wbDoKKyAgICAgICAgICAtIENoYW5nZWQgdGhlIGNvbW1lbnRzIGZpZWxkIHRvIGhhdmUgYSBt b25vc3BhY2UgZm9udAorICAgICAgICAgIC0gQWRkZWQgYW4gIkVudGVyIGNvbW1lbnRzIGJlbG93 OiIgY2FwdGlvbiBhYm92ZSB0aGUgY29tbWVudHMgZmllbGQKKyAgICAgICAgICAgIHRvIG1ha2Ug aXQgY2xlYXJlciB0aGF0IHRoaXMgaXMgd2hlcmUgY29tbWVudHMgc2hvdWxkIGdvLCBub3cgdGhh dAorICAgICAgICAgICAgdGhlIGNvbW1lbnRzIGZpZWxkIGlzIG5vdCBpbml0aWFsbHkgZW1wdHkK KyAgICAgICAgICAtIEZpbGwgdGhlIGNvbW1lbnRzIGZpZWxkIHdpdGggdGhlIHF1b3RlZCBwYXRj aAorCiAyMDA4LTEwLTE0ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAg ICBGaXggQnVnIDIxNjAyOiBCdWd6aWxsYSB0aW1lcyBvdXQgdHJ5aW5nIHRvIGRpc3BsYXkgZm9y bWF0dGVkIGRpZmYgZm9yCmRpZmYgLS1naXQgYS9CdWdzU2l0ZS9hdHRhY2htZW50LmNnaSBiL0J1 Z3NTaXRlL2F0dGFjaG1lbnQuY2dpCmluZGV4IGUwYmY1M2YuLjQzOGRlMWYgMTAwNzU1Ci0tLSBh L0J1Z3NTaXRlL2F0dGFjaG1lbnQuY2dpCisrKyBiL0J1Z3NTaXRlL2F0dGFjaG1lbnQuY2dpCkBA IC0xMTIwLDkgKzExMjAsMTAgQEAgc3ViIGVkaXQKICAgbXkgKCRhdHRhY2hfaWQpID0gdmFsaWRh dGVJRCgpOwogCiAgICMgUmV0cmlldmUgdGhlIGF0dGFjaG1lbnQgZnJvbSB0aGUgZGF0YWJhc2Uu Ci0gIFNlbmRTUUwoIlNFTEVDVCBkZXNjcmlwdGlvbiwgbWltZXR5cGUsIGZpbGVuYW1lLCBidWdf aWQsIGlzcGF0Y2gsIGlzb2Jzb2xldGUsIGlzcHJpdmF0ZSwgTEVOR1RIKHRoZWRhdGEpCisgIFNl bmRTUUwoIlNFTEVDVCBkZXNjcmlwdGlvbiwgbWltZXR5cGUsIGZpbGVuYW1lLCBidWdfaWQsIGlz cGF0Y2gsIGlzb2Jzb2xldGUsIGlzcHJpdmF0ZSwgdGhlZGF0YQogICAgICAgICAgICBGUk9NIGF0 dGFjaG1lbnRzIFdIRVJFIGF0dGFjaF9pZCA9ICRhdHRhY2hfaWQiKTsKLSAgbXkgKCRkZXNjcmlw dGlvbiwgJGNvbnRlbnR0eXBlLCAkZmlsZW5hbWUsICRidWdpZCwgJGlzcGF0Y2gsICRpc29ic29s ZXRlLCAkaXNwcml2YXRlLCAkZGF0YXNpemUpID0gRmV0Y2hTUUxEYXRhKCk7CisgIG15ICgkZGVz Y3JpcHRpb24sICRjb250ZW50dHlwZSwgJGZpbGVuYW1lLCAkYnVnaWQsICRpc3BhdGNoLCAkaXNv YnNvbGV0ZSwgJGlzcHJpdmF0ZSwgJHRoZWRhdGEpID0gRmV0Y2hTUUxEYXRhKCk7CisgIG15ICRk YXRhc2l6ZSA9IGxlbmd0aCgkdGhlZGF0YSk7CiAKICAgbXkgJGlzdmlld2FibGUgPSBpc1ZpZXdh YmxlKCRjb250ZW50dHlwZSk7CiAKQEAgLTExNjMsNiArMTE2NCwxMiBAQCBzdWIgZWRpdAogICAk dmFycy0+eydhdHRhY2htZW50cyd9ID0gXEBidWdhdHRhY2htZW50czsgCiAgICR2YXJzLT57J0dl dEJ1Z0xpbmsnfSA9IFwmR2V0QnVnTGluazsKIAorICBpZiAoJGlzcGF0Y2gpIHsKKyAgICAgIG15 ICRxdW90ZWRwYXRjaCA9ICR0aGVkYXRhOworICAgICAgJHF1b3RlZHBhdGNoID1+IHMvXi8+IC9t ZzsKKyAgICAgICR2YXJzLT57J3F1b3RlZHBhdGNoJ30gPSAkcXVvdGVkcGF0Y2g7CisgIH0KKwog ICAjIERldGVybWluZSBpZiBQYXRjaFJlYWRlciBpcyBpbnN0YWxsZWQKICAgZXZhbCB7CiAgICAg cmVxdWlyZSBQYXRjaFJlYWRlcjsKZGlmZiAtLWdpdCBhL0J1Z3NTaXRlL3RlbXBsYXRlL2VuL2N1 c3RvbS9hdHRhY2htZW50L3Jldmlld2Zvcm0uaHRtbC50bXBsIGIvQnVnc1NpdGUvdGVtcGxhdGUv ZW4vY3VzdG9tL2F0dGFjaG1lbnQvcmV2aWV3Zm9ybS5odG1sLnRtcGwKaW5kZXggZDBjODQ4MC4u M2E1NDAyOCAxMDA2NDQKLS0tIGEvQnVnc1NpdGUvdGVtcGxhdGUvZW4vY3VzdG9tL2F0dGFjaG1l bnQvcmV2aWV3Zm9ybS5odG1sLnRtcGwKKysrIGIvQnVnc1NpdGUvdGVtcGxhdGUvZW4vY3VzdG9t L2F0dGFjaG1lbnQvcmV2aWV3Zm9ybS5odG1sLnRtcGwKQEAgLTI1LDcgKzI1LDcgQEAKIDxsaW5r IGhyZWY9InNraW5zL2N1c3RvbS9nbG9iYWwuY3NzIiByZWw9InN0eWxlc2hlZXQiIHR5cGU9InRl eHQvY3NzIj4KIDxzdHlsZT4KICogeyBmb250LXNpemU6IHNtYWxsOyB9Ci0jY29tbWVudCB7IHdp ZHRoOiAxMDAlOyBoZWlnaHQ6IDEwMCU7IH0KKyNjb21tZW50IHsgd2lkdGg6IDEwMCU7IGhlaWdo dDogMTAwJTsgZm9udC1mYW1pbHk6IG1vbm9zcGFjZTsgfQogI2Zvcm0tY29udHJvbHMgeyBoZWln aHQ6IDQwcHg7IH0KICNmb3JtLWNvbnRyb2xzIHRkIHsgd2lkdGg6IDI1JTsgdGV4dC1hbGlnbjog Y2VudGVyOyB9CiA8L3N0eWxlPgpAQCAtODksNyArODksOCBAQCBCYWNrIHRvIDxhIGhyZWY9InNo b3dfYnVnLmNnaT9pZD1bJSBidWdpZCAlXSIgdGFyZ2V0PSJfdG9wIj5bJSB0ZXJtcy5CdWcgJV0g I1slCiA8L3RyPgogPHRyPgogPHRkIGNvbHNwYW49IjQiPgotPHRleHRhcmVhIGlkPWNvbW1lbnQg bmFtZT0iY29tbWVudCIgd3JhcD0ic29mdCI+PC90ZXh0YXJlYT48YnI+CitFbnRlciBjb21tZW50 cyBiZWxvdzo8YnI+Cis8dGV4dGFyZWEgaWQ9Y29tbWVudCBuYW1lPSJjb21tZW50IiB3cmFwPSJz b2Z0Ij5bJSBxdW90ZWRwYXRjaCBGSUxURVIgaHRtbCAlXTwvdGV4dGFyZWE+PGJyPgogPC90cj4K IDwvdGFibGU+CiAKLS0gCjEuNi4wLnJjMS4yNTAuZzliNWUyCgo=