214007 2020-07-06 14:03:52 -0700 [GTK][MiniBrowser] occasional crashes when closing while download in progress 2020-07-07 00:21:22 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Linux RESOLVED FIXED P2 Normal --- 1 yurys yurys bugs-noreply cgarcia clopez pnormand oldest_to_newest 1669154 0 yurys 2020-07-06 14:03:52 -0700 #0 0x00007f4072b28e4d in g_type_check_instance () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libgobject-2.0.so.0 #1 0x00007f4072b1ca34 in g_signal_handlers_disconnect_matched () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libgobject-2.0.so.0 #2 0x000056033590193b in ?? () #3 0x00007f4072b01c2d in g_closure_invoke () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libgobject-2.0.so.0 #4 0x00007f4072b1562e in ?? () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libgobject-2.0.so.0 #5 0x00007f4072b1dfe5 in g_signal_emit_valist () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libgobject-2.0.so.0 #6 0x00007f4072b1e9ff in g_signal_emit () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libgobject-2.0.so.0 #7 0x00007f4076edaafb in webkitDownloadFailed(_WebKitDownload*, WebCore::ResourceError const&) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37 #8 0x00007f4076edb9fe in webkitDownloadCancelled(_WebKitDownload*) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37 #9 0x00007f4076edc1e9 in DownloadClient::didCancel(WebKit::DownloadProxy&) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37 #10 0x00007f4076f614b5 in WebKit::DownloadProxy::didCancel(IPC::DataReference const&) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37 #11 0x00007f4076b014e1 in WebKit::DownloadProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37 #12 0x00007f4076d0b5f8 in IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37 #13 0x00007f4076f74fbf in non-virtual thunk to WebKit::NetworkProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37 #14 0x00007f4076d03f90 in IPC::Connection::dispatchMessage(IPC::Decoder&) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37 #15 0x00007f4076d05d25 in IPC::Connection::dispatchMessage(std::unique_ptr<IPC::Decoder, std::default_delete<IPC::Decoder> >) () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37 #16 0x00007f4076d064cf in IPC::Connection::dispatchOneIncomingMessage() () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libwebkit2gtk-4.0.so.37 #17 0x00007f4074940df5 in WTF::RunLoop::performWork() () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libjavascriptcoregtk-4.0.so.18 #18 0x00007f40749a9b09 in ?? () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libjavascriptcoregtk-4.0.so.18 #19 0x00007f407ab639e5 in g_main_context_dispatch () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libglib-2.0.so.0 #20 0x00007f407ab63db0 in ?? () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libglib-2.0.so.0 #21 0x00007f407ab63e3c in g_main_context_iteration () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libglib-2.0.so.0 #22 0x00007f4072e1069d in g_application_run () from /home/yurys/.cache/ms-playwright/webkit-1301/minibrowser-gtk/libgio-2.0.so.0 #23 0x00005603358ff76f in ?? () #24 0x00007f4071b30b97 in __libc_start_main (main=0x5603358ff320, argc=3, argv=0x7ffd6d806508, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffd6d8064f8) at ../csu/libc-start.c:310 #25 0x00005603358ff81a in ?? () 1669155 1 403618 yurys 2020-07-06 14:08:25 -0700 Created attachment 403618 Patch 1669157 2 pnormand 2020-07-06 14:13:00 -0700 Maybe g_signal_handler_block() could be an option? 1669197 3 yurys 2020-07-06 15:29:36 -0700 IIUC g_signal_handler_block assumes there will be g_signal_handler_unblock at some point in the future. In this case UI item representing the download is destroyed hence the signal handlers it added make no sense anymore and there is no point in unblocking them. Also they would still keep a dangling pointer. 1669339 4 ews-feeder 2020-07-07 00:21:21 -0700 Committed r264011: <https://trac.webkit.org/changeset/264011> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403618. 403618 2020-07-06 14:08:25 -0700 2020-07-07 00:21:22 -0700 Patch bug-214007-20200706140824.patch text/plain 1564 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzOTgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzBjNTIyNzA1ZGExMzUyYjUxZmJmNTg3MzBhOTgzMTg1 NTI4MTVmNi4uNGFlMWFjMDhiM2QwODg0OGVkNmUyNWVkYzcxZWUxNDdiYzVjNTA3MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIwLTA3LTA2ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFtHVEtdW01pbmlCcm93c2VyXSBvY2Nhc2lvbmFsIGNyYXNoZXMgd2hlbiBjbG9z aW5nIHdoaWxlIGRvd25sb2FkIGluIHByb2dyZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTQwMDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgc2lnbmFsIGhhbmRsZXJzIGZyb20gV2ViS2l0 RG93bmxvYWQgd2hlbiBCcm93c2VyRG93bmxvYWQgaXMgZmluYWxpemVkLAorICAgICAgICBXZWJL aXREb3dubG9hZCBtYXkgZW1pdCBhIHNpZ25hbCBhZnRlciB0aGUgVUkgaXRlbSBoYXMgYmVlbiBk ZXN0cm95ZWQgd2hpY2ggbGVhZHMKKyAgICAgICAgdG8gYSBjcmFzaC4KKworICAgICAgICAqIE1p bmlCcm93c2VyL2d0ay9Ccm93c2VyRG93bmxvYWRzQmFyLmM6CisgICAgICAgIChicm93c2VyRG93 bmxvYWRGaW5hbGl6ZSk6CisKIDIwMjAtMDctMDYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2ll aEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lQYWRPU10gVW5hYmxlIHRvIGNoYW5nZSBmb2N1cyBi ZXR3ZWVuIEdvb2dsZSBEb2NzIHdpbmRvd3MgYnkgdGFwcGluZwpkaWZmIC0tZ2l0IGEvVG9vbHMv TWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJEb3dubG9hZHNCYXIuYyBiL1Rvb2xzL01pbmlCcm93c2Vy L2d0ay9Ccm93c2VyRG93bmxvYWRzQmFyLmMKaW5kZXggYjlmZWI4ZTdkOTc3MTZmZjUwNWMzY2Uw ZDNiZWE4MzBmZjBhOWQ2Mi4uOTFkODNiZWViOGI2MzUwZjFhMDM1NTFmNjM4ZGY2NWFmODM4YzJh YSAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJEb3dubG9hZHNCYXIu YworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlckRvd25sb2Fkc0Jhci5jCkBAIC0x MjcsNiArMTI3LDcgQEAgc3RhdGljIHZvaWQgYnJvd3NlckRvd25sb2FkRmluYWxpemUoR09iamVj dCAqb2JqZWN0KQogICAgIEJyb3dzZXJEb3dubG9hZCAqYnJvd3NlckRvd25sb2FkID0gQlJPV1NF Ul9ET1dOTE9BRChvYmplY3QpOwogCiAgICAgaWYgKGJyb3dzZXJEb3dubG9hZC0+ZG93bmxvYWQp IHsKKyAgICAgICAgZ19zaWduYWxfaGFuZGxlcnNfZGlzY29ubmVjdF9ieV9kYXRhKGJyb3dzZXJE b3dubG9hZC0+ZG93bmxvYWQsIGJyb3dzZXJEb3dubG9hZCk7CiAgICAgICAgIGdfb2JqZWN0X3Vu cmVmKGJyb3dzZXJEb3dubG9hZC0+ZG93bmxvYWQpOwogICAgICAgICBicm93c2VyRG93bmxvYWQt PmRvd25sb2FkID0gTlVMTDsKICAgICB9Cg==