214005 2020-07-06 13:44:16 -0700 Cleanup WebVideoFullscreenControllerAVKit.mm and PlaybackSessionInterfaceAVKit.mm 2020-07-06 15:05:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 peng.liu6 peng.liu6 eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1669147 0 peng.liu6 2020-07-06 13:44:16 -0700 Cleanup WebVideoFullscreenControllerAVKit.mm and PlaybackSessionInterfaceAVKit.mm 1669149 1 403616 peng.liu6 2020-07-06 13:47:11 -0700 Created attachment 403616 Patch 1669151 2 403616 dbates 2020-07-06 13:51:09 -0700 Comment on attachment 403616 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403616&action=review > Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKit.mm:30 > +#if PLATFORM(COCOA) && HAVE(AVKIT) Optimal patch removes the PLATFORM(COCOA) if this file is never built on non-Cocoa platforms (e.g. Windows). 1669189 3 ews-feeder 2020-07-06 15:04:45 -0700 Committed r263990: <https://trac.webkit.org/changeset/263990> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403616. 1669190 4 webkit-bug-importer 2020-07-06 15:05:16 -0700 <rdar://problem/65150171> 403616 2020-07-06 13:47:11 -0700 2020-07-06 15:04:45 -0700 Patch bug-214005-20200706134711.patch text/plain 2460 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTM2MWVhY2Q2YWRkYTE3 ZGQzNDdlY2Q0OTI5NzlmZWY1ZjEwNmM4My4uYTEwMmUwOWQ1NDQ0MGI2YzVhZmE0ODJkNDhjMDNk MDQ5ZGE2NDQyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA3LTA2ICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgQ2xlYW51cCBXZWJWaWRlb0Z1 bGxzY3JlZW5Db250cm9sbGVyQVZLaXQubW0gYW5kIFBsYXliYWNrU2Vzc2lvbkludGVyZmFjZUFW S2l0Lm1tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTQwMDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO byBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2lv cy9QbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VBVktpdC5tbToKKyAgICAgICAgKiBwbGF0Zm9ybS9p b3MvV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxlckFWS2l0Lm1tOgorICAgICAgICAoVmlkZW9G dWxsc2NyZWVuQ29udHJvbGxlckNvbnRleHQ6OnNldFVwRnVsbHNjcmVlbik6CisgICAgICAgIFJl bW92ZSBhIHJlZHVuZGFudCBsaW5lLgorCiAyMDIwLTA2LTMwICBQZW5nIExpdSAgPHBlbmcubGl1 NkBhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxlIHRoZSBzdXBwb3J0IG9mIEZVTExTQ1JFRU5f QVBJIGluIFdlYktpdFRlc3RSdW5uZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2lvcy9QbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VBVktpdC5tbSBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2lvcy9QbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VBVktpdC5tbQppbmRleCBmZjAz OWFkOWI0MjUxYzYzYTg4YjU5Y2Y1ZGNlODU3ZjVmZGIwZWJkLi4wYWU5ZTZkZDYzZjU2MjVlZDhl YjBjOGVlYzA4NjZhMzY0NWJmY2ZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9pb3MvUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlQVZLaXQubW0KKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vaW9zL1BsYXliYWNrU2Vzc2lvbkludGVyZmFjZUFWS2l0Lm1tCkBAIC0yNyw4 ICsyNyw3IEBACiAjaW1wb3J0ICJjb25maWcuaCIKICNpbXBvcnQgIlBsYXliYWNrU2Vzc2lvbklu dGVyZmFjZUFWS2l0LmgiCiAKLSNpZiBQTEFURk9STShDT0NPQSkKLSNpZiBIQVZFKEFWS0lUKQor I2lmIFBMQVRGT1JNKENPQ09BKSAmJiBIQVZFKEFWS0lUKQogCiAjaW1wb3J0ICJMb2dnaW5nLmgi CiAjaW1wb3J0ICJNZWRpYVNlbGVjdGlvbk9wdGlvbi5oIgpAQCAtMjI5LDUgKzIyOCw0IEBAIHZv aWQgUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlQVZLaXQ6Om1vZGVsRGVzdHJveWVkKCkKIAogfQog Ci0jZW5kaWYgLy8gSEFWRShBVktJVCkKLSNlbmRpZiAvLyBQTEFURk9STShDT0NPQSkKKyNlbmRp ZiAvLyBQTEFURk9STShDT0NPQSkgJiYgSEFWRShBVktJVCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5Db250cm9sbGVyQVZLaXQubW0g Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxl ckFWS2l0Lm1tCmluZGV4IGM4ZjliY2VhMWM1NTMzM2Q5ZWMwMjJkNGE0NjNiZmZmZjIzNWU5NGIu LjdiODRkZmRjMTBiMmNlNDBkNWFiZTNkZGIyZGIzOTExYmQwNWFlYjQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5Db250cm9sbGVyQVZL aXQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVl bkNvbnRyb2xsZXJBVktpdC5tbQpAQCAtOTkxLDcgKzk5MSw2IEBAIHZvaWQgVmlkZW9GdWxsc2Ny ZWVuQ29udHJvbGxlckNvbnRleHQ6OnNldFVwRnVsbHNjcmVlbihIVE1MVmlkZW9FbGVtZW50JiB2 aWRlb0VsCiAgICAgICAgIG1faW50ZXJmYWNlID0gVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZL aXQ6OmNyZWF0ZShzZXNzaW9uSW50ZXJmYWNlLmdldCgpKTsKICAgICAgICAgbV9pbnRlcmZhY2Ut PnNldFZpZGVvRnVsbHNjcmVlbkNoYW5nZU9ic2VydmVyKHRoaXMpOwogICAgICAgICBtX2ludGVy ZmFjZS0+c2V0VmlkZW9GdWxsc2NyZWVuTW9kZWwodGhpcyk7Ci0gICAgICAgIG1faW50ZXJmYWNl LT5zZXRWaWRlb0Z1bGxzY3JlZW5DaGFuZ2VPYnNlcnZlcih0aGlzKTsKIAogICAgICAgICBtX3Zp ZGVvRnVsbHNjcmVlblZpZXcgPSBhZG9wdE5TKFtQQUw6OmFsbG9jVUlWaWV3SW5zdGFuY2UoKSBp bml0XSk7CiAK