213990 2020-07-06 05:23:24 -0700 [WPE][GTK] CMake warnings 2020-09-23 14:33:35 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214012 P2 Normal --- 214012 216773 1 pnormand webkit-unassigned aperez don.olmstead oldest_to_newest 1669023 0 pnormand 2020-07-06 05:23:24 -0700 -- demux (required): /usr/lib/x86_64-linux-gnu/libwebpdemux.so CMake Warning (dev) at /usr/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:272 (message): The package name passed to `find_package_handle_standard_args` (ATK_BRIDGE) does not match the name of the calling package (ATKBridge). This can lead to problems in calling code that expects `find_package` result variables (e.g., `_FOUND`) to follow a certain pattern. Call Stack (most recent call first): Source/cmake/FindATKBridge.cmake:47 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) Source/cmake/WebKitFindPackage.cmake:104 (_find_package) Source/cmake/OptionsWPE.cmake:132 (find_package) Source/cmake/WebKitCommon.cmake:58 (include) CMakeLists.txt:173 (include) This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning at Source/cmake/FindWOFF2.cmake:76 (message): Cannot determine WOFF2 version without pkg-config Call Stack (most recent call first): Source/cmake/WebKitFindPackage.cmake:104 (_find_package) Source/cmake/OptionsWPE.cmake:146 (find_package) Source/cmake/WebKitCommon.cmake:58 (include) CMakeLists.txt:173 (include) 1669369 1 aperez 2020-07-07 05:06:18 -0700 (In reply to Philippe Normand from comment #0) > -- demux (required): /usr/lib/x86_64-linux-gnu/libwebpdemux.so > CMake Warning (dev) at > /usr/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:272 > (message): > The package name passed to `find_package_handle_standard_args` (ATK_BRIDGE) > does not match the name of the calling package (ATKBridge). This can lead > to problems in calling code that expects `find_package` result variables > (e.g., `_FOUND`) to follow a certain pattern. > Call Stack (most recent call first): > Source/cmake/FindATKBridge.cmake:47 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) > Source/cmake/WebKitFindPackage.cmake:104 (_find_package) > Source/cmake/OptionsWPE.cmake:132 (find_package) > Source/cmake/WebKitCommon.cmake:58 (include) > CMakeLists.txt:173 (include) > This warning is for project developers. Use -Wno-dev to suppress it. We have a few more with CMake 3.17 (or at least I started to notice more warnings recently which I think it was after CMake was updated to 3.17.3 in Arch Linux). It would be good to take advantage of the situation to also convert the offending find-modules to use imported targets, while at it :-) > CMake Warning at Source/cmake/FindWOFF2.cmake:76 (message): > Cannot determine WOFF2 version without pkg-config > Call Stack (most recent call first): > Source/cmake/WebKitFindPackage.cmake:104 (_find_package) > Source/cmake/OptionsWPE.cmake:146 (find_package) > Source/cmake/WebKitCommon.cmake:58 (include) > CMakeLists.txt:173 (include) This second warning has been already fixed in bug #214012 / r264012 1691260 2 aperez 2020-09-23 14:31:41 -0700 (In reply to Philippe Normand from comment #0) > -- demux (required): /usr/lib/x86_64-linux-gnu/libwebpdemux.so > CMake Warning (dev) at > /usr/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:272 > (message): > The package name passed to `find_package_handle_standard_args` (ATK_BRIDGE) > does not match the name of the calling package (ATKBridge). This can lead > to problems in calling code that expects `find_package` result variables > (e.g., `_FOUND`) to follow a certain pattern. > Call Stack (most recent call first): > Source/cmake/FindATKBridge.cmake:47 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) > Source/cmake/WebKitFindPackage.cmake:104 (_find_package) > Source/cmake/OptionsWPE.cmake:132 (find_package) > Source/cmake/WebKitCommon.cmake:58 (include) > CMakeLists.txt:173 (include) > This warning is for project developers. Use -Wno-dev to suppress it. This one was fixed in bug #216773 ­— the fix landed in r267399 1691261 3 aperez 2020-09-23 14:33:35 -0700 Closing, CMake warnings are no more in “trunk” 😊️