213975 2020-07-05 12:36:03 -0700 Use RenderObject::positionForPoint instead of hit testing the entire view in closestEditablePositionInElementForAbsolutePoint 2020-07-06 09:28:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210939 InRadar P2 Normal --- 1 dbates dbates ews-watchlist mifenton webkit-bug-importer wenson_hsieh oldest_to_newest 1668914 0 dbates 2020-07-05 12:36:03 -0700 This bug is following up on my comment bug 210939, comment 3. closestEditablePositionInElementForAbsolutePoint can be made more efficient by using RenderObject::positionForPoint to hit test the target element's renderer instead of doing this indirectly by way of hit testing the entire RenderView. 1668918 1 403561 dbates 2020-07-05 12:52:08 -0700 Created attachment 403561 Patch 1669044 2 403561 dbates 2020-07-06 09:27:52 -0700 Comment on attachment 403561 Patch Clearing flags on attachment: 403561 Committed r263969: <https://trac.webkit.org/changeset/263969> 1669045 3 dbates 2020-07-06 09:27:54 -0700 All reviewed patches have been landed. Closing bug. 1669046 4 webkit-bug-importer 2020-07-06 09:28:14 -0700 <rdar://problem/65134809> 403561 2020-07-05 12:52:08 -0700 2020-07-06 09:27:52 -0700 Patch bug-213975-20200705125208.patch text/plain 2394 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzOTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQ0ZjExYjczYTIwNWJl ZjMzZWUzZDgzNTIyMDI3NzlkM2FmY2Y3ZC4uZjQ3MGMzYzlkYTgxYzA1ZjdkZTkxNDM2MmM2ZmVi ZTkzMmFiOThkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA3LTA1ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgUmVuZGVyT2JqZWN0 Ojpwb3NpdGlvbkZvclBvaW50IGluc3RlYWQgb2YgaGl0IHRlc3RpbmcgdGhlIGVudGlyZSB2aWV3 IGluIGNsb3Nlc3RFZGl0YWJsZVBvc2l0aW9uSW5FbGVtZW50Rm9yQWJzb2x1dGVQb2ludAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzOTc1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHRhcmdldCBy ZW5kZXJlciBpcyBrbm93biBhIHByaW9yaSBzbyBpdCBpcyBtb3JlIGVmZmljaWVudCB0byBoaXQg dGVzdCB0aGlzIGRpcmVjdGx5CisgICAgICAgIGluc3RlYWQgb2YgaW5kaXJlY3RseSBieSBoaXQg dGVzdGluZyB0aGUgZW50aXJlIHZpZXcuCisKKyAgICAgICAgKiBlZGl0aW5nL0VkaXRpbmcuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Y2xvc2VzdEVkaXRhYmxlUG9zaXRpb25JbkVsZW1lbnRGb3JB YnNvbHV0ZVBvaW50KToKKwogMjAyMC0wNS0xNyAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBs ZS5jb20+CiAKICAgICAgICAgQm90dGxlIHVwIGlPUyB3b3JkIGJvdW5kYXJ5IGhhY2sgYmVoaW5k IGludGVyZmFjZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0aW5nLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdGluZy5jcHAKaW5kZXggNGJiNDQ2Njg4NDJl NGJlYTJlZDgzNDQ3ZDNiYTYyZDkwNzNmZWQ4Mi4uZTU3YmVlMGJlMWU4NmQ5MGVkYzI0MzQ5MTdm ZWFkNWFjNmRkZDQ0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0aW5n LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRpbmcuY3BwCkBAIC01NjksOCAr NTY5LDYgQEAgVmlzaWJsZVBvc2l0aW9uIGNsb3Nlc3RFZGl0YWJsZVBvc2l0aW9uSW5FbGVtZW50 Rm9yQWJzb2x1dGVQb2ludChjb25zdCBFbGVtZW50JgogICAgICAgICByZXR1cm4geyB9OwogCiAg ICAgUmVmPGNvbnN0IEVsZW1lbnQ+IHByb3RlY3RlZEVsZW1lbnQgeyBlbGVtZW50IH07Ci0gICAg YXV0byBmcmFtZSA9IG1ha2VSZWYoKmVsZW1lbnQuZG9jdW1lbnQoKS5mcmFtZSgpKTsKLQogICAg IGVsZW1lbnQuZG9jdW1lbnQoKS51cGRhdGVMYXlvdXRJZ25vcmVQZW5kaW5nU3R5bGVzaGVldHMo KTsKIAogICAgIFJlbmRlck9iamVjdCogcmVuZGVyZXIgPSBlbGVtZW50LnJlbmRlcmVyKCk7CkBA IC01ODUsOCArNTgzLDkgQEAgVmlzaWJsZVBvc2l0aW9uIGNsb3Nlc3RFZGl0YWJsZVBvc2l0aW9u SW5FbGVtZW50Rm9yQWJzb2x1dGVQb2ludChjb25zdCBFbGVtZW50JgogICAgIGlmICghcmVuZGVy ZXIpCiAgICAgICAgIHJldHVybiB7IH07CiAgICAgYXV0byBhYnNvbHV0ZUJvdW5kaW5nQm94ID0g cmVuZGVyZXItPmFic29sdXRlQm91bmRpbmdCb3hSZWN0KCk7Ci0gICAgYXV0byBjb25zdHJhaW5l ZFBvaW50ID0gcG9pbnQuY29uc3RyYWluZWRCZXR3ZWVuKGFic29sdXRlQm91bmRpbmdCb3gubWlu WE1pbllDb3JuZXIoKSwgYWJzb2x1dGVCb3VuZGluZ0JveC5tYXhYTWF4WUNvcm5lcigpKTsKLSAg ICBhdXRvIHZpc2libGVQb3NpdGlvbiA9IGZyYW1lLT52aXNpYmxlUG9zaXRpb25Gb3JQb2ludChj b25zdHJhaW5lZFBvaW50KTsKKyAgICBhdXRvIGNvbnN0cmFpbmVkQWJzb2x1dGVQb2ludCA9IHBv aW50LmNvbnN0cmFpbmVkQmV0d2VlbihhYnNvbHV0ZUJvdW5kaW5nQm94Lm1pblhNaW5ZQ29ybmVy KCksIGFic29sdXRlQm91bmRpbmdCb3gubWF4WE1heFlDb3JuZXIoKSk7CisgICAgYXV0byBsb2Nh bFBvaW50ID0gcmVuZGVyZXItPmFic29sdXRlVG9Mb2NhbChjb25zdHJhaW5lZEFic29sdXRlUG9p bnQsIFVzZVRyYW5zZm9ybXMpOworICAgIGF1dG8gdmlzaWJsZVBvc2l0aW9uID0gcmVuZGVyZXIt PnBvc2l0aW9uRm9yUG9pbnQoZmxvb3JlZExheW91dFBvaW50KGxvY2FsUG9pbnQpLCBudWxscHRy KTsKICAgICByZXR1cm4gaXNFZGl0YWJsZVBvc2l0aW9uKHZpc2libGVQb3NpdGlvbi5kZWVwRXF1 aXZhbGVudCgpKSA/IHZpc2libGVQb3NpdGlvbiA6IFZpc2libGVQb3NpdGlvbiB7IH07CiB9CiAK