213947 2020-07-03 19:04:23 -0700 [GStreamer] media/vp9.html failing since check-in in r263894 2020-07-28 05:19:22 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=213780 InRadar P2 Normal --- 1 lmoura calvaris aperez bugs-noreply calvaris darin eric.carlson ews-watchlist glenn jer.noble philipj pnormand sergio vjaquez webkit-bug-importer youennf oldest_to_newest 1668706 0 lmoura 2020-07-03 19:04:23 -0700 Like the webrtc counterpart in bug213780, media/vp9.html is failing since added: --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/vp9-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/vp9-actual.txt @@ -1,5 +1,5 @@ -PASS HTMLMediaElement.canPlay VP9 +FAIL HTMLMediaElement.canPlay VP9 assert_equals: canPlayType expected "maybe" but got "probably" PASS VP9 decoding 1668755 1 pnormand 2020-07-04 01:15:28 -0700 I don't think 2 bugs are needed. *** This bug has been marked as a duplicate of bug 213780 *** 1668757 2 pnormand 2020-07-04 01:16:09 -0700 Oh it's 2 different tests. My bad :) 1669717 3 pnormand 2020-07-08 04:15:05 -0700 media/vp9.html has this assert: assert_equals(video.canPlayType("video/mp4; codecs=vp9"), "maybe", "canPlayType"); Youenn, in GTK/WPE this returns "probably". Would it be OK to update the test changing the assert to a less restrictive test? Perhaps simply log the result in test expectation? 1670023 4 calvaris 2020-07-08 23:00:11 -0700 (In reply to Philippe Normand from comment #3) > media/vp9.html has this assert: > > assert_equals(video.canPlayType("video/mp4; codecs=vp9"), "maybe", > "canPlayType"); > > Youenn, in GTK/WPE this returns "probably". Would it be OK to update the > test changing the assert to a less restrictive test? Perhaps simply log the > result in test expectation? From what I read in the spec at [1], it's clear that we're specifying the codec here so a user agent is per spec allowed to return probably. [1] https://html.spec.whatwg.org/multipage/media.html#dom-navigator-canplaytype This makes this test very highly dependent on the platform so I'd say we have to log the result and make different expectations for platforms. You can leave a general one with maybe and another glib one with probably. 1670048 5 pnormand 2020-07-09 02:04:20 -0700 Also exiting early if !window.internals.usingAppleInternalSDK is a bit sad, for non-Apple ports :( 1673037 6 youennf 2020-07-20 06:15:58 -0700 (In reply to Philippe Normand from comment #5) > Also exiting early if !window.internals.usingAppleInternalSDK is a bit sad, > for non-Apple ports :( (In reply to Philippe Normand from comment #3) > media/vp9.html has this assert: > > assert_equals(video.canPlayType("video/mp4; codecs=vp9"), "maybe", > "canPlayType"); > > Youenn, in GTK/WPE this returns "probably". Would it be OK to update the > test changing the assert to a less restrictive test? Perhaps simply log the > result in test expectation? I think it is fine to check for either maybe or probably. (In reply to Philippe Normand from comment #5) > Also exiting early if !window.internals.usingAppleInternalSDK is a bit sad, > for non-Apple ports :( We could probably rewrite the test so that rejection of video.play() is tolerated in case of non Apple Internal SDK. 1675249 7 405278 calvaris 2020-07-27 08:39:13 -0700 Created attachment 405278 Patch 1675263 8 405278 aperez 2020-07-27 09:05:12 -0700 Comment on attachment 405278 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405278&action=review > LayoutTests/ChangeLog:8 > + * media/vp9.html: Non Apple ports return propably instead of "" Typo: propably → probably 1675270 9 405285 calvaris 2020-07-27 09:25:57 -0700 Created attachment 405285 Patch Add isApple which gives better granularity and allows GStreamer to run the second test. 1675343 10 405285 darin 2020-07-27 12:10:56 -0700 Comment on attachment 405285 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405285&action=review > Source/WebCore/testing/Internals.cpp:5531 > +#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(MACCATALYST) > + return true; > +#else > + return false; > +#endif This is an incorrect implementation. Will return false for watchOS and tvOS. Simpler is to just write PLATFORM(COCOA). Not thrilled with the name of this. It seems imprecise. It will return false if you are running on Apple hardware but with a non-Apple port of WebKIt, and will return false if you are running on Windows with an Apple port of WebKit. 1675517 11 calvaris 2020-07-27 22:14:31 -0700 (In reply to Darin Adler from comment #10) > Comment on attachment 405285 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=405285&action=review > > > Source/WebCore/testing/Internals.cpp:5531 > > +#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(MACCATALYST) > > + return true; > > +#else > > + return false; > > +#endif > > This is an incorrect implementation. Will return false for watchOS and tvOS. > Simpler is to just write PLATFORM(COCOA). Ok, > Not thrilled with the name of this. It seems imprecise. It will return false > if you are running on Apple hardware but with a non-Apple port of WebKIt, > and will return false if you are running on Windows with an Apple port of > WebKit. I'll name it isApplePort. 1675536 12 405344 calvaris 2020-07-28 01:02:32 -0700 Created attachment 405344 Patch Implemented with internals.usingGStreamer() 1675573 13 405350 calvaris 2020-07-28 04:47:51 -0700 Created attachment 405350 Patch for landing 1675577 14 ews-feeder 2020-07-28 05:18:11 -0700 Committed r264975: <https://trac.webkit.org/changeset/264975> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405350. 1675578 15 webkit-bug-importer 2020-07-28 05:19:22 -0700 <rdar://problem/66212906> 405278 2020-07-27 08:39:13 -0700 2020-07-27 09:25:57 -0700 Patch Patch.patch text/plain 1290 calvaris ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ZTAyYjE2MDYwODMuLjAzMmU4MDk1NTA2NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBA CisyMDIwLTA3LTI3ICBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gbWVkaWEvdnA5Lmh0bWwgZmFpbGluZyBzaW5jZSBj aGVjay1pbiBpbiByMjYzODk0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTM5NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIG1lZGlhL3ZwOS5odG1sOiBOb24gQXBwbGUgcG9ydHMgcmV0dXJuIHByb3Bh Ymx5IGluc3RlYWQgb2YgIiIKKwogMjAyMC0wNy0yNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBh cHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGFzc2VydGlvbnMgaW4gUlRDVmlkZW9FbmNvZGVy SDI2NCB0aGF0IGFyZSB3cm9uZyBpbiBjYXNlIG9mIHNpbXVsY2FzdApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvbWVkaWEvdnA5Lmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS92cDkuaHRtbAppbmRl eCAwMjQ0ZWViODJlMjguLjE0NTRhODQxMTUyNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVk aWEvdnA5Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdnA5Lmh0bWwKQEAgLTcsNyArNywx MCBAQAogLy8gRklYTUU6IEFkZCB0ZXN0IGZvciBNZWRpYVNvdXJjZS5pc1R5cGVTdXBwb3J0ZWQo InZpZGVvL21wNDsgY29kZWNzPXZwOSIpCiAKIHRlc3QoKCkgPT4gewotICAgIGFzc2VydF9lcXVh bHModmlkZW8uY2FuUGxheVR5cGUoInZpZGVvL21wNDsgY29kZWNzPXZwOSIpLCAiIiwgImNhblBs YXlUeXBlIik7CisgICAgbGV0IGV4cGVjdGVkVlA5U3VwcG9ydCA9ICIiCisgICAgaWYgKHdpbmRv dy5pbnRlcm5hbHMgJiYgIXdpbmRvdy5pbnRlcm5hbHMudXNpbmdBcHBsZUludGVybmFsU0RLKCkp CisgICAgICAgIGV4cGVjdGVkVlA5U3VwcG9ydCA9ICJwcm9iYWJseSIKKyAgICBhc3NlcnRfZXF1 YWxzKHZpZGVvLmNhblBsYXlUeXBlKCJ2aWRlby9tcDQ7IGNvZGVjcz12cDkiKSwgZXhwZWN0ZWRW UDlTdXBwb3J0LCAiY2FuUGxheVR5cGUiKTsKIH0sICJIVE1MTWVkaWFFbGVtZW50LmNhblBsYXkg VlA5Iik7CiAKIHByb21pc2VfdGVzdChhc3luYygpID0+IHsK 405285 2020-07-27 09:25:57 -0700 2020-07-28 01:02:32 -0700 Patch Patch.patch text/plain 3929 calvaris ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ZTAyYjE2MDYwODMuLjRlNWYzYmNjZGU0NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDIwLTA3LTI3ICBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gbWVkaWEvdnA5Lmh0bWwgZmFpbGluZyBzaW5jZSBj aGVjay1pbiBpbiByMjYzODk0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTM5NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIG1lZGlhL3ZwOS5odG1sOiBSdW4gdGhlIGZpcnN0IHRlc3Qgd2l0aCBleHBl Y3RhdGlvbnMgYXMKKyAgICAgICAgInByb2JhYmx5IiBmb3Igbm9uIEFwcGxlIHBvcnRzLiBSdW4g dGhlIHNlY29uZCB0ZXN0IGZvciBub24gQXBwbGUKKyAgICAgICAgcG9ydHMgYXMgd2VsbC4KKwog MjAyMC0wNy0yNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAg UmVtb3ZlIGFzc2VydGlvbnMgaW4gUlRDVmlkZW9FbmNvZGVySDI2NCB0aGF0IGFyZSB3cm9uZyBp biBjYXNlIG9mIHNpbXVsY2FzdApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdnA5Lmh0 bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS92cDkuaHRtbAppbmRleCAwMjQ0ZWViODJlMjguLjQzOTkz YTY2NDAyNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvdnA5Lmh0bWwKKysrIGIvTGF5 b3V0VGVzdHMvbWVkaWEvdnA5Lmh0bWwKQEAgLTcsMTEgKzcsMTQgQEAKIC8vIEZJWE1FOiBBZGQg dGVzdCBmb3IgTWVkaWFTb3VyY2UuaXNUeXBlU3VwcG9ydGVkKCJ2aWRlby9tcDQ7IGNvZGVjcz12 cDkiKQogCiB0ZXN0KCgpID0+IHsKLSAgICBhc3NlcnRfZXF1YWxzKHZpZGVvLmNhblBsYXlUeXBl KCJ2aWRlby9tcDQ7IGNvZGVjcz12cDkiKSwgIiIsICJjYW5QbGF5VHlwZSIpOworICAgIGxldCBl eHBlY3RlZFZQOVN1cHBvcnQgPSAiIgorICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzICYmICF3aW5k b3cuaW50ZXJuYWxzLmlzQXBwbGUoKSkKKyAgICAgICAgZXhwZWN0ZWRWUDlTdXBwb3J0ID0gInBy b2JhYmx5IgorICAgIGFzc2VydF9lcXVhbHModmlkZW8uY2FuUGxheVR5cGUoInZpZGVvL21wNDsg Y29kZWNzPXZwOSIpLCBleHBlY3RlZFZQOVN1cHBvcnQsICJjYW5QbGF5VHlwZSIpOwogfSwgIkhU TUxNZWRpYUVsZW1lbnQuY2FuUGxheSBWUDkiKTsKIAogcHJvbWlzZV90ZXN0KGFzeW5jKCkgPT4g ewotICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzICYmICF3aW5kb3cuaW50ZXJuYWxzLnVzaW5nQXBw bGVJbnRlcm5hbFNESygpKQorICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzICYmIHdpbmRvdy5pbnRl cm5hbHMuaXNBcHBsZSgpICYmICF3aW5kb3cuaW50ZXJuYWxzLnVzaW5nQXBwbGVJbnRlcm5hbFNE SygpKQogICAgICAgICByZXR1cm47CiAgICAgYXdhaXQgdmlkZW8ucGxheSgpOwogICAgIGFzc2Vy dF9lcXVhbHModmlkZW8udmlkZW9XaWR0aCwgNjQwKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzODBkMTlmODBh MmQuLmVjNWVmZjQxZjdlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA3LTI3 ICBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAg ICAgW0dTdHJlYW1lcl0gbWVkaWEvdnA5Lmh0bWwgZmFpbGluZyBzaW5jZSBjaGVjay1pbiBpbiBy MjYzODk0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTM5NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgaXNBcHBsZSgpIGNoZWNrIHRvIGludGVybmFscy4KKworICAgICAgICAqIHRlc3RpbmcvSW50 ZXJuYWxzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkludGVybmFsczo6aXNBcHBsZSBjb25zdCk6 CisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbHMuaDoKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVy bmFscy5pZGw6CisKIDIwMjAtMDctMjQgIFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFy aXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBnc3RfYnVmZmVyX3VubWFwOiBh c3NlcnRpb24gJ0dTVF9JU19CVUZGRVIgKGJ1ZmZlciknIGZhaWxlZApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwIGIvU291cmNlL1dlYkNvcmUvdGVzdGlu Zy9JbnRlcm5hbHMuY3BwCmluZGV4IGFjYmZlZGM2ZDcyYi4uYjE1YzIwMzQ4Y2Q4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCkBAIC01NTIyLDYgKzU1MjIsMTUgQEAgYm9vbCBJ bnRlcm5hbHM6OnVzaW5nQXBwbGVJbnRlcm5hbFNESygpIGNvbnN0CiAjZW5kaWYKIH0KIAorYm9v bCBJbnRlcm5hbHM6OmlzQXBwbGUoKSBjb25zdAoreworI2lmIFBMQVRGT1JNKE1BQykgfHwgUExB VEZPUk0oSU9TKSB8fCBQTEFURk9STShNQUNDQVRBTFlTVCkKKyAgICByZXR1cm4gdHJ1ZTsKKyNl bHNlCisgICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCit9CisKIHZvaWQgSW50ZXJuYWxzOjpzZXRD YXB0dXJlRXh0cmFOZXR3b3JrTG9hZE1ldHJpY3NFbmFibGVkKGJvb2wgdmFsdWUpCiB7CiAgICAg cGxhdGZvcm1TdHJhdGVnaWVzKCktPmxvYWRlclN0cmF0ZWd5KCktPnNldENhcHR1cmVFeHRyYU5l dHdvcmtMb2FkTWV0cmljc0VuYWJsZWQodmFsdWUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvdGVzdGluZy9JbnRlcm5hbHMuaCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxz LmgKaW5kZXggODQzZWRmYTA0ODE0Li5jOWY1OGEzZTllZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9J bnRlcm5hbHMuaApAQCAtODM2LDYgKzgzNiw3IEBAIHB1YmxpYzoKICAgICB2b2lkIG1hcmtDb250 ZXh0QXNJbnNlY3VyZSgpOwogCiAgICAgYm9vbCB1c2luZ0FwcGxlSW50ZXJuYWxTREsoKSBjb25z dDsKKyAgICBib29sIGlzQXBwbGUoKSBjb25zdDsKIAogICAgIHN0cnVjdCBOb3dQbGF5aW5nU3Rh dGUgewogICAgICAgICBTdHJpbmcgdGl0bGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90 ZXN0aW5nL0ludGVybmFscy5pZGwgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFscy5p ZGwKaW5kZXggZTdmNjY1M2NhMDg0Li40OWExYjc3NWY5MGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5n L0ludGVybmFscy5pZGwKQEAgLTg1Nyw2ICs4NTcsNyBAQCBlbnVtIENvbnRlbnRTaXplQ2F0ZWdv cnkgewogICAgIGJvb2xlYW4gaXNTeXN0ZW1QcmV2aWV3SW1hZ2UoRWxlbWVudCBlbGVtZW50KTsK IAogICAgIGJvb2xlYW4gdXNpbmdBcHBsZUludGVybmFsU0RLKCk7CisgICAgYm9vbGVhbiBpc0Fw cGxlKCk7CiAKICAgICB2b2lkIHBvc3RUYXNrKFZvaWRDYWxsYmFjayBjYWxsYmFjayk7CiAgICAg W0NhbGxXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQsIE1heVRocm93RXhjZXB0aW9uXSB2b2lk IHF1ZXVlVGFzayhET01TdHJpbmcgc291cmNlLCBWb2lkQ2FsbGJhY2sgY2FsbGJhY2spOwo= 405344 2020-07-28 01:02:32 -0700 2020-07-28 04:48:02 -0700 Patch Patch.patch text/plain 3934 calvaris ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ZTAyYjE2MDYwODMuLmRhZmRhMDJmNTg1NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDIwLTA3LTI4ICBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gbWVkaWEvdnA5Lmh0bWwgZmFpbGluZyBzaW5jZSBj aGVjay1pbiBpbiByMjYzODk0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTM5NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIG1lZGlhL3ZwOS5odG1sOiBVc2VkIHVzaW5nR1N0cmVhbWVyKCkgdG8gYWRq dXN0IGV4cGVjdGF0aW9uIG9mCisgICAgICAgIHRoZSBmaXJzdCB0ZXN0IGFuZCB0byBlbmFibGUg dGhlIHNlY29uZC4gQm90aCBhcmUgcGFzc2luZyBub3cgZm9yCisgICAgICAgIEdTdHJlYW1lciBw b3J0cy4KKwogMjAyMC0wNy0yNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgUmVtb3ZlIGFzc2VydGlvbnMgaW4gUlRDVmlkZW9FbmNvZGVySDI2NCB0aGF0IGFy ZSB3cm9uZyBpbiBjYXNlIG9mIHNpbXVsY2FzdApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVk aWEvdnA5Lmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS92cDkuaHRtbAppbmRleCAwMjQ0ZWViODJl MjguLjJjZjRjZDI5ZjJkYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvdnA5Lmh0bWwK KysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdnA5Lmh0bWwKQEAgLTcsMTEgKzcsMTQgQEAKIC8vIEZJ WE1FOiBBZGQgdGVzdCBmb3IgTWVkaWFTb3VyY2UuaXNUeXBlU3VwcG9ydGVkKCJ2aWRlby9tcDQ7 IGNvZGVjcz12cDkiKQogCiB0ZXN0KCgpID0+IHsKLSAgICBhc3NlcnRfZXF1YWxzKHZpZGVvLmNh blBsYXlUeXBlKCJ2aWRlby9tcDQ7IGNvZGVjcz12cDkiKSwgIiIsICJjYW5QbGF5VHlwZSIpOwor ICAgIGxldCBleHBlY3RlZFZQOVN1cHBvcnQgPSAiIgorICAgIGlmICh3aW5kb3cuaW50ZXJuYWxz ICYmIHdpbmRvdy5pbnRlcm5hbHMudXNpbmdHU3RyZWFtZXIoKSkKKyAgICAgICAgZXhwZWN0ZWRW UDlTdXBwb3J0ID0gInByb2JhYmx5IgorICAgIGFzc2VydF9lcXVhbHModmlkZW8uY2FuUGxheVR5 cGUoInZpZGVvL21wNDsgY29kZWNzPXZwOSIpLCBleHBlY3RlZFZQOVN1cHBvcnQsICJjYW5QbGF5 VHlwZSIpOwogfSwgIkhUTUxNZWRpYUVsZW1lbnQuY2FuUGxheSBWUDkiKTsKIAogcHJvbWlzZV90 ZXN0KGFzeW5jKCkgPT4gewotICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzICYmICF3aW5kb3cuaW50 ZXJuYWxzLnVzaW5nQXBwbGVJbnRlcm5hbFNESygpKQorICAgIGlmICh3aW5kb3cuaW50ZXJuYWxz ICYmICF3aW5kb3cuaW50ZXJuYWxzLnVzaW5nR1N0cmVhbWVyKCkgJiYgIXdpbmRvdy5pbnRlcm5h bHMudXNpbmdBcHBsZUludGVybmFsU0RLKCkpCiAgICAgICAgIHJldHVybjsKICAgICBhd2FpdCB2 aWRlby5wbGF5KCk7CiAgICAgYXNzZXJ0X2VxdWFscyh2aWRlby52aWRlb1dpZHRoLCA2NDApOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDM4MGQxOWY4MGEyZC4uNGMyNGJhZjViYThlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMjAtMDctMjggIFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFy aXNAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBtZWRpYS92cDkuaHRtbCBmYWls aW5nIHNpbmNlIGNoZWNrLWluIGluIHIyNjM4OTQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzk0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRlc3Q6IG1lZGlhL3ZwOS5odG1sLgorCisgICAgICAgICog dGVzdGluZy9JbnRlcm5hbHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW50ZXJuYWxzOjp1c2lu Z0dTdHJlYW1lciBjb25zdCk6IEFkZGVkLgorICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxzLmg6 CisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbHMuaWRsOgorCiAyMDIwLTA3LTI0ICBYYWJpZXIg Um9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJl YW1lcl0gZ3N0X2J1ZmZlcl91bm1hcDogYXNzZXJ0aW9uICdHU1RfSVNfQlVGRkVSIChidWZmZXIp JyBmYWlsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcAppbmRleCBhY2JmZWRjNmQ3 MmIuLjljYTliZTIwY2Q1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRl cm5hbHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmNwcApAQCAt NTUyMiw2ICs1NTIyLDE1IEBAIGJvb2wgSW50ZXJuYWxzOjp1c2luZ0FwcGxlSW50ZXJuYWxTREso KSBjb25zdAogI2VuZGlmCiB9CiAKK2Jvb2wgSW50ZXJuYWxzOjp1c2luZ0dTdHJlYW1lcigpIGNv bnN0Cit7CisjaWYgVVNFKEdTVFJFQU1FUikKKyAgICByZXR1cm4gdHJ1ZTsKKyNlbHNlCisgICAg cmV0dXJuIGZhbHNlOworI2VuZGlmCit9CisKIHZvaWQgSW50ZXJuYWxzOjpzZXRDYXB0dXJlRXh0 cmFOZXR3b3JrTG9hZE1ldHJpY3NFbmFibGVkKGJvb2wgdmFsdWUpCiB7CiAgICAgcGxhdGZvcm1T dHJhdGVnaWVzKCktPmxvYWRlclN0cmF0ZWd5KCktPnNldENhcHR1cmVFeHRyYU5ldHdvcmtMb2Fk TWV0cmljc0VuYWJsZWQodmFsdWUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGlu Zy9JbnRlcm5hbHMuaCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmgKaW5kZXgg ODQzZWRmYTA0ODE0Li40MDdjMjEyODA2MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rl c3RpbmcvSW50ZXJuYWxzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMu aApAQCAtODM2LDYgKzgzNiw3IEBAIHB1YmxpYzoKICAgICB2b2lkIG1hcmtDb250ZXh0QXNJbnNl Y3VyZSgpOwogCiAgICAgYm9vbCB1c2luZ0FwcGxlSW50ZXJuYWxTREsoKSBjb25zdDsKKyAgICBi b29sIHVzaW5nR1N0cmVhbWVyKCkgY29uc3Q7CiAKICAgICBzdHJ1Y3QgTm93UGxheWluZ1N0YXRl IHsKICAgICAgICAgU3RyaW5nIHRpdGxlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVz dGluZy9JbnRlcm5hbHMuaWRsIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaWRs CmluZGV4IGU3ZjY2NTNjYTA4NC4uMTgzNDNmNzRjY2UyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS90ZXN0aW5nL0ludGVybmFscy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9J bnRlcm5hbHMuaWRsCkBAIC04NTcsNiArODU3LDcgQEAgZW51bSBDb250ZW50U2l6ZUNhdGVnb3J5 IHsKICAgICBib29sZWFuIGlzU3lzdGVtUHJldmlld0ltYWdlKEVsZW1lbnQgZWxlbWVudCk7CiAK ICAgICBib29sZWFuIHVzaW5nQXBwbGVJbnRlcm5hbFNESygpOworICAgIGJvb2xlYW4gdXNpbmdH U3RyZWFtZXIoKTsKIAogICAgIHZvaWQgcG9zdFRhc2soVm9pZENhbGxiYWNrIGNhbGxiYWNrKTsK ICAgICBbQ2FsbFdpdGg9U2NyaXB0RXhlY3V0aW9uQ29udGV4dCwgTWF5VGhyb3dFeGNlcHRpb25d IHZvaWQgcXVldWVUYXNrKERPTVN0cmluZyBzb3VyY2UsIFZvaWRDYWxsYmFjayBjYWxsYmFjayk7 Cg== 405350 2020-07-28 04:47:51 -0700 2020-07-28 05:18:12 -0700 Patch for landing Patch.patch text/plain 4737 calvaris ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ZTAyYjE2MDYwODMuLmQ2OWJkM2E5ZGJlYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBA CisyMDIwLTA3LTI4ICBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gbWVkaWEvdnA5Lmh0bWwgZmFpbGluZyBzaW5jZSBj aGVjay1pbiBpbiByMjYzODk0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTM5NDcKKworICAgICAgICBSZXZpZXdlZCBieSBQaGlsaXBwZSBOb3JtYW5k LgorCisgICAgICAgICogbWVkaWEvdnA5Lmh0bWw6IFVzZWQgdXNpbmdHU3RyZWFtZXIoKSB0byBh ZGp1c3QgZXhwZWN0YXRpb24gb2YKKyAgICAgICAgdGhlIGZpcnN0IHRlc3QgYW5kIHRvIGVuYWJs ZSB0aGUgc2Vjb25kLiBCb3RoIGFyZSBwYXNzaW5nIG5vdyBmb3IKKyAgICAgICAgR1N0cmVhbWVy IHBvcnRzLgorICAgICAgICAqIHBsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9uczogUmVtb3Zl ZCBtZWRpYS92cDkuaHRtbCBmYWlsdXJlCisgICAgICAgIGZyb20gZXhwZWN0YXRpb25zLgorCiAy MDIwLTA3LTI0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZW1vdmUgYXNzZXJ0aW9ucyBpbiBSVENWaWRlb0VuY29kZXJIMjY0IHRoYXQgYXJlIHdyb25nIGlu IGNhc2Ugb2Ygc2ltdWxjYXN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS92cDkuaHRt bCBiL0xheW91dFRlc3RzL21lZGlhL3ZwOS5odG1sCmluZGV4IDAyNDRlZWI4MmUyOC4uMmNmNGNk MjlmMmRhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9tZWRpYS92cDkuaHRtbAorKysgYi9MYXlv dXRUZXN0cy9tZWRpYS92cDkuaHRtbApAQCAtNywxMSArNywxNCBAQAogLy8gRklYTUU6IEFkZCB0 ZXN0IGZvciBNZWRpYVNvdXJjZS5pc1R5cGVTdXBwb3J0ZWQoInZpZGVvL21wNDsgY29kZWNzPXZw OSIpCiAKIHRlc3QoKCkgPT4gewotICAgIGFzc2VydF9lcXVhbHModmlkZW8uY2FuUGxheVR5cGUo InZpZGVvL21wNDsgY29kZWNzPXZwOSIpLCAiIiwgImNhblBsYXlUeXBlIik7CisgICAgbGV0IGV4 cGVjdGVkVlA5U3VwcG9ydCA9ICIiCisgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMgJiYgd2luZG93 LmludGVybmFscy51c2luZ0dTdHJlYW1lcigpKQorICAgICAgICBleHBlY3RlZFZQOVN1cHBvcnQg PSAicHJvYmFibHkiCisgICAgYXNzZXJ0X2VxdWFscyh2aWRlby5jYW5QbGF5VHlwZSgidmlkZW8v bXA0OyBjb2RlY3M9dnA5IiksIGV4cGVjdGVkVlA5U3VwcG9ydCwgImNhblBsYXlUeXBlIik7CiB9 LCAiSFRNTE1lZGlhRWxlbWVudC5jYW5QbGF5IFZQOSIpOwogCiBwcm9taXNlX3Rlc3QoYXN5bmMo KSA9PiB7Ci0gICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMgJiYgIXdpbmRvdy5pbnRlcm5hbHMudXNp bmdBcHBsZUludGVybmFsU0RLKCkpCisgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMgJiYgIXdpbmRv dy5pbnRlcm5hbHMudXNpbmdHU3RyZWFtZXIoKSAmJiAhd2luZG93LmludGVybmFscy51c2luZ0Fw cGxlSW50ZXJuYWxTREsoKSkKICAgICAgICAgcmV0dXJuOwogICAgIGF3YWl0IHZpZGVvLnBsYXko KTsKICAgICBhc3NlcnRfZXF1YWxzKHZpZGVvLnZpZGVvV2lkdGgsIDY0MCk7CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggMDE2Yjc1YjJmOGVlLi44ZmNm MjZjNDJlZjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVj dGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMK QEAgLTIxMCw3ICsyMTAsNiBAQCB3ZWJraXQub3JnL2IvMjEwNTI4IG1lZGlhL21lZGlhLXNvdXJj ZS9tZWRpYS1zb3VyY2Utc2Vlay1iYWNrLmh0bWwgWyBDcmFzaCBQYXNzCiB3ZWJraXQub3JnL2Iv MjEwNTI4IG1lZGlhL3ZpZGVvLXNyYy1ibG9iLXJlcGxheS5odG1sIFsgQ3Jhc2ggUGFzcyBdCiAK IHdlYmtpdC5vcmcvYi8yMTE5OTUgZmFzdC9pbWFnZXMvYW5pbWF0ZWQtaW1hZ2UtbXA0Lmh0bWwg WyBGYWlsdXJlIF0KLXdlYmtpdC5vcmcvYi8yMTM5NDcgbWVkaWEvdnA5Lmh0bWwgWyBGYWlsdXJl IF0KIAogd2Via2l0Lm9yZy9iLzIxNDAzOCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L2h0bWwvc2VtYW50aWNzL2VtYmVkZGVkLWNvbnRlbnQvbWVkaWEtZWxlbWVudHMvdHJhY2svdHJh Y2stZWxlbWVudC90cmFjay1jdWVzLWN1ZWNoYW5nZS5odG1sIFsgTWlzc2luZyBGYWlsdXJlIF0K IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDM4MGQxOWY4MGEyZC4uZDNjMWFjYTAyNmQ0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMjAtMDctMjggIFhhYmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2Fs dmFyaXNAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBtZWRpYS92cDkuaHRtbCBm YWlsaW5nIHNpbmNlIGNoZWNrLWluIGluIHIyNjM4OTQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzk0NworCisgICAgICAgIFJldmlld2VkIGJ5IFBo aWxpcHBlIE5vcm1hbmQuCisKKyAgICAgICAgVGVzdDogbWVkaWEvdnA5Lmh0bWwuCisKKyAgICAg ICAgKiB0ZXN0aW5nL0ludGVybmFscy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnRlcm5hbHM6 OnVzaW5nR1N0cmVhbWVyIGNvbnN0KTogQWRkZWQuCisgICAgICAgICogdGVzdGluZy9JbnRlcm5h bHMuaDoKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVybmFscy5pZGw6CisKIDIwMjAtMDctMjQgIFhh YmllciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBb R1N0cmVhbWVyXSBnc3RfYnVmZmVyX3VubWFwOiBhc3NlcnRpb24gJ0dTVF9JU19CVUZGRVIgKGJ1 ZmZlciknIGZhaWxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5h bHMuY3BwIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCmluZGV4IGFjYmZl ZGM2ZDcyYi4uOWNhOWJlMjBjZDU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5n L0ludGVybmFscy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3Bw CkBAIC01NTIyLDYgKzU1MjIsMTUgQEAgYm9vbCBJbnRlcm5hbHM6OnVzaW5nQXBwbGVJbnRlcm5h bFNESygpIGNvbnN0CiAjZW5kaWYKIH0KIAorYm9vbCBJbnRlcm5hbHM6OnVzaW5nR1N0cmVhbWVy KCkgY29uc3QKK3sKKyNpZiBVU0UoR1NUUkVBTUVSKQorICAgIHJldHVybiB0cnVlOworI2Vsc2UK KyAgICByZXR1cm4gZmFsc2U7CisjZW5kaWYKK30KKwogdm9pZCBJbnRlcm5hbHM6OnNldENhcHR1 cmVFeHRyYU5ldHdvcmtMb2FkTWV0cmljc0VuYWJsZWQoYm9vbCB2YWx1ZSkKIHsKICAgICBwbGF0 Zm9ybVN0cmF0ZWdpZXMoKS0+bG9hZGVyU3RyYXRlZ3koKS0+c2V0Q2FwdHVyZUV4dHJhTmV0d29y a0xvYWRNZXRyaWNzRW5hYmxlZCh2YWx1ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90 ZXN0aW5nL0ludGVybmFscy5oIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuaApp bmRleCA4NDNlZGZhMDQ4MTQuLjQwN2MyMTI4MDYwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvdGVzdGluZy9JbnRlcm5hbHMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVy bmFscy5oCkBAIC04MzYsNiArODM2LDcgQEAgcHVibGljOgogICAgIHZvaWQgbWFya0NvbnRleHRB c0luc2VjdXJlKCk7CiAKICAgICBib29sIHVzaW5nQXBwbGVJbnRlcm5hbFNESygpIGNvbnN0Owor ICAgIGJvb2wgdXNpbmdHU3RyZWFtZXIoKSBjb25zdDsKIAogICAgIHN0cnVjdCBOb3dQbGF5aW5n U3RhdGUgewogICAgICAgICBTdHJpbmcgdGl0bGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS90ZXN0aW5nL0ludGVybmFscy5pZGwgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFs cy5pZGwKaW5kZXggZTdmNjY1M2NhMDg0Li4xODM0M2Y3NGNjZTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxzLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0 aW5nL0ludGVybmFscy5pZGwKQEAgLTg1Nyw2ICs4NTcsNyBAQCBlbnVtIENvbnRlbnRTaXplQ2F0 ZWdvcnkgewogICAgIGJvb2xlYW4gaXNTeXN0ZW1QcmV2aWV3SW1hZ2UoRWxlbWVudCBlbGVtZW50 KTsKIAogICAgIGJvb2xlYW4gdXNpbmdBcHBsZUludGVybmFsU0RLKCk7CisgICAgYm9vbGVhbiB1 c2luZ0dTdHJlYW1lcigpOwogCiAgICAgdm9pZCBwb3N0VGFzayhWb2lkQ2FsbGJhY2sgY2FsbGJh Y2spOwogICAgIFtDYWxsV2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0LCBNYXlUaHJvd0V4Y2Vw dGlvbl0gdm9pZCBxdWV1ZVRhc2soRE9NU3RyaW5nIHNvdXJjZSwgVm9pZENhbGxiYWNrIGNhbGxi YWNrKTsK