213942 2020-07-03 13:50:57 -0700 [WPE] Fix build with clang after r263898 2020-07-03 14:27:32 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lmoura lmoura bugs-noreply cdumez ews-watchlist japhet oldest_to_newest 1668647 0 lmoura 2020-07-03 13:50:57 -0700 The WPE Release Bot is now using clang and caught[1] the following error: " DerivedSources/ForwardingHeaders/wtf/HashTable.h:956:17: error: incomplete type 'WTF::StringHash' named in nested name specifier if (HashFunctions::safeToCompareToEmptyOrDeleted) { ^~~~~~~~~~~~~~~ DerivedSources/ForwardingHeaders/wtf/HashTable.h:466:56: note: in instantiation of function template specialization 'WTF::HashTable<WTF::String, WTF::String, WTF::IdentityExtractor, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::add<WTF::IdentityHashTranslator<WTF::HashTraits<WTF::String>, WTF::StringHash>, const WTF::String &, const WTF::String &>' requested here AddResult add(const ValueType& value) { return add<IdentityTranslatorType>(Extractor::extract(value), value); } ^ DerivedSources/ForwardingHeaders/wtf/HashSet.h:239:19: note: in instantiation of member function 'WTF::HashTable<WTF::String, WTF::String, WTF::IdentityExtractor, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::add' requested here return m_impl.add(value); ^ ../../Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp:161:39: note: in instantiation of member function 'WTF::HashSet<WTF::String, WTF::StringHash, WTF::HashTraits<WTF::String> >::add' requested here manifest.explicitURLs.add(url.string()); ^ DerivedSources/ForwardingHeaders/wtf/text/StringParsingBuffer.h:119:16: note: in instantiation of function template specialization 'WebCore::parseApplicationCacheManifest(const WTF::URL &, const WTF::String &, const char *, int)::(anonymous class)::operator()<WTF::StringParsingBuffer<unsigned char> >' requested here return functor(StringParsingBuffer { string.characters8(), string.length() }); ^ ../../Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp:82:12: note: in instantiation of function template specialization 'WTF::readCharactersForParsing<WTF::String &, (lambda at ../../Source/WebCore/loader/appcache/ApplicationCacheManifestParser.cpp:82:53)>' requested here return readCharactersForParsing(manifestString, [&](auto buffer) -> Optional<ApplicationCacheManifest> {" [1] https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Build%29/builds/34853 1668650 1 403484 lmoura 2020-07-03 13:54:39 -0700 Created attachment 403484 Patch 1668653 2 403487 lmoura 2020-07-03 14:01:10 -0700 Created attachment 403487 Patch 1668654 3 403488 lmoura 2020-07-03 14:02:04 -0700 Created attachment 403488 Patch 1668661 4 ews-feeder 2020-07-03 14:27:30 -0700 Committed r263908: <https://trac.webkit.org/changeset/263908> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403488. 403484 2020-07-03 13:54:39 -0700 2020-07-03 14:01:05 -0700 Patch bug-213942-20200703175438.patch text/plain 1260 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzOTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFlYjk3YzFiOWYwYTUz ODIxMjUyNTI0ZGNiN2U5ZGYwMGEzMzAyMC4uYTkzMDA0MDQwYTAzZGUxM2M3MzI5YzRkMzMzMzM5 YmQyODQxYWFkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTA3LTAzICBMYXVy byBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdIEZpeCBidWlsZCB3 aXRoIGNsYW5nIGFmdGVyIHIyNjM4OTgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxMzk0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVNYW5pZmVz dFBhcnNlci5jcHA6CisKIDIwMjAtMDctMDMgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNv bT4KIAogICAgICAgICBbTEZDXVtURkNdW1F1aXJrXSBJbmZsb3cgY2hpbGQgYm94IHF1aXJrIHZl cnRpY2FsIG1hcmdpbnMgc2hvdWxkIGNvbGxhcHNlIHdpdGggdGFibGUgY2VsbC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlTWFuaWZl c3RQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9u Q2FjaGVNYW5pZmVzdFBhcnNlci5jcHAKaW5kZXggMDQzZGJmZWUwNDI4MzI1MzQzNmZiMjk5MTll M2Q3NWRmYTRhMTI1Ny4uOWIzYzY4MWVhZGJmNGZhMjEyMDZjOTFjNWY5MjU2MGJkYjY0YmUxMSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2Fj aGVNYW5pZmVzdFBhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hl L0FwcGxpY2F0aW9uQ2FjaGVNYW5pZmVzdFBhcnNlci5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKIAog I2luY2x1ZGUgIlBhcnNpbmdVdGlsaXRpZXMuaCIKICNpbmNsdWRlICJUZXh0UmVzb3VyY2VEZWNv ZGVyLmgiCisjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nSGFzaC5oPgogI2luY2x1ZGUgPHd0Zi90 ZXh0L1N0cmluZ1BhcnNpbmdCdWZmZXIuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdWaWV3 Lmg+CiAK 403487 2020-07-03 14:01:10 -0700 2020-07-03 14:02:00 -0700 Patch bug-213942-20200703180109.patch text/plain 1254 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzOTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFlYjk3YzFiOWYwYTUz ODIxMjUyNTI0ZGNiN2U5ZGYwMGEzMzAyMC4uZGIzMGI0NTQ4Y2VmNWIxZTljYzc5NGFlYmQ4YmRm MjJlODk2NTczOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTA3LTAzICBMYXVy byBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdIEZpeCBidWlsZCB3 aXRoIGNsYW5nIGFmdGVyIHIyNjM4OTgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxMzk0MgorCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4Lgor CisgICAgICAgICogbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVNYW5pZmVzdFBhcnNl ci5jcHA6CisKIDIwMjAtMDctMDMgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAog ICAgICAgICBbTEZDXVtURkNdW1F1aXJrXSBJbmZsb3cgY2hpbGQgYm94IHF1aXJrIHZlcnRpY2Fs IG1hcmdpbnMgc2hvdWxkIGNvbGxhcHNlIHdpdGggdGFibGUgY2VsbC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlTWFuaWZlc3RQYXJz ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVN YW5pZmVzdFBhcnNlci5jcHAKaW5kZXggMDQzZGJmZWUwNDI4MzI1MzQzNmZiMjk5MTllM2Q3NWRm YTRhMTI1Ny4uOWIzYzY4MWVhZGJmNGZhMjEyMDZjOTFjNWY5MjU2MGJkYjY0YmUxMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVNYW5p ZmVzdFBhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxp Y2F0aW9uQ2FjaGVNYW5pZmVzdFBhcnNlci5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKIAogI2luY2x1 ZGUgIlBhcnNpbmdVdGlsaXRpZXMuaCIKICNpbmNsdWRlICJUZXh0UmVzb3VyY2VEZWNvZGVyLmgi CisjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nSGFzaC5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1N0 cmluZ1BhcnNpbmdCdWZmZXIuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdWaWV3Lmg+CiAK 403488 2020-07-03 14:02:04 -0700 2020-07-03 14:27:31 -0700 Patch bug-213942-20200703180203.patch text/plain 1254 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzOTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFlYjk3YzFiOWYwYTUz ODIxMjUyNTI0ZGNiN2U5ZGYwMGEzMzAyMC4uZGIzMGI0NTQ4Y2VmNWIxZTljYzc5NGFlYmQ4YmRm MjJlODk2NTczOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTA3LTAzICBMYXVy byBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdIEZpeCBidWlsZCB3 aXRoIGNsYW5nIGFmdGVyIHIyNjM4OTgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxMzk0MgorCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4Lgor CisgICAgICAgICogbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVNYW5pZmVzdFBhcnNl ci5jcHA6CisKIDIwMjAtMDctMDMgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAog ICAgICAgICBbTEZDXVtURkNdW1F1aXJrXSBJbmZsb3cgY2hpbGQgYm94IHF1aXJrIHZlcnRpY2Fs IG1hcmdpbnMgc2hvdWxkIGNvbGxhcHNlIHdpdGggdGFibGUgY2VsbC4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlTWFuaWZlc3RQYXJz ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVN YW5pZmVzdFBhcnNlci5jcHAKaW5kZXggMDQzZGJmZWUwNDI4MzI1MzQzNmZiMjk5MTllM2Q3NWRm YTRhMTI1Ny4uOWIzYzY4MWVhZGJmNGZhMjEyMDZjOTFjNWY5MjU2MGJkYjY0YmUxMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVNYW5p ZmVzdFBhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxp Y2F0aW9uQ2FjaGVNYW5pZmVzdFBhcnNlci5jcHAKQEAgLTI4LDYgKzI4LDcgQEAKIAogI2luY2x1 ZGUgIlBhcnNpbmdVdGlsaXRpZXMuaCIKICNpbmNsdWRlICJUZXh0UmVzb3VyY2VEZWNvZGVyLmgi CisjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nSGFzaC5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1N0 cmluZ1BhcnNpbmdCdWZmZXIuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdWaWV3Lmg+CiAK