213918 2020-07-02 21:31:18 -0700 Text manipulation: add a new heuristic to decide paragraph boundary 2020-07-05 16:33:02 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu ews-watchlist mifenton webkit-bug-importer wenson_hsieh oldest_to_newest 1668480 0 sihui_liu 2020-07-02 21:31:18 -0700 ... 1668481 1 sihui_liu 2020-07-02 21:32:45 -0700 rdar://problem/63734756 1668482 2 403438 sihui_liu 2020-07-02 21:33:52 -0700 Created attachment 403438 Patch 1668483 3 403438 wenson_hsieh 2020-07-02 21:35:27 -0700 Comment on attachment 403438 Patch r=mews 1668940 4 ews-feeder 2020-07-05 16:33:02 -0700 Committed r263958: <https://trac.webkit.org/changeset/263958> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403438. 403438 2020-07-02 21:33:52 -0700 2020-07-05 16:33:02 -0700 Patch bug-213918-20200702213352.patch text/plain 5022 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTgwZjRhNDczYjM4N2M2 N2UxYmQ5OTYxNmMwZDVlN2U1OTUzYWE3Ni4uNmFlNTMxMTZmNzYwMTM2ZmIwY2YwZDYxYTMxN2E3 YjFmOWU4ZjRkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA3LTAyICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwZS5jb20+CisKKyAgICAgICAgVGV4dCBtYW5pcHVsYXRpb246 IGFkZCBhIG5ldyBoZXVyaXN0aWMgdG8gZGVjaWRlIHBhcmFncmFwaCBib3VuZGFyeQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzOTE4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW9kaWZpZWQgdGVzdDog VGV4dE1hbmlwdWxhdGlvbi5TdGFydFRleHRNYW5pcHVsYXRpb25UcmVhdHNJbmxpbmVCbG9ja0xp bmtzQW5kQnV0dG9uc0FuZFNwYW5zQXNQYXJhZ3JhcGhzLgorCisgICAgICAgICogZWRpdGluZy9U ZXh0TWFuaXB1bGF0aW9uQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjppc0VuY2xv c2luZ0l0ZW1Cb3VuZGFyeUVsZW1lbnQpOgorCiAyMDIwLTA3LTAyICBaYWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bQkZDXSBSZW1vdmUgcmVkdW5kYW50IG1h cmdpbi1ib3JkZXItcGFkZGluZyB3aGVuIGNvbXB1dGluZyB0aGUgaW50cmluc2ljIHdpZHRoCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1RleHRNYW5pcHVsYXRpb25Db250cm9s bGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dE1hbmlwdWxhdGlvbkNvbnRyb2xs ZXIuY3BwCmluZGV4IGUxZjg0NDJlYzE0ZDQ3MDQxZjQ3MGE5ZjFlNzE4ZDRjYTg0NzZkOWYuLmQw NTI4NTU2OTNiOWY5ZDE3M2Y2NDUyMWRmMTg4YjY3OGNmYjAyM2IgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvVGV4dE1hbmlwdWxhdGlvbkNvbnRyb2xsZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvVGV4dE1hbmlwdWxhdGlvbkNvbnRyb2xsZXIuY3BwCkBAIC0z MDIsOCArMzAyLDggQEAgc3RhdGljIGJvb2wgaXNFbmNsb3NpbmdJdGVtQm91bmRhcnlFbGVtZW50 KGNvbnN0IEVsZW1lbnQmIGVsZW1lbnQpCiAgICAgaWYgKGVsZW1lbnQuaGFzVGFnTmFtZShIVE1M TmFtZXM6OmJ1dHRvblRhZykgfHwgcm9sZShlbGVtZW50KSA9PSBBY2Nlc3NpYmlsaXR5Um9sZTo6 QnV0dG9uKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAorICAgIGF1dG8gZGlzcGxheVR5cGUgPSBy ZW5kZXJlci0+c3R5bGUoKS5kaXNwbGF5KCk7CiAgICAgaWYgKGVsZW1lbnQuaGFzVGFnTmFtZShI VE1MTmFtZXM6OmxpVGFnKSB8fCBlbGVtZW50Lmhhc1RhZ05hbWUoSFRNTE5hbWVzOjphVGFnKSkg ewotICAgICAgICBhdXRvIGRpc3BsYXlUeXBlID0gcmVuZGVyZXItPnN0eWxlKCkuZGlzcGxheSgp OwogICAgICAgICBpZiAoZGlzcGxheVR5cGUgPT0gRGlzcGxheVR5cGU6OkJsb2NrIHx8IGRpc3Bs YXlUeXBlID09IERpc3BsYXlUeXBlOjpJbmxpbmVCbG9jaykKICAgICAgICAgICAgIHJldHVybiB0 cnVlOwogCkBAIC0zMTMsNiArMzEzLDkgQEAgc3RhdGljIGJvb2wgaXNFbmNsb3NpbmdJdGVtQm91 bmRhcnlFbGVtZW50KGNvbnN0IEVsZW1lbnQmIGVsZW1lbnQpCiAgICAgICAgIH0KICAgICB9CiAK KyAgICBpZiAoZWxlbWVudC5oYXNUYWdOYW1lKEhUTUxOYW1lczo6c3BhblRhZykgJiYgZGlzcGxh eVR5cGUgPT0gRGlzcGxheVR5cGU6OklubGluZUJsb2NrKQorICAgICAgICByZXR1cm4gdHJ1ZTsK KwogICAgIHJldHVybiBmYWxzZTsKIH0KIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIv VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGU5NGM0NTBkMThiMDhhYjM1Mzc4NjBkNTRhOWI3NGEyMWY5 NmMzYzAuLjg4NDgwYTA4NTcwMDhlY2RmNDE4MzRjM2MzYzc2ZDEzNjQ2ZjZmNzcgMTAwNjQ0Ci0t LSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBA QAorMjAyMC0wNy0wMiAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGUuY29tPgorCisgICAgICAg IFRleHQgbWFuaXB1bGF0aW9uOiBhZGQgYSBuZXcgaGV1cmlzdGljIHRvIGRlY2lkZSBwYXJhZ3Jh cGggYm91bmRhcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxMzkxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9UZXh0TWFuaXB1bGF0aW9uLm1t OgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisKIDIwMjAtMDctMDIgIFBoaWxpcHBl IE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI2 MzYyNSk6IHJ1bi1taW5pYnJvd3NlciBmYWlscyBvbiBtYWMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvVGV4dE1hbmlwdWxhdGlvbi5tbSBiL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvVGV4dE1hbmlwdWxhdGlvbi5tbQppbmRl eCBjOGJlNDI1NjhlNTllZWE3YzA5MjUyYzc2YmZlMTQzNzEyNzE5ZWZmLi43NWQzNzFhZjYyNzA5 YmE5MjIzM2E2ZTk1YmE4MzcxYjVlYTE5OWU4IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdENvY29hL1RleHRNYW5pcHVsYXRpb24ubW0KKysrIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9UZXh0TWFuaXB1bGF0aW9uLm1tCkBAIC02NTks NyArNjU5LDcgQEAgVEVTVChUZXh0TWFuaXB1bGF0aW9uLCBTdGFydFRleHRNYW5pcHVsYXRpb25G aW5kc0luc2VydGVkQ2xpcHBlZFRleHQpCiAgICAgRVhQRUNUX1dLX1NUUkVRKCJhZnRlciIsIGl0 ZW1zWzJdLnRva2Vuc1swXS5jb250ZW50KTsKIH0KIAotVEVTVChUZXh0TWFuaXB1bGF0aW9uLCBT dGFydFRleHRNYW5pcHVsYXRpb25UcmVhdHNJbmxpbmVCbG9ja0xpbmtzQW5kQnV0dG9uc0FzUGFy YWdyYXBocykKK1RFU1QoVGV4dE1hbmlwdWxhdGlvbiwgU3RhcnRUZXh0TWFuaXB1bGF0aW9uVHJl YXRzSW5saW5lQmxvY2tMaW5rc0FuZEJ1dHRvbnNBbmRTcGFuc0FzUGFyYWdyYXBocykKIHsKICAg ICBhdXRvIGRlbGVnYXRlID0gYWRvcHROUyhbW1RleHRNYW5pcHVsYXRpb25EZWxlZ2F0ZSBhbGxv Y10gaW5pdF0pOwogICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3IGFs bG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgNDAwLCA0MDApXSk7CkBAIC02Nzks NyArNjc5LDkgQEAgVEVTVChUZXh0TWFuaXB1bGF0aW9uLCBTdGFydFRleHRNYW5pcHVsYXRpb25U cmVhdHNJbmxpbmVCbG9ja0xpbmtzQW5kQnV0dG9uc0FzUGEKICAgICAgICAgIiAgICA8YnV0dG9u Pk9uZTwvYnV0dG9uPjxidXR0b24+VHdvPC9idXR0b24+IgogICAgICAgICAiICAgIDxkaXY+PGJy PjwvZGl2PiIKICAgICAgICAgIiAgICA8YSBocmVmPScjJz5UaHJlZTwvYT48YSBocmVmPScjJz5G b3VyPC9hPiIKLSAgICAgICAgIiAgICA8c3BhbiByb2xlPSdidXR0b24nPkZpdmU8L3NwYW4+PHNw YW4gcm9sZT0nYnV0dG9uJz5TaXg8L3NwYW4+IgorICAgICAgICAiICAgIDxzcGFuIHJvbGU9J2J1 dHRvbic+Rml2ZTwvc3Bhbj4iCisgICAgICAgICIgICAgPHNwYW4+U2l4PC9zcGFuPiIKKyAgICAg ICAgIiAgICA8Yj5FbmQ8L2I+IgogICAgICAgICAiPC9ib2R5PiJdOwogCiAgICAgZG9uZSA9IGZh bHNlOwpAQCAtNjg5LDE3ICs2OTEsMjEgQEAgVEVTVChUZXh0TWFuaXB1bGF0aW9uLCBTdGFydFRl eHRNYW5pcHVsYXRpb25UcmVhdHNJbmxpbmVCbG9ja0xpbmtzQW5kQnV0dG9uc0FzUGEKICAgICBU ZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRvbmUpOwogCiAgICAgTlNBcnJheTxfV0tUZXh0TWFu aXB1bGF0aW9uSXRlbSAqPiAqaXRlbXMgPSBbZGVsZWdhdGUgaXRlbXNdOwotICAgIEVYUEVDVF9F UShpdGVtcy5jb3VudCwgNlVMKTsKKyAgICBFWFBFQ1RfRVEoaXRlbXMuY291bnQsIDdVTCk7CiAg ICAgRVhQRUNUX0VRKGl0ZW1zWzBdLnRva2Vucy5jb3VudCwgMVVMKTsKICAgICBFWFBFQ1RfRVEo aXRlbXNbMV0udG9rZW5zLmNvdW50LCAxVUwpOwogICAgIEVYUEVDVF9FUShpdGVtc1syXS50b2tl bnMuY291bnQsIDFVTCk7CiAgICAgRVhQRUNUX0VRKGl0ZW1zWzNdLnRva2Vucy5jb3VudCwgMVVM KTsKKyAgICBFWFBFQ1RfRVEoaXRlbXNbNF0udG9rZW5zLmNvdW50LCAxVUwpOworICAgIEVYUEVD VF9FUShpdGVtc1s1XS50b2tlbnMuY291bnQsIDFVTCk7CisgICAgRVhQRUNUX0VRKGl0ZW1zWzZd LnRva2Vucy5jb3VudCwgMVVMKTsKICAgICBFWFBFQ1RfV0tfU1RSRVEoIk9uZSIsIGl0ZW1zWzBd LnRva2Vuc1swXS5jb250ZW50KTsKICAgICBFWFBFQ1RfV0tfU1RSRVEoIlR3byIsIGl0ZW1zWzFd LnRva2Vuc1swXS5jb250ZW50KTsKICAgICBFWFBFQ1RfV0tfU1RSRVEoIlRocmVlIiwgaXRlbXNb Ml0udG9rZW5zWzBdLmNvbnRlbnQpOwogICAgIEVYUEVDVF9XS19TVFJFUSgiRm91ciIsIGl0ZW1z WzNdLnRva2Vuc1swXS5jb250ZW50KTsKICAgICBFWFBFQ1RfV0tfU1RSRVEoIkZpdmUiLCBpdGVt c1s0XS50b2tlbnNbMF0uY29udGVudCk7CiAgICAgRVhQRUNUX1dLX1NUUkVRKCJTaXgiLCBpdGVt c1s1XS50b2tlbnNbMF0uY29udGVudCk7CisgICAgRVhQRUNUX1dLX1NUUkVRKCJFbmQiLCBpdGVt c1s2XS50b2tlbnNbMF0uY29udGVudCk7CiB9CiAKIFRFU1QoVGV4dE1hbmlwdWxhdGlvbiwgU3Rh cnRUZXh0TWFuaXB1bGF0aW9uVHJlYXRzTGlua3NJbk5hdmlnYXRpb25FbGVtZW50c0FzUGFyYWdy YXBocykK