21391 2008-10-05 14:26:18 -0700 [Gtk] Invalid cast from GdkWindow to GtkWidget 2008-10-05 14:50:25 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED Gtk P2 Normal --- 1 jmalonzo webkit-unassigned oldest_to_newest 94172 0 jmalonzo 2008-10-05 14:26:18 -0700 I'm getting this warnings from the console when running the acid 3 tests: (lt-GtkLauncher:24087): GLib-GObject-WARNING **: invalid cast from `GdkWindow' to `GtkWidget' (lt-GtkLauncher:24087): GLib-GObject-WARNING **: invalid cast from `GdkWindow' to `GtkWidget' (lt-GtkLauncher:24087): GLib-GObject-WARNING **: invalid cast from `GdkWindow' to `GtkWidget' (lt-GtkLauncher:24087): GLib-GObject-WARNING **: invalid cast from `GdkWindow' to `GtkWidget' (lt-GtkLauncher:24087): GLib-GObject-WARNING **: invalid cast from `GdkWindow' to `GtkWidget' (lt-GtkLauncher:24087): GLib-GObject-WARNING **: invalid cast from `GdkWindow' to `GtkWidget' 94173 1 24102 jmalonzo 2008-10-05 14:31:26 -0700 Created attachment 24102 fixed a misplaced closing parenthesis The patch should fix the invalid cast by fixing a misplaced parenthesis to cast the widget and not the widget's window (which is a GdkWindow) 94174 2 24102 darin 2008-10-05 14:32:15 -0700 Comment on attachment 24102 fixed a misplaced closing parenthesis r=me 94177 3 jmalonzo 2008-10-05 14:50:25 -0700 Thanks! Landed in r37318 24102 2008-10-05 14:31:26 -0700 2008-10-05 14:32:15 -0700 fixed a misplaced closing parenthesis invalidcast.patch text/plain 1221 jmalonzo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTg1OGQ3ZS4uN2MzYThlYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOC0xMC0wNSAgSmFuIE1pY2hhZWwg QWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbnZhbGlkIGNhc3QgZnJvbSBHZGtXaW5kb3cgdG8gR3Rr V2lkZ2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTM5MQorCisgICAgICAgIEZpeCBhIG1pc3BsYWNlZCBjbG9zaW5nIHBhcmVudGhlc2lzIHRvIGFj dHVhbGx5IGNhc3QgdGhlIHdpZGdldCwgbm90IHRoZSB3aW5kb3cKKworICAgICAgICAqIHBsYXRm b3JtL2d0ay9QbGF0Zm9ybVNjcmVlbkd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzY3JlZW5E ZXB0aCk6CisKIDIwMDgtMTAtMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBbGRlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL1BsYXRmb3JtU2NyZWVuR3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Bs YXRmb3JtU2NyZWVuR3RrLmNwcAppbmRleCBmODYzYzdmLi45Nzg4MjUzIDEwMDY0NAotLS0gYS9X ZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybVNjcmVlbkd0ay5jcHAKKysrIGIvV2ViQ29yZS9w bGF0Zm9ybS9ndGsvUGxhdGZvcm1TY3JlZW5HdGsuY3BwCkBAIC01MCw3ICs1MCw3IEBAIGludCBz Y3JlZW5EZXB0aChXaWRnZXQqIHdpZGdldCkKICAgICBpZiAoIWNvbnRhaW5lcikKICAgICAgICAg cmV0dXJuIDI0OwogCi0gICAgR2RrVmlzdWFsKiB2aXN1YWwgPSBnZGtfZHJhd2FibGVfZ2V0X3Zp c3VhbChHREtfRFJBV0FCTEUoR1RLX1dJREdFVCh3aWRnZXQtPnJvb3QoKS0+aG9zdFdpbmRvdygp LT5wbGF0Zm9ybVdpbmRvdygpLT53aW5kb3cpKSk7CisgICAgR2RrVmlzdWFsKiB2aXN1YWwgPSBn ZGtfZHJhd2FibGVfZ2V0X3Zpc3VhbChHREtfRFJBV0FCTEUoR1RLX1dJREdFVCh3aWRnZXQtPnJv b3QoKS0+aG9zdFdpbmRvdygpLT5wbGF0Zm9ybVdpbmRvdygpKS0+d2luZG93KSk7CiAgICAgcmV0 dXJuIHZpc3VhbC0+ZGVwdGg7CiB9CiAK