213899 2020-07-02 13:09:07 -0700 [Flatpak SDK][WPE] Launching the remote inspector kills MB 2020-09-16 14:12:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 svillar pnormand aperez cgarcia ews-watchlist hi joepeck keith_miller mark.lam msaboff pnormand saam tzagallo webkit-bug-importer oldest_to_newest 1668343 0 svillar 2020-07-02 13:09:07 -0700 This is the error I get, seems like the code is trying to access files outside the sandbox: Error loading libWPEWebInspectorResources.so: /usr/local/lib/wpe-webkit-1.0/libWPEWebInspectorResources.so: cannot open shared object file: No such file or directory (MiniBrowser:24): GLib-CRITICAL **: 13:04:56.972: g_bytes_get_data: assertion 'bytes != NULL' failed (MiniBrowser:24): GLib-CRITICAL **: 13:04:56.973: g_bytes_get_data: assertion 'bytes != NULL' failed (MiniBrowser:24): GLib-CRITICAL **: 13:04:56.973: g_variant_new_bytestring: assertion 'string != NULL' failed (MiniBrowser:24): GLib-CRITICAL **: 13:04:56.973: g_variant_get_type: assertion 'value != NULL' failed (MiniBrowser:24): GLib-CRITICAL **: 13:04:56.974: g_variant_type_is_subtype_of: assertion 'g_variant_type_check (type)' failed (MiniBrowser:24): GLib-CRITICAL **: 13:04:56.974: g_variant_get_type_string: assertion 'value != NULL' failed (MiniBrowser:24): GLib-ERROR **: 13:04:56.974: g_variant_new: expected GVariant of type 'ay' but received value has type '(null)' ScriptError raised: Failed to run "[u'/app/webkit/WebKitBuild/Release/bin/MiniBrowser', 'https://immersive-web.github.io/webxr-samples/']" exit_code: -5 cwd: /app/webkit Traceback (most recent call last): File "/app/webkit/Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py", line 59, in main return port.run_minibrowser(args) File "/app/webkit/Tools/Scripts/webkitpy/port/wpe.py", line 146, in run_minibrowser return self._executive.run_command(command + args, cwd=self.webkit_base(), stdout=None, return_stderr=False, decode_output=False) File "/app/webkit/Tools/Scripts/webkitpy/common/system/executive.py", line 435, in run_command (error_handler or self.default_error_handler)(script_error) File "/app/webkit/Tools/Scripts/webkitpy/common/system/abstractexecutive.py", line 97, in default_error_handler raise error ScriptError: Failed to run "[u'/app/webkit/WebKitBuild/Release/bin/MiniBrowser', 'https://immersive-web.github.io/webxr-samples/']" exit_code: -5 cwd: /app/webkit 1668352 1 pnormand 2020-07-02 13:29:18 -0700 Oh yeah I saw a similar error today. But I think in GTK it works. Need to debug... :) 1668519 2 pnormand 2020-07-03 02:16:59 -0700 This fails in Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp where I suspect we might need to check an env-var additionally to the build-time hardcoded lib path. 1668521 3 pnormand 2020-07-03 02:19:16 -0700 It works fine in GTK because the inspector commands are loaded from a GResource embedded in the lib. 1669688 4 403766 pnormand 2020-07-08 01:25:47 -0700 Created attachment 403766 Patch 1669689 5 403766 pnormand 2020-07-08 01:26:44 -0700 Comment on attachment 403766 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403766&action=review > Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp:49 > + const char* path = g_getenv("WEBKIT_INJECTED_BUNDLE_PATH"); I was lazy here. I can a new variable if the reviewer kindly asks :) 1689208 6 403766 aperez 2020-09-16 13:55:28 -0700 Comment on attachment 403766 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403766&action=review >> Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorUtils.cpp:49 >> + const char* path = g_getenv("WEBKIT_INJECTED_BUNDLE_PATH"); > > I was lazy here. I can a new variable if the reviewer kindly asks :) As this is going to be used only for developer builds, I think it is okay to reuse this variable that is already being set by all our scripts instead of introducing a new one which would need handling in many places. 1689215 7 ews-feeder 2020-09-16 14:11:12 -0700 Committed r267159: <https://trac.webkit.org/changeset/267159> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403766. 1689216 8 webkit-bug-importer 2020-09-16 14:12:17 -0700 <rdar://problem/69013637> 403766 2020-07-08 01:25:47 -0700 2020-09-16 14:11:13 -0700 Patch bug-213899-20200708012545.patch text/plain 2623 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0MDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh NTNkMzJlZjk0MGU0Y2IyYTc1OGQyMzZkNWMxNzk0MjdkNTQ1OGQ2Li5lOTU5NzBlZmJlNzQ0MThh YjRkMDE5OGQyMTMwN2NhZGJlMTVjODViIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wNy0wOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CisKKyAgICAgICAgW0ZsYXRwYWsgU0RLXVtXUEVdIExhdW5jaGluZyB0aGUgcmVtb3Rl IGluc3BlY3RvciBraWxscyBNQgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjEzODk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTG9hZCBpbnNwZWN0b3IgcmVzb3VyY2VzIGZyb20gZGV2ZWxvcGVyIGJ1aWxk IGFydGVmYWN0cywgd2hlbiB0aGUgaW5zcGVjdG9yIHNlcnZlciBpcworICAgICAgICBydW5uaW5n IGluIHRoaXMgY29uZmlndXJhdGlvbi4gRmFsbCBiYWNrIHRvIHN5c3RlbSBsaWJyYXJpZXMgbG9h ZGluZyBtZWNoYW5pc20gb3RoZXJ3aXNlLgorCisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9n bGliL1JlbW90ZUluc3BlY3RvclV0aWxzLmNwcDoKKyAgICAgICAgKEluc3BlY3Rvcjo6YmFja2Vu ZENvbW1hbmRzKToKKwogMjAyMC0wNy0wNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUu Y29tPgogCiAgICAgICAgIFtKU0NdIEJ5dGVjb2RlR2VuZXJhdG9yIHNob3VsZCBiZSByb2J1c3Qg YWdhaW5zdCBmYWlsZWQgY29uc3RhbnQgZ2VuZXJhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvZ2xpYi9SZW1vdGVJbnNwZWN0b3JVdGlscy5j cHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9nbGliL1JlbW90ZUlu c3BlY3RvclV0aWxzLmNwcAppbmRleCAxMmYxZDEzZDhhNmI2ZDY1MGVhMzI3OGExODQzMmYxYjhm NDFlODFiLi45NDIxYThiNjZkMmE1MjMwN2NhYjhiMzY0NGNkNDQzMTE4Mzk2MzRmIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9nbGliL1JlbW90ZUlu c3BlY3RvclV0aWxzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Jl bW90ZS9nbGliL1JlbW90ZUluc3BlY3RvclV0aWxzLmNwcApAQCAtMzEsNiArMzEsNyBAQAogI2lu Y2x1ZGUgPGdpby9naW8uaD4KICNpbmNsdWRlIDxtdXRleD4KICNpbmNsdWRlIDx3dGYvU0hBMS5o PgorI2luY2x1ZGUgPHd0Zi9nbGliL0dVbmlxdWVQdHIuaD4KIAogI2RlZmluZSBJTlNQRUNUT1Jf QkFDS0VORF9DT01NQU5EU19QQVRIICIvb3JnL3dlYmtpdC9pbnNwZWN0b3IvVXNlckludGVyZmFj ZS9Qcm90b2NvbC9JbnNwZWN0b3JCYWNrZW5kQ29tbWFuZHMuanMiCiAKQEAgLTQxLDcgKzQyLDE2 IEBAIEdSZWZQdHI8R0J5dGVzPiBiYWNrZW5kQ29tbWFuZHMoKQogI2lmIFBMQVRGT1JNKFdQRSkK ICAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcgZmxhZzsKICAgICBzdGQ6OmNhbGxfb25jZShmbGFn LCBbXSB7Ci0gICAgICAgIEdNb2R1bGUqIHJlc291cmNlc01vZHVsZSA9IGdfbW9kdWxlX29wZW4o UEtHTElCRElSIEdfRElSX1NFUEFSQVRPUl9TICJsaWJXUEVXZWJJbnNwZWN0b3JSZXNvdXJjZXMu c28iLCBHX01PRFVMRV9CSU5EX0xBWlkpOworICAgICAgICBjb25zdCBjaGFyKiBsaWJEaXIgPSBQ S0dMSUJESVI7CisjaWYgRU5BQkxFKERFVkVMT1BFUl9NT0RFKQorICAgICAgICAvLyBQcm9iYWJs eSBubyBuZWVkIGZvciBhIHNwZWNpZmljIGVudiB2YXIgaGVyZS4gQXNzdW1lIHRoZSBpbnNwZWN0 b3IgcmVzb3VyY2VzLnNvIGZpbGUgaXMKKyAgICAgICAgLy8gaW4gdGhlIHNhbWUgZGlyZWN0b3J5 IGFzIHRoZSBpbmplY3RlZCBidW5kbGUgbGliLCBmb3IgZGV2ZWxvcGVyIGJ1aWxkcy4KKyAgICAg ICAgY29uc3QgY2hhciogcGF0aCA9IGdfZ2V0ZW52KCJXRUJLSVRfSU5KRUNURURfQlVORExFX1BB VEgiKTsKKyAgICAgICAgaWYgKHBhdGggJiYgZ19maWxlX3Rlc3QocGF0aCwgR19GSUxFX1RFU1Rf SVNfRElSKSkKKyAgICAgICAgICAgIGxpYkRpciA9IHBhdGg7CisjZW5kaWYKKyAgICAgICAgR1Vu aXF1ZVB0cjxjaGFyPiBidW5kbGVGaWxlbmFtZShnX2J1aWxkX2ZpbGVuYW1lKGxpYkRpciwgImxp YldQRVdlYkluc3BlY3RvclJlc291cmNlcy5zbyIsIG51bGxwdHIpKTsKKyAgICAgICAgR01vZHVs ZSogcmVzb3VyY2VzTW9kdWxlID0gZ19tb2R1bGVfb3BlbihidW5kbGVGaWxlbmFtZS5nZXQoKSwg R19NT0RVTEVfQklORF9MQVpZKTsKICAgICAgICAgaWYgKCFyZXNvdXJjZXNNb2R1bGUpIHsKICAg ICAgICAgICAgIFdURkxvZ0Fsd2F5cygiRXJyb3IgbG9hZGluZyBsaWJXUEVXZWJJbnNwZWN0b3JS ZXNvdXJjZXMuc286ICVzIiwgZ19tb2R1bGVfZXJyb3IoKSk7CiAgICAgICAgICAgICByZXR1cm47 Cg==