213881 2020-07-02 07:17:57 -0700 [GTK][WPE] Enable storageAccess tests 2020-07-06 02:48:06 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=213502 Gtk P2 Normal --- 212017 1 cgarcia webkit-unassigned aperez bugs-noreply mcatanzaro oldest_to_newest 1668237 0 cgarcia 2020-07-02 07:17:57 -0700 They are currently skipped by the main TestExpectations file, but we should run them now that we support ITP. The current status is: 68 tests ran as expected, 13 didn't: Regressions: Unexpected text-only failures (13) http/tests/storageAccess/deny-due-to-no-interaction-under-general-third-party-cookie-blocking-ephemeral.html [ Failure ] http/tests/storageAccess/deny-storage-access-under-opener-ephemeral.html [ Failure ] http/tests/storageAccess/deny-storage-access-under-opener-if-auto-dismiss-ephemeral.html [ Failure ] http/tests/storageAccess/deny-with-prompt-does-not-preserve-gesture-database.html [ Failure ] http/tests/storageAccess/deny-with-prompt-does-not-preserve-gesture.html [ Failure ] http/tests/storageAccess/grant-storage-access-under-opener-at-popup-user-gesture-ephemeral.html [ Failure ] http/tests/storageAccess/has-storage-access-under-general-third-party-cookie-blocking-with-cookie-ephemeral.html [ Failure ] http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access-database.html [ Failure ] http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html [ Failure ] http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access-database.html [ Failure ] http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html [ Failure ] http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access-database.html [ Failure ] http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access.html [ Failure ] Some of those failures are also skipped in mac-wk2, but we need to investigate the others. 1668568 1 cgarcia 2020-07-03 07:41:39 -0700 Most of the *-ephemeral.html tests that were failing are passing now after r263895. http/tests/storageAccess/deny-with-prompt-does-not-preserve-gesture.html http/tests/storageAccess/deny-with-prompt-does-not-preserve-gesture-database.html These are skipped in mac, but without a bug number, so I don't know why. http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-ephemeral-database.html http/tests/storageAccess/has-storage-access-true-if-third-party-has-cookies-ephemeral.html These are bug #208400. With those skipped and patch from bug #213502 applied the situation is: 252 tests ran as expected, 4 didn't: Regressions: Unexpected text-only failures (4) http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access-database.html [ Failure ] http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html [ Failure ] http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access-database.html [ Failure ] http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access.html [ Failure ] These are failing because tests are using OnlyAccordingToPerDomainPolicy as ThirdPartyCookieBlockingMode, so the cookie accept policy is kept as no-third-party. Cookies granted by storage access are still rejected by the cookie accept policy. This should only happen in tests, because we always use All as ThirdPartyCookieBlockingMode. 1669002 2 403582 cgarcia 2020-07-06 01:54:36 -0700 Created attachment 403582 Patch 1669010 3 cgarcia 2020-07-06 02:48:06 -0700 Committed r263965: <https://trac.webkit.org/changeset/263965> 403582 2020-07-06 01:54:36 -0700 2020-07-06 02:45:07 -0700 Patch wk2-storage-access-tests.diff text/plain 3853 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxN2QzMGUzZDc2NTcuLjAxYjRjZDRkOTdiNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDIwLTA3LTA2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXVtXUEVdIEVuYWJsZSBzdG9yYWdlQWNjZXNzIHRlc3RzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM4ODEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgc3RvcmFnZUFj Y2VzcyB0ZXN0cyBhbmQgbWFyayBleHBlY3RlZCBmYWlsdXJlcy4KKworICAgICAgICAqIHBsYXRm b3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAyMC0wNy0wMyAgWW91ZW5uIEZhYmxldCAg PHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgTWVkaWFSZWNvcmRlciBzaG91bGQgc3VwcG9y dCBwZWVyIGNvbm5lY3Rpb24gcmVtb3RlIHZpZGVvIHRyYWNrcwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZ2xpYi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ2xpYi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDUwODc5N2EyYWQxNS4uMGMyMDBmODAyNzA3 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ2xpYi9UZXN0RXhwZWN0YXRpb25zCkBAIC01ODks NiArNTg5LDE2IEBAIGZhc3Qvc2Nyb2xsaW5nL3J0bC1zY3JvbGxiYXJzLXBvc2l0aW9uaW5nLmh0 bWwgWyBQYXNzIF0KIGZhc3Qvc2Nyb2xsaW5nL3J0bC1zY3JvbGxiYXJzLXNpbXBsZS5odG1sIFsg UGFzcyBdCiBmYXN0L3Njcm9sbGluZy9ydGwtc2Nyb2xsYmFycy5odG1sIFsgUGFzcyBdCiAKK2h0 dHAvdGVzdHMvc3RvcmFnZUFjY2Vzcy8gWyBQYXNzIF0KK2h0dHAvdGVzdHMvc3RvcmFnZUFjY2Vz cy9kZW55LXdpdGgtcHJvbXB0LWRvZXMtbm90LXByZXNlcnZlLWdlc3R1cmUuaHRtbCBbIFNraXAg XQoraHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL2Rlbnktd2l0aC1wcm9tcHQtZG9lcy1ub3QtcHJl c2VydmUtZ2VzdHVyZS1kYXRhYmFzZS5odG1sIFsgU2tpcCBdCit3ZWJraXQub3JnL2IvMjA4NDAw IGh0dHAvdGVzdHMvc3RvcmFnZUFjY2Vzcy9oYXMtc3RvcmFnZS1hY2Nlc3MtdHJ1ZS1pZi10aGly ZC1wYXJ0eS1oYXMtY29va2llcy1lcGhlbWVyYWwtZGF0YWJhc2UuaHRtbCBbIEZhaWx1cmUgXQor d2Via2l0Lm9yZy9iLzIwODQwMCBodHRwL3Rlc3RzL3N0b3JhZ2VBY2Nlc3MvaGFzLXN0b3JhZ2Ut YWNjZXNzLXRydWUtaWYtdGhpcmQtcGFydHktaGFzLWNvb2tpZXMtZXBoZW1lcmFsLmh0bWwgWyBG YWlsdXJlIF0KK3dlYmtpdC5vcmcvYi8yMTM5NTQgaHR0cC90ZXN0cy9zdG9yYWdlQWNjZXNzL3Jl cXVlc3QtYW5kLWdyYW50LWFjY2Vzcy10aGVuLW5hdmlnYXRlLWNyb3NzLXNpdGUtc2hvdWxkLW5v dC1oYXZlLWFjY2Vzcy1kYXRhYmFzZS5odG1sIFsgRmFpbHVyZSBdCit3ZWJraXQub3JnL2IvMjEz OTU0IGh0dHAvdGVzdHMvc3RvcmFnZUFjY2Vzcy9yZXF1ZXN0LWFuZC1ncmFudC1hY2Nlc3MtdGhl bi1uYXZpZ2F0ZS1jcm9zcy1zaXRlLXNob3VsZC1ub3QtaGF2ZS1hY2Nlc3MuaHRtbCBbIEZhaWx1 cmUgXQord2Via2l0Lm9yZy9iLzIxMzk1NCBodHRwL3Rlc3RzL3N0b3JhZ2VBY2Nlc3MvcmVxdWVz dC1hbmQtZ3JhbnQtYWNjZXNzLXRoZW4tbmF2aWdhdGUtc2FtZS1zaXRlLXNob3VsZC1oYXZlLWFj Y2Vzcy1kYXRhYmFzZS5odG1sIFsgRmFpbHVyZSBdCit3ZWJraXQub3JnL2IvMjEzOTU0IGh0dHAv dGVzdHMvc3RvcmFnZUFjY2Vzcy9yZXF1ZXN0LWFuZC1ncmFudC1hY2Nlc3MtdGhlbi1uYXZpZ2F0 ZS1zYW1lLXNpdGUtc2hvdWxkLWhhdmUtYWNjZXNzLmh0bWwgWyBGYWlsdXJlIF0KKwogd2Via2l0 Lm9yZy9iLzE3MjA1NiBmYXN0L3RleHQvbXVsdGlnbHlwaC1jaGFyYWN0ZXJzLmh0bWwgWyBQYXNz IF0KIAogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWItYW5pbWF0aW9ucy9hbmlt YXRpb24tbW9kZWwvYW5pbWF0aW9uLXR5cGVzL2ludGVycG9sYXRpb24tcGVyLXByb3BlcnR5Lmh0 bWwgWyBEdW1wSlNDb25zb2xlTG9nSW5TdGRFcnIgXQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdl TG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDU3MzAxMjM0YzI0OC4uNWUxYjk5ZDBkMjQ5IDEw MDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMjAtMDctMDYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0gRW5hYmxlIHN0b3JhZ2VBY2Nlc3MgdGVzdHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzg4MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0 VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9s bGVyOjpnZXRBbGxTdG9yYWdlQWNjZXNzRW50cmllcyk6IFVzZSB0aGUgcmlnaHQgd2Vic2l0ZSBk YXRhIHN0b3JlLgorCiAyMDIwLTA2LTI5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVdIENoYW5nZSB0aGUgY29va2llcyBhY2Nl cHQgcG9saWN5IHdoZW4gSVRQIGlzIGVuYWJsZWQKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0 Q29udHJvbGxlci5jcHAKaW5kZXggMmJkNzkxODYyNmMwLi42ODA0Yzk5MjY1NmEgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCisrKyBiL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCkBAIC0zMjA1LDEyICszMjA1LDEx IEBAIHZvaWQgZ2V0QWxsU3RvcmFnZUFjY2Vzc0VudHJpZXNDYWxsYmFjayh2b2lkKiB1c2VyRGF0 YSwgV0tBcnJheVJlZiBkb21haW5MaXN0KQogCiB2b2lkIFRlc3RDb250cm9sbGVyOjpnZXRBbGxT dG9yYWdlQWNjZXNzRW50cmllcygpCiB7Ci0gICAgYXV0byBkYXRhU3RvcmUgPSBXS0NvbnRleHRH ZXRXZWJzaXRlRGF0YVN0b3JlKHBsYXRmb3JtQ29udGV4dCgpKTsKICAgICBHZXRBbGxTdG9yYWdl QWNjZXNzRW50cmllc0NhbGxiYWNrQ29udGV4dCBjb250ZXh0KCp0aGlzLCBbdGhpc10gKFZlY3Rv cjxTdHJpbmc+JiYgZG9tYWlucykgewogICAgICAgICBtX2N1cnJlbnRJbnZvY2F0aW9uLT5kaWRS ZWNlaXZlQWxsU3RvcmFnZUFjY2Vzc0VudHJpZXMoV1RGTW92ZShkb21haW5zKSk7CiAgICAgfSk7 CiAKLSAgICBXS1dlYnNpdGVEYXRhU3RvcmVHZXRBbGxTdG9yYWdlQWNjZXNzRW50cmllcyhkYXRh U3RvcmUsIG1fbWFpbldlYlZpZXctPnBhZ2UoKSwgJmNvbnRleHQsIGdldEFsbFN0b3JhZ2VBY2Nl c3NFbnRyaWVzQ2FsbGJhY2spOworICAgIFdLV2Vic2l0ZURhdGFTdG9yZUdldEFsbFN0b3JhZ2VB Y2Nlc3NFbnRyaWVzKHdlYnNpdGVEYXRhU3RvcmUoKSwgbV9tYWluV2ViVmlldy0+cGFnZSgpLCAm Y29udGV4dCwgZ2V0QWxsU3RvcmFnZUFjY2Vzc0VudHJpZXNDYWxsYmFjayk7CiAgICAgcnVuVW50 aWwoY29udGV4dC5kb25lLCBub1RpbWVvdXQpOwogfQogCg==