213876 2020-07-02 01:07:43 -0700 REGRESSION(r263625): run-minibrowser fails on mac 2020-07-02 09:32:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand darin ews-watchlist glenn jbedard webkit-bug-importer wilander oldest_to_newest 1668177 0 pnormand 2020-07-02 01:07:43 -0700 $ Tools/Scripts/run-minibrowser --mac AttributeError raised: 'list' object has no attribute 'startswith' Traceback (most recent call last): File "/Users/philn/WebKit/Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py", line 59, in main return port.run_minibrowser(args) File "/Users/philn/WebKit/Tools/Scripts/webkitpy/port/base.py", line 1372, in run_minibrowser return self._run_script(["old-run-minibrowser", ] + args) File "/Users/philn/WebKit/Tools/Scripts/webkitpy/port/base.py", line 1486, in _run_script run_script_command = [self.path_to_script(script_name)] File "/Users/philn/WebKit/Tools/Scripts/webkitpy/port/base.py", line 717, in path_to_script return self._webkit_finder.path_to_script(script_name) File "/Users/philn/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py", line 64, in path_to_script return self._filesystem.join("Tools", "Scripts", script_name) File "/Users/philn/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py", line 162, in join return os.path.join(*comps) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py", line 68, in join if b.startswith('/'): AttributeError: 'list' object has no attribute 'startswith' 1668179 1 403351 pnormand 2020-07-02 01:10:58 -0700 Created attachment 403351 Patch 1668268 2 ews-feeder 2020-07-02 09:31:50 -0700 Committed r263848: <https://trac.webkit.org/changeset/263848> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403351. 1668269 3 webkit-bug-importer 2020-07-02 09:32:19 -0700 <rdar://problem/65037915> 403351 2020-07-02 01:10:58 -0700 2020-07-02 09:31:51 -0700 Patch bug-213876-20200702011057.patch text/plain 1387 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzODM0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODEwMDM1OTU5ZmJhNmExNDExNTQxM2I4ZDc2M2I0MTdi Mzk2ZGM2MS4uOWI1NjNkNzg3MTBmZGEwOTcwZWM3NzE3NGRhOThmMTY0ZmFhNjEwNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIwLTA3LTAyICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBSRUdSRVNTSU9OKHIyNjM2MjUpOiBydW4tbWluaWJyb3dzZXIgZmFpbHMgb24g bWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM4 NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5OgorICAgICAgICAoUG9ydC5ydW5fbWluaWJyb3dz ZXIpOiBfcnVuX3NjcmlwdCgpIGV4cGVjdHMgYSBzdHJpbmcgYXMgZmlyc3QgYXJndW1lbnQuIENv bW1hbmQtbGluZSBhcmdzCisgICAgICAgIGFyZSBwYXNzZWQgdGhyb3VnaCBhIGtleXdvcmQuCisK IDIwMjAtMDctMDEgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAg ICAgICAgRml4IHRoZSBXZWJLaXQgYnVpbGQgYWZ0ZXIgPHJkYXI6Ly9wcm9ibGVtLzY0Mjg4MTkx PgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQppbmRleCAyNWYyYWM0NTc4MjMxNjM5NTM5 NzUyYmJhYmVjYWNhZWU5Y2FkZWE3Li5jNTA0YWM1MTZkZTk1YWQxYWEyMjc0ZjU3OTVmOTI3YzZl NzViYWNiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQpAQCAtMTM2OSw3ICsxMzY5 LDcgQEAgY2xhc3MgUG9ydChvYmplY3QpOgogCiAgICAgZGVmIHJ1bl9taW5pYnJvd3NlcihzZWxm LCBhcmdzKToKICAgICAgICAgIyBGSVhNRTogTWlncmF0ZSB0byB3ZWJraXRweSBiYXNlZCBydW4t bWluaWJyb3dzZXIuIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM0 NjQKLSAgICAgICAgcmV0dXJuIHNlbGYuX3J1bl9zY3JpcHQoWyJvbGQtcnVuLW1pbmlicm93c2Vy IiwgXSArIGFyZ3MpCisgICAgICAgIHJldHVybiBzZWxmLl9ydW5fc2NyaXB0KCJvbGQtcnVuLW1p bmlicm93c2VyIiwgYXJncz1hcmdzKQogCiAgICAgQG1lbW9pemVkCiAgICAgZGVmIF9wYXRoX3Rv X2ltYWdlX2RpZmYoc2VsZik6Cg==