213867 2020-07-01 16:02:05 -0700 Crash in +[UIViewController _viewControllerForFullScreenPresentationFromView:] when WKContentView is deallocated 2020-07-02 15:45:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ablackwood webkit-unassigned darin david_quesada webkit-bug-importer oldest_to_newest 1668084 0 ablackwood 2020-07-01 16:02:05 -0700 Crash in +[UIViewController _viewControllerForFullScreenPresentationFromView:] when WKContentView is deallocated 1668085 1 403326 ablackwood 2020-07-01 16:02:48 -0700 Created attachment 403326 Patch 1668094 2 403326 darin 2020-07-01 16:27:03 -0700 Comment on attachment 403326 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403326&action=review > Source/WebKit/ChangeLog:8 > + No new tests (OOPS!). Can’t land a patch with this line. Need to delete it. > Source/WebKit/ChangeLog:11 > + (-[WKFileUploadPanel dismiss]): Should have a comment here. Even a simple one like "Add a null check." would do. > Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:288 > - [[UIViewController _viewControllerForFullScreenPresentationFromView:_view.getAutoreleased()] dismissViewControllerAnimated:NO completion:nil]; > + UIView *autoreleasedView = _view.getAutoreleased(); > + if (autoreleasedView) > + [[UIViewController _viewControllerForFullScreenPresentationFromView:autoreleasedView] dismissViewControllerAnimated:NO completion:nil]; It’s wasteful and unnecessary to use getAutoreleased here; you didn’t add it, but it was wrong. Should just be get(). Autoreleased is only needed when the value is returned from an Objective-C function, not when it’s passed into one. Also there is no reason for the local variable. Should just be: if (_view) [[UIViewController _viewControllerForFullScreenPresentationFromView:_view.get()] dismissViewControllerAnimated:NO completion:nil]; 1668273 3 403374 ablackwood 2020-07-02 09:50:13 -0700 Created attachment 403374 Patch 1668300 4 403374 darin 2020-07-02 11:26:51 -0700 Comment on attachment 403374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403374&action=review > Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:287 > + RetainPtr<WKContentView> view = _view.get(); > + if (view) OK as is. But could write this: if (RetainPtr<WKContentView> view = _view.get()) or this: if (auto view = retainPtr(_view.get())) 1668359 5 403394 ablackwood 2020-07-02 14:12:16 -0700 Created attachment 403394 Patch 1668393 6 ews-feeder 2020-07-02 15:40:29 -0700 ablackwood@apple.com does not have committer permissions according to https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 403394 from commit queue. 1668394 7 ews-feeder 2020-07-02 15:44:04 -0700 Committed r263869: <https://trac.webkit.org/changeset/263869> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403394. 1668396 8 webkit-bug-importer 2020-07-02 15:45:20 -0700 <rdar://problem/65053840> 403326 2020-07-01 16:02:48 -0700 2020-07-02 09:50:11 -0700 Patch bug-213867-20200701160248.patch text/plain 1860 ablackwood U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU5Y2EwNTIyMDVhNmI1NTll MzQ0ZTBlOTljODg5YTkyNWZkYjI1NGIuLjIyN2ZkNGZkMDBhMmRlNTEzNGNhZjYzOTc5Y2ExY2Fk MTRmNmQwYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDctMDEgIEF1c3RpbiBC bGFja3dvb2QgIDxhYmxhY2t3b29vZEBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggaW4gK1tV SVZpZXdDb250cm9sbGVyIF92aWV3Q29udHJvbGxlckZvckZ1bGxTY3JlZW5QcmVzZW50YXRpb25G cm9tVmlldzpdIHdoZW4gV0tDb250ZW50VmlldyBpcyBkZWFsbG9jYXRlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzODY3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISku CisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tOgor ICAgICAgICAoLVtXS0ZpbGVVcGxvYWRQYW5lbCBkaXNtaXNzXSk6CisKIDIwMjAtMDctMDEgIEJy ZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gQWxsb3cg dGhlIFdlYkNvbnRlbnQgc2FuZGJveCB0byBjaGVjayB0aGUgJ2h3LnByb2R1Y3QnIHN5c2N0bApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9h ZFBhbmVsLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9h ZFBhbmVsLm1tCmluZGV4IGI4Mjg1MGE5OGVkOTkxNDVhOWFjMGQ4ZWUyYjc1MDY3MDdiMTkzMGUu LmEyNzIxMGU1OWQzMTAzN2VhMzhhZjRlN2U0MTM4NzUwOWY3OTk0ZTYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW0K QEAgLTI4Myw4ICsyODMsOSBAQCAtICh2b2lkKWRpc21pc3MKIHsKICAgICAvLyBEaXNtaXNzIGFu eSB2aWV3IGNvbnRyb2xsZXIgdGhhdCBpcyBiZWluZyBwcmVzZW50ZWQuIFRoaXMgd29ya3MgZm9y IGFsbCB0eXBlcyBvZiB2aWV3IGNvbnRyb2xsZXJzLCBwb3BvdmVycywgZXRjLgogICAgIC8vIElm IHRoZXJlIGlzIGFueSBraW5kIG9mIHZpZXcgY29udHJvbGxlciBwcmVzZW50ZWQgb24gdGhpcyB2 aWV3LCBpdCB3aWxsIGJlIHJlbW92ZWQuCi0gICAgCi0gICAgW1tVSVZpZXdDb250cm9sbGVyIF92 aWV3Q29udHJvbGxlckZvckZ1bGxTY3JlZW5QcmVzZW50YXRpb25Gcm9tVmlldzpfdmlldy5nZXRB dXRvcmVsZWFzZWQoKV0gZGlzbWlzc1ZpZXdDb250cm9sbGVyQW5pbWF0ZWQ6Tk8gY29tcGxldGlv bjpuaWxdOworICAgIFVJVmlldyAqYXV0b3JlbGVhc2VkVmlldyA9IF92aWV3LmdldEF1dG9yZWxl YXNlZCgpOworICAgIGlmIChhdXRvcmVsZWFzZWRWaWV3KQorICAgICAgICBbW1VJVmlld0NvbnRy b2xsZXIgX3ZpZXdDb250cm9sbGVyRm9yRnVsbFNjcmVlblByZXNlbnRhdGlvbkZyb21WaWV3OmF1 dG9yZWxlYXNlZFZpZXddIGRpc21pc3NWaWV3Q29udHJvbGxlckFuaW1hdGVkOk5PIGNvbXBsZXRp b246bmlsXTsKICAgICAKICAgICBbX3ByZXNlbnRhdGlvblBvcG92ZXIgc2V0RGVsZWdhdGU6bmls XTsKICAgICBfcHJlc2VudGF0aW9uUG9wb3ZlciA9IG5pbDsK 403374 2020-07-02 09:50:13 -0700 2020-07-02 14:12:14 -0700 Patch bug-213867-20200702095012.patch text/plain 2243 ablackwood U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU5Y2EwNTIyMDVhNmI1NTll MzQ0ZTBlOTljODg5YTkyNWZkYjI1NGIuLjgyZDZjZmMxYzIyN2IwMDM4ZmE3YWYxZDIzMDMzOGNi YjU4ZWUyNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDctMDEgIEF1c3RpbiBC bGFja3dvb2QgIDxhYmxhY2t3b29vZEBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggaW4gK1tV SVZpZXdDb250cm9sbGVyIF92aWV3Q29udHJvbGxlckZvckZ1bGxTY3JlZW5QcmVzZW50YXRpb25G cm9tVmlldzpdIHdoZW4gV0tDb250ZW50VmlldyBpcyBkZWFsbG9jYXRlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzODY3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgK1tVSVZpZXdDb250cm9sbGVyIF92 aWV3Q29udHJvbGxlckZvckZ1bGxTY3JlZW5QcmVzZW50YXRpb25Gcm9tVmlldzpdCisgICAgICAg IGFzc2VydHMgdGhhdCB0aGUgdmlldyBwYXJhbWV0ZXIgaXMgbm9uLW5pbC4gV0tGaWxlVXBsb2Fk UGFuZWwKKyAgICAgICAgcGFzc2VzIGl0cyB2aWV3IChhIHdlYWsgcG9pbnRlciB0byB0aGUgV0tD b250ZW50VmlldyksIHdoaWNoIG1heQorICAgICAgICBoYXZlIGFscmVhZHkgYmVlbiBuaWwnZCBv dXQgd2hlbiB0aGUgY29udGVudCB2aWV3IHRyaWVzIHRvIGRpc21pc3MKKyAgICAgICAgdGhlIHBh bmVsIGluIGl0cyBvd24gZGVhbGxvYy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZm9ybXMv V0tGaWxlVXBsb2FkUGFuZWwubW06CisgICAgICAgICgtW1dLRmlsZVVwbG9hZFBhbmVsIGRpc21p c3NdKToKKyAgICAgICAgQ2hlY2sgZm9yIG5pbC4KKwogMjAyMC0wNy0wMSAgQnJlbnQgRnVsZ2hh bSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBBbGxvdyB0aGUgV2ViQ29u dGVudCBzYW5kYm94IHRvIGNoZWNrIHRoZSAnaHcucHJvZHVjdCcgc3lzY3RsCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW0g Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW0K aW5kZXggYjgyODUwYTk4ZWQ5OTE0NWE5YWMwZDhlZTJiNzUwNjcwN2IxOTMwZS4uYzQ1M2Y4NGE0 YmVhZTEyZDRlOTY1YzQyNzViYWI0NzUwZjIwODRiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbQpAQCAtMjgzLDEz ICsyODMsMTQgQEAgLSAodm9pZClkaXNtaXNzCiB7CiAgICAgLy8gRGlzbWlzcyBhbnkgdmlldyBj b250cm9sbGVyIHRoYXQgaXMgYmVpbmcgcHJlc2VudGVkLiBUaGlzIHdvcmtzIGZvciBhbGwgdHlw ZXMgb2YgdmlldyBjb250cm9sbGVycywgcG9wb3ZlcnMsIGV0Yy4KICAgICAvLyBJZiB0aGVyZSBp cyBhbnkga2luZCBvZiB2aWV3IGNvbnRyb2xsZXIgcHJlc2VudGVkIG9uIHRoaXMgdmlldywgaXQg d2lsbCBiZSByZW1vdmVkLgotICAgIAotICAgIFtbVUlWaWV3Q29udHJvbGxlciBfdmlld0NvbnRy b2xsZXJGb3JGdWxsU2NyZWVuUHJlc2VudGF0aW9uRnJvbVZpZXc6X3ZpZXcuZ2V0QXV0b3JlbGVh c2VkKCldIGRpc21pc3NWaWV3Q29udHJvbGxlckFuaW1hdGVkOk5PIGNvbXBsZXRpb246bmlsXTsK KyAgICBSZXRhaW5QdHI8V0tDb250ZW50Vmlldz4gdmlldyA9IF92aWV3LmdldCgpOworICAgIGlm ICh2aWV3KQorICAgICAgICBbW1VJVmlld0NvbnRyb2xsZXIgX3ZpZXdDb250cm9sbGVyRm9yRnVs bFNjcmVlblByZXNlbnRhdGlvbkZyb21WaWV3OnZpZXcuZ2V0KCldIGRpc21pc3NWaWV3Q29udHJv bGxlckFuaW1hdGVkOk5PIGNvbXBsZXRpb246bmlsXTsKICAgICAKICAgICBbX3ByZXNlbnRhdGlv blBvcG92ZXIgc2V0RGVsZWdhdGU6bmlsXTsKICAgICBfcHJlc2VudGF0aW9uUG9wb3ZlciA9IG5p bDsKICAgICBfcHJlc2VudGF0aW9uVmlld0NvbnRyb2xsZXIgPSBuaWw7Ci0gICAgCisKICAgICBb c2VsZiBfY2FuY2VsXTsKIH0KIAo= 403394 2020-07-02 14:12:16 -0700 2020-07-02 15:44:04 -0700 Patch bug-213867-20200702141215.patch text/plain 2214 ablackwood U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU5Y2EwNTIyMDVhNmI1NTll MzQ0ZTBlOTljODg5YTkyNWZkYjI1NGIuLjgyZDZjZmMxYzIyN2IwMDM4ZmE3YWYxZDIzMDMzOGNi YjU4ZWUyNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDctMDEgIEF1c3RpbiBC bGFja3dvb2QgIDxhYmxhY2t3b29vZEBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggaW4gK1tV SVZpZXdDb250cm9sbGVyIF92aWV3Q29udHJvbGxlckZvckZ1bGxTY3JlZW5QcmVzZW50YXRpb25G cm9tVmlldzpdIHdoZW4gV0tDb250ZW50VmlldyBpcyBkZWFsbG9jYXRlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEzODY3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgK1tVSVZpZXdDb250cm9sbGVyIF92 aWV3Q29udHJvbGxlckZvckZ1bGxTY3JlZW5QcmVzZW50YXRpb25Gcm9tVmlldzpdCisgICAgICAg IGFzc2VydHMgdGhhdCB0aGUgdmlldyBwYXJhbWV0ZXIgaXMgbm9uLW5pbC4gV0tGaWxlVXBsb2Fk UGFuZWwKKyAgICAgICAgcGFzc2VzIGl0cyB2aWV3IChhIHdlYWsgcG9pbnRlciB0byB0aGUgV0tD b250ZW50VmlldyksIHdoaWNoIG1heQorICAgICAgICBoYXZlIGFscmVhZHkgYmVlbiBuaWwnZCBv dXQgd2hlbiB0aGUgY29udGVudCB2aWV3IHRyaWVzIHRvIGRpc21pc3MKKyAgICAgICAgdGhlIHBh bmVsIGluIGl0cyBvd24gZGVhbGxvYy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZm9ybXMv V0tGaWxlVXBsb2FkUGFuZWwubW06CisgICAgICAgICgtW1dLRmlsZVVwbG9hZFBhbmVsIGRpc21p c3NdKToKKyAgICAgICAgQ2hlY2sgZm9yIG5pbC4KKwogMjAyMC0wNy0wMSAgQnJlbnQgRnVsZ2hh bSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBBbGxvdyB0aGUgV2ViQ29u dGVudCBzYW5kYm94IHRvIGNoZWNrIHRoZSAnaHcucHJvZHVjdCcgc3lzY3RsCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW0g Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZm9ybXMvV0tGaWxlVXBsb2FkUGFuZWwubW0K aW5kZXggYjgyODUwYTk4ZWQ5OTE0NWE5YWMwZDhlZTJiNzUwNjcwN2IxOTMwZS4uZTUzOTkxZGIy MjI4NzFkNTI2MTExOTBlZTI4ODk5ZjY4ZDYzYjVhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRmlsZVVwbG9hZFBhbmVsLm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9mb3Jtcy9XS0ZpbGVVcGxvYWRQYW5lbC5tbQpAQCAtMjgzLDEz ICsyODMsMTQgQEAgLSAodm9pZClkaXNtaXNzCiB7CiAgICAgLy8gRGlzbWlzcyBhbnkgdmlldyBj b250cm9sbGVyIHRoYXQgaXMgYmVpbmcgcHJlc2VudGVkLiBUaGlzIHdvcmtzIGZvciBhbGwgdHlw ZXMgb2YgdmlldyBjb250cm9sbGVycywgcG9wb3ZlcnMsIGV0Yy4KICAgICAvLyBJZiB0aGVyZSBp cyBhbnkga2luZCBvZiB2aWV3IGNvbnRyb2xsZXIgcHJlc2VudGVkIG9uIHRoaXMgdmlldywgaXQg d2lsbCBiZSByZW1vdmVkLgotICAgIAotICAgIFtbVUlWaWV3Q29udHJvbGxlciBfdmlld0NvbnRy b2xsZXJGb3JGdWxsU2NyZWVuUHJlc2VudGF0aW9uRnJvbVZpZXc6X3ZpZXcuZ2V0QXV0b3JlbGVh c2VkKCldIGRpc21pc3NWaWV3Q29udHJvbGxlckFuaW1hdGVkOk5PIGNvbXBsZXRpb246bmlsXTsK KworICAgIGlmIChhdXRvIHZpZXcgPSBfdmlldy5nZXQoKSkKKyAgICAgICAgW1tVSVZpZXdDb250 cm9sbGVyIF92aWV3Q29udHJvbGxlckZvckZ1bGxTY3JlZW5QcmVzZW50YXRpb25Gcm9tVmlldzp2 aWV3LmdldCgpXSBkaXNtaXNzVmlld0NvbnRyb2xsZXJBbmltYXRlZDpOTyBjb21wbGV0aW9uOm5p bF07CiAgICAgCiAgICAgW19wcmVzZW50YXRpb25Qb3BvdmVyIHNldERlbGVnYXRlOm5pbF07CiAg ICAgX3ByZXNlbnRhdGlvblBvcG92ZXIgPSBuaWw7CiAgICAgX3ByZXNlbnRhdGlvblZpZXdDb250 cm9sbGVyID0gbmlsOwotICAgIAorCiAgICAgW3NlbGYgX2NhbmNlbF07CiB9CiAK