213839 2020-07-01 06:33:31 -0700 [Media Controls] Tracks panel can show text tracks with mode "hidden" as selected 2020-07-01 08:26:37 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts eric.carlson ews-watchlist glenn graouts jer.noble joepeck philipj sergio webkit-bug-importer oldest_to_newest 1667903 0 graouts 2020-07-01 06:33:31 -0700 [Media Controls] Tracks panel can show text tracks with mode "hidden" as selected 1667904 1 403285 graouts 2020-07-01 06:36:25 -0700 Created attachment 403285 Patch 1667905 2 graouts 2020-07-01 06:36:30 -0700 <rdar://problem/57989325> 1667945 3 ews-feeder 2020-07-01 08:26:36 -0700 Committed r263802: <https://trac.webkit.org/changeset/263802> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403285. 403285 2020-07-01 06:36:25 -0700 2020-07-01 08:26:37 -0700 Patch bug-213839-20200701153624.patch text/plain 7435 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNzg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODQyMjY5YjI2NTI1MTlm NjI0OGExMTc3MmViZDJiMmY3NTgxYzM3Mi4uZTYyZjIxODE2M2E4YmVkMTZmMTZhZTRlOTk5YTk3 M2I1ZjdhNjI5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA3LTAxICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAgICAgIFtNZWRpYSBDb250cm9s c10gVHJhY2tzIHBhbmVsIGNhbiBzaG93IHRleHQgdHJhY2tzIHdpdGggbW9kZSAiaGlkZGVuIiBh cyBzZWxlY3RlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjEzODM5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81Nzk4OTMyNT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBvbmx5IGNvbnNpZGVyZWQg dGV4dCB0cmFja3MgdGhhdCBoYWQgdGhlaXIgIm1vZGUiIHNldCB0byAiZGlzYWJsZWQiIGFzIHRy YWNrcyB0aGF0IHdlcmVuJ3Qgc2VsZWN0ZWQsCisgICAgICAgIGJ1dCB0aGVyZSBpcyBhbHNvIHRo ZSAiaGlkZGVuIiBtb2RlIHdoaWNoIHNob3VsZCBzaGFyZSB0aGUgc2FtZSBVSSBzdGF0ZS4gV2Ug bm93IGNoZWNrIGZvciAibW9kZSIgdG8KKyAgICAgICAgYmUgc2V0IHRvICJzaG93aW5nIiB0byBj b25zaWRlciBhIHRleHQgdHJhY2sgYXMgc2VsZWN0ZWQgaW4gdGhlIHRyYWNrcyBwYW5lbC4KKwor ICAgICAgICBUZXN0OiBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvdHJhY2tzLXN1cHBvcnQv dHJhY2tzLXN1cHBvcnQtaGlkZGVuLXRyYWNrcy5odG1sCisKKyAgICAgICAgKiBNb2R1bGVzL21v ZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS90cmFja3Mtc3VwcG9ydC5qczoKKyAgICAgICAgKFRy YWNrc1N1cHBvcnQucHJvdG90eXBlLnRyYWNrc1BhbmVsSXNUcmFja0luU2VjdGlvblNlbGVjdGVk KToKKwogMjAyMC0wNi0zMCAgU2FtIFdlaW5pZyAgPHdlaW5pZ0BhcHBsZS5jb20+CiAKICAgICAg ICAgU3BsaXQgQ29sb3Igc2VyaWFsaXphdGlvbiBvdXQgb2YgQ29sb3IgY2xhc3NlcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvbWVkaWEv dHJhY2tzLXN1cHBvcnQuanMgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1j b250cm9scy9tZWRpYS90cmFja3Mtc3VwcG9ydC5qcwppbmRleCBkMTFiN2U1Y2VmMDFlYzNhN2U2 MDM0NzE3ODRkYTY3NTc5ZDQxM2JmLi5hODU5MDg0YjY4OTZkZWQ4NmEyZTljZWUxNDAyZWUyNjNk Njg5YTJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1j b250cm9scy9tZWRpYS90cmFja3Mtc3VwcG9ydC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9tZWRpYS90cmFja3Mtc3VwcG9ydC5qcwpAQCAtMTA0 LDE0ICsxMDQsMTUgQEAgY2xhc3MgVHJhY2tzU3VwcG9ydCBleHRlbmRzIE1lZGlhQ29udHJvbGxl clN1cHBvcnQKICAgICAgICAgY29uc3QgdGV4dFRyYWNrcyA9IHRoaXMuX3RleHRUcmFja3MoKTsK ICAgICAgICAgY29uc3QgdHJhY2tJdGVtID0gdGV4dFRyYWNrc1t0cmFja0luZGV4XTsKICAgICAg ICAgY29uc3QgaG9zdCA9IHRoaXMubWVkaWFDb250cm9sbGVyLmhvc3Q7Ci0gICAgICAgIGNvbnN0 IGFsbFRyYWNrc0Rpc2FibGVkID0gdGV4dFRyYWNrcy5ldmVyeSh0cmFjayA9PiB0cmFjay5tb2Rl ID09PSAiZGlzYWJsZWQiKTsKKyAgICAgICAgY29uc3QgdHJhY2tJc1Nob3dpbmcgPSB0cmFjayA9 PiB0cmFjay5tb2RlID09PSAic2hvd2luZyI7CisgICAgICAgIGNvbnN0IGFsbFRyYWNrc0Rpc2Fi bGVkID0gIXRleHRUcmFja3Muc29tZSh0cmFja0lzU2hvd2luZyk7CiAgICAgICAgIGNvbnN0IHVz ZXNBdXRvbWF0aWNUcmFjayA9IGhvc3QgPyAoaG9zdC5jYXB0aW9uRGlzcGxheU1vZGUgPT09ICJh dXRvbWF0aWMiICYmIGFsbFRyYWNrc0Rpc2FibGVkKSA6IGZhbHNlOwogCiAgICAgICAgIGlmIChh bGxUcmFja3NEaXNhYmxlZCAmJiBob3N0ICYmIHRyYWNrSXRlbSA9PT0gaG9zdC5jYXB0aW9uTWVu dU9mZkl0ZW0gJiYgKGhvc3QuY2FwdGlvbkRpc3BsYXlNb2RlID09PSAiZm9yY2VkLW9ubHkiIHx8 IGhvc3QuY2FwdGlvbkRpc3BsYXlNb2RlID09PSAibWFudWFsIikpCiAgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKICAgICAgICAgaWYgKGhvc3QgJiYgdHJhY2tJdGVtID09PSBob3N0LmNhcHRpb25N ZW51QXV0b21hdGljSXRlbSAmJiB1c2VzQXV0b21hdGljVHJhY2spCiAgICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKLSAgICAgICAgcmV0dXJuICF1c2VzQXV0b21hdGljVHJhY2sgJiYgdHJhY2tJdGVt Lm1vZGUgIT09ICJkaXNhYmxlZCI7CisgICAgICAgIHJldHVybiAhdXNlc0F1dG9tYXRpY1RyYWNr ICYmIHRyYWNrSXNTaG93aW5nKHRyYWNrSXRlbSk7CiAgICAgfQogCiAgICAgdHJhY2tzUGFuZWxT ZWxlY3Rpb25EaWRDaGFuZ2UodHJhY2tJbmRleCwgc2VjdGlvbkluZGV4KQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDgxMTBh NjkyYjI2ZTA2MWYxZTgwZTE4NDNlOWNhYmY4MjEwZmZiYTMuLmU4YmZkOGY2Y2IxYjk4MmEzNWMy ZTBhZWIxODkzN2IxODZkMjRkMDYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAyMC0wNy0wMSAg QW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KKworICAgICAgICBbTWVkaWEgQ29u dHJvbHNdIFRyYWNrcyBwYW5lbCBjYW4gc2hvdyB0ZXh0IHRyYWNrcyB3aXRoIG1vZGUgImhpZGRl biIgYXMgc2VsZWN0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIxMzgzOQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTc5ODkzMjU+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgbmV3IHRlc3Qg dGhhdCBkdW1wcyB0aGUgc2VsZWN0aW9uIHN0YXRlIG9mIHRyYWNrcyBpbiB0aGUgdHJhY2tzIHBh bmVsIHdoZW4gYWxsIG9mIG1lZGlhLnRleHRUcmFja3MKKyAgICAgICAgaGF2ZSBiZWVuIHNldCB0 byBtb2RlID0gImhpZGRlbiIuCisKKyAgICAgICAgKiBtZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJv bHMvdHJhY2tzLXN1cHBvcnQvdHJhY2tzLXN1cHBvcnQtaGlkZGVuLXRyYWNrcy1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy90cmFja3Mt c3VwcG9ydC90cmFja3Mtc3VwcG9ydC1oaWRkZW4tdHJhY2tzLmh0bWw6IEFkZGVkLgorCiAyMDIw LTA2LTMwICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVd IEdhcmRlbiBzb21lIGZhaWx1cmVzIGFuZCBhZGQgbmV3IHNlY3Rpb24gdG8gZXhwZWN0YXRpb24K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy90cmFj a3Mtc3VwcG9ydC90cmFja3Mtc3VwcG9ydC1oaWRkZW4tdHJhY2tzLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy90cmFja3Mtc3VwcG9ydC90cmFj a3Mtc3VwcG9ydC1oaWRkZW4tdHJhY2tzLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43YWQzZmMx OTZiNjU5OTVmM2E3MDRjN2MyMTc4MGY1MzMyNmFiODRlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3RyYWNrcy1zdXBwb3J0L3RyYWNr cy1zdXBwb3J0LWhpZGRlbi10cmFja3MtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjEgQEAKK1Ro aXMgdGVzdCBjaGVja3MgdGhhdCB0aGUgdHJhY2tzIHBhbmVsIGRvZXNuJ3Qgc2hvdyBhbnkgdHJh Y2sgYXMgc2VsZWN0ZWQgaWYgYWxsIHRoZSB0ZXh0IHRyYWNrcyBmb3IgYSBtZWRpYSBlbGVtZW50 IGFyZSBtYXJrZWQgYXMgImhpZGRlbiIuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNl cmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKwor CitQQVNTIHNoYWRvd1Jvb3QucXVlcnlTZWxlY3RvcignYnV0dG9uLnRyYWNrcycpIGJlY2FtZSBk aWZmZXJlbnQgZnJvbSBudWxsCitQQVNTIHNoYWRvd1Jvb3QucXVlcnlTZWxlY3RvcignYnV0dG9u LnRyYWNrcycpLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpLndpZHRoIGJlY2FtZSBkaWZmZXJlbnQg ZnJvbSAwCisKKz09PSBJbml0aWFsIHN0YXRlID09PQorCitbeF0gT2ZmCitbLV0gQXV0byAoUmVj b21tZW5kZWQpCitbLV0gRW5nbGlzaCBTdWJ0aXRsZXMKK1stXSBGcmVuY2ggU3VidGl0bGVzCitb LV0gR2VybWFuIFN1YnRpdGxlcworWy1dIFNwYW5pc2ggU3VidGl0bGVzCisKK1BBU1Mgc3VjY2Vz c2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvdHJhY2tzLXN1cHBvcnQvdHJhY2tz LXN1cHBvcnQtaGlkZGVuLXRyYWNrcy5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1l ZGlhLWNvbnRyb2xzL3RyYWNrcy1zdXBwb3J0L3RyYWNrcy1zdXBwb3J0LWhpZGRlbi10cmFja3Mu aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi41NjI3Nzg1ZDRiOTEwYmQxNWY2MWEyZjdjOWFiMDBhMGFkOTNiMzFm Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRy b2xzL3RyYWNrcy1zdXBwb3J0L3RyYWNrcy1zdXBwb3J0LWhpZGRlbi10cmFja3MuaHRtbApAQCAt MCwwICsxLDcyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNv dXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPGJvZHk+Cis8dmlkZW8gc3JjPSIuLi8u Li9jb250ZW50L0NDK1N1YnRpdGxlcy5tb3YiIHN0eWxlPSJwb3NpdGlvbjogYWJzb2x1dGU7IGxl ZnQ6IDA7IHRvcDogMDsgd2lkdGg6IDY0MHB4OyBoZWlnaHQ6IDM2MHB4OyIgY29udHJvbHMgYXV0 b3BsYXk+PC92aWRlbz4KKzxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KKword2luZG93 LmpzVGVzdElzQXN5bmMgPSB0cnVlOworCitkZXNjcmlwdGlvbihgVGhpcyB0ZXN0IGNoZWNrcyB0 aGF0IHRoZSB0cmFja3MgcGFuZWwgZG9lc24ndCBzaG93IGFueSB0cmFjayBhcyBzZWxlY3RlZCBp ZiBhbGwgdGhlIHRleHQgdHJhY2tzIGZvciBhIG1lZGlhIGVsZW1lbnQgYXJlIG1hcmtlZCBhcyAi aGlkZGVuIi5gKTsKKworY29uc3QgbWVkaWEgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCJ2aWRl byIpOworY29uc3Qgc2hhZG93Um9vdCA9IHdpbmRvdy5pbnRlcm5hbHMuc2hhZG93Um9vdChtZWRp YSk7CisKK21lZGlhLmFkZEV2ZW50TGlzdGVuZXIoInBsYXkiLCAoKSA9PiB7CisgICAgbWVkaWEu cGF1c2UoKTsKKworICAgIHNob3VsZEJlY29tZURpZmZlcmVudCgic2hhZG93Um9vdC5xdWVyeVNl bGVjdG9yKCdidXR0b24udHJhY2tzJykiLCAibnVsbCIsICgpID0+IHsKKyAgICAgICAgc2hvdWxk QmVjb21lRGlmZmVyZW50KCJzaGFkb3dSb290LnF1ZXJ5U2VsZWN0b3IoJ2J1dHRvbi50cmFja3Mn KS5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKS53aWR0aCIsICIwIiwgcnVuVGVzdCk7CisgICAgfSk7 Cit9KTsKKworYXN5bmMgZnVuY3Rpb24gcnVuVGVzdCgpCit7CisgICAgLy8gU3RhcnQgYnkgbWFr aW5nIHN1cmUgYWxsIHRyYWNrcyBhcmUgbWFya2VkIGFzICJoaWRkZW4iLgorICAgIEFycmF5LmZy b20obWVkaWEudGV4dFRyYWNrcykuZm9yRWFjaCh0cmFjayA9PiB0cmFjay5tb2RlID0gImhpZGRl biIpOworCisgICAgLy8gTmV4dCwgYnJpbmcgdXAgdGhlIHRyYWNrcyBtZW51IGJ5IGNsaWNraW5n IG9uIHRoZSB0cmFja3MgYnV0dG9uLgorICAgIGF3YWl0IGNsaWNrT25UcmFja3NCdXR0b24oKTsK KyAgICAvLyBEdW1wIHRoZSBzdGF0ZSBvZiB0aGUgdHJhY2tzIG1lbnUgZm9yIHRleHQgdHJhY2tz LCB3aGljaCBzaG91bGQgc2hvdyB0aGUgZmlyc3QgZW1iZWRkZWQgdGV4dCB0cmFjayBhcyBzZWxl Y3RlZC4KKyAgICBkdW1wVGV4dFRyYWNrc0xpc3ROb2RlcygiSW5pdGlhbCBzdGF0ZSIpOworCisg ICAgZmluaXNoVGVzdCgpOworfQorCitmdW5jdGlvbiB0ZXh0VHJhY2tzTGlzdE5vZGVzKCkKK3sK KyAgICByZXR1cm4gc2hhZG93Um9vdC5xdWVyeVNlbGVjdG9yQWxsKCIudHJhY2tzLXBhbmVsIHNl Y3Rpb246bGFzdC1vZi10eXBlID4gdWwgPiBsaSIpOworfQorCitmdW5jdGlvbiBkdW1wVGV4dFRy YWNrc0xpc3ROb2Rlcyhtc2cpCit7CisgICAgZGVidWcoIiIpOworICAgIGRlYnVnKGA9PT0gJHtt c2d9ID09PWApOworICAgIGRlYnVnKCIiKTsKKyAgICBBcnJheS5mcm9tKHRleHRUcmFja3NMaXN0 Tm9kZXMoKSkuZm9yRWFjaChsaSA9PiBkZWJ1ZyhgJHtsaS5jbGFzc0xpc3QuY29udGFpbnMoInNl bGVjdGVkIikgPyAiW3hdIiA6ICJbLV0ifSAke2xpLnRleHRDb250ZW50fWApKTsKK30KKworYXN5 bmMgZnVuY3Rpb24gY2xpY2tPblRyYWNrc0J1dHRvbigpCit7CisgICAgYXdhaXQgbmV3IFByb21p c2UocmVxdWVzdEFuaW1hdGlvbkZyYW1lKTsKKyAgICBjbGlja09uRWxlbWVudChzaGFkb3dSb290 Lmxhc3RDaGlsZC5xdWVyeVNlbGVjdG9yKCJidXR0b24udHJhY2tzIikpOworICAgIGF3YWl0IG5l dyBQcm9taXNlKHJlcXVlc3RBbmltYXRpb25GcmFtZSk7Cit9CisKK2Z1bmN0aW9uIGNsaWNrT25F bGVtZW50KGVsZW1lbnQpCit7CisgICAgY29uc3QgYm91bmRzID0gZWxlbWVudC5nZXRCb3VuZGlu Z0NsaWVudFJlY3QoKTsKKyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhib3VuZHMubGVmdCAr IDEsIGJvdW5kcy50b3AgKyAxKTsKKyAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAgICBl dmVudFNlbmRlci5tb3VzZVVwKCk7Cit9CisKK2Z1bmN0aW9uIGZpbmlzaFRlc3QoKQoreworICAg IGRlYnVnKCIiKTsKKyAgICBtZWRpYS5yZW1vdmUoKTsKKyAgICBmaW5pc2hKU1Rlc3QoKTsKK30K KworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9z dC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cg==