21381 2008-10-04 23:50:03 -0700 Incremental parsing of html causes bogus line numbers in some cases 2008-10-05 01:29:15 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://webkit.org P2 Normal --- 1 oliver oliver hyatt timothy oldest_to_newest 94141 0 oliver 2008-10-04 23:50:03 -0700 When incremental parsing of an html document pauses midway through a <script> element, reentry to the parser resets the script start line number, leading to somewhat borken behaviour. Originally reported by Tim on bug #20187 but it turned out be an unrelated issue. (from tim's comment: With the fix for bug 19053, this bug can be seen on webkit.org. Just attach the debugger, pause and reload the page. ) 94143 1 24099 oliver 2008-10-05 00:01:07 -0700 Created attachment 24099 Fixeration, but no layout test I haaven't been able to make a layout test, but i'm sure it should be possible. I am going to see if weinig can help out -- however the patch itself should be reviewable. 94146 2 oliver 2008-10-05 01:29:15 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/http/tests/incremental/pause-in-script-element-expected.txt A LayoutTests/http/tests/incremental/pause-in-script-element.pl M WebCore/ChangeLog M WebCore/html/HTMLTokenizer.cpp Committed r37315 24099 2008-10-05 00:01:07 -0700 2008-10-05 00:07:24 -0700 Fixeration, but no layout test fix-js-linenos.patch text/plain 3086 oliver ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWFmOGFhMS4uMjRmMDkyNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAwOC0xMC0wNCAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEJ1ZyAyMTM4MTogSW5jcmVtZW50YWwgcGFyc2luZyBvZiBodG1sIGNhdXNl cyBib2d1cyBsaW5lIG51bWJlcnMgaW4gc29tZSBjYXNlcworICAgICAgICA8aHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzgxPgorCisgICAgICAgIElmIHdlIGhpdCBh IHBhcnNpbmcgYm91bmRhcnkgKGVuZCBvZiBhIHBhY2tldCwgZXRjKSBpbiB0aGUgbWlkZGxlIG9m IGEKKyAgICAgICAgPHNjcmlwdD4gZWxlbWVudCB3aGVuIHdlIGFyZSBkb2luZyBhbiBpbmNyZW1l bnRhbCBwYXJzZSwgd2UgZXhpdCB0aGUKKyAgICAgICAgcGFyc2VyLCBhbmQgcmVlbnRlciBsYXRl ciB3aGVuIG1vcmUgZGF0YSBpcyBhdmFpbGFibGUuICBEdXJpbmcgdGhpcworICAgICAgICByZWVu dHJ5IHdlIGluY29ycmVjdGx5IHJlc2V0IHRoZSBzY3JpcHRTdGFydExpbmVubyB0byB0aGUgY3Vy cmVudCBsaW5lCisgICAgICAgIGluIHRoZSBwYXJzZXIsIHdoaWNoIGlzIG5vdyBwYXJ0IHdheSB0 aHJvdWdoIHRoZSBzY3JpcHQgZWxlbWVudC4KKworICAgICAgICBUaGUgc29sdXRpb24gaXMgdG8g dHJhY2sgd2hldGhlciB3ZSBhcmUgZW50ZXJpbmcgb3IgcmVlbnRlcmluZyB0aGUgcGFyc2luZwor ICAgICAgICBvZiBhIHNjcmlwdCBlbGVtZW50LiAgV2UgZG8gdGhpcyBzaW1wbHkgYnkgMCBjaGVj a2luZyBzY3JpcHRTdGFydExpbmVubywKKyAgICAgICAgYW5kIHJlc2V0dGluZyBpdCBhZnRlciB3 ZSBjb21wbGV0ZSBwYXJzaW5nIG9mIGVhY2ggc2NyaXB0IGVsZW1lbnQuIAorCisgICAgICAgICog aHRtbC9IVE1MVG9rZW5pemVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxUb2tlbml6ZXI6 OnBhcnNlU3BlY2lhbCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVG9rZW5pemVyOjpzY3JpcHRI YW5kbGVyKToKKwogMjAwOC0xMC0wNCAgQWxwIFRva2VyICA8YWxwQG51YW50aS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgSHlhdHQuIExhbmRlZCBieSBKYW4gQWxvbnpvLgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxUb2tlbml6ZXIuY3BwIGIvV2ViQ29yZS9odG1sL0hU TUxUb2tlbml6ZXIuY3BwCmluZGV4IDVjYWFhMGQuLmUyMGI3YjggMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvaHRtbC9IVE1MVG9rZW5pemVyLmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTFRva2VuaXpl ci5jcHAKQEAgLTMxNyw3ICszMTcsNyBAQCBIVE1MVG9rZW5pemVyOjpTdGF0ZSBIVE1MVG9rZW5p emVyOjpwYXJzZVNwZWNpYWwoU2VnbWVudGVkU3RyaW5nICZzcmMsIFN0YXRlIHN0YQogICAgIEFT U0VSVChzdGF0ZS5pblRleHRBcmVhKCkgfHwgc3RhdGUuaW5UaXRsZSgpIHx8IHN0YXRlLmluSUZy YW1lKCkgfHwgIXN0YXRlLmhhc0VudGl0eVN0YXRlKCkpOwogICAgIEFTU0VSVCghc3RhdGUuaGFz VGFnU3RhdGUoKSk7CiAgICAgQVNTRVJUKHN0YXRlLmluWG1wKCkgKyBzdGF0ZS5pblRleHRBcmVh KCkgKyBzdGF0ZS5pblRpdGxlKCkgKyBzdGF0ZS5pblN0eWxlKCkgKyBzdGF0ZS5pblNjcmlwdCgp ICsgc3RhdGUuaW5JRnJhbWUoKSA9PSAxICk7Ci0gICAgaWYgKHN0YXRlLmluU2NyaXB0KCkpCisg ICAgaWYgKHN0YXRlLmluU2NyaXB0KCkgJiYgIXNjcmlwdFN0YXJ0TGluZW5vKQogICAgICAgICBz Y3JpcHRTdGFydExpbmVubyA9IG1fbGluZU51bWJlciArIDE7IC8vIFNjcmlwdCBsaW5lIG51bWJl cnMgYXJlIDEgYmFzZWQuCiAKICAgICBpZiAoc3RhdGUuaW5Db21tZW50KCkpIApAQCAtNDEzLDYg KzQxMywxMCBAQCBIVE1MVG9rZW5pemVyOjpTdGF0ZSBIVE1MVG9rZW5pemVyOjpzY3JpcHRIYW5k bGVyKFN0YXRlIHN0YXRlKQogewogICAgIC8vIFdlIGFyZSBpbnNpZGUgYSA8c2NyaXB0PgogICAg IGJvb2wgZG9TY3JpcHRFeGVjID0gZmFsc2U7CisgICAgaW50IHN0YXJ0TGluZSA9IHNjcmlwdFN0 YXJ0TGluZW5vOworCisgICAgLy8gUmVzZXQgc2NyaXB0U3RhcnRMaW5lbm8gdG8gaW5kaWNhdGUg dGhhdCB3ZSd2ZSBmaW5pc2hlZCBwYXJzaW5nIHRoZSBjdXJyZW50IHNjcmlwdCBlbGVtZW50Cisg ICAgc2NyaXB0U3RhcnRMaW5lbm8gPSAwOwogCiAgICAgLy8gKEJ1Z3ppbGxhIDM4MzcpIFNjcmlw dHMgZm9sbG93aW5nIGEgZnJhbWVzZXQgZWxlbWVudCBzaG91bGQgbm90IGV4ZWN1dGUgb3IsIAog ICAgIC8vIGluIHRoZSBjYXNlIG9mIGV4dGVybiBzY3JpcHRzLCBldmVuIGxvYWQuCkBAIC00OTYs NyArNTAwLDcgQEAgSFRNTFRva2VuaXplcjo6U3RhdGUgSFRNTFRva2VuaXplcjo6c2NyaXB0SGFu ZGxlcihTdGF0ZSBzdGF0ZSkKICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICBwcmVw ZW5kaW5nU3JjID0gc3JjOwogICAgICAgICAgICAgc2V0U3JjKFNlZ21lbnRlZFN0cmluZygpKTsK LSAgICAgICAgICAgIHN0YXRlID0gc2NyaXB0RXhlY3V0aW9uKHNjcmlwdFN0cmluZywgc3RhdGUs IFN0cmluZygpLCBzY3JpcHRTdGFydExpbmVubyk7CisgICAgICAgICAgICBzdGF0ZSA9IHNjcmlw dEV4ZWN1dGlvbihzY3JpcHRTdHJpbmcsIHN0YXRlLCBTdHJpbmcoKSwgc3RhcnRMaW5lKTsKICAg ICAgICAgfQogICAgIH0KIApAQCAtNTIyLDcgKzUyNiw3IEBAIEhUTUxUb2tlbml6ZXI6OlN0YXRl IEhUTUxUb2tlbml6ZXI6OnNjcmlwdEhhbmRsZXIoU3RhdGUgc3RhdGUpCiAgICAgICAgICAgICB3 cml0ZShwcmVwZW5kaW5nU3JjLCBmYWxzZSk7CiAgICAgICAgICAgICBzdGF0ZSA9IG1fc3RhdGU7 CiAgICAgICAgIH0KLSAgICB9IAorICAgIH0KICAgICAKICNpZiBQUkVMT0FEX1NDQU5ORVJfRU5B QkxFRAogICAgIGlmICghcGVuZGluZ1NjcmlwdHMuaXNFbXB0eSgpICYmICFtX2V4ZWN1dGluZ1Nj cmlwdCkgewo=