213804 2020-06-30 11:36:30 -0700 [ macOS wk2 ] REGRESSION(r263485): fast/scrolling/mac/scroll-snapping-in-progress.html is a flaky failure 2020-07-16 09:28:33 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified ASSIGNED InRadar P2 Normal --- 1 jacob_uphoff webkit-unassigned ap hector_i_lopez simon.fraser tsavell webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1667639 0 jacob_uphoff 2020-06-30 11:36:30 -0700 fast/scrolling/mac/scroll-snapping-in-progress.html This test has been a flaky failure on macOS wk2 since it was introduced on r263485. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fscrolling%2Fmac%2Fscroll-snapping-in-progress.html Diff: Sending wheel events PASS container.scrollTop > 0 is true -PASS window.internals.isScrollSnapInProgress(container) is true +FAIL window.internals.isScrollSnapInProgress(container) should be true. Was false. PASS successfullyParsed is true +Some tests failed. TEST COMPLETE 1667640 1 webkit-bug-importer 2020-06-30 11:36:59 -0700 <rdar://problem/64948258> 1667766 2 simon.fraser 2020-06-30 15:35:15 -0700 I can reproduce. 1667773 3 simon.fraser 2020-06-30 16:04:29 -0700 Doesn't reproduce when I turn on logging. 1667780 4 simon.fraser 2020-06-30 16:30:06 -0700 When it flakes, we send the scroll event earlier, so we haven't started the scroll snap timer in ScrollController yet. 1667781 5 simon.fraser 2020-06-30 16:32:45 -0700 Seem to relate to whether we handle the two wheel events in the same commit, or different commits. 1667788 6 simon.fraser 2020-06-30 16:49:33 -0700 I don't see a way to make a non-flakey version of this test with the APIs we have. I can't wait for scrolling completion, because scroll snap is something that delays completion. I can't control when scroll events fire relative to wheel events, and I can't use wheel handlers in the test because that sends us down the slow-scrolling path. 1672137 7 404448 hector_i_lopez 2020-07-16 09:24:22 -0700 Created attachment 404448 Patch 1672140 8 404448 tsavell 2020-07-16 09:28:33 -0700 Comment on attachment 404448 Patch Clearing flags on attachment: 404448 Committed r264460: <https://trac.webkit.org/changeset/264460> 404448 2020-07-16 09:24:22 -0700 2020-07-16 09:28:33 -0700 Patch bug-213804-20200716092421.patch text/plain 1529 hector_i_lopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY0NDU3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmY4ZGViYWI1MzdlOTM5M2RiMThj NmMzOTMxODliMGJhMjNmMDYzNi4uMWU4YjQwMzQyOGIzMDI0MzgyNmQ0NjQwMWM2MzA2MTg3Yzdh NjBjYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTA3LTE2ICBIZWN0b3IgTG9wZXogIDxo ZWN0b3JfaV9sb3BlekBhcHBsZS5jb20+CisKKyAgICAgICAgWyBtYWNPUyB3azIgXSBSRUdSRVNT SU9OKHIyNjM0ODUpOiBmYXN0L3Njcm9sbGluZy9tYWMvc2Nyb2xsLXNuYXBwaW5nLWluLXByb2dy ZXNzLmh0bWwgaXMgYSBmbGFreSBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM4MDQKKworICAgICAgICBVbnJldmlld2VkIHRlc3QgZ2Fy ZGVuaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zOgor CiAyMDIwLTA3LTE2ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFVwZGF0ZSBXUFQgY3NzL3N1cHBvcnQgZGlyZWN0b3J5CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZGRmNWFkNDQ1 M2JlN2U1NmY3M2ZjOTI3NGY5NTc5ZWY4YzNmNWQ4Mi4uMTdkOWIwN2M1NTYwMzA1OTlmZjRhNzFl NmM3Yzg5OWU5NmM3NmFkOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdr Mi9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVz dEV4cGVjdGF0aW9ucwpAQCAtMTA0Miw0ICsxMDQyLDYgQEAgd2Via2l0Lm9yZy9iLzIxMzY1MiB3 ZWJydGMvdmlkZW8tYXV0b3BsYXkxLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCiB3ZWJraXQub3Jn L2IvMjE0MDg0IFsgUmVsZWFzZSBdIHdlYnJ0Yy9saWJ3ZWJydGMvZGVzY3JpcHRpb25HZXR0ZXJz Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMjE0Mjg2IGltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvd2VicnRjL1JUQ1BlZXJDb25uZWN0aW9uLWNvbm5lY3Rpb25T dGF0ZS5odHRwcy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBm aWxlCit3ZWJraXQub3JnL2IvMjE0Mjg2IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv d2VicnRjL1JUQ1BlZXJDb25uZWN0aW9uLWNvbm5lY3Rpb25TdGF0ZS5odHRwcy5odG1sIFsgUGFz cyBGYWlsdXJlIF0KKword2Via2l0Lm9yZy9iLzIxMzgwNCBmYXN0L3Njcm9sbGluZy9tYWMvc2Ny b2xsLXNuYXBwaW5nLWluLXByb2dyZXNzLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQo=