213798 2020-06-30 08:07:22 -0700 [iOS] Crash under WebKit::WebPage::getFocusedElementInformation() 2020-06-30 17:16:54 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts darin graouts webkit-bug-importer wenson_hsieh oldest_to_newest 1667578 0 graouts 2020-06-30 08:07:22 -0700 [iOS] Crash under WebKit::WebPage::getFocusedElementInformation() 1667579 1 403201 graouts 2020-06-30 08:11:25 -0700 Created attachment 403201 Patch 1667580 2 graouts 2020-06-30 08:11:56 -0700 <rdar://problem/62754594> 1667590 3 ews-feeder 2020-06-30 08:56:51 -0700 Committed r263752: <https://trac.webkit.org/changeset/263752> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403201. 1667799 4 403201 darin 2020-06-30 17:16:54 -0700 Comment on attachment 403201 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403201&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3108 > + for (unsigned index = 0; index < labels->length(); ++index) { > + if (is<Element>(labels->item(index)) && labels->item(index)->renderer()) > + associatedLabels.append(downcast<Element>(*labels->item(index))); > + } Not new to this patch: Is NodeList::item efficient enough that we should call it 3 times rather than putting the result into a local? 403201 2020-06-30 08:11:25 -0700 2020-06-30 08:56:51 -0700 Patch bug-213798-20200630171124.patch text/plain 2711 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY2NzI3ZmRjOWMwZWU1ZmUz MTM2ZTNlMTdjZjIzMTAxNzJlNDJmYzYuLmI2ODE4M2RiZDQ0OGRlNTZjMjk0ZjEwODVmNjM3ZGY4 NGRmYmI3N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDYtMzAgIEFudG9pbmUg UXVpbnQgIDxncmFvdXRzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW2lPU10gQ3Jhc2ggdW5kZXIg V2ViS2l0OjpXZWJQYWdlOjpnZXRGb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uKCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzc5OAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNjI3NTQ1OTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU2luY2UgTGFiZWxhYmxlRWxlbWVudDo6bGFiZWxzKCkgcmV0dXJu cyBhIFJlZlB0cjxOb2RlTGlzdD4sIGVuc3VyZSB3ZSBnZXQgYSB2YWx1ZSBiZWZvcmUgYXR0ZW1w dGluZyB0byByZWFkIGRhdGEgZnJvbSBpdC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFn ZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6Z2V0Rm9jdXNl ZEVsZW1lbnRJbmZvcm1hdGlvbik6CisKIDIwMjAtMDYtMzAgIENvbW1pdCBRdWV1ZSAgPGNvbW1p dC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjYz NzI0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dl YlBhZ2VJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFn ZUlPUy5tbQppbmRleCBkOGU5YTJmMTJkMGQ1ZjEwNDUzN2E0ZWNkMWVhMmI0OTIzYWE3ZTRlLi5k NjExNjhlOTQ0MDI2N2MwOTc4YWJhZjA5MmY1NzYzZGE1NjY4YjA3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQpAQCAtMzEwMCwx NyArMzEwMCwxOCBAQCB2b2lkIFdlYlBhZ2U6OmdldEZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb24o Rm9jdXNlZEVsZW1lbnRJbmZvcm1hdGlvbiYgaW5mb3JtYXRpbwogICAgIGluZm9ybWF0aW9uLmZv Y3VzZWRFbGVtZW50SWRlbnRpZmllciA9IG1fY3VycmVudEZvY3VzZWRFbGVtZW50SWRlbnRpZmll cjsKIAogICAgIGlmIChpczxMYWJlbGFibGVFbGVtZW50PigqZm9jdXNlZEVsZW1lbnQpKSB7Ci0g ICAgICAgIGF1dG8gbGFiZWxzID0gZG93bmNhc3Q8TGFiZWxhYmxlRWxlbWVudD4oKmZvY3VzZWRF bGVtZW50KS5sYWJlbHMoKTsKLSAgICAgICAgVmVjdG9yPFJlZjxFbGVtZW50Pj4gYXNzb2NpYXRl ZExhYmVsczsKLSAgICAgICAgZm9yICh1bnNpZ25lZCBpbmRleCA9IDA7IGluZGV4IDwgbGFiZWxz LT5sZW5ndGgoKTsgKytpbmRleCkgewotICAgICAgICAgICAgaWYgKGlzPEVsZW1lbnQ+KGxhYmVs cy0+aXRlbShpbmRleCkpICYmIGxhYmVscy0+aXRlbShpbmRleCktPnJlbmRlcmVyKCkpCi0gICAg ICAgICAgICAgICAgYXNzb2NpYXRlZExhYmVscy5hcHBlbmQoZG93bmNhc3Q8RWxlbWVudD4oKmxh YmVscy0+aXRlbShpbmRleCkpKTsKLSAgICAgICAgfQotICAgICAgICBmb3IgKGF1dG8mIGxhYmVs RWxlbWVudCA6IGFzc29jaWF0ZWRMYWJlbHMpIHsKLSAgICAgICAgICAgIGF1dG8gdGV4dCA9IGxh YmVsRWxlbWVudC0+aW5uZXJUZXh0KCk7Ci0gICAgICAgICAgICBpZiAoIXRleHQuaXNFbXB0eSgp KSB7Ci0gICAgICAgICAgICAgICAgaW5mb3JtYXRpb24ubGFiZWwgPSBXVEZNb3ZlKHRleHQpOwot ICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICBpZiAoYXV0byBsYWJlbHMgPSBkb3duY2Fz dDxMYWJlbGFibGVFbGVtZW50PigqZm9jdXNlZEVsZW1lbnQpLmxhYmVscygpKSB7CisgICAgICAg ICAgICBWZWN0b3I8UmVmPEVsZW1lbnQ+PiBhc3NvY2lhdGVkTGFiZWxzOworICAgICAgICAgICAg Zm9yICh1bnNpZ25lZCBpbmRleCA9IDA7IGluZGV4IDwgbGFiZWxzLT5sZW5ndGgoKTsgKytpbmRl eCkgeworICAgICAgICAgICAgICAgIGlmIChpczxFbGVtZW50PihsYWJlbHMtPml0ZW0oaW5kZXgp KSAmJiBsYWJlbHMtPml0ZW0oaW5kZXgpLT5yZW5kZXJlcigpKQorICAgICAgICAgICAgICAgICAg ICBhc3NvY2lhdGVkTGFiZWxzLmFwcGVuZChkb3duY2FzdDxFbGVtZW50PigqbGFiZWxzLT5pdGVt KGluZGV4KSkpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgZm9yIChhdXRvJiBsYWJlbEVs ZW1lbnQgOiBhc3NvY2lhdGVkTGFiZWxzKSB7CisgICAgICAgICAgICAgICAgYXV0byB0ZXh0ID0g bGFiZWxFbGVtZW50LT5pbm5lclRleHQoKTsKKyAgICAgICAgICAgICAgICBpZiAoIXRleHQuaXNF bXB0eSgpKSB7CisgICAgICAgICAgICAgICAgICAgIGluZm9ybWF0aW9uLmxhYmVsID0gV1RGTW92 ZSh0ZXh0KTsKKyAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgfQog ICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQo=