213795 2020-06-30 07:13:55 -0700 [ iOS Debug and Mojave Debug ] http/tests/storage/storage-map-leaking.html is flaky timing out. 2020-07-01 14:46:06 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Mac macOS 10.14 RESOLVED FIXED InRadar P2 Normal --- 1 Lawrence.j cdumez achristensen cdumez darin ggaren webkit-bot-watchers-bugzilla webkit-bug-importer ysuzuki oldest_to_newest 1667563 0 Lawrence.j 2020-06-30 07:13:55 -0700 http/tests/storage/storage-map-leaking.html Description: This test is flaky timing out on iOS Debug and Mojave Debug. The flaky timeouts initially appeared in the visible history on 06/29/2020. History: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fstorage%2Fstorage-map-leaking.html&style=debug&platform=ios&platform=mac&version_name=iOS%2013&version_name=Mojave&limit=50000 Diff: --- /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test-results/http/tests/storage/storage-map-leaking-expected.txt +++ /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test-results/http/tests/storage/storage-map-leaking-actual.txt @@ -1,10 +1,3 @@ -Make sure that StorageAreaMap objects do no leak. +#PID UNRESPONSIVE - WebKitTestRunnerApp (pid 50459) +FAIL: Timed out waiting for notifyDone to be called -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS StorageAreaMap objects are not leaking -PASS successfullyParsed is true - -TEST COMPLETE - 1667565 1 Lawrence.j 2020-06-30 07:24:30 -0700 I have marked this test as flaky timing out while this issue is investigated. https://trac.webkit.org/changeset/263747/webkit 1667566 2 webkit-bug-importer 2020-06-30 07:24:40 -0700 <rdar://problem/64937993> 1668030 3 403311 cdumez 2020-07-01 12:53:38 -0700 Created attachment 403311 Patch 1668031 4 403311 achristensen 2020-07-01 12:59:33 -0700 Comment on attachment 403311 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403311&action=review > LayoutTests/ChangeLog:9 > + Because our GC is conservative, a particular JS wrapper is not guaranteed to go away in a timely fashion. Couldn't we instead try gc multiple times, or make a way to completely gc, or gc until it succeeds? > LayoutTests/ChangeLog:11 > + We treat the test as passive if any of the 4 storage wrappers go away after removing the 4 subframes from passive -> passing 1668032 5 cdumez 2020-07-01 13:00:48 -0700 (In reply to Alex Christensen from comment #4) > Comment on attachment 403311 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=403311&action=review > > > LayoutTests/ChangeLog:9 > > + Because our GC is conservative, a particular JS wrapper is not guaranteed to go away in a timely fashion. > > Couldn't we instead try gc multiple times, or make a way to completely gc, > or gc until it succeeds? The test already called gc() repeatedly in a setInterval(). From what I have been told, this is still not sufficient but Geoff / Yusuke know these things better. > > > LayoutTests/ChangeLog:11 > > + We treat the test as passive if any of the 4 storage wrappers go away after removing the 4 subframes from > > passive -> passing 1668033 6 403312 cdumez 2020-07-01 13:01:15 -0700 Created attachment 403312 Patch 1668035 7 ggaren 2020-07-01 13:09:42 -0700 > > Couldn't we instead try gc multiple times, or make a way to completely gc, > > or gc until it succeeds? > > The test already called gc() repeatedly in a setInterval(). From what I have > been told, this is still not sufficient but Geoff / Yusuke know these things > better. Trying multiple objects is indeed the state of the art in WebKit GC testing. The good news is, it works -- even though it's a bit ugly. In addition to working around conservative GC, trying multiple objects also works around other implementation details like single element caches. If a single object sticks around for a bit, one could reasonably wonder if that's really a leak. If hundreds stick around, that's obviously a leak. 1668046 8 403312 darin 2020-07-01 13:19:46 -0700 Comment on attachment 403312 Patch Seems worth a try. Also seems worth a comment about why there need to be 4 and why these 4 hostnames will work. 1668058 9 403318 cdumez 2020-07-01 13:57:41 -0700 Created attachment 403318 Patch 1668059 10 cdumez 2020-07-01 13:59:35 -0700 (In reply to Darin Adler from comment #8) > Comment on attachment 403312 [details] > Patch > > Seems worth a try. Also seems worth a comment about why there need to be 4 > and why these 4 hostnames will work. Layout tests only support those 4 origins AFAIK. The objects we are worried about leaking are the StorageAreaMap and there is one of these per origin. Using more frames won't be useful because even though we'll get more Storage JS wrappers, they will share the same underlying StorageMap objects. 1668067 11 darin 2020-07-01 14:22:11 -0700 (In reply to Chris Dumez from comment #10) > Layout tests only support those 4 origins AFAIK. The objects we are worried > about leaking are the StorageAreaMap and there is one of these per origin. > Using more frames won't be useful because even though we'll get more Storage > JS wrappers, they will share the same underlying StorageMap objects. Yes, I meant leaving a comment behind in the test so people understand it. 1668068 12 darin 2020-07-01 14:22:26 -0700 (In reply to Darin Adler from comment #11) > Yes, I meant leaving a comment behind in the test so people understand it. Which you did. 1668073 13 ews-feeder 2020-07-01 14:46:06 -0700 Committed r263822: <https://trac.webkit.org/changeset/263822> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403318. 403311 2020-07-01 12:53:38 -0700 2020-07-01 13:01:13 -0700 Patch bug-213795-20200701125337.patch text/plain 4323 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzODE1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGYyMDQ3NmEwZjIxMjQ0MzQ4ZWUx MjU1MGY2MjQxOTA0OTVjMGYyMy4uZTQxOWYxZGUyNWQyZGVhODM0YjljMWUyYWMzMjAzYTVhZDI4 MTdlZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA3LTAxICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgWyBpT1MgRGVidWcgYW5kIE1vamF2ZSBEZWJ1ZyBd IGh0dHAvdGVzdHMvc3RvcmFnZS9zdG9yYWdlLW1hcC1sZWFraW5nLmh0bWwgaXMgZmxha3kgdGlt aW5nIG91dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMzc5NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQ5Mzc5OTM+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmVjYXVzZSBvdXIgR0MgaXMgY29u c2VydmF0aXZlLCBhIHBhcnRpY3VsYXIgSlMgd3JhcHBlciBpcyBub3QgZ3VhcmFudGVlZCB0byBn byBhd2F5IGluIGEgdGltZWx5IGZhc2hpb24uCisgICAgICAgIFRvIHRyeSBhbmQgbWFrZSB0aGUg dGVzdCBtb3JlIHJlbGlhYmxlLCB3ZSBub3cgdXNlIDQgc2VwYXJhdGUgU3RvcmFnZSB3cmFwcGVy cyBpbnN0ZWFkIG9mIGEgc2luZ2xlIG9uZS4KKyAgICAgICAgV2UgdHJlYXQgdGhlIHRlc3QgYXMg cGFzc2l2ZSBpZiBhbnkgb2YgdGhlIDQgc3RvcmFnZSB3cmFwcGVycyBnbyBhd2F5IGFmdGVyIHJl bW92aW5nIHRoZSA0IHN1YmZyYW1lcyBmcm9tCisgICAgICAgIDQgc2VwYXJhdGUgb3JpZ2lucy4K KworICAgICAgICAqIGh0dHAvdGVzdHMvc3RvcmFnZS9zdG9yYWdlLW1hcC1sZWFraW5nLmh0bWw6 CisgICAgICAgICogcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAq IHBsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAyMC0wNy0wMSAgS2FybCBS YWNrbGVyICA8cmFja2xlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGV4cGVjdGF0aW9u IGZvciBmYXN0L2V2ZW50cy9iZWZvcmUtaW5wdXQtZGVsZXRlLWVtcHR5LWxpc3QtdGFyZ2V0LXJh bmdlcy5odG1sIGFuZCBmYXN0L2V2ZW50cy9iZWZvcmUtaW5wdXQtZXZlbnRzLXByZXZlbnQtaW5z ZXJ0LWNvbXBvc2l0aW9uLmh0bWwgYW5kIGZhc3QvZXZlbnRzL2JlZm9yZS1pbnB1dC1ldmVudHMt cHJldmVudC1yZWNvbXBvc2l0aW9uLmh0bWwgYXMgdGhleSBhcmUgcGFzc2luZy4gCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3N0b3JhZ2Uvc3RvcmFnZS1tYXAtbGVha2luZy5o dG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zdG9yYWdlL3N0b3JhZ2UtbWFwLWxlYWtpbmcu aHRtbAppbmRleCA1NDdkMTlhYzA1NzEzYjRhZTdmNGY2ZGJkNjNjZmJjZDBhZWRlY2RjLi5hODM2 ZTJjMTdkZjdiMDMxYjYyNWNhODFkZDEzMWFjMDJhMjk1NmU2IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3N0b3JhZ2Uvc3RvcmFnZS1tYXAtbGVha2luZy5odG1sCisrKyBiL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvc3RvcmFnZS9zdG9yYWdlLW1hcC1sZWFraW5nLmh0bWwKQEAg LTEwLDcgKzEwLDEwIEBAIGxvY2FsU3RvcmFnZS5zZXRJdGVtKCJmb28iLCAiYmFyIik7CiBvbmxv YWQgPSBmdW5jdGlvbigpIHsKICAgICBpbml0aWFsU3RvcmFnZUFyZWFNYXBDb3VudCA9IGludGVy bmFscy5zdG9yYWdlQXJlYU1hcENvdW50OwogCi0gICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo InRlc3RGcmFtZSIpLnJlbW92ZSgpOworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0 RnJhbWUxIikucmVtb3ZlKCk7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RGcmFt ZTIiKS5yZW1vdmUoKTsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGVzdEZyYW1lMyIp LnJlbW92ZSgpOworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0RnJhbWU0IikucmVt b3ZlKCk7CiAKICAgICBoYW5kbGUgPSBzZXRJbnRlcnZhbCgoKSA9PiB7CiAgICAgICAgIGdjKCkK QEAgLTIyLDYgKzI1LDkgQEAgb25sb2FkID0gZnVuY3Rpb24oKSB7CiAgICAgfSwgMTApOwogfQog PC9zY3JpcHQ+Ci08aWZyYW1lIGlkPSJ0ZXN0RnJhbWUiIHNyYz0iaHR0cDovL2xvY2FsaG9zdDo4 MDAwL3N0b3JhZ2UvcmVzb3VyY2VzL3N0b3JhZ2UtbWFwLWxlYWtpbmctaWZyYW1lLmh0bWwiPjwv aWZyYW1lPgorPGlmcmFtZSBpZD0idGVzdEZyYW1lMSIgc3JjPSJodHRwOi8vbG9jYWxob3N0Ojgw MDAvc3RvcmFnZS9yZXNvdXJjZXMvc3RvcmFnZS1tYXAtbGVha2luZy1pZnJhbWUuaHRtbCI+PC9p ZnJhbWU+Cis8aWZyYW1lIGlkPSJ0ZXN0RnJhbWUyIiBzcmM9Imh0dHBzOi8vbG9jYWxob3N0Ojg0 NDMvc3RvcmFnZS9yZXNvdXJjZXMvc3RvcmFnZS1tYXAtbGVha2luZy1pZnJhbWUuaHRtbCI+PC9p ZnJhbWU+Cis8aWZyYW1lIGlkPSJ0ZXN0RnJhbWUzIiBzcmM9Imh0dHA6Ly8xMjcuMC4wLjE6ODQ0 My9zdG9yYWdlL3Jlc291cmNlcy9zdG9yYWdlLW1hcC1sZWFraW5nLWlmcmFtZS5odG1sIj48L2lm cmFtZT4KKzxpZnJhbWUgaWQ9InRlc3RGcmFtZTQiIHNyYz0iaHR0cHM6Ly8xMjcuMC4wLjE6ODQ0 My9zdG9yYWdlL3Jlc291cmNlcy9zdG9yYWdlLW1hcC1sZWFraW5nLWlmcmFtZS5odG1sIj48L2lm cmFtZT4KIDwvYm9keT4KIDwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2lvcy13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIv VGVzdEV4cGVjdGF0aW9ucwppbmRleCA1ZjQxYTgzYzRkM2RmZjdhYjg0MzljZGNhM2NhNDViZWYw ODljNTM4Li40ZjE4MzY3MTM2M2I5ZTBmYjM1ZjQ5MTJjYmE3YjBkNzU4NDhhOTA4IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC0xNzU4LDUg KzE3NTgsMyBAQCB3ZWJraXQub3JnL2IvMjEzNTIwIHBlcmYvaHRtbGNvbGxlY3Rpb24tYmFja3dh cmRzLWl0ZXJhdGlvbi5odG1sIFsgUGFzcyBGYWlsdXJlCiB3ZWJraXQub3JnL2IvMjEzNTUzIGh0 dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9ncmFuZGZhdGhlcmluZy1kYXRhYmFzZS5o dG1sIFsgUGFzcyBUaW1lb3V0IF0KIAogd2Via2l0Lm9yZy9iLzIxMzY1IGltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRkZWQtY29udGVudC90aGUtdmlk ZW8tZWxlbWVudC9pbnRyaW5zaWNfc2l6ZXMuaHRtIFsgUGFzcyBGYWlsdXJlIF0KLQotd2Via2l0 Lm9yZy9iLzIxMzc5NSBbIERlYnVnIF0gaHR0cC90ZXN0cy9zdG9yYWdlL3N0b3JhZ2UtbWFwLWxl YWtpbmcuaHRtbCBbIFBhc3MgVGltZW91dCBdClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25z IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGJh MDY4ODQ2ZjgwY2ZkYzI1NDQyOTcwNGNlZTliMDIzMmJhODk0ODQuLjg3MWI2MmY5M2Y5ZGJlOGM1 YjBjMjYzMmEyY2Y5NGYwYjYwYTY3NmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMt d2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTEwMzcsNSArMTAzNywzIEBAIHdlYmtpdC5vcmcvYi8y MTM1NTMgaHR0cC90ZXN0cy9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzL2dyYW5kZmF0aGVyaW5nLWRh dGFiYXNlLmh0CiB3ZWJraXQub3JnL2IvMjEzNjIxIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvd2VicnRjL1JUQ1J0cFJlY2VpdmVyLWdldENvbnRyaWJ1dGluZ1NvdXJjZXMuaHR0cHMu aHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8yMTM2NTIgd2VicnRjL3ZpZGVv LWF1dG9wbGF5MS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQotd2Via2l0Lm9yZy9iLzIxMzc5NSBb IE1vamF2ZSBEZWJ1ZyBdIGh0dHAvdGVzdHMvc3RvcmFnZS9zdG9yYWdlLW1hcC1sZWFraW5nLmh0 bWwgWyBQYXNzIFRpbWVvdXQgXQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK 403312 2020-07-01 13:01:15 -0700 2020-07-01 13:57:39 -0700 Patch bug-213795-20200701130114.patch text/plain 4323 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzODE1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGYyMDQ3NmEwZjIxMjQ0MzQ4ZWUx MjU1MGY2MjQxOTA0OTVjMGYyMy4uYjIzNzU5Y2FlZTUyYjFhMTFjYTY1MGIxZTAxZjUxNWI2NmM5 YWQxOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA3LTAxICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgWyBpT1MgRGVidWcgYW5kIE1vamF2ZSBEZWJ1ZyBd IGh0dHAvdGVzdHMvc3RvcmFnZS9zdG9yYWdlLW1hcC1sZWFraW5nLmh0bWwgaXMgZmxha3kgdGlt aW5nIG91dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMzc5NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQ5Mzc5OTM+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmVjYXVzZSBvdXIgR0MgaXMgY29u c2VydmF0aXZlLCBhIHBhcnRpY3VsYXIgSlMgd3JhcHBlciBpcyBub3QgZ3VhcmFudGVlZCB0byBn byBhd2F5IGluIGEgdGltZWx5IGZhc2hpb24uCisgICAgICAgIFRvIHRyeSBhbmQgbWFrZSB0aGUg dGVzdCBtb3JlIHJlbGlhYmxlLCB3ZSBub3cgdXNlIDQgc2VwYXJhdGUgU3RvcmFnZSB3cmFwcGVy cyBpbnN0ZWFkIG9mIGEgc2luZ2xlIG9uZS4KKyAgICAgICAgV2UgdHJlYXQgdGhlIHRlc3QgYXMg cGFzc2luZyBpZiBhbnkgb2YgdGhlIDQgc3RvcmFnZSB3cmFwcGVycyBnbyBhd2F5IGFmdGVyIHJl bW92aW5nIHRoZSA0IHN1YmZyYW1lcyBmcm9tCisgICAgICAgIDQgc2VwYXJhdGUgb3JpZ2lucy4K KworICAgICAgICAqIGh0dHAvdGVzdHMvc3RvcmFnZS9zdG9yYWdlLW1hcC1sZWFraW5nLmh0bWw6 CisgICAgICAgICogcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAq IHBsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAyMC0wNy0wMSAgS2FybCBS YWNrbGVyICA8cmFja2xlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGV4cGVjdGF0aW9u IGZvciBmYXN0L2V2ZW50cy9iZWZvcmUtaW5wdXQtZGVsZXRlLWVtcHR5LWxpc3QtdGFyZ2V0LXJh bmdlcy5odG1sIGFuZCBmYXN0L2V2ZW50cy9iZWZvcmUtaW5wdXQtZXZlbnRzLXByZXZlbnQtaW5z ZXJ0LWNvbXBvc2l0aW9uLmh0bWwgYW5kIGZhc3QvZXZlbnRzL2JlZm9yZS1pbnB1dC1ldmVudHMt cHJldmVudC1yZWNvbXBvc2l0aW9uLmh0bWwgYXMgdGhleSBhcmUgcGFzc2luZy4gCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3N0b3JhZ2Uvc3RvcmFnZS1tYXAtbGVha2luZy5o dG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zdG9yYWdlL3N0b3JhZ2UtbWFwLWxlYWtpbmcu aHRtbAppbmRleCA1NDdkMTlhYzA1NzEzYjRhZTdmNGY2ZGJkNjNjZmJjZDBhZWRlY2RjLi5hODM2 ZTJjMTdkZjdiMDMxYjYyNWNhODFkZDEzMWFjMDJhMjk1NmU2IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3N0b3JhZ2Uvc3RvcmFnZS1tYXAtbGVha2luZy5odG1sCisrKyBiL0xh eW91dFRlc3RzL2h0dHAvdGVzdHMvc3RvcmFnZS9zdG9yYWdlLW1hcC1sZWFraW5nLmh0bWwKQEAg LTEwLDcgKzEwLDEwIEBAIGxvY2FsU3RvcmFnZS5zZXRJdGVtKCJmb28iLCAiYmFyIik7CiBvbmxv YWQgPSBmdW5jdGlvbigpIHsKICAgICBpbml0aWFsU3RvcmFnZUFyZWFNYXBDb3VudCA9IGludGVy bmFscy5zdG9yYWdlQXJlYU1hcENvdW50OwogCi0gICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo InRlc3RGcmFtZSIpLnJlbW92ZSgpOworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0 RnJhbWUxIikucmVtb3ZlKCk7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RGcmFt ZTIiKS5yZW1vdmUoKTsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGVzdEZyYW1lMyIp LnJlbW92ZSgpOworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0RnJhbWU0IikucmVt b3ZlKCk7CiAKICAgICBoYW5kbGUgPSBzZXRJbnRlcnZhbCgoKSA9PiB7CiAgICAgICAgIGdjKCkK QEAgLTIyLDYgKzI1LDkgQEAgb25sb2FkID0gZnVuY3Rpb24oKSB7CiAgICAgfSwgMTApOwogfQog PC9zY3JpcHQ+Ci08aWZyYW1lIGlkPSJ0ZXN0RnJhbWUiIHNyYz0iaHR0cDovL2xvY2FsaG9zdDo4 MDAwL3N0b3JhZ2UvcmVzb3VyY2VzL3N0b3JhZ2UtbWFwLWxlYWtpbmctaWZyYW1lLmh0bWwiPjwv aWZyYW1lPgorPGlmcmFtZSBpZD0idGVzdEZyYW1lMSIgc3JjPSJodHRwOi8vbG9jYWxob3N0Ojgw MDAvc3RvcmFnZS9yZXNvdXJjZXMvc3RvcmFnZS1tYXAtbGVha2luZy1pZnJhbWUuaHRtbCI+PC9p ZnJhbWU+Cis8aWZyYW1lIGlkPSJ0ZXN0RnJhbWUyIiBzcmM9Imh0dHBzOi8vbG9jYWxob3N0Ojg0 NDMvc3RvcmFnZS9yZXNvdXJjZXMvc3RvcmFnZS1tYXAtbGVha2luZy1pZnJhbWUuaHRtbCI+PC9p ZnJhbWU+Cis8aWZyYW1lIGlkPSJ0ZXN0RnJhbWUzIiBzcmM9Imh0dHA6Ly8xMjcuMC4wLjE6ODQ0 My9zdG9yYWdlL3Jlc291cmNlcy9zdG9yYWdlLW1hcC1sZWFraW5nLWlmcmFtZS5odG1sIj48L2lm cmFtZT4KKzxpZnJhbWUgaWQ9InRlc3RGcmFtZTQiIHNyYz0iaHR0cHM6Ly8xMjcuMC4wLjE6ODQ0 My9zdG9yYWdlL3Jlc291cmNlcy9zdG9yYWdlLW1hcC1sZWFraW5nLWlmcmFtZS5odG1sIj48L2lm cmFtZT4KIDwvYm9keT4KIDwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L2lvcy13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIv VGVzdEV4cGVjdGF0aW9ucwppbmRleCA1ZjQxYTgzYzRkM2RmZjdhYjg0MzljZGNhM2NhNDViZWYw ODljNTM4Li40ZjE4MzY3MTM2M2I5ZTBmYjM1ZjQ5MTJjYmE3YjBkNzU4NDhhOTA4IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC0xNzU4LDUg KzE3NTgsMyBAQCB3ZWJraXQub3JnL2IvMjEzNTIwIHBlcmYvaHRtbGNvbGxlY3Rpb24tYmFja3dh cmRzLWl0ZXJhdGlvbi5odG1sIFsgUGFzcyBGYWlsdXJlCiB3ZWJraXQub3JnL2IvMjEzNTUzIGh0 dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9ncmFuZGZhdGhlcmluZy1kYXRhYmFzZS5o dG1sIFsgUGFzcyBUaW1lb3V0IF0KIAogd2Via2l0Lm9yZy9iLzIxMzY1IGltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRkZWQtY29udGVudC90aGUtdmlk ZW8tZWxlbWVudC9pbnRyaW5zaWNfc2l6ZXMuaHRtIFsgUGFzcyBGYWlsdXJlIF0KLQotd2Via2l0 Lm9yZy9iLzIxMzc5NSBbIERlYnVnIF0gaHR0cC90ZXN0cy9zdG9yYWdlL3N0b3JhZ2UtbWFwLWxl YWtpbmcuaHRtbCBbIFBhc3MgVGltZW91dCBdClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25z IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGJh MDY4ODQ2ZjgwY2ZkYzI1NDQyOTcwNGNlZTliMDIzMmJhODk0ODQuLjg3MWI2MmY5M2Y5ZGJlOGM1 YjBjMjYzMmEyY2Y5NGYwYjYwYTY3NmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L21hYy13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMt d2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTEwMzcsNSArMTAzNywzIEBAIHdlYmtpdC5vcmcvYi8y MTM1NTMgaHR0cC90ZXN0cy9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzL2dyYW5kZmF0aGVyaW5nLWRh dGFiYXNlLmh0CiB3ZWJraXQub3JnL2IvMjEzNjIxIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvd2VicnRjL1JUQ1J0cFJlY2VpdmVyLWdldENvbnRyaWJ1dGluZ1NvdXJjZXMuaHR0cHMu aHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8yMTM2NTIgd2VicnRjL3ZpZGVv LWF1dG9wbGF5MS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQotd2Via2l0Lm9yZy9iLzIxMzc5NSBb IE1vamF2ZSBEZWJ1ZyBdIGh0dHAvdGVzdHMvc3RvcmFnZS9zdG9yYWdlLW1hcC1sZWFraW5nLmh0 bWwgWyBQYXNzIFRpbWVvdXQgXQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK 403318 2020-07-01 13:57:41 -0700 2020-07-01 14:46:06 -0700 Patch bug-213795-20200701135740.patch text/plain 4671 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzODE5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGYyMDQ3NmEwZjIxMjQ0MzQ4ZWUx MjU1MGY2MjQxOTA0OTVjMGYyMy4uZWYyMzI0OTliMTMxOTZmMzk1MjgyYzUyYmIxZjc3NjljNDI3 NTU0OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA3LTAxICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgWyBpT1MgRGVidWcgYW5kIE1vamF2ZSBEZWJ1ZyBd IGh0dHAvdGVzdHMvc3RvcmFnZS9zdG9yYWdlLW1hcC1sZWFraW5nLmh0bWwgaXMgZmxha3kgdGlt aW5nIG91dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMzc5NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQ5Mzc5OTM+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgQmVjYXVzZSBvdXIgR0MgaXMgY29uc2Vy dmF0aXZlLCBhIHBhcnRpY3VsYXIgSlMgd3JhcHBlciBpcyBub3QgZ3VhcmFudGVlZCB0byBnbyBh d2F5IGluIGEgdGltZWx5IGZhc2hpb24uCisgICAgICAgIFRvIHRyeSBhbmQgbWFrZSB0aGUgdGVz dCBtb3JlIHJlbGlhYmxlLCB3ZSBub3cgdXNlIDQgc2VwYXJhdGUgU3RvcmFnZSB3cmFwcGVycyBp bnN0ZWFkIG9mIGEgc2luZ2xlIG9uZS4KKyAgICAgICAgV2UgdHJlYXQgdGhlIHRlc3QgYXMgcGFz c2luZyBpZiBhbnkgb2YgdGhlIDQgc3RvcmFnZSB3cmFwcGVycyBnbyBhd2F5IGFmdGVyIHJlbW92 aW5nIHRoZSA0IHN1YmZyYW1lcyBmcm9tCisgICAgICAgIDQgc2VwYXJhdGUgb3JpZ2lucy4KKwor ICAgICAgICAqIGh0dHAvdGVzdHMvc3RvcmFnZS9zdG9yYWdlLW1hcC1sZWFraW5nLmh0bWw6Cisg ICAgICAgICogcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIHBs YXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAyMC0wNy0wMSAgS2FybCBSYWNr bGVyICA8cmFja2xlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGV4cGVjdGF0aW9uIGZv ciBmYXN0L2V2ZW50cy9iZWZvcmUtaW5wdXQtZGVsZXRlLWVtcHR5LWxpc3QtdGFyZ2V0LXJhbmdl cy5odG1sIGFuZCBmYXN0L2V2ZW50cy9iZWZvcmUtaW5wdXQtZXZlbnRzLXByZXZlbnQtaW5zZXJ0 LWNvbXBvc2l0aW9uLmh0bWwgYW5kIGZhc3QvZXZlbnRzL2JlZm9yZS1pbnB1dC1ldmVudHMtcHJl dmVudC1yZWNvbXBvc2l0aW9uLmh0bWwgYXMgdGhleSBhcmUgcGFzc2luZy4gCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3N0b3JhZ2Uvc3RvcmFnZS1tYXAtbGVha2luZy5odG1s IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zdG9yYWdlL3N0b3JhZ2UtbWFwLWxlYWtpbmcuaHRt bAppbmRleCA1NDdkMTlhYzA1NzEzYjRhZTdmNGY2ZGJkNjNjZmJjZDBhZWRlY2RjLi5hMjI4NzYw NjViNTk1OGYzOTliMWFkMmFkZmM4OWY2ZjA2MzU5ZDgyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL3N0b3JhZ2Uvc3RvcmFnZS1tYXAtbGVha2luZy5odG1sCisrKyBiL0xheW91 dFRlc3RzL2h0dHAvdGVzdHMvc3RvcmFnZS9zdG9yYWdlLW1hcC1sZWFraW5nLmh0bWwKQEAgLTEw LDcgKzEwLDE0IEBAIGxvY2FsU3RvcmFnZS5zZXRJdGVtKCJmb28iLCAiYmFyIik7CiBvbmxvYWQg PSBmdW5jdGlvbigpIHsKICAgICBpbml0aWFsU3RvcmFnZUFyZWFNYXBDb3VudCA9IGludGVybmFs cy5zdG9yYWdlQXJlYU1hcENvdW50OwogCi0gICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRl c3RGcmFtZSIpLnJlbW92ZSgpOworICAgIC8vIFdlIHVzZSA0IGZyYW1lcywgb25lIHBlciBvcmln aW4gdGhhdCB3ZSBzdXBwb3J0IGluIGxheW91dCB0ZXN0cyBzbyB0aGF0IHdlIGdldCA0IFN0b3Jh Z2VBcmVhTWFwIG9iamVjdHMKKyAgICAvLyBhbmQgNCBTdG9yYWdlIEpTIHdyYXBwZXJzLiBCZWNh dXNlIG91ciBHQyBpcyBjb25zZXJ2YXRpdmUsIHdlIGNvbnNpZGVyIHRoYXQgdGhpcyB0ZXN0IGlz IHBhc3NpbmcgaWYKKyAgICAvLyBhbnkgb2YgdGhlIFN0b3JhZ2UgSlMgd3JhcHBlcnMgZ2V0cyBj b2xsZWN0ZWQgYW5kIHRodXMgYW55IG9mIHRoZSB1bmRlcmx5aW5nIFN0b3JhZ2VBcmVhTWFwIG9i amVjdHMKKyAgICAvLyBnZXQgZGVzdHJveWVkLgorICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJ0ZXN0RnJhbWUxIikucmVtb3ZlKCk7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRl c3RGcmFtZTIiKS5yZW1vdmUoKTsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGVzdEZy YW1lMyIpLnJlbW92ZSgpOworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0RnJhbWU0 IikucmVtb3ZlKCk7CiAKICAgICBoYW5kbGUgPSBzZXRJbnRlcnZhbCgoKSA9PiB7CiAgICAgICAg IGdjKCkKQEAgLTIyLDYgKzI5LDkgQEAgb25sb2FkID0gZnVuY3Rpb24oKSB7CiAgICAgfSwgMTAp OwogfQogPC9zY3JpcHQ+Ci08aWZyYW1lIGlkPSJ0ZXN0RnJhbWUiIHNyYz0iaHR0cDovL2xvY2Fs aG9zdDo4MDAwL3N0b3JhZ2UvcmVzb3VyY2VzL3N0b3JhZ2UtbWFwLWxlYWtpbmctaWZyYW1lLmh0 bWwiPjwvaWZyYW1lPgorPGlmcmFtZSBpZD0idGVzdEZyYW1lMSIgc3JjPSJodHRwOi8vbG9jYWxo b3N0OjgwMDAvc3RvcmFnZS9yZXNvdXJjZXMvc3RvcmFnZS1tYXAtbGVha2luZy1pZnJhbWUuaHRt bCI+PC9pZnJhbWU+Cis8aWZyYW1lIGlkPSJ0ZXN0RnJhbWUyIiBzcmM9Imh0dHBzOi8vbG9jYWxo b3N0Ojg0NDMvc3RvcmFnZS9yZXNvdXJjZXMvc3RvcmFnZS1tYXAtbGVha2luZy1pZnJhbWUuaHRt bCI+PC9pZnJhbWU+Cis8aWZyYW1lIGlkPSJ0ZXN0RnJhbWUzIiBzcmM9Imh0dHA6Ly8xMjcuMC4w LjE6ODQ0My9zdG9yYWdlL3Jlc291cmNlcy9zdG9yYWdlLW1hcC1sZWFraW5nLWlmcmFtZS5odG1s Ij48L2lmcmFtZT4KKzxpZnJhbWUgaWQ9InRlc3RGcmFtZTQiIHNyYz0iaHR0cHM6Ly8xMjcuMC4w LjE6ODQ0My9zdG9yYWdlL3Jlc291cmNlcy9zdG9yYWdlLW1hcC1sZWFraW5nLWlmcmFtZS5odG1s Ij48L2lmcmFtZT4KIDwvYm9keT4KIDwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2lvcy13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lv cy13azIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA1ZjQxYTgzYzRkM2RmZjdhYjg0MzljZGNhM2Nh NDViZWYwODljNTM4Li40ZjE4MzY3MTM2M2I5ZTBmYjM1ZjQ5MTJjYmE3YjBkNzU4NDhhOTA4IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC0x NzU4LDUgKzE3NTgsMyBAQCB3ZWJraXQub3JnL2IvMjEzNTIwIHBlcmYvaHRtbGNvbGxlY3Rpb24t YmFja3dhcmRzLWl0ZXJhdGlvbi5odG1sIFsgUGFzcyBGYWlsdXJlCiB3ZWJraXQub3JnL2IvMjEz NTUzIGh0dHAvdGVzdHMvcmVzb3VyY2VMb2FkU3RhdGlzdGljcy9ncmFuZGZhdGhlcmluZy1kYXRh YmFzZS5odG1sIFsgUGFzcyBUaW1lb3V0IF0KIAogd2Via2l0Lm9yZy9iLzIxMzY1IGltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRkZWQtY29udGVudC90 aGUtdmlkZW8tZWxlbWVudC9pbnRyaW5zaWNfc2l6ZXMuaHRtIFsgUGFzcyBGYWlsdXJlIF0KLQot d2Via2l0Lm9yZy9iLzIxMzc5NSBbIERlYnVnIF0gaHR0cC90ZXN0cy9zdG9yYWdlL3N0b3JhZ2Ut bWFwLWxlYWtpbmcuaHRtbCBbIFBhc3MgVGltZW91dCBdClwgTm8gbmV3bGluZSBhdCBlbmQgb2Yg ZmlsZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0 YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCmlu ZGV4IGJhMDY4ODQ2ZjgwY2ZkYzI1NDQyOTcwNGNlZTliMDIzMmJhODk0ODQuLjg3MWI2MmY5M2Y5 ZGJlOGM1YjBjMjYzMmEyY2Y5NGYwYjYwYTY3NmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTEwMzcsNSArMTAzNywzIEBAIHdlYmtpdC5v cmcvYi8yMTM1NTMgaHR0cC90ZXN0cy9yZXNvdXJjZUxvYWRTdGF0aXN0aWNzL2dyYW5kZmF0aGVy aW5nLWRhdGFiYXNlLmh0CiB3ZWJraXQub3JnL2IvMjEzNjIxIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvd2VicnRjL1JUQ1J0cFJlY2VpdmVyLWdldENvbnRyaWJ1dGluZ1NvdXJjZXMu aHR0cHMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8yMTM2NTIgd2VicnRj L3ZpZGVvLWF1dG9wbGF5MS5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQotd2Via2l0Lm9yZy9iLzIx Mzc5NSBbIE1vamF2ZSBEZWJ1ZyBdIGh0dHAvdGVzdHMvc3RvcmFnZS9zdG9yYWdlLW1hcC1sZWFr aW5nLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK