213769 2020-06-29 19:50:06 -0700 [TestExpectations] Add architecture for Apple's ports 2020-06-30 07:48:44 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=213761 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap ews-watchlist glenn webkit-bug-importer oldest_to_newest 1667431 0 jbedard 2020-06-29 19:50:06 -0700 Apple's ports need to support architecture modifiers in test expectations, this is particularly important for for supporting Apple Silicon. 1667433 1 webkit-bug-importer 2020-06-29 19:54:50 -0700 <rdar://problem/64920013> 1667439 2 403166 jbedard 2020-06-29 20:18:45 -0700 Created attachment 403166 Patch 1667441 3 jbedard 2020-06-29 20:19:56 -0700 Turns out, we already have support for this. We should still refactor our test expectation parser, it's far more complicated than it needs to be. 1667564 4 aakash_jain 2020-06-30 07:14:53 -0700 rs=me 1667567 5 403197 jbedard 2020-06-30 07:28:19 -0700 Created attachment 403197 Patch for landing 1667571 6 ews-feeder 2020-06-30 07:48:43 -0700 Committed r263749: <https://trac.webkit.org/changeset/263749> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403197. 403166 2020-06-29 20:18:45 -0700 2020-06-30 07:28:17 -0700 Patch bug-213769-20200629201844.patch text/plain 1379 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MzcyMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA2LTI5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbVGVzdEV4cGVjdGF0aW9uc10gQWRkIGFyY2hpdGVjdHVyZSBmb3IgQXBw bGUncyBwb3J0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjEzNzY5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NDkyMDAxMz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weToKKyAgICAgICAgKFRlc3RF eHBlY3RhdGlvblBhcnNlcik6IEFkZCBhcmNoaXRlY3R1cmVzIGZvciBBcHBsZSdzIHBvcnRzLgor CiAyMDIwLTA2LTI5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAg ICAgICBbVGVzdEV4cGVjdGF0aW9uc10gUmVtb3ZlIC0tY3N2IG9wdGlvbgpJbmRleDogVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVs cy90ZXN0X2V4cGVjdGF0aW9ucy5weQkocmV2aXNpb24gMjYzNzE5KQorKysgVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC0yMjksNiArMjI5LDcgQEAgY2xhc3MgVGVzdEV4cGVjdGF0aW9uUGFyc2Vy KG9iamVjdCk6CiAgICAgX2NvbmZpZ3VyYXRpb25fdG9rZW5zX2xpc3QgPSBbCiAgICAgICAgICdT bm93TGVvcGFyZCcsICdMaW9uJywgJ01vdW50YWluTGlvbicsICdNYXZlcmlja3MnLCAnWW9zZW1p dGUnLCAnRWxDYXBpdGFuJywgIyBMZWdhY3kgbWFjT1MKICAgICAgICAgJ01hYycsICdTaWVycmEn LCAnSGlnaFNpZXJyYScsICdNb2phdmUnLCAnQ2F0YWxpbmEnLCAnQmlnU3VyJywKKyAgICAgICAg J3g4Nl82NCcsICd4ODYnLCAnYXJtNjQnLCAnYXJtNjRfMzInLCAnYXJtdjdrJywKICAgICAgICAg J1dpbicsICdYUCcsICdWaXN0YScsICdXaW43JywKICAgICAgICAgJ0xpbnV4JywKICAgICAgICAg J0FuZHJvaWQnLAo= 403197 2020-06-30 07:28:19 -0700 2020-06-30 07:48:44 -0700 Patch for landing bug-213769-20200630072818.patch text/plain 1382 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MzcyMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA2LTI5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbVGVzdEV4cGVjdGF0aW9uc10gQWRkIGFyY2hpdGVjdHVyZSBmb3IgQXBw bGUncyBwb3J0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjEzNzY5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NDkyMDAxMz4KKworICAgICAgICBS dWJiZXItc3RhbXBlZCBieSBBYWthc2ggSmFpbi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weToKKyAgICAgICAgKFRl c3RFeHBlY3RhdGlvblBhcnNlcik6IEFkZCBhcmNoaXRlY3R1cmVzIGZvciBBcHBsZSdzIHBvcnRz LgorCiAyMDIwLTA2LTI5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAog ICAgICAgICBbVGVzdEV4cGVjdGF0aW9uc10gUmVtb3ZlIC0tY3N2IG9wdGlvbgpJbmRleDogVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25z LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21v ZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weQkocmV2aXNpb24gMjYzNzE5KQorKysgVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CSh3 b3JraW5nIGNvcHkpCkBAIC0yMjksNiArMjI5LDcgQEAgY2xhc3MgVGVzdEV4cGVjdGF0aW9uUGFy c2VyKG9iamVjdCk6CiAgICAgX2NvbmZpZ3VyYXRpb25fdG9rZW5zX2xpc3QgPSBbCiAgICAgICAg ICdTbm93TGVvcGFyZCcsICdMaW9uJywgJ01vdW50YWluTGlvbicsICdNYXZlcmlja3MnLCAnWW9z ZW1pdGUnLCAnRWxDYXBpdGFuJywgIyBMZWdhY3kgbWFjT1MKICAgICAgICAgJ01hYycsICdTaWVy cmEnLCAnSGlnaFNpZXJyYScsICdNb2phdmUnLCAnQ2F0YWxpbmEnLCAnQmlnU3VyJywKKyAgICAg ICAgJ3g4Nl82NCcsICd4ODYnLCAnYXJtNjQnLCAnYXJtNjRfMzInLCAnYXJtdjdrJywKICAgICAg ICAgJ1dpbicsICdYUCcsICdWaXN0YScsICdXaW43JywKICAgICAgICAgJ0xpbnV4JywKICAgICAg ICAgJ0FuZHJvaWQnLAo=