213739 2020-06-29 09:44:25 -0700 [css-flexbox] Don't include scrollbar extents when computing sizes for percentage resolution 2020-07-01 03:45:02 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 213809 1 svillar svillar changseok esprehn+autocc ews-watchlist glenn jfernandez kondapallykalyan pdr rego webkit-bug-importer oldest_to_newest 1667151 0 svillar 2020-06-29 09:44:25 -0700 [css-flexbox] Don't include scrollbar extents when computing sizes for percentage resolution 1667153 1 403075 svillar 2020-06-29 09:47:27 -0700 Created attachment 403075 Patch 1667279 2 jfernandez 2020-06-29 14:33:43 -0700 Please, make sure the patch is not the cause of some of the flakiness detected by the mac2 bots: fast/scrolling/mac/scroll-snapping-in-progress.html 1667501 3 403075 rego 2020-06-30 01:05:02 -0700 Comment on attachment 403075 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403075&action=review BTW, about the confusion regarding storing something different than what its name says, in Chromium the solution for that was https://chromium-review.googlesource.com/c/chromium/src/+/1024171/, maybe we should try to port that or something similar into WebKit. > LayoutTests/ChangeLog:8 > + * TestExpectations: Unskipped percentage-heights-004.html. The test is only for heights, wouldn't we need a test for widths too? You're changing both things in the code in I'm not getting it wrong. 1667505 4 svillar 2020-06-30 01:22:26 -0700 (In reply to Javier Fernandez from comment #2) > Please, make sure the patch is not the cause of some of the flakiness > detected by the mac2 bots: > > fast/scrolling/mac/scroll-snapping-in-progress.html That's failing without the patch as well. 1667606 5 svillar 2020-06-30 10:23:05 -0700 (In reply to Manuel Rego Casasnovas from comment #3) > Comment on attachment 403075 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=403075&action=review > > BTW, about the confusion regarding storing something different than what its > name says, in Chromium the solution for that was > https://chromium-review.googlesource.com/c/chromium/src/+/1024171/, maybe we > should try to port that or something similar into WebKit. > > > LayoutTests/ChangeLog:8 > > + * TestExpectations: Unskipped percentage-heights-004.html. > > The test is only for heights, wouldn't we need a test for widths too? You're > changing both things in the code in I'm not getting it wrong. Now that you mention it, the width paths are not reachable. I'll post a prequel patch to remove them. 1667888 6 svillar 2020-07-01 03:41:11 -0700 Committed r263794: <https://trac.webkit.org/changeset/263794> 1667889 7 webkit-bug-importer 2020-07-01 03:42:14 -0700 <rdar://problem/64980642> 1667890 8 svillar 2020-07-01 03:45:02 -0700 (In reply to Manuel Rego Casasnovas from comment #3) > Comment on attachment 403075 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=403075&action=review > > BTW, about the confusion regarding storing something different than what its > name says, in Chromium the solution for that was > https://chromium-review.googlesource.com/c/chromium/src/+/1024171/, maybe we > should try to port that or something similar into WebKit. > > > LayoutTests/ChangeLog:8 > > + * TestExpectations: Unskipped percentage-heights-004.html. > > The test is only for heights, wouldn't we need a test for widths too? You're > changing both things in the code in I'm not getting it wrong. After landing bug 213809 there is no need to test widths as those code paths were not reachable and thus they're removed. 403075 2020-06-29 09:47:27 -0700 2020-06-29 14:30:57 -0700 Patch bug-213739-20200629184726.patch text/plain 4930 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODc2MWFiMDQyYzc3MjNl M2ZiYTJmN2RlMmZmZTVjM2JjZmY3ZjU3Ni4uOTBlODk1MTc1M2ZiOWU3M2U4NWNkOWYxYzExOGJi MDhjMmIxY2QzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA2LTI5ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZmxl eGJveF0gRG9uJ3QgaW5jbHVkZSBzY3JvbGxiYXIgZXh0ZW50cyB3aGVuIGNvbXB1dGluZyBzaXpl cyBmb3IgcGVyY2VudGFnZSByZXNvbHV0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM3MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDb250ZW50IG92ZXJyaWRlIHNpemVzIGRvIGluY2x1ZGUgc2Ny b2xsYmFycyBzbyB0aGV5IG11c3QgYmUgc3Vic3RyYWN0ZWQgd2hlbiB1c2luZyB0aGUgb3ZlcnJp ZGUgc2l6ZQorICAgICAgICB0byBjb21wdXRlIHBlcmNlbnRhZ2VzLgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckZs ZXhpYmxlQm94Ojpjcm9zc1NpemVGb3JQZXJjZW50YWdlUmVzb2x1dGlvbik6IFJlbW92ZSBzY3Jv bGxiYXJzLgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxleGlibGVCb3g6Om1haW5TaXplRm9y UGVyY2VudGFnZVJlc29sdXRpb24pOiBEaXR0by4KKwogMjAyMC0wNi0yOSAgQ2hyaXMgRHVtZXog IDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIE9uIGxvYWQgZnJvbSBiYWNrL2ZvcndhcmQg Y2FjaGUsIGNhbGwgY2hlY2tDb21wbGV0ZWQoKSBmb3IgQUxMIGZyYW1lcyBpbnNpZGUgRnJhbWVM b2FkZXI6OmNvbW1pdFByb3Zpc2lvbmFsTG9hZCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcAppbmRleCBhY2FmZGZkMDg0NWUzMmQ0NmNjNTI2M2Zi ODJkNjE0NmJlOTM4YjNlLi5mNDM0NDE1MGE5N2MxMTNlMzExNDZjNTdhNGRjN2ZkNmU1ZmZkYTJl IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxleGlibGVCb3gu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAK QEAgLTExNjYsOSArMTE2Niw5IEBAIE9wdGlvbmFsPExheW91dFVuaXQ+IFJlbmRlckZsZXhpYmxl Qm94Ojpjcm9zc1NpemVGb3JQZXJjZW50YWdlUmVzb2x1dGlvbihjb25zdCBSCiAKICAgICAvLyBI ZXJlIHdlIGltcGxlbWVudCBodHRwczovL2RyYWZ0cy5jc3N3Zy5vcmcvY3NzLWZsZXhib3gvI2Fs Z28tc3RyZXRjaAogICAgIGlmIChoYXNPcnRob2dvbmFsRmxvdyhjaGlsZCkgJiYgY2hpbGQuaGFz T3ZlcnJpZGVDb250ZW50TG9naWNhbFdpZHRoKCkpCi0gICAgICAgIHJldHVybiBjaGlsZC5vdmVy cmlkZUNvbnRlbnRMb2dpY2FsV2lkdGgoKTsKKyAgICAgICAgcmV0dXJuIGNoaWxkLm92ZXJyaWRl Q29udGVudExvZ2ljYWxXaWR0aCgpIC0gY2hpbGQuc2Nyb2xsYmFyTG9naWNhbFdpZHRoKCk7CiAg ICAgaWYgKCFoYXNPcnRob2dvbmFsRmxvdyhjaGlsZCkgJiYgY2hpbGQuaGFzT3ZlcnJpZGVDb250 ZW50TG9naWNhbEhlaWdodCgpKQotICAgICAgICByZXR1cm4gY2hpbGQub3ZlcnJpZGVDb250ZW50 TG9naWNhbEhlaWdodCgpOworICAgICAgICByZXR1cm4gY2hpbGQub3ZlcnJpZGVDb250ZW50TG9n aWNhbEhlaWdodCgpIC0gY2hpbGQuc2Nyb2xsYmFyTG9naWNhbEhlaWdodCgpOwogICAgIAogICAg IC8vIFdlIGRvbid0IGN1cnJlbnRseSBpbXBsZW1lbnQgdGhlIG9wdGltaXphdGlvbiBmcm9tCiAg ICAgLy8gaHR0cHM6Ly9kcmFmdHMuY3Nzd2cub3JnL2Nzcy1mbGV4Ym94LyNkZWZpbml0ZS1zaXpl cyBjYXNlIDEuIFdoaWxlIHRoYXQKQEAgLTExODgsOCArMTE4OCw4IEBAIE9wdGlvbmFsPExheW91 dFVuaXQ+IFJlbmRlckZsZXhpYmxlQm94OjptYWluU2l6ZUZvclBlcmNlbnRhZ2VSZXNvbHV0aW9u KGNvbnN0IFJlCiAgICAgICAgIHJldHVybiBXVEY6Om51bGxvcHQ7CiAKICAgICBpZiAoaGFzT3J0 aG9nb25hbEZsb3coY2hpbGQpKQotICAgICAgICByZXR1cm4gY2hpbGQuaGFzT3ZlcnJpZGVDb250 ZW50TG9naWNhbEhlaWdodCgpID8gT3B0aW9uYWw8TGF5b3V0VW5pdD4oY2hpbGQub3ZlcnJpZGVD b250ZW50TG9naWNhbEhlaWdodCgpKSA6IFdURjo6bnVsbG9wdDsKLSAgICByZXR1cm4gY2hpbGQu aGFzT3ZlcnJpZGVDb250ZW50TG9naWNhbFdpZHRoKCkgPyBPcHRpb25hbDxMYXlvdXRVbml0Pihj aGlsZC5vdmVycmlkZUNvbnRlbnRMb2dpY2FsV2lkdGgoKSkgOiBXVEY6Om51bGxvcHQ7CisgICAg ICAgIHJldHVybiBjaGlsZC5oYXNPdmVycmlkZUNvbnRlbnRMb2dpY2FsSGVpZ2h0KCkgPyBPcHRp b25hbDxMYXlvdXRVbml0PihjaGlsZC5vdmVycmlkZUNvbnRlbnRMb2dpY2FsSGVpZ2h0KCkgLSBj aGlsZC5zY3JvbGxiYXJMb2dpY2FsSGVpZ2h0KCkpIDogV1RGOjpudWxsb3B0OworICAgIHJldHVy biBjaGlsZC5oYXNPdmVycmlkZUNvbnRlbnRMb2dpY2FsV2lkdGgoKSA/IE9wdGlvbmFsPExheW91 dFVuaXQ+KGNoaWxkLm92ZXJyaWRlQ29udGVudExvZ2ljYWxXaWR0aCgpIC0gY2hpbGQuc2Nyb2xs YmFyTG9naWNhbFdpZHRoKCkpIDogV1RGOjpudWxsb3B0OwogfQogCiBPcHRpb25hbDxMYXlvdXRV bml0PiBSZW5kZXJGbGV4aWJsZUJveDo6Y2hpbGRMb2dpY2FsSGVpZ2h0Rm9yUGVyY2VudGFnZVJl c29sdXRpb24oY29uc3QgUmVuZGVyQm94JiBjaGlsZCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3NmU2OWRiYzFmODViM2Y4 MGM5NmUwYTMwNDhkMGNjZGY4MTM0YmIzLi5hNmVhZDQ5ZDBiZThlMzBiMzk1NmUzZmRhOWVlNWYz Mzg0ZGI5NzhjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDYtMjkgIFNlcmdpbyBWaWxs YXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW2Nzcy1mbGV4Ym94XSBE b24ndCBpbmNsdWRlIHNjcm9sbGJhciBleHRlbnRzIHdoZW4gY29tcHV0aW5nIHNpemVzIGZvciBw ZXJjZW50YWdlIHJlc29sdXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxMzczOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVGVzdEV4cGVjdGF0aW9uczogVW5za2lwcGVkIHBlcmNlbnRhZ2UtaGVp Z2h0cy0wMDQuaHRtbC4KKwogMjAyMC0wNi0yOSAgS2FybCBSYWNrbGVyICA8cmFja2xlckBhcHBs ZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIGV4cGVjdGF0aW9uIGZvciBpbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2NvcnMvcHJlZmxpZ2h0LWZhaWx1cmUuaHRtIGFuZCBpbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2NvcnMvc3RhdHVzLWFzeW5jLmh0bSBhcyB0aGV5IGFyZSBw YXNzaW5nLiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlv dXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDM2OTZiOTQ3NjhiN2I0ODY1ZDNlYTYzZmI4 OGM2ZGI3ZGQ4MjgyYmMuLmIyNWM5ZjA1NWM4MGZkNDM2NGIzYzU0MTQzNTI4ZDZhYzU3ZmU5MTkg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVz dHMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNDI3NSw3ICs0Mjc1LDYgQEAgd2Via2l0Lm9yZy9iLzIx MjA0NiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZmxleGJveC9mbGV4 LW1pbmltdW0KIHdlYmtpdC5vcmcvYi8yMTIwNDYgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9jc3MvY3NzLWZsZXhib3gvb3ZlcmZsb3ctYXJlYS0wMDEuaHRtbCBbIEltYWdlT25seUZh aWx1cmUgXQogd2Via2l0Lm9yZy9iLzIxMjA0NiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2Nzcy9jc3MtZmxleGJveC9vdmVyZmxvdy1hcmVhLTAwMi5odG1sIFsgSW1hZ2VPbmx5RmFp bHVyZSBdCiB3ZWJraXQub3JnL2IvMjEyMDQ2IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvY3NzL2Nzcy1mbGV4Ym94L292ZXJmbG93LWF1dG8tMDA1Lmh0bWwgWyBJbWFnZU9ubHlGYWls dXJlIF0KLXdlYmtpdC5vcmcvYi8yMTIwNDYgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0 cy9jc3MvY3NzLWZsZXhib3gvcGVyY2VudGFnZS1oZWlnaHRzLTAwNC5odG1sIFsgSW1hZ2VPbmx5 RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjEyMDQ2IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvY3NzL2Nzcy1mbGV4Ym94L3BlcmNlbnRhZ2UtaGVpZ2h0cy0wMDcuaHRtbCBbIEltYWdl T25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzIxMjA0NiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL2Nzcy9jc3MtZmxleGJveC9wZXJjZW50YWdlLWhlaWdodHMtMDE0Lmh0bWwgWyBJ bWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMTIwNDYgaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWZsZXhib3gvcGVyY2VudGFnZS1zaXplLXN1Yml0ZW1zLTAw MS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCg==