213729 2020-06-29 07:33:39 -0700 REGRESSION(r263626): 2 imported/w3c/web-platform-tests/cors/ tests failing constantly 2020-06-29 10:52:10 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jacob_uphoff webkit-unassigned cdumez webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1667085 0 jacob_uphoff 2020-06-29 07:33:39 -0700 imported/w3c/web-platform-tests/cors/credentials-flag.htm imported/w3c/web-platform-tests/cors/origin.htm These tests became a constant failure after commit r263626 for Catalina and iOS 13. History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcors%2Fcredentials-flag.htm Diff: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/cors/credentials-flag-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/cors/credentials-flag-actual.txt @@ -14,6 +14,6 @@ PASS Access-Control-Allow-Credentials: 0 should be disallowed (async) PASS Access-Control-Allow-Credentials: ,true should be disallowed (async) PASS Access-Control-Allow-Credentials: true, should be disallowed (async) -FAIL Access-Control-Allow-Credentials: true%0B should be disallowed (async) assert_unreached: onload Reached unreachable code -FAIL Access-Control-Allow-Credentials: true%0C should be disallowed (async) assert_unreached: onload Reached unreachable code +PASS Access-Control-Allow-Credentials: true%0B should be disallowed (async) +PASS Access-Control-Allow-Credentials: true%0C should be disallowed (async) --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/cors/origin-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/cors/origin-actual.txt @@ -33,11 +33,11 @@ PASS Disallow origin: ,* PASS Disallow origin: *, PASS Disallow origin: \0* -FAIL Disallow origin: * assert_throws_dom: send function "function () { client.send() }" did not throw -FAIL Disallow origin: * assert_throws_dom: send function "function () { client.send() }" did not throw +PASS Disallow origin: * +PASS Disallow origin: * PASS Disallow origin: *\0 -FAIL Disallow origin: * assert_throws_dom: send function "function () { client.send() }" did not throw -FAIL Disallow origin: * assert_throws_dom: send function "function () { client.send() }" did not throw +PASS Disallow origin: * +PASS Disallow origin: * PASS Disallow origin: '*' PASS Disallow origin: "*" PASS Disallow origin: * * 1667086 1 cdumez 2020-06-29 07:34:39 -0700 Looks like they need to be rebaselined. 1667087 2 cdumez 2020-06-29 07:38:25 -0700 Committed r263661: <https://trac.webkit.org/changeset/263661> 1667186 3 ryanhaddad 2020-06-29 10:52:10 -0700 (In reply to Chris Dumez from comment #2) > Committed r263661: <https://trac.webkit.org/changeset/263661> This caused failures on Mojave, so I added a baseline for that OS in https://trac.webkit.org/changeset/263667/webkit.