213690 2020-06-27 20:40:11 -0700 REGRESSION (r262776): Leak of NSMutableURLRequest in -[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:] 2020-06-29 03:54:40 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 211999 213059 1 ddkilzer ddkilzer achristensen andersca rwlbuis webkit-bug-importer oldest_to_newest 1666833 0 ddkilzer 2020-06-27 20:40:11 -0700 Leak of NSMutableURLRequest in -[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]: + if (equalLettersIgnoringASCIICase(m_handle->firstRequest().httpMethod(), "post") && !m_handle->firstRequest().hasHTTPHeaderField(HTTPHeaderName::ContentType)) { + NSMutableURLRequest *modifiedRequest = [newRequest mutableCopy]; + [modifiedRequest setValue:nil forHTTPHeaderField:@"Content-Type"]; + return modifiedRequest; // LEAK: This variable needs to be autoreleased. + } Regressed with: Bug 211999: XMLHTTPRequest.send should not send Content-Type headers when Blob has no type <https://bugs.webkit.org/show_bug.cgi?id=211999> <https://trac.webkit.org/r262776> 1666834 1 webkit-bug-importer 2020-06-27 20:40:37 -0700 <rdar://problem/64853619> 1666835 2 402980 ddkilzer 2020-06-27 20:43:36 -0700 Created attachment 402980 Patch v1 1667052 3 ews-feeder 2020-06-29 03:54:39 -0700 Committed r263653: <https://trac.webkit.org/changeset/263653> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402980. 402980 2020-06-27 20:43:36 -0700 2020-06-29 03:54:40 -0700 Patch v1 bug-213690-20200627204627.patch text/plain 2411 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjNmYjNlZWVhOGI1MDk3 NzViNTY3NjJmMDUzZjFjYzk4NTc0MmFjZC4uZDQ0Y2RmYTBjNzQ0MzBlNzMxN2VlZmJjZGI0ODhk MjFiMDAyNjg2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA2LTI3ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI2 Mjc3Nik6IExlYWsgb2YgTlNNdXRhYmxlVVJMUmVxdWVzdCBpbiAtW1dlYkNvcmVSZXNvdXJjZUhh bmRsZUFzT3BlcmF0aW9uUXVldWVEZWxlZ2F0ZSBjb25uZWN0aW9uOndpbGxTZW5kUmVxdWVzdDpy ZWRpcmVjdFJlc3BvbnNlOl0KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIxMzY5MD4K KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY0ODUzNjE5PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9tYWMvV2ViQ29y ZVJlc291cmNlSGFuZGxlQXNPcGVyYXRpb25RdWV1ZURlbGVnYXRlLm1tOgorICAgICAgICAoLVtX ZWJDb3JlUmVzb3VyY2VIYW5kbGVBc09wZXJhdGlvblF1ZXVlRGVsZWdhdGUgY29ubmVjdGlvbjp3 aWxsU2VuZFJlcXVlc3Q6cmVkaXJlY3RSZXNwb25zZTpdKToKKyAgICAgICAgLSBVc2UgUmV0YWlu UHRyPD4gZm9yIHRoZSBtdXRhYmxlIGNvcHkgYW5kIGF1dG9yZWxlYXNlIHRoZQorICAgICAgICAg IHJldHVybiB2YWx1ZS4KKwogMjAyMC0wNi0yNiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxl LmNvbT4KIAogICAgICAgICBDUkFTSDogaW5jb21wYXRpYmxlIGRvd25jYXN0PD4gb3BlcmF0aW9u IGluIFNvdXJjZUJ1ZmZlclByaXZhdGVBVkZPYmpDOjpzZXRDRE1JbnN0YW5jZSgpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9XZWJDb3JlUmVzb3VyY2VI YW5kbGVBc09wZXJhdGlvblF1ZXVlRGVsZWdhdGUubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL21hYy9XZWJDb3JlUmVzb3VyY2VIYW5kbGVBc09wZXJhdGlvblF1ZXVlRGVsZWdh dGUubW0KaW5kZXggNWFkNmUxN2ZmNDI1YTJlNjVjYThlY2FiMTg4ZjE4MTEyNzNlOTI4OC4uYzMz NDQxOWY2ZGZiZDk2ZDQ5ZTI4YWI1YjYyMWI0MmIyMzMyZmQ2OSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvV2ViQ29yZVJlc291cmNlSGFuZGxlQXNPcGVy YXRpb25RdWV1ZURlbGVnYXRlLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvbWFjL1dlYkNvcmVSZXNvdXJjZUhhbmRsZUFzT3BlcmF0aW9uUXVldWVEZWxlZ2F0ZS5tbQpA QCAtMTI0LDkgKzEyNCw5IEBAIC0gKE5TVVJMUmVxdWVzdCAqKWNvbm5lY3Rpb246KE5TVVJMQ29u bmVjdGlvbiAqKWNvbm5lY3Rpb24gd2lsbFNlbmRSZXF1ZXN0OihOU1VSCiAgICAgaWYgKCFyZWRp cmVjdFJlc3BvbnNlKSB7CiAgICAgICAgIC8vIENGTmV0d29yayB3aWxsIGFkZCAiYXBwbGljYXRp b24veC13d3ctZm9ybS11cmxlbmNvZGVkIiBjb250ZW50LXR5cGUgZm9yIFBPU1QsIGV2ZW4gaWYg bm8gQ29udGVudC1UeXBlIHdhcyBzcGVjaWZpZWQsIHJlbW92ZSBpdCBpbiB0aGF0IGNhc2UuCiAg ICAgICAgIGlmIChtX2hhbmRsZSAmJiBlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShtX2hh bmRsZS0+Zmlyc3RSZXF1ZXN0KCkuaHR0cE1ldGhvZCgpLCAicG9zdCIpICYmICFtX2hhbmRsZS0+ Zmlyc3RSZXF1ZXN0KCkuaGFzSFRUUEhlYWRlckZpZWxkKEhUVFBIZWFkZXJOYW1lOjpDb250ZW50 VHlwZSkpIHsKLSAgICAgICAgICAgIE5TTXV0YWJsZVVSTFJlcXVlc3QgKm1vZGlmaWVkUmVxdWVz dCA9IFtuZXdSZXF1ZXN0IG11dGFibGVDb3B5XTsKLSAgICAgICAgICAgIFttb2RpZmllZFJlcXVl c3Qgc2V0VmFsdWU6bmlsIGZvckhUVFBIZWFkZXJGaWVsZDpAIkNvbnRlbnQtVHlwZSJdOwotICAg ICAgICAgICAgcmV0dXJuIG1vZGlmaWVkUmVxdWVzdDsKKyAgICAgICAgICAgIGF1dG8gbXV0YWJs ZU1vZGlmaWVkUmVxdWVzdCA9IGFkb3B0TlMoW25ld1JlcXVlc3QgbXV0YWJsZUNvcHldKTsKKyAg ICAgICAgICAgIFttdXRhYmxlTW9kaWZpZWRSZXF1ZXN0IHNldFZhbHVlOm5pbCBmb3JIVFRQSGVh ZGVyRmllbGQ6QCJDb250ZW50LVR5cGUiXTsKKyAgICAgICAgICAgIHJldHVybiBtdXRhYmxlTW9k aWZpZWRSZXF1ZXN0LmF1dG9yZWxlYXNlKCk7CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuIG5l d1JlcXVlc3Q7CiAgICAgfQo=