21369 2008-10-04 11:06:25 -0700 Add opcode documentation for all undocumented opcodes 2008-10-04 13:33:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich zwarich oldest_to_newest 94088 0 zwarich 2008-10-04 11:06:25 -0700 I have a patch to do this. 94089 1 24089 zwarich 2008-10-04 11:08:20 -0700 Created attachment 24089 Proposed patch 94095 2 24089 darin 2008-10-04 13:24:24 -0700 Comment on attachment 24089 Proposed patch Should we use the single word "callframe" or two words "call frame"? r=me 94098 3 zwarich 2008-10-04 13:33:15 -0700 Landed in r37294, with 'callframe' changed to 'call frame' to match our camelization, but we do use the former in comments as well. 24089 2008-10-04 11:08:20 -0700 2008-10-04 13:24:24 -0700 Proposed patch docs.diff text/plain 6493 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3Mjkw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMDgtMTAt MDQgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMTM2OTogQWRkIG9wY29kZSBk b2N1bWVudGF0aW9uIGZvciBhbGwgdW5kb2N1bWVudGVkIG9wY29kZXMKKyAgICAgICAgPGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM2OT4KKworICAgICAgICBUaGlz IHBhdGNoIGFkZHMgb3Bjb2RlIGRvY3VtZW50YXRpb24gZm9yIGFsbCB1bmRvY3VtZW50ZWQgb3Bj b2RlcywgYW5kCisgICAgICAgIGl0IGFsc28gcmVuYW1lcyBvcF9pbml0X2FyZ3VtZW50cyB0byBv cF9jcmVhdGVfYXJndW1lbnRzLgorCisgICAgICAgICogVk0vQ1RJLmNwcDoKKyAgICAgICAgKEpT Qzo6Q1RJOjpwcml2YXRlQ29tcGlsZU1haW5QYXNzKToKKyAgICAgICAgKiBWTS9Db2RlQmxvY2su Y3BwOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6OmR1bXApOgorICAgICAgICAqIFZNL0NvZGVH ZW5lcmF0b3IuY3BwOgorICAgICAgICAoSlNDOjpDb2RlR2VuZXJhdG9yOjpDb2RlR2VuZXJhdG9y KToKKyAgICAgICAgKiBWTS9NYWNoaW5lLmNwcDoKKyAgICAgICAgKEpTQzo6TWFjaGluZTo6cHJp dmF0ZUV4ZWN1dGUpOgorICAgICAgICAoSlNDOjpNYWNoaW5lOjpjdGlfb3BfY3JlYXRlX2FyZ3Vt ZW50cyk6CisgICAgICAgICogVk0vTWFjaGluZS5oOgorICAgICAgICAqIFZNL09wY29kZS5oOgor CiAyMDA4LTEwLTAzICBNYWNpZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQ2FtZXJvbiBad2FyaWNoLgpJbmRleDogVk0vQ1RJLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBWTS9DVEkuY3BwCShyZXZpc2lvbiAzNzI5MCkKKysrIFZNL0NUSS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTE5ODgsOCArMTk4OCw4IEBAIHZvaWQgQ1RJOjpwcml2YXRlQ29tcGlsZU1h aW5QYXNzKCkKICAgICAgICAgICAgIGkrPSAxOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg IH0KLSAgICAgICAgY2FzZSBvcF9pbml0X2FyZ3VtZW50czogewotICAgICAgICAgICAgZW1pdENh bGwoaSwgTWFjaGluZTo6Y3RpX29wX2luaXRfYXJndW1lbnRzKTsKKyAgICAgICAgY2FzZSBvcF9j cmVhdGVfYXJndW1lbnRzOiB7CisgICAgICAgICAgICBlbWl0Q2FsbChpLCBNYWNoaW5lOjpjdGlf b3BfY3JlYXRlX2FyZ3VtZW50cyk7CiAgICAgICAgICAgICBpICs9IDE7CiAgICAgICAgICAgICBi cmVhazsKICAgICAgICAgfQpJbmRleDogVk0vQ29kZUJsb2NrLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBW TS9Db2RlQmxvY2suY3BwCShyZXZpc2lvbiAzNzI5MCkKKysrIFZNL0NvZGVCbG9jay5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTM1Niw4ICszNTYsOCBAQCB2b2lkIENvZGVCbG9jazo6ZHVtcChFeGVj U3RhdGUqIGV4ZWMsIGNvCiAgICAgICAgICAgICBwcmludGYoIlslNGRdIGVudGVyX3dpdGhfYWN0 aXZhdGlvblxuIiwgbG9jYXRpb24pOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KLSAg ICAgICAgY2FzZSBvcF9pbml0X2FyZ3VtZW50czogewotICAgICAgICAgICAgcHJpbnRmKCJbJTRk XSBpbml0X2FyZ3VtZW50c1xuIiwgbG9jYXRpb24pOworICAgICAgICBjYXNlIG9wX2NyZWF0ZV9h cmd1bWVudHM6IHsKKyAgICAgICAgICAgIHByaW50ZigiWyU0ZF0gY3JlYXRlX2FyZ3VtZW50c1xu IiwgbG9jYXRpb24pOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICAgICAgY2Fz ZSBvcF9jb252ZXJ0X3RoaXM6IHsKSW5kZXg6IFZNL0NvZGVHZW5lcmF0b3IuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFZNL0NvZGVHZW5lcmF0b3IuY3BwCShyZXZpc2lvbiAzNzI5MCkKKysrIFZNL0NvZGVH ZW5lcmF0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOTUsNyArMjk1LDcgQEAgQ29kZUdlbmVy YXRvcjo6Q29kZUdlbmVyYXRvcihGdW5jdGlvbkJvZAogICAgIGJvb2wgdXNlc0FyZ3VtZW50cyA9 IGZ1bmN0aW9uQm9keS0+dXNlc0FyZ3VtZW50cygpOwogICAgIGNvZGVCbG9jay0+dXNlc0FyZ3Vt ZW50cyA9IHVzZXNBcmd1bWVudHM7CiAgICAgaWYgKHVzZXNBcmd1bWVudHMpIHsKLSAgICAgICAg ZW1pdE9wY29kZShvcF9pbml0X2FyZ3VtZW50cyk7CisgICAgICAgIGVtaXRPcGNvZGUob3BfY3Jl YXRlX2FyZ3VtZW50cyk7CiAgICAgICAgIG1fYXJndW1lbnRzUmVnaXN0ZXIuc2V0SW5kZXgoUmVn aXN0ZXJGaWxlOjpPcHRpb25hbENhbGxlZUFyZ3VtZW50cyk7CiAgICAgICAgIGFkZFZhcihwcm9w ZXJ0eU5hbWVzKCkuYXJndW1lbnRzLCBmYWxzZSk7CiAgICAgfQpJbmRleDogVk0vTWFjaGluZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gVk0vTWFjaGluZS5jcHAJKHJldmlzaW9uIDM3MjkwKQorKysgVk0v TWFjaGluZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzNDIsNyArMzM0Miw3IEBAIEpTVmFsdWUq IE1hY2hpbmU6OnByaXZhdGVFeGVjdXRlKEV4ZWN1dGkKICAgICAgICAgICAgcmVzdG9yZSB0aGUg c2NvcGUgY2hhaW4sIGNvZGUgYmxvY2sgaW5zdHJ1Y3Rpb24gcG9pbnRlciBhbmQKICAgICAgICAg ICAgcmVnaXN0ZXIgYmFzZSB0byB0aG9zZSBvZiB0aGUgY2FsbGluZyBmdW5jdGlvbi4KICAgICAg ICAgKi8KLSAgICAgICAgICAgCisKICAgICAgICAgaW50IHJlc3VsdCA9ICgrK3ZQQyktPnUub3Bl cmFuZDsKIAogICAgICAgICAvLyBJZiB0aGlzIGNhbGwgZnJhbWUgY3JlYXRlZCBhbiBhY3RpdmF0 aW9uIG9yIGFuICdhcmd1bWVudHMnIG9iamVjdCwgdGVhciBpdCBvZmYuCkBAIC0zMzc2LDYgKzMz NzYsMTYgQEAgSlNWYWx1ZSogTWFjaGluZTo6cHJpdmF0ZUV4ZWN1dGUoRXhlY3V0aQogICAgICAg ICBORVhUX09QQ09ERTsKICAgICB9CiAgICAgQkVHSU5fT1BDT0RFKG9wX2VudGVyKSB7CisgICAg ICAgIC8qIGVudGVyCisKKyAgICAgICAgICAgSW5pdGlhbGl6ZXMgbG9jYWwgdmFyaWFibGVzIHRv IHVuZGVmaW5lZCBhbmQgZmlsbHMgY29uc3RhbnQKKyAgICAgICAgICAgcmVnaXN0ZXJzIHdpdGgg dGhlaXIgdmFsdWVzLiBJZiB0aGUgY29kZSBibG9jayByZXF1aXJlcyBhbgorICAgICAgICAgICBh Y3RpdmF0aW9uLCBlbnRlcl93aXRoX2FjdGl2YXRpb24gc2hvdWxkIGJlIHVzZWQgaW5zdGVhZC4K KworICAgICAgICAgICBUaGlzIG9wY29kZSBzaG91bGQgb25seSBiZSB1c2VkIGF0IHRoZSBiZWdp bm5pbmcgb2YgYSBjb2RlCisgICAgICAgICAgIGJsb2NrLgorICAgICAgICAqLworCiAgICAgICAg IHNpemVfdCBpID0gMDsKICAgICAgICAgQ29kZUJsb2NrKiBjb2RlQmxvY2sgPSB0aGlzLT5jb2Rl QmxvY2socik7CiAgICAgICAgIApAQCAtMzM4OSw2ICszMzk5LDE5IEBAIEpTVmFsdWUqIE1hY2hp bmU6OnByaXZhdGVFeGVjdXRlKEV4ZWN1dGkKICAgICAgICAgTkVYVF9PUENPREU7CiAgICAgfQog ICAgIEJFR0lOX09QQ09ERShvcF9lbnRlcl93aXRoX2FjdGl2YXRpb24pIHsKKyAgICAgICAgLyog ZW50ZXJfd2l0aF9hY3RpdmF0aW9uCisKKyAgICAgICAgICAgSW5pdGlhbGl6ZXMgbG9jYWwgdmFy aWFibGVzIHRvIHVuZGVmaW5lZCwgZmlsbHMgY29uc3RhbnQKKyAgICAgICAgICAgcmVnaXN0ZXJz IHdpdGggdGhlaXIgdmFsdWVzLCBjcmVhdGVzIGFuIGFjdGl2YXRpb24gb2JqZWN0LAorICAgICAg ICAgICBhbmQgcGxhY2VzIHRoZSBuZXcgYWN0aXZhdGlvbiBib3RoIGluIHRoZSBhY3RpdmF0aW9u IHNsb3QKKyAgICAgICAgICAgaW4gdGhlIGNhbGxmcmFtZSBhbmQgYXQgdGhlIHRvcCBvZiB0aGUg c2NvcGUgY2hhaW4uIElmIHRoZQorICAgICAgICAgICBjb2RlIGJsb2NrIGRvZXMgbm90IHJlcXVp cmUgYW4gYWN0aXZhdGlvbiwgZW50ZXIgc2hvdWxkIGJlCisgICAgICAgICAgIHVzZWQgaW5zdGVh ZC4KKworICAgICAgICAgICBUaGlzIG9wY29kZSBzaG91bGQgb25seSBiZSB1c2VkIGF0IHRoZSBi ZWdpbm5pbmcgb2YgYSBjb2RlCisgICAgICAgICAgIGJsb2NrLgorICAgICAgICAqLworCiAgICAg ICAgIHNpemVfdCBpID0gMDsKICAgICAgICAgQ29kZUJsb2NrKiBjb2RlQmxvY2sgPSB0aGlzLT5j b2RlQmxvY2socik7CiAKQEAgLTM0MTQsNyArMzQzNywxNyBAQCBKU1ZhbHVlKiBNYWNoaW5lOjpw cml2YXRlRXhlY3V0ZShFeGVjdXRpCiAgICAgICAgICsrdlBDOwogICAgICAgICBORVhUX09QQ09E RTsKICAgICB9Ci0gICAgQkVHSU5fT1BDT0RFKG9wX2luaXRfYXJndW1lbnRzKSB7CisgICAgQkVH SU5fT1BDT0RFKG9wX2NyZWF0ZV9hcmd1bWVudHMpIHsKKyAgICAgICAgLyogY3JlYXRlX2FyZ3Vt ZW50cworCisgICAgICAgICAgIENyZWF0ZXMgdGhlICdhcmd1bWVudHMnIG9iamVjdCBhbmQgcGxh Y2VzIGl0IGluIGJvdGggdGhlCisgICAgICAgICAgICdhcmd1bWVudHMnIGNhbGxmcmFtZSBzbG90 IGFuZCB0aGUgbG9jYWwgJ2FyZ3VtZW50cycKKyAgICAgICAgICAgcmVnaXN0ZXIuCisKKyAgICAg ICAgICAgVGhpcyBvcGNvZGUgc2hvdWxkIG9ubHkgYmUgdXNlZCBhdCB0aGUgYmVnaW5uaW5nIG9m IGEgY29kZQorICAgICAgICAgICBibG9jay4KKyAgICAgICAgKi8KKwogICAgICAgICBKU1ZhbHVl KiBhY3RpdmF0aW9uID0gcltSZWdpc3RlckZpbGU6Ok9wdGlvbmFsQ2FsbGVlQWN0aXZhdGlvbl0u Z2V0SlNWYWx1ZSgpOwogICAgICAgICBBcmd1bWVudHMqIGFyZ3VtZW50czsKICAgICAgICAgaWYg KGFjdGl2YXRpb24pIHsKQEAgLTQ2MjUsNyArNDY1OCw3IEBAIEpTVmFsdWUqIE1hY2hpbmU6OmN0 aV9vcF9jYWxsX05vdEpTRnVuY3QKICAgICByZXR1cm4gMDsKIH0KIAotdm9pZCBNYWNoaW5lOjpj dGlfb3BfaW5pdF9hcmd1bWVudHMoQ1RJX0FSR1MpCit2b2lkIE1hY2hpbmU6OmN0aV9vcF9jcmVh dGVfYXJndW1lbnRzKENUSV9BUkdTKQogewogICAgIEV4ZWNTdGF0ZSogZXhlYyA9IEFSR19leGVj OwogICAgIFJlZ2lzdGVyKiByID0gQVJHX3I7CkluZGV4OiBWTS9NYWNoaW5lLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVk0vTWFjaGluZS5oCShyZXZpc2lvbiAzNzI5MCkKKysrIFZNL01hY2hpbmUuaAkod29y a2luZyBjb3B5KQpAQCAtMTY0LDcgKzE2NCw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBz dGF0aWMgSlNWYWx1ZSogU0ZYX0NBTEwgY3RpX29wX25ld19mdW5jKENUSV9BUkdTKTsKICAgICAg ICAgc3RhdGljIHZvaWQqIFNGWF9DQUxMIGN0aV9vcF9jYWxsX0pTRnVuY3Rpb24oQ1RJX0FSR1Mp OwogICAgICAgICBzdGF0aWMgSlNWYWx1ZSogU0ZYX0NBTEwgY3RpX29wX2NhbGxfTm90SlNGdW5j dGlvbihDVElfQVJHUyk7Ci0gICAgICAgIHN0YXRpYyB2b2lkIFNGWF9DQUxMIGN0aV9vcF9pbml0 X2FyZ3VtZW50cyhDVElfQVJHUyk7CisgICAgICAgIHN0YXRpYyB2b2lkIFNGWF9DQUxMIGN0aV9v cF9jcmVhdGVfYXJndW1lbnRzKENUSV9BUkdTKTsKICAgICAgICAgc3RhdGljIHZvaWQgU0ZYX0NB TEwgY3RpX29wX3JldF9hY3RpdmF0aW9uX2FyZ3VtZW50cyhDVElfQVJHUyk7CiAgICAgICAgIHN0 YXRpYyB2b2lkIFNGWF9DQUxMIGN0aV9vcF9yZXRfcHJvZmlsZXIoQ1RJX0FSR1MpOwogICAgICAg ICBzdGF0aWMgdm9pZCBTRlhfQ0FMTCBjdGlfb3BfcmV0X3Njb3BlQ2hhaW4oQ1RJX0FSR1MpOwpJ bmRleDogVk0vT3Bjb2RlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVk0vT3Bjb2RlLmgJKHJldmlzaW9uIDM3 MjkwKQorKysgVk0vT3Bjb2RlLmgJKHdvcmtpbmcgY29weSkKQEAgLTQyLDcgKzQyLDcgQEAgbmFt ZXNwYWNlIEpTQyB7CiAgICAgI2RlZmluZSBGT1JfRUFDSF9PUENPREVfSUQobWFjcm8pIFwKICAg ICAgICAgbWFjcm8ob3BfZW50ZXIpIFwKICAgICAgICAgbWFjcm8ob3BfZW50ZXJfd2l0aF9hY3Rp dmF0aW9uKSBcCi0gICAgICAgIG1hY3JvKG9wX2luaXRfYXJndW1lbnRzKSBcCisgICAgICAgIG1h Y3JvKG9wX2NyZWF0ZV9hcmd1bWVudHMpIFwKICAgICAgICAgbWFjcm8ob3BfY29udmVydF90aGlz KSBcCiAgICAgICAgIFwKICAgICAgICAgbWFjcm8ob3BfdW5leHBlY3RlZF9sb2FkKSBcCg==