213671 2020-06-26 18:06:56 -0700 Unable to select multiple lines of vertical text correctly 2020-08-01 01:02:10 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner darin wenson_hsieh oldest_to_newest 1666704 0 megan_gardner 2020-06-26 18:06:56 -0700 Unable to select multiple lines of vertial text correclty. 1666706 1 402937 megan_gardner 2020-06-26 18:13:55 -0700 Created attachment 402937 Patch 1666707 2 megan_gardner 2020-06-26 18:14:19 -0700 <rdar://problem/53753636> 1666801 3 402937 wenson_hsieh 2020-06-27 12:01:07 -0700 Comment on attachment 402937 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402937&action=review It would also be nice to add a new layout test for this, as well. > Source/WebKit/ChangeLog:3 > + Unable to select multiple lines of vertial text correclty. Nits - vertial => vertical correclty => correctly > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1501 > + if (existingSelection.rootEditableElement()->computedStyle()->isVerticalWritingMode()) { Wouldn't this only work when the selection is in editable content? I think this will also crash when trying to move selection handles in non-editable text on iOS :P We probably want to check the RenderStyle of the container node of the base VisiblePosition instead. 1676975 4 405741 megan_gardner 2020-07-31 14:36:37 -0700 Created attachment 405741 Patch 1676977 5 405741 darin 2020-07-31 14:43:51 -0700 Comment on attachment 405741 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405741&action=review > Source/WebKit/ChangeLog:14 > + In order to make for a better text selection experience, we pulled the selection position > + down to be on the last line selectable, rather than snap the selection to a single position. > + This made for a better selection experience on small text, but we failed to take > + vertical text into account, and a user is locked into only selecting vertical text that ends below the > + other anchor point of the selection. We should have the same behavior for vertical text, but correctly > + calculated for X instead of Y. Can we create a regression test? > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1497 > + WebCore::Node *node = selectionStart.deepEquivalent().containerNode(); auto node = or WebCore::Node* node = 1676995 6 405741 megan_gardner 2020-07-31 15:15:41 -0700 Comment on attachment 405741 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405741&action=review >> Source/WebKit/ChangeLog:14 >> + calculated for X instead of Y. > > Can we create a regression test? The selection test infrastructure is currently broken by changes in UIKit. There are plans to change how those tests are written, and I will add a test with those changes. 1677006 7 405748 megan_gardner 2020-07-31 15:27:32 -0700 Created attachment 405748 Patch 1677092 8 405772 megan_gardner 2020-08-01 00:34:09 -0700 Created attachment 405772 Patch for landing 1677102 9 ews-feeder 2020-08-01 01:02:09 -0700 Committed r265174: <https://trac.webkit.org/changeset/265174> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405772. 402937 2020-06-26 18:13:55 -0700 2020-07-31 14:36:35 -0700 Patch bug-213671-20200626181354.patch text/plain 3189 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEyZDU2NzAyODQ2OWVhYzBi ODIxNTlhOGZjZjIxZmVjNWJmYmNmMTQuLjJiYTBkMTA0OTFjZmQzOGIwYWNiNmI0ZDA5ZTJiOTJi MjE0OTdhZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMDYtMjYgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBVbmFibGUgdG8gc2Vs ZWN0IG11bHRpcGxlIGxpbmVzIG9mIHZlcnRpYWwgdGV4dCBjb3JyZWNsdHkuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM2NzEKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzUzNzUzNjM2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEluIG9yZGVyIHRvIG1ha2UgZm9yIGEgYmV0dGVyIHRleHQgc2VsZWN0 aW9uIGV4cGVyaWVuY2UsIHdlIHB1bGxlZCB0aGUgc2VsZWN0aW9uIHBvc2l0aW9uIAorICAgICAg ICBkb3duIHRvIGJlIG9uIHRoZSBsYXN0IGxpbmUgc2VsZWN0YWJsZSwgcmF0aGVyIHRoYW4gc25h cCB0aGUgc2VsZWN0aW9uIHRvIGEgc2luZ2xlIHBvc2l0aW9uLgorICAgICAgICBUaGlzIG1hZGUg Zm9yIGEgYmV0dGVyIHNlbGVjdGlvbiBleHBlcmllbmNlIG9uIHNtYWxsIHRleHQsIGJ1dCB3ZSBm YWlsZWQgdG8gdGFrZQorICAgICAgICB2ZXJ0aWNhbCB0ZXh0IGludG8gYWNjb3VudCwgYW5kIGEg dXNlciBpcyBsb2NrZWQgaW50byBvbmx5IHNlbGVjdGluZyB2ZXJ0aWNhbCB0ZXh0IHRoYXQgZW5k cyBiZWxvdyB0aGUKKyAgICAgICAgb3RoZXIgYW5jaG9yIHBvaW50IG9mIHRoZSBzZWxlY3Rpb24u IFdlIHNob3VsZCBoYXZlIHRoZSBzYW1lIGJlaGF2aW9yIGZvciB2ZXJ0aWNhbCB0ZXh0LCBidXQg Y29ycmVjdGx5IAorICAgICAgICBjYWxjdWxhdGVkIGZvciBYIGluc3RlYWQgb2YgWS4KKworICAg ICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdl YktpdDo6cmFuZ2VGb3JQb2ludEluUm9vdFZpZXdDb29yZGluYXRlcyk6CisKIDIwMjAtMDYtMjUg IERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIC1fcmVx dWVzdFRleHRJbnB1dENvbnRleHRzSW5SZWN0IGNhbm5vdCBmaW5kIGVtcHR5IFF1aXAgc3ByZWFk c2hlZXQgdGl0bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdl L2lvcy9XZWJQYWdlSU9TLm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9z L1dlYlBhZ2VJT1MubW0KaW5kZXggZGRiMjM2Yjg3ZGQ3MDA4MTE0OTNkMTFkMjkxZDFhYjQ1NDg5 NGM3Zi4uMGYwZjM4NGM0YzM5YTFjMmE0YjE3OTMyNTBhOTUwNWIzYzQ5YjJkNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KKysr IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KQEAg LTE0OTcsMTUgKzE0OTcsMjcgQEAgc3RhdGljIFJlZlB0cjxSYW5nZT4gcmFuZ2VGb3JQb2ludElu Um9vdFZpZXdDb29yZGluYXRlcyhGcmFtZSYgZnJhbWUsIGNvbnN0IEludFAKICAgICBWaXNpYmxl UG9zaXRpb24gc2VsZWN0aW9uRW5kID0gZXhpc3RpbmdTZWxlY3Rpb24udmlzaWJsZUVuZCgpOwog CiAgICAgYXV0byBwb2ludEluRG9jdW1lbnQgPSBmcmFtZS52aWV3KCktPnJvb3RWaWV3VG9Db250 ZW50cyhwb2ludEluUm9vdFZpZXdDb29yZGluYXRlcyk7Ci0KLSAgICBpZiAoYmFzZUlzU3RhcnQp IHsKLSAgICAgICAgaW50IHN0YXJ0WSA9IHNlbGVjdGlvblN0YXJ0LmFic29sdXRlQ2FyZXRCb3Vu ZHMoKS5jZW50ZXIoKS55KCk7Ci0gICAgICAgIGlmIChwb2ludEluRG9jdW1lbnQueSgpIDwgc3Rh cnRZKQotICAgICAgICAgICAgcG9pbnRJbkRvY3VtZW50LnNldFkoc3RhcnRZKTsKKyAgICAKKyAg ICBpZiAoZXhpc3RpbmdTZWxlY3Rpb24ucm9vdEVkaXRhYmxlRWxlbWVudCgpLT5jb21wdXRlZFN0 eWxlKCktPmlzVmVydGljYWxXcml0aW5nTW9kZSgpKSB7CisgICAgICAgIGlmIChiYXNlSXNTdGFy dCkgeworICAgICAgICAgICAgaW50IHN0YXJ0WCA9IHNlbGVjdGlvblN0YXJ0LmFic29sdXRlQ2Fy ZXRCb3VuZHMoKS5jZW50ZXIoKS54KCk7CisgICAgICAgICAgICBpZiAocG9pbnRJbkRvY3VtZW50 LngoKSA+IHN0YXJ0WCkKKyAgICAgICAgICAgICAgICBwb2ludEluRG9jdW1lbnQuc2V0WChzdGFy dFgpOworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgaW50IGVuZFggPSBzZWxlY3Rpb25F bmQuYWJzb2x1dGVDYXJldEJvdW5kcygpLmNlbnRlcigpLngoKTsKKyAgICAgICAgICAgIGlmIChw b2ludEluRG9jdW1lbnQueCgpIDwgZW5kWCkKKyAgICAgICAgICAgICAgICBwb2ludEluRG9jdW1l bnQuc2V0WChlbmRYKTsKKyAgICAgICAgfQogICAgIH0gZWxzZSB7Ci0gICAgICAgIGludCBlbmRZ ID0gc2VsZWN0aW9uRW5kLmFic29sdXRlQ2FyZXRCb3VuZHMoKS5jZW50ZXIoKS55KCk7Ci0gICAg ICAgIGlmIChwb2ludEluRG9jdW1lbnQueSgpID4gZW5kWSkKLSAgICAgICAgICAgIHBvaW50SW5E b2N1bWVudC5zZXRZKGVuZFkpOworICAgICAgICBpZiAoYmFzZUlzU3RhcnQpIHsKKyAgICAgICAg ICAgIGludCBzdGFydFkgPSBzZWxlY3Rpb25TdGFydC5hYnNvbHV0ZUNhcmV0Qm91bmRzKCkuY2Vu dGVyKCkueSgpOworICAgICAgICAgICAgaWYgKHBvaW50SW5Eb2N1bWVudC55KCkgPCBzdGFydFkp CisgICAgICAgICAgICAgICAgcG9pbnRJbkRvY3VtZW50LnNldFkoc3RhcnRZKTsKKyAgICAgICAg fSBlbHNlIHsKKyAgICAgICAgICAgIGludCBlbmRZID0gc2VsZWN0aW9uRW5kLmFic29sdXRlQ2Fy ZXRCb3VuZHMoKS5jZW50ZXIoKS55KCk7CisgICAgICAgICAgICBpZiAocG9pbnRJbkRvY3VtZW50 LnkoKSA+IGVuZFkpCisgICAgICAgICAgICAgICAgcG9pbnRJbkRvY3VtZW50LnNldFkoZW5kWSk7 CisgICAgICAgIH0KICAgICB9CiAgICAgCiAgICAgVmlzaWJsZVBvc2l0aW9uIHJlc3VsdDsK 405741 2020-07-31 14:36:37 -0700 2020-08-01 00:34:06 -0700 Patch bug-213671-20200731143636.patch text/plain 3388 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIyZjYxYWZmN2ZkNTVjNWYw OTA5NmJmNGU0YjNlMGYwM2EyZWM0NGYuLjdjZDEyNzJjNTExMGZlMmNjNDgwMzAxZjUzZTQ5ZTc5 MDFhNzZjNjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMDctMzEgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBVbmFibGUgdG8gc2Vs ZWN0IG11bHRpcGxlIGxpbmVzIG9mIHZlcnRpY2FsIHRleHQgY29ycmVjdGx5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM2NzEKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzUzNzUzNjM2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEluIG9yZGVyIHRvIG1ha2UgZm9yIGEgYmV0dGVyIHRleHQgc2VsZWN0 aW9uIGV4cGVyaWVuY2UsIHdlIHB1bGxlZCB0aGUgc2VsZWN0aW9uIHBvc2l0aW9uIAorICAgICAg ICBkb3duIHRvIGJlIG9uIHRoZSBsYXN0IGxpbmUgc2VsZWN0YWJsZSwgcmF0aGVyIHRoYW4gc25h cCB0aGUgc2VsZWN0aW9uIHRvIGEgc2luZ2xlIHBvc2l0aW9uLgorICAgICAgICBUaGlzIG1hZGUg Zm9yIGEgYmV0dGVyIHNlbGVjdGlvbiBleHBlcmllbmNlIG9uIHNtYWxsIHRleHQsIGJ1dCB3ZSBm YWlsZWQgdG8gdGFrZQorICAgICAgICB2ZXJ0aWNhbCB0ZXh0IGludG8gYWNjb3VudCwgYW5kIGEg dXNlciBpcyBsb2NrZWQgaW50byBvbmx5IHNlbGVjdGluZyB2ZXJ0aWNhbCB0ZXh0IHRoYXQgZW5k cyBiZWxvdyB0aGUKKyAgICAgICAgb3RoZXIgYW5jaG9yIHBvaW50IG9mIHRoZSBzZWxlY3Rpb24u IFdlIHNob3VsZCBoYXZlIHRoZSBzYW1lIGJlaGF2aW9yIGZvciB2ZXJ0aWNhbCB0ZXh0LCBidXQg Y29ycmVjdGx5IAorICAgICAgICBjYWxjdWxhdGVkIGZvciBYIGluc3RlYWQgb2YgWS4KKworICAg ICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdl YktpdDo6cmFuZ2VGb3JQb2ludEluUm9vdFZpZXdDb29yZGluYXRlcyk6CisKIDIwMjAtMDctMzAg IFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbWVtYmVy IHRvIGNoZWNrIGVudGl0bGVtZW50IGJlZm9yZSBjb21tdW5pY2F0aW5nIG92ZXIgWFBDCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5t bSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCmlu ZGV4IGU1M2U3N2E3MGJhNTBkMmM1Y2ZmMmY3MDMwZWU0NWM0ZTBkOTNhNTAuLjFjY2E4MDQ1OTk5 OWJlMWY4MDU3YmU3ZGMwMjMyN2E5OWMyMWNhODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBAIC0xMDcsNiArMTA3LDcgQEAK ICNpbXBvcnQgPFdlYkNvcmUvTWVkaWFTZXNzaW9uTWFuYWdlcklPUy5oPgogI2ltcG9ydCA8V2Vi Q29yZS9Ob2RlLmg+CiAjaW1wb3J0IDxXZWJDb3JlL05vZGVMaXN0Lmg+CisjaW1wb3J0IDxXZWJD b3JlL05vZGVSZW5kZXJTdHlsZS5oPgogI2ltcG9ydCA8V2ViQ29yZS9Ob3RJbXBsZW1lbnRlZC5o PgogI2ltcG9ydCA8V2ViQ29yZS9QYWdlLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1Bhc3RlYm9hcmQu aD4KQEAgLTE0OTMsMTQgKzE0OTQsMjcgQEAgc3RhdGljIE9wdGlvbmFsPFNpbXBsZVJhbmdlPiBy YW5nZUZvclBvaW50SW5Sb290Vmlld0Nvb3JkaW5hdGVzKEZyYW1lJiBmcmFtZSwgY28KIAogICAg IGF1dG8gcG9pbnRJbkRvY3VtZW50ID0gZnJhbWUudmlldygpLT5yb290Vmlld1RvQ29udGVudHMo cG9pbnRJblJvb3RWaWV3Q29vcmRpbmF0ZXMpOwogCi0gICAgaWYgKGJhc2VJc1N0YXJ0KSB7Ci0g ICAgICAgIGludCBzdGFydFkgPSBzZWxlY3Rpb25TdGFydC5hYnNvbHV0ZUNhcmV0Qm91bmRzKCku Y2VudGVyKCkueSgpOwotICAgICAgICBpZiAocG9pbnRJbkRvY3VtZW50LnkoKSA8IHN0YXJ0WSkK LSAgICAgICAgICAgIHBvaW50SW5Eb2N1bWVudC5zZXRZKHN0YXJ0WSk7CisgICAgV2ViQ29yZTo6 Tm9kZSAqbm9kZSA9IHNlbGVjdGlvblN0YXJ0LmRlZXBFcXVpdmFsZW50KCkuY29udGFpbmVyTm9k ZSgpOworICAgIGlmIChub2RlLT5yZW5kZXJTdHlsZSgpLT5pc1ZlcnRpY2FsV3JpdGluZ01vZGUo KSkgeworICAgICAgICBpZiAoYmFzZUlzU3RhcnQpIHsKKyAgICAgICAgICAgIGludCBzdGFydFgg PSBzZWxlY3Rpb25TdGFydC5hYnNvbHV0ZUNhcmV0Qm91bmRzKCkuY2VudGVyKCkueCgpOworICAg ICAgICAgICAgaWYgKHBvaW50SW5Eb2N1bWVudC54KCkgPiBzdGFydFgpCisgICAgICAgICAgICAg ICAgcG9pbnRJbkRvY3VtZW50LnNldFgoc3RhcnRYKTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAg ICAgICAgIGludCBlbmRYID0gc2VsZWN0aW9uRW5kLmFic29sdXRlQ2FyZXRCb3VuZHMoKS5jZW50 ZXIoKS54KCk7CisgICAgICAgICAgICBpZiAocG9pbnRJbkRvY3VtZW50LngoKSA8IGVuZFgpCisg ICAgICAgICAgICAgICAgcG9pbnRJbkRvY3VtZW50LnNldFgoZW5kWCk7CisgICAgICAgIH0KICAg ICB9IGVsc2UgewotICAgICAgICBpbnQgZW5kWSA9IHNlbGVjdGlvbkVuZC5hYnNvbHV0ZUNhcmV0 Qm91bmRzKCkuY2VudGVyKCkueSgpOwotICAgICAgICBpZiAocG9pbnRJbkRvY3VtZW50LnkoKSA+ IGVuZFkpCi0gICAgICAgICAgICBwb2ludEluRG9jdW1lbnQuc2V0WShlbmRZKTsKKyAgICAgICAg aWYgKGJhc2VJc1N0YXJ0KSB7CisgICAgICAgICAgICBpbnQgc3RhcnRZID0gc2VsZWN0aW9uU3Rh cnQuYWJzb2x1dGVDYXJldEJvdW5kcygpLmNlbnRlcigpLnkoKTsKKyAgICAgICAgICAgIGlmIChw b2ludEluRG9jdW1lbnQueSgpIDwgc3RhcnRZKQorICAgICAgICAgICAgICAgIHBvaW50SW5Eb2N1 bWVudC5zZXRZKHN0YXJ0WSk7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBpbnQgZW5k WSA9IHNlbGVjdGlvbkVuZC5hYnNvbHV0ZUNhcmV0Qm91bmRzKCkuY2VudGVyKCkueSgpOworICAg ICAgICAgICAgaWYgKHBvaW50SW5Eb2N1bWVudC55KCkgPiBlbmRZKQorICAgICAgICAgICAgICAg IHBvaW50SW5Eb2N1bWVudC5zZXRZKGVuZFkpOworICAgICAgICB9CiAgICAgfQogICAgIAogICAg IFZpc2libGVQb3NpdGlvbiByZXN1bHQ7Cg== 405748 2020-07-31 15:27:32 -0700 2020-08-01 00:34:07 -0700 Patch bug-213671-20200731152731.patch text/plain 3484 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIyZjYxYWZmN2ZkNTVjNWYw OTA5NmJmNGU0YjNlMGYwM2EyZWM0NGYuLjA2ZDUzNGM3YTJlOTVmNmY0M2U2NDg5YmY4Mjg5ZTg0 MGNmMzcxNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDctMzEgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBVbmFibGUgdG8gc2Vs ZWN0IG11bHRpcGxlIGxpbmVzIG9mIHZlcnRpY2FsIHRleHQgY29ycmVjdGx5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM2NzEKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzUzNzUzNjM2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEluIG9yZGVyIHRvIG1ha2UgZm9yIGEgYmV0dGVyIHRleHQgc2VsZWN0 aW9uIGV4cGVyaWVuY2UsIHdlIHB1bGxlZCB0aGUgc2VsZWN0aW9uIHBvc2l0aW9uIAorICAgICAg ICBkb3duIHRvIGJlIG9uIHRoZSBsYXN0IGxpbmUgc2VsZWN0YWJsZSwgcmF0aGVyIHRoYW4gc25h cCB0aGUgc2VsZWN0aW9uIHRvIGEgc2luZ2xlIHBvc2l0aW9uLgorICAgICAgICBUaGlzIG1hZGUg Zm9yIGEgYmV0dGVyIHNlbGVjdGlvbiBleHBlcmllbmNlIG9uIHNtYWxsIHRleHQsIGJ1dCB3ZSBm YWlsZWQgdG8gdGFrZQorICAgICAgICB2ZXJ0aWNhbCB0ZXh0IGludG8gYWNjb3VudCwgYW5kIGEg dXNlciBpcyBsb2NrZWQgaW50byBvbmx5IHNlbGVjdGluZyB2ZXJ0aWNhbCB0ZXh0IHRoYXQgZW5k cyBiZWxvdyB0aGUKKyAgICAgICAgb3RoZXIgYW5jaG9yIHBvaW50IG9mIHRoZSBzZWxlY3Rpb24u IFdlIHNob3VsZCBoYXZlIHRoZSBzYW1lIGJlaGF2aW9yIGZvciB2ZXJ0aWNhbCB0ZXh0LCBidXQg Y29ycmVjdGx5IAorICAgICAgICBjYWxjdWxhdGVkIGZvciBYIGluc3RlYWQgb2YgWS4KKyAgICAg ICAgVGhpcyBkb2VzIG5vdCBmaXggYWxsIGNhc2VzLCBidXQgaXQgZml4ZXMgdGhlIG1vc3QgZ2xh cmluZyBjYXNlcy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlP Uy5tbToKKyAgICAgICAgKFdlYktpdDo6cmFuZ2VGb3JQb2ludEluUm9vdFZpZXdDb29yZGluYXRl cyk6CisKIDIwMjAtMDctMzAgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgog CiAgICAgICAgIFJlbWVtYmVyIHRvIGNoZWNrIGVudGl0bGVtZW50IGJlZm9yZSBjb21tdW5pY2F0 aW5nIG92ZXIgWFBDCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFn ZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lv cy9XZWJQYWdlSU9TLm1tCmluZGV4IGU1M2U3N2E3MGJhNTBkMmM1Y2ZmMmY3MDMwZWU0NWM0ZTBk OTNhNTAuLjAxNmIwYWFiYjUyYmI5ZmI3MzI3NWFiODI4Yzg3MDZlYmY2ZGNhNWIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCisr KyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBA IC0xMDcsNiArMTA3LDcgQEAKICNpbXBvcnQgPFdlYkNvcmUvTWVkaWFTZXNzaW9uTWFuYWdlcklP Uy5oPgogI2ltcG9ydCA8V2ViQ29yZS9Ob2RlLmg+CiAjaW1wb3J0IDxXZWJDb3JlL05vZGVMaXN0 Lmg+CisjaW1wb3J0IDxXZWJDb3JlL05vZGVSZW5kZXJTdHlsZS5oPgogI2ltcG9ydCA8V2ViQ29y ZS9Ob3RJbXBsZW1lbnRlZC5oPgogI2ltcG9ydCA8V2ViQ29yZS9QYWdlLmg+CiAjaW1wb3J0IDxX ZWJDb3JlL1Bhc3RlYm9hcmQuaD4KQEAgLTE0OTMsMTQgKzE0OTQsMjcgQEAgc3RhdGljIE9wdGlv bmFsPFNpbXBsZVJhbmdlPiByYW5nZUZvclBvaW50SW5Sb290Vmlld0Nvb3JkaW5hdGVzKEZyYW1l JiBmcmFtZSwgY28KIAogICAgIGF1dG8gcG9pbnRJbkRvY3VtZW50ID0gZnJhbWUudmlldygpLT5y b290Vmlld1RvQ29udGVudHMocG9pbnRJblJvb3RWaWV3Q29vcmRpbmF0ZXMpOwogCi0gICAgaWYg KGJhc2VJc1N0YXJ0KSB7Ci0gICAgICAgIGludCBzdGFydFkgPSBzZWxlY3Rpb25TdGFydC5hYnNv bHV0ZUNhcmV0Qm91bmRzKCkuY2VudGVyKCkueSgpOwotICAgICAgICBpZiAocG9pbnRJbkRvY3Vt ZW50LnkoKSA8IHN0YXJ0WSkKLSAgICAgICAgICAgIHBvaW50SW5Eb2N1bWVudC5zZXRZKHN0YXJ0 WSk7CisgICAgYXV0byBub2RlID0gc2VsZWN0aW9uU3RhcnQuZGVlcEVxdWl2YWxlbnQoKS5jb250 YWluZXJOb2RlKCk7CisgICAgaWYgKG5vZGUgJiYgbm9kZS0+cmVuZGVyU3R5bGUoKSAmJiBub2Rl LT5yZW5kZXJTdHlsZSgpLT5pc1ZlcnRpY2FsV3JpdGluZ01vZGUoKSkgeworICAgICAgICBpZiAo YmFzZUlzU3RhcnQpIHsKKyAgICAgICAgICAgIGludCBzdGFydFggPSBzZWxlY3Rpb25TdGFydC5h YnNvbHV0ZUNhcmV0Qm91bmRzKCkuY2VudGVyKCkueCgpOworICAgICAgICAgICAgaWYgKHBvaW50 SW5Eb2N1bWVudC54KCkgPiBzdGFydFgpCisgICAgICAgICAgICAgICAgcG9pbnRJbkRvY3VtZW50 LnNldFgoc3RhcnRYKTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGludCBlbmRYID0g c2VsZWN0aW9uRW5kLmFic29sdXRlQ2FyZXRCb3VuZHMoKS5jZW50ZXIoKS54KCk7CisgICAgICAg ICAgICBpZiAocG9pbnRJbkRvY3VtZW50LngoKSA8IGVuZFgpCisgICAgICAgICAgICAgICAgcG9p bnRJbkRvY3VtZW50LnNldFgoZW5kWCk7CisgICAgICAgIH0KICAgICB9IGVsc2UgewotICAgICAg ICBpbnQgZW5kWSA9IHNlbGVjdGlvbkVuZC5hYnNvbHV0ZUNhcmV0Qm91bmRzKCkuY2VudGVyKCku eSgpOwotICAgICAgICBpZiAocG9pbnRJbkRvY3VtZW50LnkoKSA+IGVuZFkpCi0gICAgICAgICAg ICBwb2ludEluRG9jdW1lbnQuc2V0WShlbmRZKTsKKyAgICAgICAgaWYgKGJhc2VJc1N0YXJ0KSB7 CisgICAgICAgICAgICBpbnQgc3RhcnRZID0gc2VsZWN0aW9uU3RhcnQuYWJzb2x1dGVDYXJldEJv dW5kcygpLmNlbnRlcigpLnkoKTsKKyAgICAgICAgICAgIGlmIChwb2ludEluRG9jdW1lbnQueSgp IDwgc3RhcnRZKQorICAgICAgICAgICAgICAgIHBvaW50SW5Eb2N1bWVudC5zZXRZKHN0YXJ0WSk7 CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBpbnQgZW5kWSA9IHNlbGVjdGlvbkVuZC5h YnNvbHV0ZUNhcmV0Qm91bmRzKCkuY2VudGVyKCkueSgpOworICAgICAgICAgICAgaWYgKHBvaW50 SW5Eb2N1bWVudC55KCkgPiBlbmRZKQorICAgICAgICAgICAgICAgIHBvaW50SW5Eb2N1bWVudC5z ZXRZKGVuZFkpOworICAgICAgICB9CiAgICAgfQogICAgIAogICAgIFZpc2libGVQb3NpdGlvbiBy ZXN1bHQ7Cg== 405772 2020-08-01 00:34:09 -0700 2020-08-01 01:02:10 -0700 Patch for landing bug-213671-20200801003408.patch text/plain 3481 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIyZjYxYWZmN2ZkNTVjNWYw OTA5NmJmNGU0YjNlMGYwM2EyZWM0NGYuLjVlNDczNjM1ZDFkMmEzZGY1MDg4MTRkMGI4ZmI2YTcz YWFkNjNlNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDctMzEgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBVbmFibGUgdG8gc2Vs ZWN0IG11bHRpcGxlIGxpbmVzIG9mIHZlcnRpY2FsIHRleHQgY29ycmVjdGx5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM2NzEKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzUzNzUzNjM2PgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgorCisgICAgICAgIEluIG9yZGVyIHRvIG1ha2UgZm9yIGEgYmV0dGVyIHRleHQgc2VsZWN0aW9u IGV4cGVyaWVuY2UsIHdlIHB1bGxlZCB0aGUgc2VsZWN0aW9uIHBvc2l0aW9uIAorICAgICAgICBk b3duIHRvIGJlIG9uIHRoZSBsYXN0IGxpbmUgc2VsZWN0YWJsZSwgcmF0aGVyIHRoYW4gc25hcCB0 aGUgc2VsZWN0aW9uIHRvIGEgc2luZ2xlIHBvc2l0aW9uLgorICAgICAgICBUaGlzIG1hZGUgZm9y IGEgYmV0dGVyIHNlbGVjdGlvbiBleHBlcmllbmNlIG9uIHNtYWxsIHRleHQsIGJ1dCB3ZSBmYWls ZWQgdG8gdGFrZQorICAgICAgICB2ZXJ0aWNhbCB0ZXh0IGludG8gYWNjb3VudCwgYW5kIGEgdXNl ciBpcyBsb2NrZWQgaW50byBvbmx5IHNlbGVjdGluZyB2ZXJ0aWNhbCB0ZXh0IHRoYXQgZW5kcyBi ZWxvdyB0aGUKKyAgICAgICAgb3RoZXIgYW5jaG9yIHBvaW50IG9mIHRoZSBzZWxlY3Rpb24uIFdl IHNob3VsZCBoYXZlIHRoZSBzYW1lIGJlaGF2aW9yIGZvciB2ZXJ0aWNhbCB0ZXh0LCBidXQgY29y cmVjdGx5IAorICAgICAgICBjYWxjdWxhdGVkIGZvciBYIGluc3RlYWQgb2YgWS4KKyAgICAgICAg VGhpcyBkb2VzIG5vdCBmaXggYWxsIGNhc2VzLCBidXQgaXQgZml4ZXMgdGhlIG1vc3QgZ2xhcmlu ZyBjYXNlcy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5t bToKKyAgICAgICAgKFdlYktpdDo6cmFuZ2VGb3JQb2ludEluUm9vdFZpZXdDb29yZGluYXRlcyk6 CisKIDIwMjAtMDctMzAgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbWVtYmVyIHRvIGNoZWNrIGVudGl0bGVtZW50IGJlZm9yZSBjb21tdW5pY2F0aW5n IG92ZXIgWFBDCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9p b3MvV2ViUGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9X ZWJQYWdlSU9TLm1tCmluZGV4IGU1M2U3N2E3MGJhNTBkMmM1Y2ZmMmY3MDMwZWU0NWM0ZTBkOTNh NTAuLjAxNmIwYWFiYjUyYmI5ZmI3MzI3NWFiODI4Yzg3MDZlYmY2ZGNhNWIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBAIC0x MDcsNiArMTA3LDcgQEAKICNpbXBvcnQgPFdlYkNvcmUvTWVkaWFTZXNzaW9uTWFuYWdlcklPUy5o PgogI2ltcG9ydCA8V2ViQ29yZS9Ob2RlLmg+CiAjaW1wb3J0IDxXZWJDb3JlL05vZGVMaXN0Lmg+ CisjaW1wb3J0IDxXZWJDb3JlL05vZGVSZW5kZXJTdHlsZS5oPgogI2ltcG9ydCA8V2ViQ29yZS9O b3RJbXBsZW1lbnRlZC5oPgogI2ltcG9ydCA8V2ViQ29yZS9QYWdlLmg+CiAjaW1wb3J0IDxXZWJD b3JlL1Bhc3RlYm9hcmQuaD4KQEAgLTE0OTMsMTQgKzE0OTQsMjcgQEAgc3RhdGljIE9wdGlvbmFs PFNpbXBsZVJhbmdlPiByYW5nZUZvclBvaW50SW5Sb290Vmlld0Nvb3JkaW5hdGVzKEZyYW1lJiBm cmFtZSwgY28KIAogICAgIGF1dG8gcG9pbnRJbkRvY3VtZW50ID0gZnJhbWUudmlldygpLT5yb290 Vmlld1RvQ29udGVudHMocG9pbnRJblJvb3RWaWV3Q29vcmRpbmF0ZXMpOwogCi0gICAgaWYgKGJh c2VJc1N0YXJ0KSB7Ci0gICAgICAgIGludCBzdGFydFkgPSBzZWxlY3Rpb25TdGFydC5hYnNvbHV0 ZUNhcmV0Qm91bmRzKCkuY2VudGVyKCkueSgpOwotICAgICAgICBpZiAocG9pbnRJbkRvY3VtZW50 LnkoKSA8IHN0YXJ0WSkKLSAgICAgICAgICAgIHBvaW50SW5Eb2N1bWVudC5zZXRZKHN0YXJ0WSk7 CisgICAgYXV0byBub2RlID0gc2VsZWN0aW9uU3RhcnQuZGVlcEVxdWl2YWxlbnQoKS5jb250YWlu ZXJOb2RlKCk7CisgICAgaWYgKG5vZGUgJiYgbm9kZS0+cmVuZGVyU3R5bGUoKSAmJiBub2RlLT5y ZW5kZXJTdHlsZSgpLT5pc1ZlcnRpY2FsV3JpdGluZ01vZGUoKSkgeworICAgICAgICBpZiAoYmFz ZUlzU3RhcnQpIHsKKyAgICAgICAgICAgIGludCBzdGFydFggPSBzZWxlY3Rpb25TdGFydC5hYnNv bHV0ZUNhcmV0Qm91bmRzKCkuY2VudGVyKCkueCgpOworICAgICAgICAgICAgaWYgKHBvaW50SW5E b2N1bWVudC54KCkgPiBzdGFydFgpCisgICAgICAgICAgICAgICAgcG9pbnRJbkRvY3VtZW50LnNl dFgoc3RhcnRYKTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGludCBlbmRYID0gc2Vs ZWN0aW9uRW5kLmFic29sdXRlQ2FyZXRCb3VuZHMoKS5jZW50ZXIoKS54KCk7CisgICAgICAgICAg ICBpZiAocG9pbnRJbkRvY3VtZW50LngoKSA8IGVuZFgpCisgICAgICAgICAgICAgICAgcG9pbnRJ bkRvY3VtZW50LnNldFgoZW5kWCk7CisgICAgICAgIH0KICAgICB9IGVsc2UgewotICAgICAgICBp bnQgZW5kWSA9IHNlbGVjdGlvbkVuZC5hYnNvbHV0ZUNhcmV0Qm91bmRzKCkuY2VudGVyKCkueSgp OwotICAgICAgICBpZiAocG9pbnRJbkRvY3VtZW50LnkoKSA+IGVuZFkpCi0gICAgICAgICAgICBw b2ludEluRG9jdW1lbnQuc2V0WShlbmRZKTsKKyAgICAgICAgaWYgKGJhc2VJc1N0YXJ0KSB7Cisg ICAgICAgICAgICBpbnQgc3RhcnRZID0gc2VsZWN0aW9uU3RhcnQuYWJzb2x1dGVDYXJldEJvdW5k cygpLmNlbnRlcigpLnkoKTsKKyAgICAgICAgICAgIGlmIChwb2ludEluRG9jdW1lbnQueSgpIDwg c3RhcnRZKQorICAgICAgICAgICAgICAgIHBvaW50SW5Eb2N1bWVudC5zZXRZKHN0YXJ0WSk7Cisg ICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBpbnQgZW5kWSA9IHNlbGVjdGlvbkVuZC5hYnNv bHV0ZUNhcmV0Qm91bmRzKCkuY2VudGVyKCkueSgpOworICAgICAgICAgICAgaWYgKHBvaW50SW5E b2N1bWVudC55KCkgPiBlbmRZKQorICAgICAgICAgICAgICAgIHBvaW50SW5Eb2N1bWVudC5zZXRZ KGVuZFkpOworICAgICAgICB9CiAgICAgfQogICAgIAogICAgIFZpc2libGVQb3NpdGlvbiByZXN1 bHQ7Cg==