213670 2020-06-26 17:09:08 -0700 BytecodeBasicBlock::addSuccessor should check if the successor already exists 2020-06-27 08:54:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov guijemont jsc32 keith_miller mark.lam msaboff rmorisset ross.kirsling ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1666695 0 saam 2020-06-26 17:09:08 -0700 we end up with duplicates for switch, e.g: baz#BV6yLf:[0x10d3bc360->0x10d3e5200, NoneFunctionCall, 87]: 19 instructions (0 16-bit instructions, 0 32-bit instructions, 9 instructions with metadata); 207 bytes (120 metadata bytes); 2 parameter(s); 16 callee register(s); 6 variable(s); scope at loc4 bb#1 [ 0] enter [ 1] get_scope loc4 [ 3] mov loc5, loc4 [ 6] check_traps Successors: [ #2 ] bb#2 [ 7] switch_imm 0, 76(->83), arg1 Successors: [ #2 #3 #4 #5 #6 #3 ] bb#3 [ 11] resolve_scope loc10, loc4, 0, GlobalProperty, 0 [ 18] get_from_scope loc6, loc10, 0, 2048<ThrowIfNotFound|GlobalProperty|NotInitialization|NotStrictMode>, 0, 0 [ 26] mov loc9, Int32: 42(const0) [ 29] call loc6, loc6, 2, 16 Successors: [ #4 ] bb#4 [ 35] resolve_scope loc10, loc4, 0, GlobalProperty, 0 [ 42] get_from_scope loc6, loc10, 0, 2048<ThrowIfNotFound|GlobalProperty|NotInitialization|NotStrictMode>, 0, 0 [ 50] mov loc9, Int32: 43(const1) [ 53] call loc6, loc6, 2, 16 Successors: [ #5 ] bb#5 [ 59] resolve_scope loc10, loc4, 0, GlobalProperty, 0 [ 66] get_from_scope loc6, loc10, 0, 2048<ThrowIfNotFound|GlobalProperty|NotInitialization|NotStrictMode>, 0, 0 [ 74] mov loc9, Int32: 44(const2) [ 77] call loc6, loc6, 2, 16 Successors: [ #6 ] bb#6 [ 83] jmp 2(->85) Successors: [ #7 ] bb#7 [ 85] ret Undefined(const3) Successors: [ ] Identifiers: id0 = print Constants: k0 = Int32: 42: in source as integer k1 = Int32: 43: in source as integer k2 = Int32: 44: in source as integer k3 = Undefined Switch Jump Tables: 0 = { 1 => 0004 2 => 0028 4 => 0052 } 1666702 1 402935 saam 2020-06-26 17:30:55 -0700 Created attachment 402935 patch 1666709 2 402935 ysuzuki 2020-06-26 18:32:56 -0700 Comment on attachment 402935 patch r=me 1666764 3 ews-feeder 2020-06-27 08:53:45 -0700 Committed r263619: <https://trac.webkit.org/changeset/263619> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402935. 1666765 4 webkit-bug-importer 2020-06-27 08:54:17 -0700 <rdar://problem/64844062> 402935 2020-06-26 17:30:55 -0700 2020-06-27 08:53:46 -0700 patch c-backup.diff text/plain 1732 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjYzNjA2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDIwLTA2LTI2ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEJ5dGVjb2RlQmFzaWNCbG9jazo6YWRkU3VjY2Vzc29yIHNob3VsZCBjaGVjayBpZiB0aGUgIHN1 Y2Nlc3NvciBhbHJlYWR5IGV4aXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjEzNjcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgSXQgbWFrZXMgaXQgbmljZXIgZm9yIGFsZ29yaXRobXMgdXNpbmcgQnl0 ZWNvZGVHcmFwaCB0byBub3QgaGF2ZSB0byBjb25zaWRlcgorICAgICAgICB3aGV0aGVyIG9yIG5v dCB0aGVyZSBhcmUgZHVwbGljYXRlcyBpbiB0aGUgc3VjY2Vzc29yIGxpc3QuIEFsc28sIGJlY2F1 c2Ugb2YKKyAgICAgICAgdGhpcywgYnl0ZWNvZGUgbGl2ZW5lc3Mgd2FzIGRvaW5nIGV4dHJhIHdv cmsgc2luY2UgaXQgd2Fsa2VkIHRoZSBzdWNjZXNzb3IgbGlzdCwKKyAgICAgICAgaW5jbHVkaW5n IGFueSBkdXBsaWNhdGVzIGluIGl0LgorCisgICAgICAgICogYnl0ZWNvZGUvQnl0ZWNvZGVCYXNp Y0Jsb2NrLmg6CisgICAgICAgIChKU0M6OkJ5dGVjb2RlQmFzaWNCbG9jazo6YWRkU3VjY2Vzc29y KToKKwogMjAyMC0wNi0yNiAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAg ICAgICAgIEluaXRpYWxpemluZyB0aGUgbWFpbiB0aHJlYWQgc2hvdWxkIGluaXRpYWxpemUgdGhl IG1haW4gcnVuIGxvb3AKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9CeXRl Y29kZUJhc2ljQmxvY2suaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvQnl0ZWNvZGVCYXNpY0Jsb2NrLmgJKHJldmlzaW9uIDI2MzYwNikKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9CeXRlY29kZUJhc2ljQmxvY2suaAkod29ya2luZyBjb3B5 KQpAQCAtNzcsNyArNzcsMTEgQEAgcHJpdmF0ZToKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBCbG9j az4gc3RhdGljIEJhc2ljQmxvY2tWZWN0b3IgY29tcHV0ZUltcGwoQmxvY2sqIGNvZGVCbG9jaywg Y29uc3QgSW5zdHJ1Y3Rpb25TdHJlYW0mIGluc3RydWN0aW9ucyk7CiAgICAgdm9pZCBzaHJpbmtU b0ZpdCgpOwogCi0gICAgdm9pZCBhZGRTdWNjZXNzb3IoQnl0ZWNvZGVCYXNpY0Jsb2NrJiBibG9j aykgeyBtX3N1Y2Nlc3NvcnMuYXBwZW5kKGJsb2NrLmluZGV4KCkpOyB9CisgICAgdm9pZCBhZGRT dWNjZXNzb3IoQnl0ZWNvZGVCYXNpY0Jsb2NrJiBibG9jaykKKyAgICB7CisgICAgICAgIGlmICgh bV9zdWNjZXNzb3JzLmNvbnRhaW5zKGJsb2NrLmluZGV4KCkpKQorICAgICAgICAgICAgbV9zdWNj ZXNzb3JzLmFwcGVuZChibG9jay5pbmRleCgpKTsKKyAgICB9CiAKICAgICBpbmxpbmUgdm9pZCBh ZGRMZW5ndGgodW5zaWduZWQpOwogCg==