213657 2020-06-26 13:09:42 -0700 On load from back/forward cache, call checkCompleted() for ALL frames inside FrameLoader::commitProvisionalLoad() 2022-02-28 03:44:08 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=156356 InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson ews-watchlist ggaren japhet webkit-bug-importer youennf oldest_to_newest 1666568 0 cdumez 2020-06-26 13:09:42 -0700 On load from back/forward cache, call checkCompleted() for ALL frames inside FrameLoader::commitProvisionalLoad(). Previously, we were doing it for the main frame in FrameLoader::commitProvisionalLoad() and for subframes in FrameLoader::open(). 1666569 1 402893 cdumez 2020-06-26 13:11:23 -0700 Created attachment 402893 Patch 1666570 2 402894 cdumez 2020-06-26 13:13:35 -0700 Created attachment 402894 Patch 1667126 3 cdumez 2020-06-29 09:15:53 -0700 ping review? 1667137 4 402894 youennf 2020-06-29 09:25:46 -0700 Comment on attachment 402894 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402894&action=review > Source/WebCore/loader/FrameLoader.cpp:-2080 > - checkCompleted(); Is there a potential change of behavior in case checkCompleted done here would have changed the list of children iframes below? > Source/WebCore/loader/FrameLoader.cpp:2082 > + for (Frame* child = m_frame.tree().firstChild(); child; child = child->tree().traverseNext(&m_frame)) auto* 1667143 5 cdumez 2020-06-29 09:32:40 -0700 Committed r263662: <https://trac.webkit.org/changeset/263662> 1667144 6 webkit-bug-importer 2020-06-29 09:33:16 -0700 <rdar://problem/64893675> 402893 2020-06-26 13:11:23 -0700 2020-06-26 13:11:59 -0700 Patch bug-213657-20200626131122.patch text/plain 2472 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGUyMGQ0MGIzNWNjYTg4 MmJhOGQ2NjlhYTY2M2IyZjIwOTEzNzdjNy4uMTUxZGZiODU1M2FjMzU0ZGNjMDM1ZDQ5MmRjOTMw YWNhNTY2YjA0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA2LTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgT24gbG9hZCBmcm9tIGJhY2sv Zm9yd2FyZCBjYWNoZSwgY2FsbCBjaGVja0NvbXBsZXRlZCgpIGZvciBBTEwgZnJhbWVzIGluc2lk ZSBGcmFtZUxvYWRlcjo6Y29tbWl0UHJvdmlzaW9uYWxMb2FkKCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzY1NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIGxvYWQgZnJvbSBiYWNrL2ZvcndhcmQg Y2FjaGUsIGNhbGwgY2hlY2tDb21wbGV0ZWQoKSBmb3IgQUxMIGZyYW1lcyBpbnNpZGUgRnJhbWVM b2FkZXI6OmNvbW1pdFByb3Zpc2lvbmFsTG9hZCgpLgorICAgICAgICBQcmV2aW91c2x5LCB3ZSB3 ZXJlIGRvaW5nIGl0IGZvciB0aGUgbWFpbiBmcmFtZSBpbiBGcmFtZUxvYWRlcjo6Y29tbWl0UHJv dmlzaW9uYWxMb2FkKCkgYW5kIGZvciBzdWJmcmFtZXMgaW4KKyAgICAgICAgRnJhbWVMb2FkZXI6 Om9wZW4oKS4gRG9pbmcgaXQgYWxsIGluIG9uZSBwbGFjZSByZXN1bHRzIGluIG1vcmUgdW5kZXJz dGFuZGFibGUgY29kZSBhbmQgaXMgbGVzcyBlcnJvci1wcm9uZS4KKworICAgICAgICAqIGxvYWRl ci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y29tbWl0 UHJvdmlzaW9uYWxMb2FkKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpvcGVuKToK KwogMjAyMC0wNi0yNiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAg ICAgTWVkaWFSZWNvcmRlci5zdGFydCgpIE1ldGhvZCBpcyBJZ25vcmluZyB0aGUgInRpbWVzbGlj ZSIgUGFyYW1ldGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2Fk ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRleCA0ZjRl ZTMwNGVkNGZkYmZkMWQwODA2NTMyODEzNzkzODQ2NGVkNGIyLi44MGFkMTE1MGUyNzc1ZDk1MmIz NGJhMTM1NTQ0NDAwMjk0OWNhZjMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv RnJhbWVMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5j cHAKQEAgLTIwNzcsNyArMjA3NywxMyBAQCB2b2lkIEZyYW1lTG9hZGVyOjpjb21taXRQcm92aXNp b25hbExvYWQoKQogICAgICAgICBub3RpZmllcigpLnNlbmRSZW1haW5pbmdEZWxlZ2F0ZU1lc3Nh Z2VzKG1fZG9jdW1lbnRMb2FkZXIuZ2V0KCksIG1haW5SZXNvdXJjZUlkZW50aWZpZXIsIG1haW5S ZXNvdXJjZVJlcXVlc3QsIFJlc291cmNlUmVzcG9uc2UoKSwKICAgICAgICAgICAgIG51bGxwdHIs IHN0YXRpY19jYXN0PGludD4obV9kb2N1bWVudExvYWRlci0+cmVzcG9uc2UoKS5leHBlY3RlZENv bnRlbnRMZW5ndGgoKSksIDAsIG1haW5SZXNvdWNlRXJyb3IpOwogCi0gICAgICAgIGNoZWNrQ29t cGxldGVkKCk7CisgICAgICAgIFZlY3RvcjxSZWY8RnJhbWU+PiB0YXJnZXRGcmFtZXM7CisgICAg ICAgIHRhcmdldEZyYW1lcy5hcHBlbmQobV9mcmFtZSk7CisgICAgICAgIGZvciAoRnJhbWUqIGNo aWxkID0gbV9mcmFtZS50cmVlKCkuZmlyc3RDaGlsZCgpOyBjaGlsZDsgY2hpbGQgPSBjaGlsZC0+ dHJlZSgpLnRyYXZlcnNlTmV4dCgmbV9mcmFtZSkpCisgICAgICAgICAgICB0YXJnZXRGcmFtZXMu YXBwZW5kKCpjaGlsZCk7CisKKyAgICAgICAgZm9yIChhdXRvJiBmcmFtZSA6IHRhcmdldEZyYW1l cykKKyAgICAgICAgICAgIGZyYW1lLT5sb2FkZXIoKS5jaGVja0NvbXBsZXRlZCgpOwogICAgIH0g ZWxzZQogICAgICAgICBkaWRPcGVuVVJMKCk7CiAKQEAgLTIzNTAsMTAgKzIzNTYsNiBAQCB2b2lk IEZyYW1lTG9hZGVyOjpvcGVuKENhY2hlZEZyYW1lQmFzZSYgY2FjaGVkRnJhbWUpCiAgICAgdXBk YXRlRmlyc3RQYXJ0eUZvckNvb2tpZXMoKTsKIAogICAgIGNhY2hlZEZyYW1lLnJlc3RvcmUoKTsK LQotICAgIC8vIEZvciB0aGUgbWFpbiBmcmFtZSwgdGhpcyBnZXRzIGNhbGxlZCBpbiBGcmFtZUxv YWRlcjo6Y29tbWl0UHJvdmlzaW9uYWxMb2FkKCkuCi0gICAgaWYgKCFtX2ZyYW1lLmlzTWFpbkZy YW1lKCkpCi0gICAgICAgIGNoZWNrQ29tcGxldGVkKCk7CiB9CiAKIGJvb2wgRnJhbWVMb2FkZXI6 OmlzUmVwbGFjaW5nKCkgY29uc3QK 402894 2020-06-26 13:13:35 -0700 2022-02-28 03:44:08 -0800 Patch bug-213657-20200626131334.patch text/plain 2631 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGUyMGQ0MGIzNWNjYTg4 MmJhOGQ2NjlhYTY2M2IyZjIwOTEzNzdjNy4uNzczMzk3YzIxNDJkNGE4ZmZhYzQ4MTMzZTg0MWRh OTYzZjkyY2ExYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTA2LTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgT24gbG9hZCBmcm9tIGJhY2sv Zm9yd2FyZCBjYWNoZSwgY2FsbCBjaGVja0NvbXBsZXRlZCgpIGZvciBBTEwgZnJhbWVzIGluc2lk ZSBGcmFtZUxvYWRlcjo6Y29tbWl0UHJvdmlzaW9uYWxMb2FkKCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMzY1NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIGxvYWQgZnJvbSBiYWNrL2ZvcndhcmQg Y2FjaGUsIGNhbGwgY2hlY2tDb21wbGV0ZWQoKSBmb3IgQUxMIGZyYW1lcyBpbnNpZGUgRnJhbWVM b2FkZXI6OmNvbW1pdFByb3Zpc2lvbmFsTG9hZCgpLgorICAgICAgICBQcmV2aW91c2x5LCB3ZSB3 ZXJlIGRvaW5nIGl0IGZvciB0aGUgbWFpbiBmcmFtZSBpbiBGcmFtZUxvYWRlcjo6Y29tbWl0UHJv dmlzaW9uYWxMb2FkKCkgYW5kIGZvciBzdWJmcmFtZXMgaW4KKyAgICAgICAgRnJhbWVMb2FkZXI6 Om9wZW4oKS4gRG9pbmcgaXQgYWxsIGluIG9uZSBwbGFjZSByZXN1bHRzIGluIG1vcmUgdW5kZXJz dGFuZGFibGUgY29kZSBhbmQgaXMgbGVzcyBlcnJvci1wcm9uZS4KKworICAgICAgICBOb3RlIHRo YXQgY2FsbGluZyBjaGVja0NvbXBsZXRlZCgpIGZvciBzdWJmcmFtZXMgd2FzIG5ldyBpbiByMjYy MjIxIGFuZCBpcyBjb3ZlcmVkIGJ5OgorICAgICAgICBmYXN0L2hpc3RvcnkvbXVsdGlwbGUtYmFj ay1mb3J3YXJkLW5hdmlnYXRpb25zLmh0bWwKKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y29tbWl0UHJvdmlzaW9uYWxM b2FkKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpvcGVuKToKKwogMjAyMC0wNi0y NiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgTWVkaWFSZWNv cmRlci5zdGFydCgpIE1ldGhvZCBpcyBJZ25vcmluZyB0aGUgInRpbWVzbGljZSIgUGFyYW1ldGVy CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRleCA0ZjRlZTMwNGVkNGZkYmZk MWQwODA2NTMyODEzNzkzODQ2NGVkNGIyLi44MGFkMTE1MGUyNzc1ZDk1MmIzNGJhMTM1NTQ0NDAw Mjk0OWNhZjMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKQEAgLTIwNzcs NyArMjA3NywxMyBAQCB2b2lkIEZyYW1lTG9hZGVyOjpjb21taXRQcm92aXNpb25hbExvYWQoKQog ICAgICAgICBub3RpZmllcigpLnNlbmRSZW1haW5pbmdEZWxlZ2F0ZU1lc3NhZ2VzKG1fZG9jdW1l bnRMb2FkZXIuZ2V0KCksIG1haW5SZXNvdXJjZUlkZW50aWZpZXIsIG1haW5SZXNvdXJjZVJlcXVl c3QsIFJlc291cmNlUmVzcG9uc2UoKSwKICAgICAgICAgICAgIG51bGxwdHIsIHN0YXRpY19jYXN0 PGludD4obV9kb2N1bWVudExvYWRlci0+cmVzcG9uc2UoKS5leHBlY3RlZENvbnRlbnRMZW5ndGgo KSksIDAsIG1haW5SZXNvdWNlRXJyb3IpOwogCi0gICAgICAgIGNoZWNrQ29tcGxldGVkKCk7Cisg ICAgICAgIFZlY3RvcjxSZWY8RnJhbWU+PiB0YXJnZXRGcmFtZXM7CisgICAgICAgIHRhcmdldEZy YW1lcy5hcHBlbmQobV9mcmFtZSk7CisgICAgICAgIGZvciAoRnJhbWUqIGNoaWxkID0gbV9mcmFt ZS50cmVlKCkuZmlyc3RDaGlsZCgpOyBjaGlsZDsgY2hpbGQgPSBjaGlsZC0+dHJlZSgpLnRyYXZl cnNlTmV4dCgmbV9mcmFtZSkpCisgICAgICAgICAgICB0YXJnZXRGcmFtZXMuYXBwZW5kKCpjaGls ZCk7CisKKyAgICAgICAgZm9yIChhdXRvJiBmcmFtZSA6IHRhcmdldEZyYW1lcykKKyAgICAgICAg ICAgIGZyYW1lLT5sb2FkZXIoKS5jaGVja0NvbXBsZXRlZCgpOwogICAgIH0gZWxzZQogICAgICAg ICBkaWRPcGVuVVJMKCk7CiAKQEAgLTIzNTAsMTAgKzIzNTYsNiBAQCB2b2lkIEZyYW1lTG9hZGVy OjpvcGVuKENhY2hlZEZyYW1lQmFzZSYgY2FjaGVkRnJhbWUpCiAgICAgdXBkYXRlRmlyc3RQYXJ0 eUZvckNvb2tpZXMoKTsKIAogICAgIGNhY2hlZEZyYW1lLnJlc3RvcmUoKTsKLQotICAgIC8vIEZv ciB0aGUgbWFpbiBmcmFtZSwgdGhpcyBnZXRzIGNhbGxlZCBpbiBGcmFtZUxvYWRlcjo6Y29tbWl0 UHJvdmlzaW9uYWxMb2FkKCkuCi0gICAgaWYgKCFtX2ZyYW1lLmlzTWFpbkZyYW1lKCkpCi0gICAg ICAgIGNoZWNrQ29tcGxldGVkKCk7CiB9CiAKIGJvb2wgRnJhbWVMb2FkZXI6OmlzUmVwbGFjaW5n KCkgY29uc3QK