213636 2020-06-25 20:58:59 -0700 WKHTTPCookieStore.setCookie should flush the cookies to disk before calling completion handler when we are using the UIProcess's default cookie storage 2020-08-14 18:44:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen beidson webkit-bug-importer oldest_to_newest 1666362 0 achristensen 2020-06-25 20:58:59 -0700 WKHTTPCookieStore.setCookie should flush the cookies to disk before calling completion handler when we are using the UIProcess's default cookie storage 1666363 1 402847 achristensen 2020-06-25 20:59:53 -0700 Created attachment 402847 Patch 1666372 2 ews-feeder 2020-06-25 21:36:24 -0700 Committed r263551: <https://trac.webkit.org/changeset/263551> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402847. 1666373 3 webkit-bug-importer 2020-06-25 21:37:13 -0700 <rdar://problem/64789854> 1680548 4 402847 achristensen 2020-08-14 18:04:42 -0700 Comment on attachment 402847 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402847&action=review > Source/WebKit/UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm:42 > + ASSERT(RunLoop::isMain()); > + [[NSHTTPCookieStorage sharedHTTPCookieStorage] _saveCookies:makeBlockPtr([completionHandler = WTFMove(completionHandler)]() mutable { This being on the main thread caused hangs which I believe were resolved with http://trac.webkit.org/r264613 1680565 5 achristensen 2020-08-14 18:44:23 -0700 Reverting in https://bugs.webkit.org/show_bug.cgi?id=215530 402847 2020-06-25 20:59:53 -0700 2020-06-25 21:36:24 -0700 Patch bug-213636-20200625205952.patch text/plain 6959 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjM1NDkpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDIwLTA2LTI1ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgV0tIVFRQQ29va2ll U3RvcmUuc2V0Q29va2llIHNob3VsZCBmbHVzaCB0aGUgY29va2llcyB0byBkaXNrIGJlZm9yZSBj YWxsaW5nIGNvbXBsZXRpb24gaGFuZGxlciB3aGVuIHdlIGFyZSB1c2luZyB0aGUgVUlQcm9jZXNz J3MgZGVmYXVsdCBjb29raWUgc3RvcmFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjEzNjM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBmaXhlcyBhIHJhY2UgY29uZGl0aW9uIHRoYXQgbWFueSwg bWFueSB0aGlyZCBwYXJ0eSBkZXZlbG9wZXJzIHJ1biBpbnRvLCBjYXVzaW5nIHRoZW0gdG8gbm90 IGJlIGxvZ2dlZCBpbiB3aGVuIHRoZXkgdGhvdWdodCB0aGV5IGRpZC4KKworICAgICAgICAqIE5l dHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtQcm9jZXNzQ29jb2EubW06CisgICAgICAgIChXZWJL aXQ6OnNhdmVDb29raWVzKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0FQSUhUVFBDb29raWVT dG9yZS5jcHA6CisgICAgICAgIChBUEk6OkhUVFBDb29raWVTdG9yZTo6c2V0Q29va2llcyk6Cisg ICAgICAgIChBUEk6OkhUVFBDb29raWVTdG9yZTo6cmVnaXN0ZXJGb3JOZXdQcm9jZXNzUG9vbE5v dGlmaWNhdGlvbnMpOgorICAgICAgICAoQVBJOjpIVFRQQ29va2llU3RvcmU6OmZsdXNoRGVmYXVs dFVJUHJvY2Vzc0Nvb2tpZVN0b3JlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0FQSUhUVFBD b29raWVTdG9yZS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvQVBJSFRUUENvb2tp ZVN0b3JlQ29jb2EubW06CisgICAgICAgIChBUEk6OkhUVFBDb29raWVTdG9yZTo6Zmx1c2hEZWZh dWx0VUlQcm9jZXNzQ29va2llU3RvcmUpOgorCiAyMDIwLTA2LTI1ICBNZWdhbiBHYXJkbmVyICA8 bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CiAKICAgICAgICAgVXBzdHJlYW0gZGF0ZS90aW1lIHBp Y2tlciBzdHlsZQpJbmRleDogU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3 b3JrUHJvY2Vzc0NvY29hLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvTmV0d29ya1By b2Nlc3MvY29jb2EvTmV0d29ya1Byb2Nlc3NDb2NvYS5tbQkocmV2aXNpb24gMjYzNDU5KQorKysg U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrUHJvY2Vzc0NvY29hLm1t CSh3b3JraW5nIGNvcHkpCkBAIC0yMTYsOSArMjE2LDcgQEAgc3RhdGljIHZvaWQgc2F2ZUNvb2tp ZXMoTlNIVFRQQ29va2llU3RvcgogICAgIEFTU0VSVChSdW5Mb29wOjppc01haW4oKSk7CiAgICAg W2Nvb2tpZVN0b3JhZ2UgX3NhdmVDb29raWVzOm1ha2VCbG9ja1B0cihbY29tcGxldGlvbkhhbmRs ZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKV0oKSBtdXRhYmxlIHsKICAgICAgICAgLy8g Q0ZOZXR3b3JrIG1heSBjYWxsIHRoZSBjb21wbGV0aW9uIGJsb2NrIG9uIGEgYmFja2dyb3VuZCBx dWV1ZSwgc28gd2UgbmVlZCB0byByZWRpc3BhdGNoIHRvIHRoZSBtYWluIHRocmVhZC4KLSAgICAg ICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFtjb21wbGV0aW9uSGFuZGxlciA9IFdURk1vdmUo Y29tcGxldGlvbkhhbmRsZXIpXSgpIG11dGFibGUgewotICAgICAgICAgICAgY29tcGxldGlvbkhh bmRsZXIoKTsKLSAgICAgICAgfSk7CisgICAgICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChX VEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CiAgICAgfSkuZ2V0KCldOwogfQogI2VuZGlmCklu ZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJSFRUUENvb2tpZVN0b3JlLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJSFRUUENvb2tpZVN0 b3JlLmNwcAkocmV2aXNpb24gMjYzNDU5KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L0FQSUhUVFBDb29raWVTdG9yZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNywxNyArMTE3LDIy IEBAIHZvaWQgSFRUUENvb2tpZVN0b3JlOjpjb29raWVzRm9yVVJMKFdURjoKIHZvaWQgSFRUUENv b2tpZVN0b3JlOjpzZXRDb29raWVzKGNvbnN0IFZlY3RvcjxXZWJDb3JlOjpDb29raWU+JiBjb29r aWVzLCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCiB7CiAg ICAgZmlsdGVyQXBwQm91bmRDb29raWVzKGNvb2tpZXMsIFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0g bWFrZVJlZigqdGhpcyksIGNvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShjb21wbGV0aW9uSGFu ZGxlcildIChhdXRvJiYgYXBwQm91bmRDb29raWVzKSBtdXRhYmxlIHsKKyAgICAgICAgYm9vbCBu ZWVkc0ZsdXNoID0gZmFsc2U7CiAgICAgICAgIGF1dG8qIHBvb2wgPSBtX293bmluZ0RhdGFTdG9y ZS0+cHJvY2Vzc1Bvb2xGb3JDb29raWVTdG9yYWdlT3BlcmF0aW9ucygpOwogICAgICAgICBpZiAo IXBvb2wpIHsKICAgICAgICAgICAgIGZvciAoYXV0byYgY29va2llIDogYXBwQm91bmRDb29raWVz KSB7CiAgICAgICAgICAgICAgICAgLy8gRklYTUU6IHBlbmRpbmdDb29raWVzIHVzZWQgZm9yIGRl ZmF1bHRTZXNzaW9uIGJlY2F1c2Ugc2Vzc2lvbiBjb29raWVzIGNhbm5vdCBiZSBwcm9wYWdhdGVk IHRvIE5ldHdvcmsgUHJvY2VzcyB3aXRoIHVpUHJvY2Vzc0Nvb2tpZVN0b3JhZ2VJZGVudGlmaWVy LgotICAgICAgICAgICAgICAgIGlmIChtX293bmluZ0RhdGFTdG9yZS0+c2Vzc2lvbklEKCkgPT0g UEFMOjpTZXNzaW9uSUQ6OmRlZmF1bHRTZXNzaW9uSUQoKSAmJiAhY29va2llLnNlc3Npb24pCisg ICAgICAgICAgICAgICAgaWYgKG1fb3duaW5nRGF0YVN0b3JlLT5zZXNzaW9uSUQoKSA9PSBQQUw6 OlNlc3Npb25JRDo6ZGVmYXVsdFNlc3Npb25JRCgpICYmICFjb29raWUuc2Vzc2lvbikgeworICAg ICAgICAgICAgICAgICAgICBuZWVkc0ZsdXNoID0gdHJ1ZTsKICAgICAgICAgICAgICAgICAgICAg c2V0Q29va2llSW5EZWZhdWx0VUlQcm9jZXNzQ29va2llU3RvcmUoY29va2llKTsKLSAgICAgICAg ICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICAgICAgICAg IG1fb3duaW5nRGF0YVN0b3JlLT5hZGRQZW5kaW5nQ29va2llKGNvb2tpZSk7CiAgICAgICAgICAg ICB9CiAKLSAgICAgICAgICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChXVEZNb3ZlKGNvbXBs ZXRpb25IYW5kbGVyKSk7CisgICAgICAgICAgICBpZiAobmVlZHNGbHVzaCkKKyAgICAgICAgICAg ICAgICBmbHVzaERlZmF1bHRVSVByb2Nlc3NDb29raWVTdG9yZShXVEZNb3ZlKGNvbXBsZXRpb25I YW5kbGVyKSk7CisgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgUnVuTG9vcDo6bWFp bigpLmRpc3BhdGNoKFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKICAgICAgICAgICAgIHJl dHVybjsKICAgICAgICAgfQogCkBAIC0yOTQsNyArMjk5LDcgQEAgdm9pZCBIVFRQQ29va2llU3Rv cmU6OnJlZ2lzdGVyRm9yTmV3UHJvYwogCiAgICAgICAgIC8vIE5vdyB0aGF0IGFuIGFzc29jaWF0 ZWQgcHJvY2VzcyBwb29sIGV4aXN0cywgd2UgbmVlZCB0byBmbHVzaCB0aGUgVUkgcHJvY2VzcyBj b29raWUgc3RvcmUKICAgICAgICAgLy8gdG8gbWFrZSBzdXJlIGFueSBjaGFuZ2VzIGFyZSByZWZs ZWN0ZWQgd2l0aGluIHRoZSBuZXcgcHJvY2VzcyBwb29sLgotICAgICAgICBmbHVzaERlZmF1bHRV SVByb2Nlc3NDb29raWVTdG9yZSgpOworICAgICAgICBmbHVzaERlZmF1bHRVSVByb2Nlc3NDb29r aWVTdG9yZShbXSB7IH0pOwogICAgICAgICBuZXdQcm9jZXNzUG9vbC5lbnN1cmVOZXR3b3JrUHJv Y2VzcygpOwogCiAgICAgICAgIGlmIChtX2Nvb2tpZU1hbmFnZXJQcm94eU9ic2VydmVyKSB7CkBA IC0zMTQsNyArMzE5LDcgQEAgdm9pZCBIVFRQQ29va2llU3RvcmU6OnVucmVnaXN0ZXJGb3JOZXdQ cgogfQogCiAjaWYgIVBMQVRGT1JNKENPQ09BKQotdm9pZCBIVFRQQ29va2llU3RvcmU6OmZsdXNo RGVmYXVsdFVJUHJvY2Vzc0Nvb2tpZVN0b3JlKCkgeyB9Cit2b2lkIEhUVFBDb29raWVTdG9yZTo6 Zmx1c2hEZWZhdWx0VUlQcm9jZXNzQ29va2llU3RvcmUoQ29tcGxldGlvbkhhbmRsZXI8dm9pZCgp PiYmIGNvbXBsZXRpb25IYW5kbGVyKSB7IGNvbXBsZXRpb25IYW5kbGVyKCk7IH0KIFZlY3RvcjxX ZWJDb3JlOjpDb29raWU+IEhUVFBDb29raWVTdG9yZTo6Z2V0QWxsRGVmYXVsdFVJUHJvY2Vzc0Nv b2tpZVN0b3JlQ29va2llcygpIHsgcmV0dXJuIHsgfTsgfQogdm9pZCBIVFRQQ29va2llU3RvcmU6 OnNldENvb2tpZUluRGVmYXVsdFVJUHJvY2Vzc0Nvb2tpZVN0b3JlKGNvbnN0IFdlYkNvcmU6OkNv b2tpZSYpIHsgfQogdm9pZCBIVFRQQ29va2llU3RvcmU6OmRlbGV0ZUNvb2tpZUZyb21EZWZhdWx0 VUlQcm9jZXNzQ29va2llU3RvcmUoY29uc3QgV2ViQ29yZTo6Q29va2llJikgeyB9CkluZGV4OiBT b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJSFRUUENvb2tpZVN0b3JlLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0FQSUhUVFBDb29raWVTdG9yZS5oCShy ZXZpc2lvbiAyNjM0NTkpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJSFRUUENv b2tpZVN0b3JlLmgJKHdvcmtpbmcgY29weSkKQEAgLTg1LDcgKzg1LDcgQEAgcHJpdmF0ZToKICAg ICB2b2lkIHJlZ2lzdGVyRm9yTmV3UHJvY2Vzc1Bvb2xOb3RpZmljYXRpb25zKCk7CiAgICAgdm9p ZCB1bnJlZ2lzdGVyRm9yTmV3UHJvY2Vzc1Bvb2xOb3RpZmljYXRpb25zKCk7CiAKLSAgICBzdGF0 aWMgdm9pZCBmbHVzaERlZmF1bHRVSVByb2Nlc3NDb29raWVTdG9yZSgpOworICAgIHN0YXRpYyB2 b2lkIGZsdXNoRGVmYXVsdFVJUHJvY2Vzc0Nvb2tpZVN0b3JlKENvbXBsZXRpb25IYW5kbGVyPHZv aWQoKT4mJik7CiAgICAgc3RhdGljIFZlY3RvcjxXZWJDb3JlOjpDb29raWU+IGdldEFsbERlZmF1 bHRVSVByb2Nlc3NDb29raWVTdG9yZUNvb2tpZXMoKTsKICAgICBzdGF0aWMgdm9pZCBzZXRDb29r aWVJbkRlZmF1bHRVSVByb2Nlc3NDb29raWVTdG9yZShjb25zdCBXZWJDb3JlOjpDb29raWUmKTsK ICAgICBzdGF0aWMgdm9pZCBkZWxldGVDb29raWVGcm9tRGVmYXVsdFVJUHJvY2Vzc0Nvb2tpZVN0 b3JlKGNvbnN0IFdlYkNvcmU6OkNvb2tpZSYpOwpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL0NvY29hL0FQSUhUVFBDb29raWVTdG9yZUNvY29hLm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9BUElIVFRQQ29va2llU3RvcmVDb2NvYS5t bQkocmV2aXNpb24gMjYzNDU5KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29h L0FQSUhUVFBDb29raWVTdG9yZUNvY29hLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMCwxMiArMzAs MjMgQEAKICNpbXBvcnQgPFdlYkNvcmUvQ29va2llU3RvcmFnZU9ic2VydmVyLmg+CiAjaW1wb3J0 IDxXZWJDb3JlL0hUVFBDb29raWVBY2NlcHRQb2xpY3kuaD4KICNpbXBvcnQgPHBhbC9zcGkvY2Yv Q0ZOZXR3b3JrU1BJLmg+CisjaW1wb3J0IDx3dGYvQmxvY2tQdHIuaD4KKyNpbXBvcnQgPHd0Zi9S dW5Mb29wLmg+CiAKIG5hbWVzcGFjZSBBUEkgewogCi12b2lkIEhUVFBDb29raWVTdG9yZTo6Zmx1 c2hEZWZhdWx0VUlQcm9jZXNzQ29va2llU3RvcmUoKQordm9pZCBIVFRQQ29va2llU3RvcmU6OmZs dXNoRGVmYXVsdFVJUHJvY2Vzc0Nvb2tpZVN0b3JlKENvbXBsZXRpb25IYW5kbGVyPHZvaWQoKT4m JiBjb21wbGV0aW9uSGFuZGxlcikKIHsKKyNpZiBIQVZFKEZPVU5EQVRJT05fV0lUSF9TQVZFX0NP T0tJRVNfV0lUSF9DT01QTEVUSU9OX0hBTkRMRVIpCisgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFp bigpKTsKKyAgICBbW05TSFRUUENvb2tpZVN0b3JhZ2Ugc2hhcmVkSFRUUENvb2tpZVN0b3JhZ2Vd IF9zYXZlQ29va2llczptYWtlQmxvY2tQdHIoW2NvbXBsZXRpb25IYW5kbGVyID0gV1RGTW92ZShj b21wbGV0aW9uSGFuZGxlcildKCkgbXV0YWJsZSB7CisgICAgICAgIC8vIENGTmV0d29yayBtYXkg Y2FsbCB0aGUgY29tcGxldGlvbiBibG9jayBvbiBhIGJhY2tncm91bmQgcXVldWUsIHNvIHdlIG5l ZWQgdG8gcmVkaXNwYXRjaCB0byB0aGUgbWFpbiB0aHJlYWQuCisgICAgICAgIFJ1bkxvb3A6Om1h aW4oKS5kaXNwYXRjaChXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CisgICAgfSkuZ2V0KCld OworI2Vsc2UKICAgICBbW05TSFRUUENvb2tpZVN0b3JhZ2Ugc2hhcmVkSFRUUENvb2tpZVN0b3Jh Z2VdIF9zYXZlQ29va2llc107CisgICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFdURk1vdmUo Y29tcGxldGlvbkhhbmRsZXIpKTsKKyNlbmRpZgogfQogCiBWZWN0b3I8V2ViQ29yZTo6Q29va2ll PiBIVFRQQ29va2llU3RvcmU6OmdldEFsbERlZmF1bHRVSVByb2Nlc3NDb29raWVTdG9yZUNvb2tp ZXMoKQo=