213630 2020-06-25 17:22:32 -0700 Upstream date/time picker style 2020-06-25 19:48:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner webkit-bug-importer wenson_hsieh oldest_to_newest 1666314 0 megan_gardner 2020-06-25 17:22:32 -0700 Upstream date/time picker style 1666315 1 402830 megan_gardner 2020-06-25 17:27:30 -0700 Created attachment 402830 Patch 1666327 2 402830 wenson_hsieh 2020-06-25 17:54:57 -0700 Comment on attachment 402830 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review > Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102 > + return UIDatePickerStyleInline; This still needs to be guarded by HAVE(UIDATEPICKER_STYLE). 1666346 3 402830 megan_gardner 2020-06-25 18:23:03 -0700 Comment on attachment 402830 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review >> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102 >> + return UIDatePickerStyleInline; > > This still needs to be guarded by HAVE(UIDATEPICKER_STYLE). It is at the call site, but I can add more guards if that seems prudent. 1666347 4 wenson_hsieh 2020-06-25 18:25:50 -0700 (In reply to Megan Gardner from comment #3) > Comment on attachment 402830 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=402830&action=review > > >> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102 > >> + return UIDatePickerStyleInline; > > > > This still needs to be guarded by HAVE(UIDATEPICKER_STYLE). > > It is at the call site, but I can add more guards if that seems prudent. (To clarify — this needs to be guarded in order to fix the iOS 13.4 build) 1666348 5 402840 megan_gardner 2020-06-25 18:25:53 -0700 Created attachment 402840 Patch 1666349 6 402830 megan_gardner 2020-06-25 18:28:25 -0700 Comment on attachment 402830 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402830&action=review >>>> Source/WebKit/UIProcess/ios/forms/WKDateTimeInputControl.mm:102 >>>> + return UIDatePickerStyleInline; >>> >>> This still needs to be guarded by HAVE(UIDATEPICKER_STYLE). >> >> It is at the call site, but I can add more guards if that seems prudent. > > (To clarify — this needs to be guarded in order to fix the iOS 13.4 build) yes... I see that now... 1666352 7 402842 megan_gardner 2020-06-25 19:25:34 -0700 Created attachment 402842 Patch for landing 1666355 8 ews-feeder 2020-06-25 19:47:20 -0700 Committed r263549: <https://trac.webkit.org/changeset/263549> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402842. 1666356 9 webkit-bug-importer 2020-06-25 19:48:14 -0700 <rdar://problem/64787064> 402830 2020-06-25 17:27:30 -0700 2020-06-25 18:25:51 -0700 Patch bug-213630-20200625172729.patch text/plain 2004 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEyZDU2NzAyODQ2OWVhYzBi ODIxNTlhOGZjZjIxZmVjNWJmYmNmMTQuLmJjOThiNDY4MDYzNDlhOGNjY2E1OGNjMzk0ZWY0MTY2 NjFhNmE2N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDYtMjUgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBVcHN0cmVhbSBkYXRl L3RpbWUgcGlja2VyIHN0eWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTM2MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZm9ybXMvV0tEYXRlVGltZUlucHV0Q29udHJvbC5t bToKKyAgICAgICAgKC1bV0tEYXRlVGltZVBpY2tlciBkYXRlUGlja2VyU3R5bGVdKToKKwogMjAy MC0wNi0yNSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lP U10gLV9yZXF1ZXN0VGV4dElucHV0Q29udGV4dHNJblJlY3QgY2Fubm90IGZpbmQgZW1wdHkgUXVp cCBzcHJlYWRzaGVldCB0aXRsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv aW9zL2Zvcm1zL1dLRGF0ZVRpbWVJbnB1dENvbnRyb2wubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvZm9ybXMvV0tEYXRlVGltZUlucHV0Q29udHJvbC5tbQppbmRleCBmMWIzNTg0MGU4 YWRjYmIyOTcwNmY3Y2U0MDdlNjAwNDc0NjQ0YmJlLi45NmQ0NmExMjkzNjk4YTAwYWNlOThjNjkx OTNjNWM1MjdiNjgyMDMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv Zm9ybXMvV0tEYXRlVGltZUlucHV0Q29udHJvbC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvZm9ybXMvV0tEYXRlVGltZUlucHV0Q29udHJvbC5tbQpAQCAtNzAsMTEgKzcwLDYg QEAgQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBkb3VibGUgbWludXRlOwogLSAodm9p ZClzZXRIb3VyOihOU0ludGVnZXIpaG91ciBtaW51dGU6KE5TSW50ZWdlciltaW51dGU7CiBAZW5k CiAKLSNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQotI2ltcG9ydCA8V2ViS2l0QWRkaXRpb25z L1dLRm9ybUlucHV0Q29udHJvbEFkZGl0aW9ucy5tbT4KLSNlbmRpZgotCi0KIEBpbXBsZW1lbnRh dGlvbiBXS0RhdGVUaW1lQ29udGV4dE1lbnVWaWV3Q29udHJvbGxlcgogCiAtIChDR1NpemUpcHJl ZmVycmVkQ29udGVudFNpemUKQEAgLTEwMCwxMiArOTUsMTIgQEAgc3RhdGljIE5TU3RyaW5nICog Y29uc3Qga01vbnRoRm9ybWF0U3RyaW5nID0gQCJ5eXl5LU1NIjsgLy8gIjIwMTEtMDEiLgogc3Rh dGljIE5TU3RyaW5nICogY29uc3Qga1RpbWVGb3JtYXRTdHJpbmcgPSBAIkhIOm1tIjsgLy8gIjEz OjQ1Ii4KIHN0YXRpYyBjb25zdCBOU1RpbWVJbnRlcnZhbCBrTWlsbGlzZWNvbmRzUGVyU2Vjb25k ID0gMTAwMDsKIAotI2lmICFVU0UoQVBQTEVfSU5URVJOQUxfU0RLKSAmJiBIQVZFKFVJREFURVBJ Q0tFUl9TVFlMRSkKIC0gKFVJRGF0ZVBpY2tlclN0eWxlKWRhdGVQaWNrZXJTdHlsZQogewotICAg IHJldHVybiBVSURhdGVQaWNrZXJTdHlsZUF1dG9tYXRpYzsKKyAgICBpZiAoW192aWV3IGZvY3Vz ZWRFbGVtZW50SW5mb3JtYXRpb25dLmVsZW1lbnRUeXBlID09IFdlYktpdDo6SW5wdXRUeXBlOjpN b250aCkKKyAgICAgICAgcmV0dXJuIFVJRGF0ZVBpY2tlclN0eWxlV2hlZWxzOworICAgIHJldHVy biBVSURhdGVQaWNrZXJTdHlsZUlubGluZTsKIH0KLSNlbmRpZgogCiAtIChpZClpbml0V2l0aFZp ZXc6KFdLQ29udGVudFZpZXcgKil2aWV3IGRhdGVQaWNrZXJNb2RlOihVSURhdGVQaWNrZXJNb2Rl KW1vZGUKIHsK 402840 2020-06-25 18:25:53 -0700 2020-06-25 19:25:32 -0700 Patch bug-213630-20200625182552.patch text/plain 1951 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEyZDU2NzAyODQ2OWVhYzBi ODIxNTlhOGZjZjIxZmVjNWJmYmNmMTQuLmJjOThiNDY4MDYzNDlhOGNjY2E1OGNjMzk0ZWY0MTY2 NjFhNmE2N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDYtMjUgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBVcHN0cmVhbSBkYXRl L3RpbWUgcGlja2VyIHN0eWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTM2MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZm9ybXMvV0tEYXRlVGltZUlucHV0Q29udHJvbC5t bToKKyAgICAgICAgKC1bV0tEYXRlVGltZVBpY2tlciBkYXRlUGlja2VyU3R5bGVdKToKKwogMjAy MC0wNi0yNSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lP U10gLV9yZXF1ZXN0VGV4dElucHV0Q29udGV4dHNJblJlY3QgY2Fubm90IGZpbmQgZW1wdHkgUXVp cCBzcHJlYWRzaGVldCB0aXRsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv aW9zL2Zvcm1zL1dLRGF0ZVRpbWVJbnB1dENvbnRyb2wubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvZm9ybXMvV0tEYXRlVGltZUlucHV0Q29udHJvbC5tbQppbmRleCBmMWIzNTg0MGU4 YWRjYmIyOTcwNmY3Y2U0MDdlNjAwNDc0NjQ0YmJlLi45YjU2Nzg5NDJiNjMzODI2MDc2Nzc0NDQy OTViOTI0ZDU0ZjEzYjU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv Zm9ybXMvV0tEYXRlVGltZUlucHV0Q29udHJvbC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvZm9ybXMvV0tEYXRlVGltZUlucHV0Q29udHJvbC5tbQpAQCAtNzAsMTEgKzcwLDYg QEAgQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBkb3VibGUgbWludXRlOwogLSAodm9p ZClzZXRIb3VyOihOU0ludGVnZXIpaG91ciBtaW51dGU6KE5TSW50ZWdlciltaW51dGU7CiBAZW5k CiAKLSNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQotI2ltcG9ydCA8V2ViS2l0QWRkaXRpb25z L1dLRm9ybUlucHV0Q29udHJvbEFkZGl0aW9ucy5tbT4KLSNlbmRpZgotCi0KIEBpbXBsZW1lbnRh dGlvbiBXS0RhdGVUaW1lQ29udGV4dE1lbnVWaWV3Q29udHJvbGxlcgogCiAtIChDR1NpemUpcHJl ZmVycmVkQ29udGVudFNpemUKQEAgLTEwMCwxMCArOTUsMTIgQEAgc3RhdGljIE5TU3RyaW5nICog Y29uc3Qga01vbnRoRm9ybWF0U3RyaW5nID0gQCJ5eXl5LU1NIjsgLy8gIjIwMTEtMDEiLgogc3Rh dGljIE5TU3RyaW5nICogY29uc3Qga1RpbWVGb3JtYXRTdHJpbmcgPSBAIkhIOm1tIjsgLy8gIjEz OjQ1Ii4KIHN0YXRpYyBjb25zdCBOU1RpbWVJbnRlcnZhbCBrTWlsbGlzZWNvbmRzUGVyU2Vjb25k ID0gMTAwMDsKIAotI2lmICFVU0UoQVBQTEVfSU5URVJOQUxfU0RLKSAmJiBIQVZFKFVJREFURVBJ Q0tFUl9TVFlMRSkKKyNpZiBIQVZFKFVJREFURVBJQ0tFUl9TVFlMRSkKIC0gKFVJRGF0ZVBpY2tl clN0eWxlKWRhdGVQaWNrZXJTdHlsZQogewotICAgIHJldHVybiBVSURhdGVQaWNrZXJTdHlsZUF1 dG9tYXRpYzsKKyAgICBpZiAoW192aWV3IGZvY3VzZWRFbGVtZW50SW5mb3JtYXRpb25dLmVsZW1l bnRUeXBlID09IFdlYktpdDo6SW5wdXRUeXBlOjpNb250aCkKKyAgICAgICAgcmV0dXJuIFVJRGF0 ZVBpY2tlclN0eWxlV2hlZWxzOworICAgIHJldHVybiBVSURhdGVQaWNrZXJTdHlsZUlubGluZTsK IH0KICNlbmRpZgogCg== 402842 2020-06-25 19:25:34 -0700 2020-06-25 19:47:21 -0700 Patch for landing bug-213630-20200625192533.patch text/plain 1949 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEyZDU2NzAyODQ2OWVhYzBi ODIxNTlhOGZjZjIxZmVjNWJmYmNmMTQuLjM2ZmU2OTQ1MDEwNjU4OWJjMGIxM2E5OWFlMWU0Y2Uy ODlhYjA0MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDYtMjUgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBVcHN0cmVhbSBkYXRl L3RpbWUgcGlja2VyIHN0eWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTM2MzAKKworICAgICAgICBSZXZpZXdlZCBieSBXZW5zb24gSHNpZWguCisK KyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Zvcm1zL1dLRGF0ZVRpbWVJbnB1dENvbnRyb2wubW06 CisgICAgICAgICgtW1dLRGF0ZVRpbWVQaWNrZXIgZGF0ZVBpY2tlclN0eWxlXSk6CisKIDIwMjAt MDYtMjUgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1Nd IC1fcmVxdWVzdFRleHRJbnB1dENvbnRleHRzSW5SZWN0IGNhbm5vdCBmaW5kIGVtcHR5IFF1aXAg c3ByZWFkc2hlZXQgdGl0bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9mb3Jtcy9XS0RhdGVUaW1lSW5wdXRDb250cm9sLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL2Zvcm1zL1dLRGF0ZVRpbWVJbnB1dENvbnRyb2wubW0KaW5kZXggZjFiMzU4NDBlOGFk Y2JiMjk3MDZmN2NlNDA3ZTYwMDQ3NDY0NGJiZS4uOWI1Njc4OTQyYjYzMzgyNjA3Njc3NDQ0Mjk1 YjkyNGQ1NGYxM2I1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Zv cm1zL1dLRGF0ZVRpbWVJbnB1dENvbnRyb2wubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL2Zvcm1zL1dLRGF0ZVRpbWVJbnB1dENvbnRyb2wubW0KQEAgLTcwLDExICs3MCw2IEBA IEBwcm9wZXJ0eSAobm9uYXRvbWljLCByZWFkb25seSkgZG91YmxlIG1pbnV0ZTsKIC0gKHZvaWQp c2V0SG91cjooTlNJbnRlZ2VyKWhvdXIgbWludXRlOihOU0ludGVnZXIpbWludXRlOwogQGVuZAog Ci0jaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykKLSNpbXBvcnQgPFdlYktpdEFkZGl0aW9ucy9X S0Zvcm1JbnB1dENvbnRyb2xBZGRpdGlvbnMubW0+Ci0jZW5kaWYKLQotCiBAaW1wbGVtZW50YXRp b24gV0tEYXRlVGltZUNvbnRleHRNZW51Vmlld0NvbnRyb2xsZXIKIAogLSAoQ0dTaXplKXByZWZl cnJlZENvbnRlbnRTaXplCkBAIC0xMDAsMTAgKzk1LDEyIEBAIHN0YXRpYyBOU1N0cmluZyAqIGNv bnN0IGtNb250aEZvcm1hdFN0cmluZyA9IEAieXl5eS1NTSI7IC8vICIyMDExLTAxIi4KIHN0YXRp YyBOU1N0cmluZyAqIGNvbnN0IGtUaW1lRm9ybWF0U3RyaW5nID0gQCJISDptbSI7IC8vICIxMzo0 NSIuCiBzdGF0aWMgY29uc3QgTlNUaW1lSW50ZXJ2YWwga01pbGxpc2Vjb25kc1BlclNlY29uZCA9 IDEwMDA7CiAKLSNpZiAhVVNFKEFQUExFX0lOVEVSTkFMX1NESykgJiYgSEFWRShVSURBVEVQSUNL RVJfU1RZTEUpCisjaWYgSEFWRShVSURBVEVQSUNLRVJfU1RZTEUpCiAtIChVSURhdGVQaWNrZXJT dHlsZSlkYXRlUGlja2VyU3R5bGUKIHsKLSAgICByZXR1cm4gVUlEYXRlUGlja2VyU3R5bGVBdXRv bWF0aWM7CisgICAgaWYgKFtfdmlldyBmb2N1c2VkRWxlbWVudEluZm9ybWF0aW9uXS5lbGVtZW50 VHlwZSA9PSBXZWJLaXQ6OklucHV0VHlwZTo6TW9udGgpCisgICAgICAgIHJldHVybiBVSURhdGVQ aWNrZXJTdHlsZVdoZWVsczsKKyAgICByZXR1cm4gVUlEYXRlUGlja2VyU3R5bGVJbmxpbmU7CiB9 CiAjZW5kaWYKIAo=