213609 2020-06-25 09:21:06 -0700 [ews] Improve handling of invalid changelog 2020-07-16 08:07:32 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214365 InRadar P2 Normal --- 1 aakash_jain aakash_jain ap ews-watchlist glenn jbedard rackler ryanhaddad webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1666063 0 aakash_jain 2020-06-25 09:21:06 -0700 [ews] Improve handling of invalid changelog. In https://ews-build.webkit.org/#/builders/28/builds/2949 7 validate-changelog-and-reviewer step failed with below exception because ChangeLog was invalid (started with :wq). Such issue solved be handled in a better manner, and a user readable error message should be displayed. Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 80, in <module> main() File "Tools/Scripts/webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 53, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' 1666065 1 402741 aakash_jain 2020-06-25 09:27:30 -0700 Created attachment 402741 Patch 1666066 2 aakash_jain 2020-06-25 09:28:11 -0700 > Patch Speculative fix. 1666070 3 aakash_jain 2020-06-25 09:47:31 -0700 Committed r263513: <https://trac.webkit.org/changeset/263513> 1666076 4 aakash_jain 2020-06-25 10:10:30 -0700 > Committed r263513: <https://trac.webkit.org/changeset/263513> This change worked as expected, e.g.: https://bugs.webkit.org/show_bug.cgi?id=213602#c3 1666302 5 webkit-bug-importer 2020-06-25 17:11:31 -0700 <rdar://problem/64781527> 402741 2020-06-25 09:27:30 -0700 2020-06-25 09:43:25 -0700 Patch bug-213609-20200625122729.patch text/plain 1346 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2MzUxMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTA2LTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBJbXByb3ZlIGhhbmRsaW5nIG9mIGludmFsaWQgY2hhbmdlbG9n CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM2MDkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvdG9vbC9zdGVwcy92YWxpZGF0ZXJldmlld2VyLnB5OgorICAgICAgICAoVmFs aWRhdGVSZXZpZXdlci5ydW4pOgorCiAyMDIwLTA2LTI0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8 YXBAYXBwbGUuY29tPgogCiAgICAgICAgIG1hY09TIEJpZyBTdXIgYnVpbGQgZml4LgpJbmRleDog VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3ZhbGlkYXRlcmV2aWV3ZXIucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3ZhbGlkYXRlcmV2 aWV3ZXIucHkJKHJldmlzaW9uIDI2MzUxMSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9v bC9zdGVwcy92YWxpZGF0ZXJldmlld2VyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC01MCw2ICs1MCw5 IEBAIGNsYXNzIFZhbGlkYXRlUmV2aWV3ZXIoQWJzdHJhY3RTdGVwKToKICAgICAgICAgICAgIHJl dHVybgogICAgICAgICBmb3IgY2hhbmdlbG9nX3BhdGggaW4gc2VsZi5jYWNoZWRfbG9va3VwKHN0 YXRlLCAiY2hhbmdlbG9ncyIpOgogICAgICAgICAgICAgY2hhbmdlbG9nX2VudHJ5ID0gQ2hhbmdl TG9nKGNoYW5nZWxvZ19wYXRoKS5sYXRlc3RfZW50cnkoKQorICAgICAgICAgICAgaWYgbm90IGNo YW5nZWxvZ19lbnRyeToKKyAgICAgICAgICAgICAgICBfbG9nLmVycm9yKCdJbnZhbGlkIENoYW5n ZUxvZyBhdCB7fScuZm9ybWF0KGNoYW5nZWxvZ19wYXRoKSkKKyAgICAgICAgICAgICAgICBzeXMu ZXhpdCgxKQogICAgICAgICAgICAgaWYgY2hhbmdlbG9nX2VudHJ5Lmhhc192YWxpZF9yZXZpZXdl cigpOgogICAgICAgICAgICAgICAgIGNvbnRpbnVlCiAgICAgICAgICAgICByZXZpZXdlcl90ZXh0 ID0gY2hhbmdlbG9nX2VudHJ5LnJldmlld2VyX3RleHQoKQo=