213604 2020-06-25 07:53:11 -0700 [GTK] Initialize m_currentState and m_oldState 2020-06-26 06:36:49 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj pnormand sergio vjaquez oldest_to_newest 1666043 0 aboya 2020-06-25 07:53:11 -0700 While working on another issue I noticed this line in the log... 0:00:06.798920099 26 0x5644fb378ec0 DEBUG webkitmediaplayer MediaPlayerPrivateGStreamer.cpp:1463:playbin3SendSelectStreamsIfAppropriate:<media-player-0> Checking if to send SELECT_STREAMS, m_waitingForStreamsSelectedEvent = false, haveDifferentStreamIds = false, m_currentState = UNKNOWN!(-8421505)... shouldSendSelectStreams = false m_currentState is used before being initialized! GstState m_currentState; GstState m_oldState; This is not only affecting a debug statement, but also affects updateStates(): GstStateChangeReturn getStateResult = gst_element_get_state(m_pipeline.get(), &state, &pending, 250 * GST_NSECOND); if (state != m_currentState) { m_oldState = m_currentState; m_currentState = state; stateReallyChanged = true; } This patch initializes both m_currentState and m_oldState to GST_STATE_NULL. 1666049 1 402736 aboya 2020-06-25 08:13:31 -0700 Created attachment 402736 Patch 1666406 2 402858 aboya 2020-06-26 06:15:19 -0700 Created attachment 402858 Patch for landing 1666414 3 ews-feeder 2020-06-26 06:36:48 -0700 Committed r263556: <https://trac.webkit.org/changeset/263556> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402858. 402736 2020-06-25 08:13:31 -0700 2020-06-26 06:15:14 -0700 Patch bug-213604-20200625171329.patch text/plain 2270 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWMyNGQwYjg4YmNhMjMx NDU3NjI4NjZmNmEzNDI0ZDM1NDE5NGU5Mi4uMDJlNjc3ZTlkNDE3MGY3YmZlZWM1ZDYzZDI3NDQ3 ZjU5YWMzZTNmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA2LTI1ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBJbml0 aWFsaXplIG1fY3VycmVudFN0YXRlIGFuZCBtX29sZFN0YXRlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM2MDQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIg d2FzIG5vdCBpbml0aWFsaXppbmcgbV9jdXJyZW50U3RhdGUgYW5kCisgICAgICAgIG1fb2xkU3Rh dGUsIGNhdXNpbmcgdGhlbSB0byBiZSBjaGVja2VkIGUuZy4gdXBkYXRlU3RhdGVzKCkgd2hpbGUg dGhleQorICAgICAgICBzdGlsbCBjb250YWluIGdhcmJhZ2UuCisKKyAgICAgICAgQmVjYXVzZSB0 aGUgYmlnZ2VzdCB1bmluaXRpYWxpemVkIHVzYWdlIGlzIGEgIT0gY29tcGFyaXNvbiwgaW4KKyAg ICAgICAgcHJhY3RpY2UgdGhpbmdzIHN0aWxsIHdvcmtlZCwgYnV0IHRoYXQncyBzdGlsbCBhIGJ1 Zy4gSSBkZXRlY3RlZCB0aGUKKyAgICAgICAgYnVnIGFmdGVyIHNlZWluZyB0aGlzIGluIHRoZSBs b2dzOgorCisgICAgICAgIHBsYXliaW4zU2VuZFNlbGVjdFN0cmVhbXNJZkFwcHJvcHJpYXRlOjxt ZWRpYS1wbGF5ZXItMD4gQ2hlY2tpbmcgaWYgdG8gc2VuZCBTRUxFQ1RfU1RSRUFNUywgbV93YWl0 aW5nRm9yU3RyZWFtc1NlbGVjdGVkRXZlbnQgPSBmYWxzZSwgaGF2ZURpZmZlcmVudFN0cmVhbUlk cyA9IGZhbHNlLCBtX2N1cnJlbnRTdGF0ZSA9IFVOS05PV04hKC04NDIxNTA1KS4uLiAgc2hvdWxk U2VuZFNlbGVjdFN0cmVhbXMgPSBmYWxzZQorCisgICAgICAgIFRoaXMgcGF0Y2ggZml4ZXMgYSBz bGlnaHQgbWVtb3J5IGVycm9yIHdoaWNoIGRvZXNuJ3QgYWx0ZXIKKyAgICAgICAgVGVzdEV4cGVj dGF0aW9ucy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIuaDoKKwogMjAyMC0wNi0yNSAgQWxpY2lhIEJveWEgR2FyY8Ot YSAgPGFib3lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gRG9uJ3QgaW52YWxp ZGF0ZSBNYWluVGhyZWFkTm90aWZpZXIgdW50aWwgdGhlIHN0cmVhbWluZyB0aHJlYWRzIGFyZSBq b2luZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaAppbmRl eCAwOTM3ZDlkYzUwZDlkNDJiNGVlN2I2YTI4MTRkZjNhMGQxNDA1Njg0Li4xZWVjOWIyNjlmZmRk NmQxOWM0NjAxNWY5MWM0MGIzMWJlY2MwMGQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lci5oCkBAIC0zNDEsOCArMzQxLDggQEAgcHJvdGVjdGVkOgogICAg IG11dGFibGUgYm9vbCBtX2lzTGl2ZVN0cmVhbSB7IGZhbHNlIH07CiAgICAgYm9vbCBtX2lzUGF1 c2VkIHsgdHJ1ZSB9OwogICAgIGZsb2F0IG1fcGxheWJhY2tSYXRlIHsgMSB9OwotICAgIEdzdFN0 YXRlIG1fY3VycmVudFN0YXRlOwotICAgIEdzdFN0YXRlIG1fb2xkU3RhdGU7CisgICAgR3N0U3Rh dGUgbV9jdXJyZW50U3RhdGUgeyBHU1RfU1RBVEVfTlVMTCB9OworICAgIEdzdFN0YXRlIG1fb2xk U3RhdGUgeyBHU1RfU1RBVEVfTlVMTCB9OwogICAgIEdzdFN0YXRlIG1fcmVxdWVzdGVkU3RhdGUg eyBHU1RfU1RBVEVfVk9JRF9QRU5ESU5HIH07CiAgICAgYm9vbCBtX3Nob3VsZFJlc2V0UGlwZWxp bmUgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9pc1NlZWtpbmcgeyBmYWxzZSB9Owo= 402858 2020-06-26 06:15:19 -0700 2020-06-26 06:36:49 -0700 Patch for landing bug-213604-20200626151517.patch text/plain 2274 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWMyNGQwYjg4YmNhMjMx NDU3NjI4NjZmNmEzNDI0ZDM1NDE5NGU5Mi4uNTVkNGE4MjQyYzIzZDdjYTFiZjE0ZjNiZWY2Mjgw M2U0NGRlNWI3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA2LTI1ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBJbml0aWFsaXplIG1fY3VycmVudFN0YXRlIGFuZCBtX29sZFN0YXRlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTM2MDQKKworICAgICAgICBSZXZp ZXdlZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyIHdhcyBub3QgaW5pdGlhbGl6aW5nIG1fY3VycmVudFN0YXRlIGFuZAorICAgICAgICBtX29s ZFN0YXRlLCBjYXVzaW5nIHRoZW0gdG8gYmUgY2hlY2tlZCBlLmcuIHVwZGF0ZVN0YXRlcygpIHdo aWxlIHRoZXkKKyAgICAgICAgc3RpbGwgY29udGFpbiBnYXJiYWdlLgorCisgICAgICAgIEJlY2F1 c2UgdGhlIGJpZ2dlc3QgdW5pbml0aWFsaXplZCB1c2FnZSBpcyBhICE9IGNvbXBhcmlzb24sIGlu CisgICAgICAgIHByYWN0aWNlIHRoaW5ncyBzdGlsbCB3b3JrZWQsIGJ1dCB0aGF0J3Mgc3RpbGwg YSBidWcuIEkgZGV0ZWN0ZWQgdGhlCisgICAgICAgIGJ1ZyBhZnRlciBzZWVpbmcgdGhpcyBpbiB0 aGUgbG9nczoKKworICAgICAgICBwbGF5YmluM1NlbmRTZWxlY3RTdHJlYW1zSWZBcHByb3ByaWF0 ZTo8bWVkaWEtcGxheWVyLTA+IENoZWNraW5nIGlmIHRvIHNlbmQgU0VMRUNUX1NUUkVBTVMsIG1f d2FpdGluZ0ZvclN0cmVhbXNTZWxlY3RlZEV2ZW50ID0gZmFsc2UsIGhhdmVEaWZmZXJlbnRTdHJl YW1JZHMgPSBmYWxzZSwgbV9jdXJyZW50U3RhdGUgPSBVTktOT1dOISgtODQyMTUwNSkuLi4gIHNo b3VsZFNlbmRTZWxlY3RTdHJlYW1zID0gZmFsc2UKKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVz IGEgc2xpZ2h0IG1lbW9yeSBlcnJvciB3aGljaCBkb2Vzbid0IGFsdGVyCisgICAgICAgIFRlc3RF eHBlY3RhdGlvbnMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmg6CisKIDIwMjAtMDYtMjUgIEFsaWNpYSBCb3lhIEdh cmPDrWEgIDxhYm95YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIERvbid0IGlu dmFsaWRhdGUgTWFpblRocmVhZE5vdGlmaWVyIHVudGlsIHRoZSBzdHJlYW1pbmcgdGhyZWFkcyBh cmUgam9pbmVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmgK aW5kZXggMDkzN2Q5ZGM1MGQ5ZDQyYjRlZTdiNmEyODE0ZGYzYTBkMTQwNTY4NC4uMWVlYzliMjY5 ZmZkZDZkMTljNDYwMTVmOTFjNDBiMzFiZWNjMDBkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuaApAQCAtMzQxLDggKzM0MSw4IEBAIHByb3RlY3RlZDoK ICAgICBtdXRhYmxlIGJvb2wgbV9pc0xpdmVTdHJlYW0geyBmYWxzZSB9OwogICAgIGJvb2wgbV9p c1BhdXNlZCB7IHRydWUgfTsKICAgICBmbG9hdCBtX3BsYXliYWNrUmF0ZSB7IDEgfTsKLSAgICBH c3RTdGF0ZSBtX2N1cnJlbnRTdGF0ZTsKLSAgICBHc3RTdGF0ZSBtX29sZFN0YXRlOworICAgIEdz dFN0YXRlIG1fY3VycmVudFN0YXRlIHsgR1NUX1NUQVRFX05VTEwgfTsKKyAgICBHc3RTdGF0ZSBt X29sZFN0YXRlIHsgR1NUX1NUQVRFX05VTEwgfTsKICAgICBHc3RTdGF0ZSBtX3JlcXVlc3RlZFN0 YXRlIHsgR1NUX1NUQVRFX1ZPSURfUEVORElORyB9OwogICAgIGJvb2wgbV9zaG91bGRSZXNldFBp cGVsaW5lIHsgZmFsc2UgfTsKICAgICBib29sIG1faXNTZWVraW5nIHsgZmFsc2UgfTsK